h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2026-05-28 03:53:45 +08:00
Code Issues Releases Wiki Activity

Fix various weirdness around refetching

Browse Source
This commit is contained in:
Bartłomiej Dach
2025-04-08 13:35:24 +02:00
Unverified
parent 9aaa1fe5f4
commit 68b5f9a314
1 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
osu.Game/Screens/Select/Leaderboards/BeatmapLeaderboard.cs
+12 -12
View File
@@ -63,7 +63,7 @@ namespace osu.Game.Screens.Select.Leaderboards
}
}
private readonly IBindable<LeaderboardScores?> fetchedScores = new Bindable<LeaderboardScores?>();
private readonly Bindable<LeaderboardScores?> fetchedScores = new Bindable<LeaderboardScores?>();
[Resolved]
private IBindable<RulesetInfo> ruleset { get; set; } = null!;
@@ -86,17 +86,7 @@ namespace osu.Game.Screens.Select.Leaderboards
if (filterMods)
RefetchScores();
};
fetchedScores.BindTo(leaderboardManager.Scores);
}
protected override void LoadComplete()
{
base.LoadComplete();
fetchedScores.BindValueChanged(_ =>
{
if (fetchedScores.Value != null)
SetScores(fetchedScores.Value.TopScores, fetchedScores.Value.UserScore);
});
((IBindable<LeaderboardScores?>)fetchedScores).BindTo(leaderboardManager.Scores);
}
protected override bool IsOnlineScope => Scope != BeatmapLeaderboardScope.Local;
@@ -147,7 +137,17 @@ namespace osu.Game.Screens.Select.Leaderboards
.ContinueWith(t =>
{
if (t.Exception != null && !t.IsCanceled)
{
Schedule(() => SetErrorState(LeaderboardState.NetworkFailure));
return;
}
fetchedScores.UnbindEvents();
fetchedScores.BindValueChanged(scores =>
{
if (scores.NewValue != null)
Schedule(() => SetScores(scores.NewValue.TopScores, scores.NewValue.UserScore));
}, true);
}, cancellationToken);
return null;