osu-lazer

Fix presenting score potentially dying due to deleted beatmap

- Closes https://github.com/ppy/osu/issues/27168
- Closes https://github.com/ppy/osu/issues/32930

It's a little manual (if you perform any of the scenarios in the issues
above on this branch, the first click will re-import the beatmap but not
start the replay, and only the second will play it), but maybe fine?

Bartłomiej Dach · 2025-04-24 08:47:08 +02:00

c52dce0f38

Fix thread safety when calling BeatmapStore.GetBeatmapSets

While usually we'd handle this locally by moving bind operations to
`LoadComponent`, this component was explicitly made to be used in
asynchronous scenarios (to allow cases like song select to coexist with
realm without adding huge compliexities to the classes locally).

So I think it makes sense to hide this as an implementation detail. The
locked segments should all be quite fast to run so I do not see a
performance issue with lock contention here.

Dean Herbert · 2025-04-16 15:53:20 +09:00

e8af0dabea

Fix timeout during diffcalc causing batch import to bail

Closes https://github.com/ppy/osu/discussions/32628.

Dean Herbert · 2025-04-03 14:30:47 +09:00

21c6756336

Re-fetch status of any beatmaps stuck in qualified status

Best we do this rather than leaving it up to users to fix their broken
beatmaps.

https://github.com/ppy/osu/discussions/32406
https://github.com/ppy/osu/discussions/32431

Dean Herbert · 2025-03-19 14:35:43 +09:00

76f286a01b

Ensure realm database file is touched on startup

Closes https://github.com/ppy/osu/discussions/32304.

Dean Herbert · 2025-03-11 15:47:51 +09:00

75bd101c9e

Pull actual diffcalc out of realm transaction

Bartłomiej Dach · 2025-03-10 10:36:19 +01:00

6b1472b070

Cache ruleset instance to avoid instantiation per beatmap processed

Dean Herbert · 2025-03-10 17:17:45 +09:00

7ca9d8392d

Ensure that star rating reprocessing does not incur online lookup requests

Yesterday after the lazer release there was a bit of a spike in the
number of osu-web requests pointed at `/api/v2/beatmaps/lookup`
specifically. The most likely reason for this is that prior to this
commit, the star rating recalculation was fully performed by the
`BeatmapUpdater.Process()` flow.

This process does full metadata lookups, and while it *will* attempt
to use the local `online.db` metadata cache, it *will* also fall back to
API requests if the local metadata fetch fails. While that means that
the local cache likely saved us from a doomsday scenario here, it *also*
is the case that all of that metadata lookup stuff is *entirely
unnecessary* when wanting to just update star ratings.

Therefore, this splits out only the part relevant to star ratings
as a separate background process, so that it can run completely
locally.

Bartłomiej Dach · 2025-03-07 10:48:29 +01:00

12fa96de25

Implement special exporter intended specifically for submission flows

Bartłomiej Dach · 2025-02-05 14:01:37 +01:00

fff99a8b40

Do not double up first control point of path

Bartłomiej Dach · 2025-01-31 09:01:42 +01:00

20280cd195

Move control point double-up logic to LegacyBeatmapExporter

Done for two reasons:

- During review it was requested for the logic to be moved out of
  `BezierConverter` as `BezierConverter` was intended to produce
  "lazer style" sliders with per-control-point curve types,
  as a future usability / code layering concern.

- It is also relevant for encode-decode stability. With how the logic
  was structured between the Bezier converter and the legacy beatmap
  encoder, the encoder would leave behind per-control-point Bezier curve
  specs that stable ignored, but subsequent encodes and decodes in lazer
  would end up multiplying the doubled-up control points ad nauseam.
  Instead, it is sufficient to only specify the curve type for the
  head control point as Bezier, not specify any further curve types
  later on, and instead just keep the double-up-control-point for new
  implicit segment logic which is enough to make stable cooperate
  (and also as close to outputting the slider exactly as stable would
  have produced it as we've ever been)

Bartłomiej Dach · 2025-01-30 15:28:47 +01:00

b4f63da048

Merge pull request #31509 from bdach/local-metadata-cache-corruption

Refetch local metadata cache if corruption is detected

Dean Herbert · 2025-01-23 02:43:14 +09:00

bf23c67603

Merge pull request #31604 from peppy/fix-song-select-right-click-handling

Fix song select right click handling

Bartłomiej Dach · 2025-01-22 10:00:03 +01:00

2623d8dcac

Remove outdated ef related catch-when usage

Dean Herbert · 2025-01-22 17:04:30 +09:00

26ef23c9a9

Switch IsImportant to init property isntead of virtual

Dean Herbert · 2025-01-22 16:41:26 +09:00

4cf4b8c73d

Remove right click default for absolute scroll

Dean Herbert · 2025-01-21 17:24:41 +09:00

66be9f2d1b

Update realm xmldoc references

Dean Herbert · 2025-01-08 01:35:56 +09:00

125d652dd8

Merge branch 'master' into upgrade-packages

Dean Herbert · 2025-01-08 01:23:28 +09:00

18ff25bc6d

Round object coordinates to nearest integers rather than truncating

Addresses https://github.com/ppy/osu/issues/31256.

Bartłomiej Dach · 2024-12-27 11:10:29 +01:00

e9762422b3

Add migration

Dean Herbert · 2024-12-26 15:46:12 +09:00

2a374c0695

Add explanatory comment for schema version bump

Bartłomiej Dach · 2024-12-24 08:21:27 +01:00

d9be172647

Add migration to update users which have previous default bindings for beat snap

Dean Herbert · 2024-12-23 22:14:03 +09:00

9ff4a58fa3

Merge pull request #31076 from peppy/beatmap-store-interface

Access beatmap store via abstract base class

Bartłomiej Dach · 2024-12-11 17:48:32 +09:00

4e4a99decc

Remove BeatmapCarousel testing backdoor

Dean Herbert · 2024-12-11 16:28:51 +09:00

a868c33380

Access beatmap store via abstract base class

The intention here is to make things more testable going forward.
Specifically, to remove the "back-door" entrance into `BeatmapCarousel`
where `BeatmapSets` can be set by tests and bypas/block realm retrieval.

Dean Herbert · 2024-12-11 16:28:51 +09:00

c94b393e30

Revert unnecessary complexity

Salman Alshamrani · 2024-12-11 01:03:55 -05:00

e0aec6f907

Use temporary storage for exported files on iOS

Salman Alshamrani · 2024-12-09 08:16:37 -05:00

0c0dcb1e15

Merge branch 'master' into netcore-analyzer

Huo Yaoyuan · 2024-12-05 17:18:56 +08:00

d92ea910cf

Merge pull request #28473 from bdach/beatmap-info-purge

Move unnecessary properties from `BeatmapInfo` / realm to `IBeatmap`

Dean Herbert · 2024-12-02 16:19:12 +09:00

5b2558cec2

Merge branch 'master'

Huo Yaoyuan · 2024-11-30 01:07:08 +08:00

fa3c95c296

Fix one remaining method call

Dean Herbert · 2024-11-29 21:21:05 +09:00

a719693d10

Expose more migration helper methods

For use in https://github.com/ppy/osu-queue-score-statistics/pull/305.

Some of these might look a bit odd, but I personally still prefer having
them all in one central location.

Dean Herbert · 2024-11-29 21:10:30 +09:00

0e1b62ef85

Enable recommended rules for documentation

Huo Yaoyuan · 2024-11-28 20:41:32 +08:00

c57ace0b5f

Fix incorrect comment

Bartłomiej Dach · 2024-11-22 11:06:36 +01:00

ead7e99c59

Merge branch 'master' into beatmap-info-purge

Dean Herbert · 2024-11-22 18:47:32 +09:00

086a34f5c0

Merge pull request #30402 from peppy/import-paused-visibility

Update notification text when import is paused due to gameplay

Dan Balasescu · 2024-11-20 16:00:13 +09:00

53f0befc05

Ensure cleanup tasks are run even on a cancelled / exceptioned import task

Dean Herbert · 2024-11-18 16:51:46 +09:00

ebc2cc3570

Re-throw OperationCanceledException for consistency?

Mostly to see if it breaks anything.

Dean Herbert · 2024-11-14 13:14:35 +09:00

2afd357901

Fix timing point truncation in legacy beatmap export

OliBomby · 2024-11-13 14:23:28 +01:00

b6eff38520

Merge branch 'master' into import-paused-visibility

Dean Herbert · 2024-11-12 17:02:21 +09:00

ce86208e09

Fix tests not working by forgoing beatmap updates

Dan Balasescu · 2024-11-07 17:26:10 +09:00

bd630c189e

Prefer not deleted models when picking model instances for reuse when importing

This fell out while investigating why the issue with online IDs
mismatching in the `.osu` could be worked around by importing the map
three times in total when starting from it not being available locally.

Here follows an explanation of why that "helped".

Import 1:
- The beatmap set is imported normally.
- Online metadata population sees the online ID mismatch and resets it
  on the problematic beatmap.

Import 2:
- The existing beatmap set is found, but deemed not reusable
  because of the single beatmap having its ID reset to -1.
- The existing beatmap set is marked deleted, and all the IDs of
  its beatmaps are reset to -1.
- The beatmap set is reimported afresh.
- Online metadata population still sees the online ID mismatch
  and resets it on the problematic beatmap.

Note that at this point the first import *is still physically present
in the database* but marked deleted.

Import 3:
- When trying to find the existing beatmap set to see if it can be
  reused, *the one pending deletion and with its IDs reset -
  - the remnant from import 1 - is returned*.
- Because of this, `validateOnlineIds()` resets online IDs
  *on the model representing the current reimport*.
- The beatmap set is reimported yet again.
- With the online ID reset, the online metadata population check for
  online ID mismatch does not run because *the IDs were reset to -1*
  earlier.

Preferring undeleted models when picking the model instance for reuse
prevents this scenario.

Bartłomiej Dach · 2024-10-30 08:18:44 +01:00

0e52797f29

Make flow more async to avoid any chance of deadlocks

Dean Herbert · 2024-10-24 17:56:51 +09:00

61f0cfd688

Update notification text when import is paused due to gameplay

Addresses https://github.com/ppy/osu/discussions/30388.

Dean Herbert · 2024-10-23 17:51:29 +09:00

be5cb209e5

Merge branch 'master' into lookup-users-endpoint

Dean Herbert · 2024-10-22 18:48:00 +09:00

6ea1623889

Don't delete scores when deleting beatmaps

The score model's spec allows for null `BeatmapInfo` so the reasoning of
the inline comment is no longer valid. We match based on hash these
days.

Dean Herbert · 2024-10-22 01:39:05 +09:00

cbaee98674

Fix migration not checking combination properly

Bartłomiej Dach · 2024-10-16 08:17:22 +02:00

f8a13b0beb

migrate clearance of conflicting ToggleFPSDisplay keybind

Leander Furumo · 2024-10-14 16:03:29 +02:00

035e5a9613

Rename and xmldoc RealmResetEmptySet

Dean Herbert · 2024-10-09 14:18:34 +09:00

d836dba982

Fix DetachedBeatmapStore special condition for detecting resets from blocking all operations failing on empty databases

See https://discord.com/channels/188630481301012481/188630652340404224/1293309912591368244.

Bartłomiej Dach · 2024-10-08 23:16:17 +02:00

b811b9baf6

1656 Commits