1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-18 00:23:22 +08:00
Commit Graph

68703 Commits

Author SHA1 Message Date
OliBomby
ad8e7f1897 Fix scroll speed visualisation missing on start kiai effect points
They were being drawn far offscreen because the width of the kiai multiplied with the X coordinate of the scroll speed vis.
2024-08-22 20:17:09 +02:00
OliBomby
998b5fdc12 Add property EditorShowScrollSpeed to Ruleset 2024-08-22 19:53:34 +02:00
OliBomby
621c4d65a3 Hide scroll speed in effect row attribute 2024-08-16 14:43:33 +02:00
OliBomby
b253d8ecbf Hide scroll speed in bottom timeline 2024-08-16 14:43:09 +02:00
Dan Balasescu
3b94d1f8eb
Merge pull request #29433 from OliBomby/grid-anchors
Fix grid snap slider placement double-click not making new segment if anchor not hovered
2024-08-16 17:42:15 +09:00
Dean Herbert
68bad9a277
Attempt file operations more than once in another test instance
See
https://github.com/ppy/osu/pull/29433/checks?check_run_id=28833985792.
2024-08-16 17:39:45 +09:00
Dan Balasescu
4ea7d9fb9a
Merge pull request #29438 from Joehuu/fix-play-button-click-area
Fix preview play button having incorrect click area
2024-08-16 16:29:49 +09:00
Joseph Madamba
e2bf02cf94 Fix preview play button having incorrect click area 2024-08-15 22:49:12 -07:00
Joseph Madamba
fda17a5a72 Expose BeatmapCardNormal height const 2024-08-15 22:49:12 -07:00
Dean Herbert
e01e630fd7
Merge pull request #29434 from OliBomby/change-segment
Fix PathControlPointVisualiser eating inputs when no control points are selected
2024-08-16 12:35:46 +09:00
OliBomby
00e210147a Fix inputs being eaten by PathControlPointVisualizer when no control points are selected 2024-08-15 23:11:07 +02:00
OliBomby
29fda745a4 add failure test 2024-08-15 22:59:26 +02:00
OliBomby
f717938a28 Fix grid snap slider placement double-click does not make new segment if anchor not hovered 2024-08-15 22:49:05 +02:00
Dan Balasescu
52c1858bbe
Merge pull request #29428 from peppy/update-editor-menu-items-difficulty-change
Ensure the "Change Difficulty" menu uses up-to-date difficulty names
2024-08-16 00:44:59 +09:00
Dean Herbert
5710f0f302
Merge pull request #26254 from frenzibyte/mania-combo-counter
Add argon/classic osu!mania combo counter
2024-08-15 17:56:28 +09:00
Dean Herbert
e7b4a2f451
Merge pull request #29427 from frenzibyte/fix-ruleset-components-beatmap-skin
Fix beatmap skin always overriding ruleset HUD components
2024-08-15 17:53:13 +09:00
Dean Herbert
b5f615882f
Ensure the "Change Difficulty" menu uses up-to-date difficulty names
Closes https://github.com/ppy/osu/issues/29391.
2024-08-15 17:25:30 +09:00
Salman Ahmed
7427237873 Try make code look better 2024-08-15 17:03:08 +09:00
Salman Ahmed
358572ebb3 Update code order to match everything else 2024-08-15 16:57:29 +09:00
Salman Ahmed
a421231aad Fix beatmap skin on mania breaking HUD apart 2024-08-15 16:55:05 +09:00
Salman Ahmed
49c71f7863 Fix beatmap skin always overriding ruleset HUD components 2024-08-15 16:47:10 +09:00
Dean Herbert
4b279ecaa8
Fix mistake 2024-08-15 16:44:15 +09:00
Dean Herbert
26da2c0637
Update MultiplayerClient test output with new knowledge 2024-08-15 16:16:48 +09:00
Salman Ahmed
66adddbfb8 Actually bring back position-flipping logic and disable "closest" anchor 2024-08-15 15:50:32 +09:00
Dean Herbert
9dc496d6a7
Merge pull request #29415 from Joehuu/difficulty-name-content
Implement song select v2 difficulty name content component
2024-08-15 15:20:52 +09:00
Salman Ahmed
3a4546d62d Remove x symbol from argon mania combo counter 2024-08-15 15:08:35 +09:00
Salman Ahmed
ff1ab2bb0e Remove position-flipping logic from mania combo counters for now
We need a general method to do this amicably, such as an HUD target that flips the position of its children when the direction is flipped. Something to consider later.
2024-08-15 15:02:18 +09:00
Dan Balasescu
70cfac0eb8
Merge pull request #29426 from peppy/fix-dot-misalign
Fix some characters ('.', ',') being misaligned in legacy counters
2024-08-15 14:19:53 +09:00
Dean Herbert
054366b25d
Use zero baseline for legacy sprite text display 2024-08-15 13:07:42 +09:00
Dan Balasescu
8bfb5cedc4
Merge pull request #29406 from peppy/fix-skin-change-crash
Fix crash on changing skins when classic mod is enabled and game is rewound
2024-08-15 01:04:32 +09:00
Dan Balasescu
a6aa35a9b8
Merge pull request #29417 from peppy/remove-main-menu-challenge-tooltip
Remove daily challenge tooltip from main menu
2024-08-14 22:30:56 +09:00
Dean Herbert
e603888130
Update remaining tests to use new base class (and tidy up V2 suffixes) 2024-08-14 21:09:28 +09:00
Dean Herbert
1665d9a93e
Fix failing test setup 2024-08-14 21:01:35 +09:00
Dean Herbert
28ab65243d
Remove daily challenge tooltip from main menu
Now that we have a nice intro screen for the daily challenge, it's
generally thought that we want to "spoil" the beatmap until the intro is
shown.

Also I was never a huge fan of having a tooltip on a main menu button..
just feels a bit odd.
2024-08-14 20:45:27 +09:00
Dean Herbert
58d9a4adba
Merge pull request #29414 from smoogipoo/fix-daily-challenge-2
Add localisation for daily challenge day/week units
2024-08-14 18:45:12 +09:00
Joseph Madamba
6f2bc7e6f1 Use Content override instead 2024-08-14 00:44:03 -07:00
Joseph Madamba
11bd0c9a61 Inline single-frame layout issue comment instead 2024-08-14 00:41:43 -07:00
Dean Herbert
2174510544
Move other V2 tests to new test namespace 2024-08-14 15:51:07 +09:00
Joseph Madamba
c24f1444f9 Directly resolve IBindable<WorkingBeatmap> by making a local variant of DifficultyNameContent 2024-08-13 23:26:18 -07:00
Joseph Madamba
f8796e3192 Move resizing width and background logic to SongSelectComponentsTestScene 2024-08-13 23:26:17 -07:00
Joseph Madamba
2b41f71fd0 Workaround single-frame layout issues with {Link|Text|Fill}FlowContainers 2024-08-13 23:26:17 -07:00
Joseph Madamba
625c6fc7eb Implement song select v2 difficulty name content component 2024-08-13 23:26:17 -07:00
Joseph Madamba
46d41cb590 Add base song select components test scene 2024-08-13 23:26:17 -07:00
Dean Herbert
7c142bcedf
Fix incorrect anchor handling in ArgonManiaComboCounter 2024-08-14 15:12:23 +09:00
Dean Herbert
e465049050
Merge branch 'master' into mania-combo-counter 2024-08-14 15:12:00 +09:00
Dan Balasescu
f882ad4a53
Add localisation for daily challenge day/week units 2024-08-14 15:10:55 +09:00
Dan Balasescu
6840f4bca4
Merge pull request #29412 from peppy/file-io-test-failure 2024-08-14 13:06:14 +09:00
Dean Herbert
dd9705b660
Fix file access test failure by forcing retries
See https://github.com/ppy/osu/actions/runs/10369630825/job/28708248682.
2024-08-14 12:26:21 +09:00
Dean Herbert
78ef436ea0
Update test debug output to test second scenario 2024-08-14 12:23:47 +09:00
Dean Herbert
1b29b9bbb8
Merge pull request #29403 from smoogipoo/fix-catch-missing-objects
Fix fruit positions getting mangled when exploded from the plate
2024-08-14 00:59:56 +09:00