65490 Commits

This Branch

This Branch

All Branches

• Merge pull request #25857 from peppy/fix-mod-settings-keyboard-adjust

  Fix mod search textbox having focus while settings are visible

  Bartłomiej Dach · 2023-12-19 15:44:17 +01:00
  64b0534fb8
• Merge pull request #25838 from peppy/fix-song-select-realm-refresh-performance

  Fix song select realm refresh performance

  Bartłomiej Dach · 2023-12-19 15:04:20 +01:00
  b86997318b
• Add test coverage of desired input handling behaviour
  Bartłomiej Dach · 2023-12-19 14:52:16 +01:00
  d793d1cea1
• Merge branch 'master' into fix-song-select-realm-refresh-performance
  Bartłomiej Dach · 2023-12-19 14:14:46 +01:00
  e306cc35ba
• Allow choosing "Edit" from any beatmap carousel item
  Dean Herbert · 2023-12-19 19:58:49 +09:00
  bbfdd6892d
• Revert to using a more manual approach to holding focus
  Dean Herbert · 2023-12-19 19:46:30 +09:00
  c556475c2c
• Add missing invalidation call
  Dean Herbert · 2023-12-19 19:39:48 +09:00
  502e3edac3
• Change default song select tab display to local leaderboard
  Dean Herbert · 2023-12-19 19:31:05 +09:00
  2c5ca9c1c8
• Tidy up visual look
  Dean Herbert · 2023-12-19 19:28:02 +09:00
  3b848e8503
• Move advanced stats to a more permanent location on song select
  Dean Herbert · 2023-12-19 19:10:43 +09:00
  07bb0805e9
• Add support for dual-column advanced stats
  Dean Herbert · 2023-12-19 19:09:47 +09:00
  0a64d631e2
• Merge pull request #25893 from smoogipoo/fix-early-slide-sample

  Fix sliding sample playing before Slider's start time

  Bartłomiej Dach · 2023-12-19 10:37:41 +01:00
  1161e0ad0e
• Merge pull request #25888 from peppy/fix-sort-failures

  Fix incorrect ordering of items at song select when certain sort modes are used

  Bartłomiej Dach · 2023-12-19 10:37:20 +01:00
  c078d63e90
• Refactor usage of object counts for mania key count lookup to be a bit safer

  Protects against non-initialised values and also div-by-zero.

  Dean Herbert · 2023-12-19 18:28:04 +09:00
  372f930f8b
• Change default values of new object counts to -1 to identify non-processed values
  Dean Herbert · 2023-12-19 18:20:02 +09:00
  f09c6b8c1b
• Actually fix realm selection retention regression
  Dean Herbert · 2023-12-19 18:10:55 +09:00
  8f5d21dc70
• Use sender's realm (because we can)
  Dean Herbert · 2023-12-19 17:27:52 +09:00
  7e9c1b2acb
• Fix sliding sample playing before Slider's start time
  Dan Balasescu · 2023-12-19 17:01:52 +09:00
  fe5e071e70
• Add more detail to exception
  Bartłomiej Dach · 2023-12-19 08:57:18 +01:00
  7c05d66bd7
• Give sliders in test scene a sample
  Dan Balasescu · 2023-12-19 16:47:49 +09:00
  011bd61e7d
• Roll back incorrect change in ShouldMigrateToNewStandardised()
  Bartłomiej Dach · 2023-12-19 08:13:02 +01:00
  ddb67c87a8
• Fix incorrect ordering of items at song select when certain sort modes are used
  Dean Herbert · 2023-12-19 15:09:03 +09:00
  44efa2c540
• Rename class/file (this is not a test scene)
  Dan Balasescu · 2023-12-19 14:27:29 +09:00
  30957f847c
• Add test
  Dan Balasescu · 2023-12-19 14:01:08 +09:00
  f2edb3ea54
• Make taiko OKs worth 150 points
  Dan Balasescu · 2023-12-19 14:01:05 +09:00
  35c0eaee1c
• Add ScoreProcessor methods to override numeric result
  Dan Balasescu · 2023-12-19 13:50:31 +09:00
  c1b55c7fac
• Fix arrow pointing to wrong place
  Dean Herbert · 2023-12-19 13:35:02 +09:00
  469a659938
• Update bug-issue.yml with new workflow for exporting logs
  Dean Herbert · 2023-12-19 13:33:45 +09:00
  ee8a5d5a30
• Merge pull request #25871 from Susko3/fix-logfile-notification

  Fix opening log files from notification not presenting the correct file

  Dan Balasescu · 2023-12-19 10:21:18 +09:00
  b6ed792a41
• Run score conversion for previously-imported scores
  Bartłomiej Dach · 2023-12-18 22:27:51 +01:00
  9c8df4e6d1
• Fix osu! standardised score conversion sometimes exceeding bounds

  Co-authored-by: Zyf <zyfarok@gmail.com>
  
  Closes https://github.com/ppy/osu/issues/25860
  
  Users reported that some stable scores would convert to large negative
  total scores in lazer after the introduction of combo exponent. Those
  large negative total scores were actually mangled NaNs.
  
  The root cause of this was the following calculation going below zero
  unexpectedly:
  
  	https://github.com/ppy/osu/blob/8e8d9b2cd96be4c4b3d8f1f01dc013fc9d41f765/osu.Game/Database/StandardisedScoreMigrationTools.cs#L323
  
  which then propagates negative numbers onward until
  
  	https://github.com/ppy/osu/blob/8e8d9b2cd96be4c4b3d8f1f01dc013fc9d41f765/osu.Game/Database/StandardisedScoreMigrationTools.cs#L337
  
  which yields a NaN due to attempting to take the square root of a
  negative number.
  
  To fix, clamp `comboPortionInScoreV1` to sane limits: to
  `comboPortionFromLongestComboInScoreV1` from below, and to
  `maximumAchievableComboPortionInScoreV1` from above. This is a less
  direct fix than perhaps imagined, but it seems like a better one as it
  will also affect the calculation of both the lower and the upper
  estimate of the score.

  Bartłomiej Dach · 2023-12-18 22:05:19 +01:00
  017003deea
• Fix opening log files from notification not presenting the correct file
  Susko3 · 2023-12-18 21:11:00 +01:00
  cc800a18b2
• Merge pull request #25832 from peppy/more-background-processing-progress-notifications

  Show more comprehensive background processing progress notifications

  Bartłomiej Dach · 2023-12-18 20:05:47 +01:00
  8e8d9b2cd9
• Merge pull request #25856 from peppy/fix-keybaord-adjust-nc-dc

  Fix keyboard precision of nightcore/daycore adjustments being incorrect

  Bartłomiej Dach · 2023-12-18 19:54:17 +01:00
  b8bcf7a097
• Update framework
  Dean Herbert · 2023-12-19 03:22:22 +09:00
  9594ae7802
• Use nunit constraints in test for transparency
  Bartłomiej Dach · 2023-12-18 19:02:23 +01:00
  bf668174ec
• Add realm refresh steps in an attempt to stabilise failing test

  I think this is required because there is a higher chance of batched
  updates with the new structure (and less calls to `BeatmapSetsChanged`
  which causes re-selection).

  Dean Herbert · 2023-12-19 02:08:29 +09:00
  41485c19cf
• Fix mod search textbox having focus while settings are visible

  Stopped arrow key adjust on slider bars from working.
  
  Also just felt wrong that you could type into an off-screen textbox.

  Dean Herbert · 2023-12-19 01:32:34 +09:00
  51f4c7254c
• Fix keyboard precision of nightcore/daycore adjustments being incorrect

  Closes https://github.com/ppy/osu/issues/25854.

  Dean Herbert · 2023-12-19 01:07:33 +09:00
  374425ea75
• Merge pull request #25821 from bdach/fix-collection-dropdown-crash

  Fix collections dropdown crashing during storage migration

  Dean Herbert · 2023-12-19 01:01:23 +09:00
  c466775f78
• Merge pull request #25848 from 65-7a/dropdown-search-padding

  Fix padding on dropdown search bar

  Dean Herbert · 2023-12-19 00:36:14 +09:00
  c88c25e77f
• Merge pull request #25839 from bdach/collection-name-clashes-crashes

  Fix crash when creating collections named "All beatmaps" or "Manage collections..."

  Dean Herbert · 2023-12-19 00:32:18 +09:00
  da658bbf25
• Don't show progress notifications when there are too few items to be worthwhile
  Dean Herbert · 2023-12-19 00:01:09 +09:00
  9aaaa12809
• Revert "Improve performance of attemptSelection using new cached count and LastSelected"

  This reverts commit 25df42630e.

  Dean Herbert · 2023-12-18 22:46:02 +09:00
  d81cabc063
• Fix a few of silly issues
  Dean Herbert · 2023-12-18 22:45:58 +09:00
  25e3a8e82e
• Fix padding on dropdown search bar
  65-7a · 2023-12-19 00:28:23 +11:00
  17f1f8bb43
• Fix crash when creating collections named "All beatmaps" or "Manage collections..."

  Closes https://github.com/ppy/osu/issues/25834
  
  The name fallback that was there previously since
  https://github.com/ppy/osu/pull/11892 was half broken. This way should
  be a lot less prone to failure.

  Bartłomiej Dach · 2023-12-18 12:52:39 +01:00
  eeeb5aa3d4
• Add failing test for adding collection w/ name colliding w/\ default items
  Bartłomiej Dach · 2023-12-18 12:47:42 +01:00
  be16e0e538
• Improve performance of attemptSelection using new cached count and LastSelected
  Dean Herbert · 2023-12-18 20:47:08 +09:00
  25df42630e
• Cache non-filtered beatmap counts to massively improve count performance
  Dean Herbert · 2023-12-18 20:44:08 +09:00
  5755fa214a