2995 Commits

• Add unranked indicator to song select footer too
  Bartłomiej Dach · 2024-02-01 21:51:41 +01:00
  865f4d76ff
• Apply NRT to FooterButtonMods
  Bartłomiej Dach · 2024-02-01 21:32:38 +01:00
  f87ab19731
• Apply alternative solution

  Fixes the logo flying out of the wrong corner when transitioning from
  song select to gameplay.
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Bartłomiej Dach · 2024-01-29 20:07:27 +01:00
  acc2614090
• Fix osu! logo being mispositioned in song select on very wide resolutions
  Dean Herbert · 2024-01-29 20:45:51 +09:00
  f2546d72c2
• Avoid using .Children for enumeration in other locations
  Dean Herbert · 2024-01-23 05:32:11 +09:00
  02bb506cce
• Apply same fix in more places
  Dean Herbert · 2024-01-22 15:56:16 +09:00
  1f0ad5cff2
• Use container itself rather than ScrollContent
  Dean Herbert · 2024-01-22 15:54:24 +09:00
  74f05a5c4b
• Reduce allocation overhead in BeatmapCarousel
  Andrei Zavatski · 2024-01-22 03:12:23 +03:00
  cec4f670d1
• Fix scores not showing up on leaderboards during gameplay
  Dean Herbert · 2024-01-14 15:13:20 +09:00
  68496f7a0e
• Move current screen check to better place
  Bartłomiej Dach · 2024-01-09 10:44:30 +01:00
  66b3945cd6
• Fix crash when clicking osu! logo in song select immediately after exiting

  Closes https://github.com/ppy/osu/issues/26415.
  
  The crash report with incomplete log was backwards, the exit comes
  first. Sentry events and the reproducing test in
  8a87301c55 confirm this.

  Bartłomiej Dach · 2024-01-08 21:37:25 +01:00
  58db39ec32
• Merge pull request #26385 from peppy/carousel-thing

  Fix beatmap carousel not preloading panels when off-screen

  Bartłomiej Dach · 2024-01-08 19:37:34 +01:00
  70ba5dd0d3
• Restore comment regarding usage of MinBy
  Dean Herbert · 2024-01-09 01:08:47 +09:00
  51bd32bf7e
• Refactor delayed load logic to hopefully read better
  Dean Herbert · 2024-01-09 01:08:17 +09:00
  e77d203a24
• Remove scores from song select leaderboard when leaving the screen
  Dean Herbert · 2024-01-06 20:53:20 +09:00
  d3710f0bfd
• Load items closer to the centre of the screen as a priority
  Dean Herbert · 2024-01-04 19:25:12 +09:00
  81c6fd5589
• Fix beatmap carousel not preloading panels when off-screen
  Dean Herbert · 2024-01-04 19:25:12 +09:00
  adac3b65ce
• Update existing code to use helper method
  Salman Ahmed · 2023-12-31 05:18:07 +03:00
  4dc11c4c48
• Use 0.99x or 1.01x

  Signed-off-by: CaffeeLake <PascalCoffeeLake@gmail.com>

  CaffeeLake · 2023-12-31 00:47:09 +09:00
  bca0600482
• Fix song select leaderboard tab ordering not matching stable
  Dean Herbert · 2023-12-28 14:13:35 +09:00
  ffc8778d67
• Fix rewind backtracking
  Nathan Tran · 2023-12-25 15:27:32 -08:00
  060bf8beff
• adjust beatmap length and drain based on rate changing mods
  Simon G · 2023-12-22 03:04:48 +01:00
  b31b9e96d0
• Fix selection retention logic copy paste failure
  Dean Herbert · 2023-12-20 19:27:57 +09:00
  7fa4dcf0fb
• Fix beatmap updates causing one extra carousel selection
  Dean Herbert · 2023-12-20 19:15:02 +09:00
  e003462f7d
• Fix song select running updates when screen is not active

  Who would have guessed that `Schedule` calls were there for a reason!
  
  I've tidied things up. Most of the changes I've made here are not
  required – the schedule is the main thing here. The reason the sound was
  playing is because one-too-many schedules was removed causing beatmap
  updates to update carousel specifics while still at the player loader
  screen.
  
  Note that the selection sound still plays on returning to song select,
  but this is not a regression. I'm looking at fixing this in a separate
  PR because I'm in a good place as far as understanding the logic right
  now and it would be a waste to leave it broken.
  
  Closes https://github.com/ppy/osu/issues/25875.

  Dean Herbert · 2023-12-20 17:31:09 +09:00
  64f62e7d90
• Merge pull request #25900 from peppy/editor-from-any-carousel

  Allow choosing "Edit" from any beatmap carousel item

  Bartłomiej Dach · 2023-12-20 08:35:42 +01:00
  9a5027e556
• Merge pull request #25898 from peppy/song-select-stats

  Update song select to always show difficulty stats

  Dan Balasescu · 2023-12-20 14:39:35 +09:00
  3818977a36
• Apply proposed changes
  Dean Herbert · 2023-12-20 12:42:06 +09:00
  85e5d74a16
• Merge branch 'master' into fix-song-select-realm-refresh-performance
  Bartłomiej Dach · 2023-12-19 14:14:46 +01:00
  e306cc35ba
• Allow choosing "Edit" from any beatmap carousel item
  Dean Herbert · 2023-12-19 19:58:49 +09:00
  bbfdd6892d
• Add missing invalidation call
  Dean Herbert · 2023-12-19 19:39:48 +09:00
  502e3edac3
• Tidy up visual look
  Dean Herbert · 2023-12-19 19:28:02 +09:00
  3b848e8503
• Move advanced stats to a more permanent location on song select
  Dean Herbert · 2023-12-19 19:10:43 +09:00
  07bb0805e9
• Add support for dual-column advanced stats
  Dean Herbert · 2023-12-19 19:09:47 +09:00
  0a64d631e2
• Actually fix realm selection retention regression
  Dean Herbert · 2023-12-19 18:10:55 +09:00
  8f5d21dc70
• Use sender's realm (because we can)
  Dean Herbert · 2023-12-19 17:27:52 +09:00
  7e9c1b2acb
• Add more detail to exception
  Bartłomiej Dach · 2023-12-19 08:57:18 +01:00
  7c05d66bd7
• Fix incorrect ordering of items at song select when certain sort modes are used
  Dean Herbert · 2023-12-19 15:09:03 +09:00
  44efa2c540
• Revert "Improve performance of attemptSelection using new cached count and LastSelected"

  This reverts commit 25df42630e.

  Dean Herbert · 2023-12-18 22:46:02 +09:00
  d81cabc063
• Fix a few of silly issues
  Dean Herbert · 2023-12-18 22:45:58 +09:00
  25e3a8e82e
• Improve performance of attemptSelection using new cached count and LastSelected
  Dean Herbert · 2023-12-18 20:47:08 +09:00
  25df42630e
• Cache non-filtered beatmap counts to massively improve count performance
  Dean Herbert · 2023-12-18 20:44:08 +09:00
  5755fa214a
• Debounce count updates for good measure
  Dean Herbert · 2023-12-18 20:43:23 +09:00
  034c5cd654
• Simplify invalidation logic

  The only case where this was checking is guaranteed by realm to only be called once.

  Dean Herbert · 2023-12-18 20:31:02 +09:00
  6fa1f5ef9b
• Avoid calling invalidation logic per beatmap set updated

  Realm will batch the updates. We don't want to do expensive operations per set when we don't need to.

  Dean Herbert · 2023-12-18 20:31:02 +09:00
  87b7699fcc
• Combine multiple similar invalidation logic into single event
  Dean Herbert · 2023-12-18 20:31:02 +09:00
  32cc3f9ef7
• Merge pull request #25760 from bdach/if-i-speak-i-am-in-big-trouble-pt-1

  Fix `AdjustedAttributesTooltip` being broken by design

  Dean Herbert · 2023-12-15 12:26:10 +09:00
  48e89b903c
• Reduce some allocations in SongSelect in the mania ruleset
  Dan Balasescu · 2023-12-15 11:01:15 +09:00
  fbef40bb1f
• Fix AdjustedAttributesTooltip being broken by design

  Fixes issue described in the following comment:
  https://github.com/ppy/osu/pull/25759#issuecomment-1855954637
  
  That is just not how the tooltip system is supposed to be used.
  
  To name the individual sins:
  
  - Caching and returning a tooltip instance like the classes that used
    tooltips is incorrect. The lifetime of tooltip instances is managed by
    the tooltip container. `GetCustomTooltip()` is called by it
    exclusively. It should return a fresh instance every time.
  
  - Not putting actual data in `IHasCustomTooltip.TooltipContent` is
    wrong.
  
  - Having `Tooltip.SetContent()` be a no-op is *grossly and flagrantly*
    wrong.
  
  I'm not even sure which particular combination of the above
  transgressions caused the issue as it presented itself, but at this time
  I frankly do not care.

  Bartłomiej Dach · 2023-12-14 16:15:56 +01:00
  9e5b6b97ff
• Update AdvancedStats.cs
  Givikap120 · 2023-12-14 14:31:58 +02:00
  b22a7cf520