193 Commits

• Simplify playback logic
  Salman Ahmed · 2024-02-05 01:03:04 +03:00
  44a594ba05
• Remove unused parameter
  Salman Ahmed · 2024-02-02 00:44:51 +03:00
  4dbcb41dd1
• Play legacy applause sound only when rank is B or higher
  Salman Ahmed · 2024-02-01 16:08:36 +03:00
  5bbaeb6836
• Merge branch 'master' into fix-results-f-rank
  Salman Ahmed · 2024-02-01 15:29:07 +03:00
  35c3f5e250
• Remove ScorePerformanceCache

  This class was only used in two places, both on the results screen, but
  was holding references to `OsuPlayfield` game-wide (due to unrelated
  issues, but still).
  
  Because I can't really think of future use cases for this, and running
  the calculation twice at results screen isn't a huge overhead, let's
  just do that for now to keep things simple.

  Dean Herbert · 2024-01-29 15:28:20 +09:00
  76832a1495
• Force results screen to play default D rank applause sound on fail (regardless of skin)
  Salman Ahmed · 2024-01-27 01:46:43 +03:00
  d25262944e
• Fix results screen showing other rank badges on F rank
  Salman Ahmed · 2024-01-27 01:46:12 +03:00
  47f0b86018
• Fix crash at results screen when hidden is enabled and S rank becomes A due to miss

  Closes https://github.com/ppy/osu/issues/26692.

  Dean Herbert · 2024-01-25 15:02:44 +09:00
  37e370e654
• Apply more correct visual offset adjustment

  Co-authored-by: Walavouchey <36758269+Walavouchey@users.noreply.github.com>

  Dean Herbert · 2024-01-23 19:16:55 +09:00
  0cf90677e6
• Remove remnant of old implementation of showing "A due to misses"
  Bartłomiej Dach · 2024-01-22 19:58:11 +01:00
  45dc9de1e0
• Adjust results screen to handle S->A rank adjustment when misses are present
  Dean Herbert · 2024-01-22 21:43:32 +09:00
  83f9118b22
• Change rolling counters to use quicker easing types
  Dean Herbert · 2024-01-17 18:18:53 +09:00
  a66ddc7813
• Reorder badges so that SS shows above others

  This isn't perfect and probably needs much more consideration, but let's
  at least give the "better" ranks more visibility by bringing them to the
  front.
  
  Of note, this is only important due to the changes to osu!catch
  accuracy-grade cutoffs, which brings things closer in proximity than
  ever before.

  Dean Herbert · 2023-11-29 20:29:52 +09:00
  1cfcaee121
• Adjust catch score grade cutoffs
  Dan Balasescu · 2023-11-29 19:05:31 +09:00
  295a1b01d6
• Silence a few remaining nullability warnings
  Bartłomiej Dach · 2023-07-04 22:39:26 +02:00
  e2ddcb2349
• Automated pass
  Dean Herbert · 2023-06-24 01:00:03 +09:00
  0ab0c52ad5
• Also move GetMaxAchievableCombo
  Dean Herbert · 2023-06-16 15:26:13 +09:00
  362aa4b376
• Add tooltips to truncated text
  Joseph Madamba · 2023-06-08 19:44:07 -07:00
  85fedbd025
• Centralise accuracy cutoff constants and add lookup helper methods
  Dean Herbert · 2023-02-09 15:41:58 +09:00
  cf009432cc
• adjust RankNotch gap size to match original value
  Walavouchey · 2023-02-09 02:20:05 +01:00
  57312279f0
• move rank accuracy requirements to class-local constants
  Walavouchey · 2023-02-09 00:46:24 +01:00
  fd93bd3f50
• use Precision.AlmostEquals for bounds check
  Walavouchey · 2023-02-08 23:59:19 +01:00
  ee40444fd3
• display RankBadges on on their sector centres

  the D `RankBadge` does this anyway. the A and S badges are slightly off
  centre to prevent overlap with the SS badge

  Walavouchey · 2023-02-08 14:01:40 +01:00
  0531c010eb
• ensure AccuracyCircle doesn't land in gaps created by RankNotches
  Walavouchey · 2023-02-08 13:20:53 +01:00
  6ace6bfee1
• Use LocalisableStrings for date and time formats
  Susko3 · 2022-12-16 00:05:47 +01:00
  0f34d908c7
• Delete SmoothCircularProgress.cs
  Andrei Zavatski · 2022-12-03 16:40:41 +03:00
  41f7dad8e9
• Remove SmoothCircularProgress usage in AccuracyCircle
  Andrei Zavatski · 2022-12-03 16:39:44 +03:00
  97b6d88f00
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Refactor to avoid passing around bindables
  Dan Balasescu · 2022-09-16 13:14:25 +09:00
  d9499abc33
• Fixed irresponsiveness of score panel timestamp to time format
  Drison64 · 2022-09-16 13:50:18 +14:00
  4f208416be
• Remove async calls from ScoreManager
  Dan Balasescu · 2022-08-29 15:34:08 +09:00
  423f6f90f2
• Inline rolling duration
  Dean Herbert · 2022-07-23 02:38:00 +09:00
  db632c0d6e
• Simplify TotalScoreCounter tick playback logic
  Dean Herbert · 2022-07-23 02:27:17 +09:00
  bb46ba66e0
• Add total score counter sfx
  Jamie Taylor · 2022-07-22 21:03:47 +09:00
  89da21b6de
• Add panel appearance sounds
  Jamie Taylor · 2022-07-22 21:03:46 +09:00
  6ce8e74e6b
• Update parameter discards
  Dean Herbert · 2022-06-24 21:26:19 +09:00
  31a447fda0
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Fix difficulty name overflow in score panel
  Henry Lin · 2022-06-07 12:05:03 +08:00
  ef5d601f67
• Fix AccuracyCircle storing accuracy values in float
  Salman Ahmed · 2022-04-26 04:52:48 +03:00
  f958010d29
• Use existing web localisation for most hardcoded strings
  Joseph Madamba · 2022-04-20 16:31:11 -07:00
  5e5c8e78a6
• GetBeatmapMaximumComboAsync -> GetMaximumAchievableComboAsync
  Salman Ahmed · 2022-03-20 16:18:53 +03:00
  2a78042038
• Compute the beatmap maximum achievable combo instead of Beatmap.MaxCombo
  Salman Ahmed · 2022-03-20 05:38:14 +03:00
  eca7975864
• Update score panel to check for all combo-breaking statistics
  Salman Ahmed · 2022-03-18 15:23:14 +03:00
  fa8eb1feec
• Fix perfect combo check not accounting for LargeTickMiss

  `LargeTickMiss` can affect combo, see
  https://github.com/ppy/osu/blob/a352a140bc145f342fadc300797a2b05ade3f920/osu.Game/Rulesets/Scoring/HitResult.cs#L124-L144.

  Salman Ahmed · 2022-03-18 13:11:41 +03:00
  af22e67e15
• Display beatmap maximum combo in score panel
  Salman Ahmed · 2022-03-18 13:11:41 +03:00
  9215384229
• Fix performance statistic not handling rulesets with unimplemented calculator
  Salman Ahmed · 2022-03-01 20:43:20 +03:00
  97c54de3bf
• Remove tooltip from performance statistic
  Henry Lin · 2022-02-05 21:18:23 +08:00
  c35ef917a1
• Hide attribute if the maximum is 0
  Henry Lin · 2022-02-02 11:02:01 +08:00
  b4fd1ecba2
• Split total pp into 2 lines
  Henry Lin · 2022-02-01 22:26:30 +08:00
  39524f3dd2
• Schedule setPerformanceValue
  Henry Lin · 2022-01-21 08:54:08 +08:00
  e0fe8af365