14223 Commits

• Merge branch 'master' into fix-results-f-rank
  Bartłomiej Dach · 2024-02-05 13:05:37 +01:00
  ad69259eb8
• Simplify playback logic
  Salman Ahmed · 2024-02-05 01:03:04 +03:00
  44a594ba05
• Merge pull request #26934 from bdach/which-mods-for-pp

  Display which mods grant pp

  Dean Herbert · 2024-02-04 19:15:11 +08:00
  c64d414d1b
• Update R# + fix inspections
  Dan Balasescu · 2024-02-02 21:00:28 +09:00
  b44f77cee1
• Remove unused parameter
  Salman Ahmed · 2024-02-02 00:44:51 +03:00
  4dbcb41dd1
• Add unranked indicator to song select footer too
  Bartłomiej Dach · 2024-02-01 21:51:41 +01:00
  865f4d76ff
• Apply NRT to FooterButtonMods
  Bartłomiej Dach · 2024-02-01 21:32:38 +01:00
  f87ab19731
• Play legacy applause sound only when rank is B or higher
  Salman Ahmed · 2024-02-01 16:08:36 +03:00
  5bbaeb6836
• Merge branch 'master' into fix-results-f-rank
  Salman Ahmed · 2024-02-01 15:29:07 +03:00
  35c3f5e250
• Show login overlay at main menu when 2FA is required
  Dean Herbert · 2024-02-01 21:10:53 +09:00
  bf3746daa8
• Show a better message when score submission fails due to system clock being set wrong
  Dean Herbert · 2024-01-31 16:52:50 +09:00
  a7f9f50ce5
• Apply alternative solution

  Fixes the logo flying out of the wrong corner when transitioning from
  song select to gameplay.
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Bartłomiej Dach · 2024-01-29 20:07:27 +01:00
  acc2614090
• Fix osu! logo being mispositioned in song select on very wide resolutions
  Dean Herbert · 2024-01-29 20:45:51 +09:00
  f2546d72c2
• Merge pull request #26616 from peppy/dont-round-sv
  Dean Herbert · 2024-01-29 20:42:38 +09:00
  811b31386b
• Merge pull request #26772 from peppy/update-framework

  Update framework

  Dean Herbert · 2024-01-29 20:15:01 +09:00
  f1c1d9cb14
• Merge branch 'master' into dont-round-sv
  Bartłomiej Dach · 2024-01-29 11:52:46 +01:00
  11ec8a1cad
• Apply local precision workaround to editor effect section
  Bartłomiej Dach · 2024-01-29 11:52:38 +01:00
  8a11ff1227
• Merge pull request #26751 from frenzibyte/fix-multiplayer-fail-freezing-score

  Fix score processor no longer applying results when failing in multiplayer match

  Dean Herbert · 2024-01-29 19:51:31 +09:00
  a1fe5eedd5
• Update resources
  Dean Herbert · 2024-01-29 19:33:13 +09:00
  dc28a6b873
• Mark ResultsScreen.Score as nullable

  Is nullable in playlist results at very least.

  Dean Herbert · 2024-01-29 16:43:26 +09:00
  fb24c66342
• Add safety in ResultsScreen.Exit to ensure HitEvents are not holding references

  This is a catch-all safety disconnecting `ScoreInfo` from `HitObject`s.

  Dean Herbert · 2024-01-29 16:16:17 +09:00
  eb90ee5415
• Remove ScorePerformanceCache

  This class was only used in two places, both on the results screen, but
  was holding references to `OsuPlayfield` game-wide (due to unrelated
  issues, but still).
  
  Because I can't really think of future use cases for this, and running
  the calculation twice at results screen isn't a huge overhead, let's
  just do that for now to keep things simple.

  Dean Herbert · 2024-01-29 15:28:20 +09:00
  76832a1495
• Remove unnecessary bindable
  Dean Herbert · 2024-01-29 02:13:39 +09:00
  462dab3c90
• Fix various inconsistencies and document better
  Dean Herbert · 2024-01-29 02:10:33 +09:00
  f4dd84fa77
• Should not be a container
  Dean Herbert · 2024-01-29 01:50:27 +09:00
  23f12e1ea3
• Stop using SliderBar as a base
  Andrei Zavatski · 2024-01-28 18:06:09 +03:00
  b48f99ba4b
• Merge branch 'master' into progress-bar-improvements
  Andrei Zavatski · 2024-01-28 17:59:29 +03:00
  ed9e0fe1db
• Move solution to multiplayer flow instead
  Salman Ahmed · 2024-01-28 00:42:04 +03:00
  64b61108ad
• Fix score processor no longer applying results when failing in multiplayer match
  Salman Ahmed · 2024-01-27 23:23:10 +03:00
  a25be9927d
• Rename GameplayState.HasFailed to properly clarify its meaning
  Salman Ahmed · 2024-01-27 23:23:10 +03:00
  ea641bb8d2
• Clamp logo triangles along both axes
  Andrei Zavatski · 2024-01-27 19:06:04 +03:00
  9d73d0e04d
• Merge pull request #26704 from peppy/new-logo

  Update logo

  Dean Herbert · 2024-01-27 19:34:22 +09:00
  3cad5fe292
• Fix song progress value may go beyond 1
  Andrei Zavatski · 2024-01-27 03:11:12 +03:00
  3387565ba9
• Refactor ArgonSongProgress for same CurrentTime meaning
  Andrei Zavatski · 2024-01-27 03:03:01 +03:00
  567d2bedbf
• Force results screen to play default D rank applause sound on fail (regardless of skin)
  Salman Ahmed · 2024-01-27 01:46:43 +03:00
  d25262944e
• Fix results screen showing other rank badges on F rank
  Salman Ahmed · 2024-01-27 01:46:12 +03:00
  47f0b86018
• Move cast to local function and make direct cast
  Dean Herbert · 2024-01-26 12:55:36 +09:00
  6e3eb674f6
• Move common logic into own SongProgressBar class
  Andrei Zavatski · 2024-01-26 05:03:40 +03:00
  9b5b313193
• Remove useless bindable from ArgonSongProgressBar
  Andrei Zavatski · 2024-01-26 04:09:00 +03:00
  d2af05b30e
• Remove LINQ cast in HUDOverlay
  Andrei Zavatski · 2024-01-26 01:03:22 +03:00
  542f571dee
• Adjust spawn ratio up slightly
  Dean Herbert · 2024-01-25 21:59:38 +09:00
  6a338ce555
• Merge pull request #26689 from myQwil/divisor_cycle

  Prevent custom divisor ranges from halting divisor preset cycling

  Dean Herbert · 2024-01-25 20:46:16 +09:00
  baaf33d995
• Update logo to new version
  Dean Herbert · 2024-01-25 20:37:50 +09:00
  4a629fbc79
• Change name and description of force parameter in SetArbitraryDivisor
  Mike Will · 2024-01-25 05:12:54 -05:00
  a264ac9f38
• Fix crash at results screen when hidden is enabled and S rank becomes A due to miss

  Closes https://github.com/ppy/osu/issues/26692.

  Dean Herbert · 2024-01-25 15:02:44 +09:00
  37e370e654
• Fix ArgonScoreCounter is still using localisation
  Andrei Zavatski · 2024-01-25 03:28:02 +03:00
  7811968582
• Prevent custom divisor ranges from halting preset cycling

  A custom divisor like 24 or 32 will result in a range containing
  many divisors that are already in the `Common` and `Triplets` presets.
  When this happens, it can become impossible to cycle between presets,
  because the preset can only be changed if the new divisor isn't already
  contained within the current preset's range.

  Mike Will · 2024-01-24 18:31:39 -05:00
  9e1c242713
• Merge pull request #26630 from peppy/s-rank-change

  Change S rank to require no miss

  Dean Herbert · 2024-01-24 13:27:40 +09:00
  b272d34960
• Apply more correct visual offset adjustment

  Co-authored-by: Walavouchey <36758269+Walavouchey@users.noreply.github.com>

  Dean Herbert · 2024-01-23 19:16:55 +09:00
  0cf90677e6
• Avoid using .Children for enumeration in other locations
  Dean Herbert · 2024-01-23 05:32:11 +09:00
  02bb506cce