297 Commits

• Display mod icons using stable ordering

  In discussion with nanaya, we likely want this now that we're adding the
  ability for some icons to be extended. Historically mod icons have been
  displayed in a stable but arbitrary order (based on their position in
  the `Mods` enum).
  
  This change aims to make them stable across lazer scores (where they are
  stored based on .. the order the user selected them).

  Dean Herbert · 2023-09-28 16:48:09 +09:00
  7d74d84e6c
• Silence a few remaining nullability warnings
  Bartłomiej Dach · 2023-07-04 22:39:26 +02:00
  e2ddcb2349
• Automated pass
  Dean Herbert · 2023-06-24 01:00:03 +09:00
  0ab0c52ad5
• Move OrderByTotalScore() to an extension method
  Dean Herbert · 2023-06-16 15:24:30 +09:00
  ce41ef6e5d
• Replace all hardcoded 50 horizontal padding with const
  Joseph Madamba · 2023-04-02 20:50:18 -07:00
  af389b1107
• Fix parameters with the same default value inspection
  Joseph Madamba · 2022-12-25 16:15:02 -08:00
  973fd90af2
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Remove async calls from ScoreManager
  Dan Balasescu · 2022-08-29 15:34:08 +09:00
  423f6f90f2
• Localise hit result name
  naoei · 2022-08-14 14:57:02 -04:00
  45e9eda9e7
• Display placeholder for leaderboard top scores
  Salman Ahmed · 2022-07-25 09:18:04 +03:00
  f54cee0270
• Separate unprocessed PP placeholder to own class
  Salman Ahmed · 2022-07-25 09:07:51 +03:00
  91d1c9686c
• Display exclamation triangle on scores with unprocessed PP
  Salman Ahmed · 2022-07-25 07:30:57 +03:00
  54eb2b98a9
• Fix beatmap overlay leaderboard not handling null PP scores properly
  Salman Ahmed · 2022-07-24 04:20:49 +03:00
  7c477e6f22
• Highlight perfect slider tick/end values in beatmap info leaderboards
  Salman Ahmed · 2022-07-20 00:53:10 +03:00
  1270abdf42
• Country -> CountryCode
  Salman Ahmed · 2022-07-18 08:40:34 +03:00
  100c53f9ef
• Rename placeholder display flag property to make sense
  Salman Ahmed · 2022-07-16 06:07:53 +03:00
  4968859e69
• Combine ScoreInfo construction helper methods
  Dean Herbert · 2022-07-12 18:00:25 +09:00
  f956955d4d
• Add and consume SoloScoreInfo
  Dean Herbert · 2022-07-12 18:00:25 +09:00
  1bef2d7b39
• Update parameter discards
  Dean Herbert · 2022-06-24 21:26:19 +09:00
  31a447fda0
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Update flag sizes after switch to twemoji assets

  The old flags used a size of 150x100, while the new assets based on
  twemoji use a size of 150x108. Update existing usages to match this new
  aspect ratio better.

  Bartłomiej Dach · 2022-06-15 21:45:47 +02:00
  f88c568c8d
• Always show mod selector on beatmap info leaderboards regardless of supporter
  Joseph Madamba · 2022-06-08 13:22:49 -07:00
  f3371e8bc8
• Fix beatmap info scores container not hiding when there's no leaderboard
  Joseph Madamba · 2022-05-26 19:50:54 -07:00
  3554563114
• Fix IDE0005 and IDE0034
  Huo Yaoyuan · 2022-05-03 13:09:19 +08:00
  7cf4dabe29
• Fix localisation use cases not falling back to default(LocalisableString)

  Previously such use cases have been returning `null` values just fine since `GetLocalisableString` was returning `LocalisableFormattableString`, and these null values were wrapped in `LocalisableString`s implicitly, therefore not requiring an explicit fallback string and `null` doesn't break anything.

  Salman Ahmed · 2022-04-28 11:21:00 +03:00
  be2d616e34
• Use existing web localisation for most hardcoded strings
  Joseph Madamba · 2022-04-20 16:31:11 -07:00
  5e5c8e78a6
• Resolve inspection issues
  Dan Balasescu · 2022-04-14 13:11:11 +09:00
  494955aff1
• Obsolete BeatmapInfo.MaxCombo and suppress in usages
  Salman Ahmed · 2022-03-20 16:30:29 +03:00
  b9859f9f21
• Fix scores not being recalculated in beatmap listing
  Dan Balasescu · 2022-03-08 19:07:39 +09:00
  f5cd967635
• Move to extension method and revert logic to match previous implementation
  Dean Herbert · 2022-02-21 13:42:26 +09:00
  fc1877b6fa
• Add xmldoc and clean up ScoreboardTimeUtils extension methods a touch
  Dean Herbert · 2022-02-21 13:30:58 +09:00
  79408f6afc
• Merge scoreboard and leaderboard implementations together
  dekrain · 2022-02-19 20:47:02 +01:00
  15ed9ec4fa
• Fix a couple of cases of incorrect equality checks in the case both values are null
  Dean Herbert · 2022-01-28 14:29:56 +09:00
  b7d8c9bf06
• Merge branch 'master' into realm-integration/score-and-beatmaps
  Dean Herbert · 2022-01-18 15:07:59 +09:00
  1b62a685f3
• Improve ScoresContainer loading overlay logic to work better with tests
  Dean Herbert · 2022-01-17 15:15:39 +09:00
  51ade3251d
• Fix null reference in equality comparison causing beatmap set overlay to crash
  Dean Herbert · 2022-01-17 13:05:55 +09:00
  88bf406c22
• Fix some null inspections
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  3811bd8520
• more fixes (almost compiles, except ruleset and manager)
  Dean Herbert · 2022-01-12 16:57:27 +09:00
  53792811b2
• Merge branch 'master' into async-deadlock-safety
  Dan Balasescu · 2022-01-10 16:11:09 +09:00
  af9fad00c3
• Add score time to beatmap set overlay scoreboard table
  Bartłomiej Dach · 2022-01-07 19:18:16 +01:00
  9e84e31eac
• Implement scoreboard-specific time formatting
  Bartłomiej Dach · 2022-01-07 19:18:16 +01:00
  87f7c7e691
• Add basic test scene for scoreboard time
  Bartłomiej Dach · 2022-01-07 19:18:16 +01:00
  881fa2b86b
• Update usages to new naming
  Dean Herbert · 2022-01-06 22:54:43 +09:00
  00177a3ae1
• Update continuation usages to use GetCompletedResult
  Dean Herbert · 2022-01-06 22:53:07 +09:00
  3ea7588a91
• Replace usage of .Result with .WaitSafelyForResult
  Dean Herbert · 2022-01-04 11:51:41 +09:00
  73b40e6833
• Use OnlineID instead of legacy IDs for equality and lookups
  Dean Herbert · 2021-12-10 16:11:48 +09:00
  bf1418bafc
• Rename BeatmapSetOnlineStatus to BeatmapOnlineStatus

  This variable is used at more than just a set level.

  Dean Herbert · 2021-11-24 18:42:49 +09:00
  183b95cbc2
• Rename User to APIUser and move to correct namespace
  Dean Herbert · 2021-11-07 11:26:01 +09:00
  0ecf5f201c
• Also propagate Status in temporary BeatmapInfo usage
  Dean Herbert · 2021-11-05 14:44:58 +09:00
  9f9ef570ee
• Update ScoresContainer to not use ToBeatmapInfo
  Dean Herbert · 2021-11-04 17:09:53 +09:00
  08d94f864f