32 Commits

• Fix control points not being cloned when running beatmap conversion

  Closes #20994.
  
  I haven't considered how this affects performance of difficulty
  calculation or otherwise. Seems like a sane initial fix which we can
  iterate on going forward.
  
  I've tested using the scenario in the linked issue.
  
  I'm not going to add test coverage because
  [BeatmapConversionTest](https://github.com/ppy/osu/blob/master/osu.Game/Tests/Beatmaps/BeatmapConversionTest.cs)
  should correctly cover this scenario once we are serialising control
  points as well.

  Dean Herbert · 2022-11-01 17:42:09 +09:00
  978d15955c
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Shallow clone BeatmapInfo during conversion process to avoid overwriting fields
  Dean Herbert · 2021-10-12 16:43:56 +09:00
  1373cc02d7
• Remove obsolete code
  smoogipoo · 2021-04-09 13:56:58 +09:00
  8293b06c0a
• Fix a couple of new inspections introduced in Rider EAPs
  Dean Herbert · 2021-03-15 13:35:08 +09:00
  6d4c1ba2ae
• Rework to support obsoletion
  smoogipoo · 2020-09-17 21:37:32 +09:00
  de5ef8a471
• Make beatmap conversion support cancellation tokens
  smoogipoo · 2020-09-17 17:40:05 +09:00
  c7d24203ce
• Fix potential out-of-order objects after conversion
  smoogipoo · 2020-07-13 16:52:05 +09:00
  1116703e92
• Merge branch 'master' into remove-legacy-id
  Dan Balasescu · 2019-12-25 21:01:12 +09:00
  9702cc9809
• Provide the ruleset to converter classes
  Dean Herbert · 2019-12-24 16:02:16 +09:00
  0677f746aa
• Simplify/improve beatmap conversion precheck
  smoogipoo · 2019-12-23 17:44:18 +09:00
  6e7426a098
• Turn on warnings, resolve issues
  smoogipoo · 2019-04-25 17:36:17 +09:00
  0bd35ab7bb
• Fix remaining issues
  Dean Herbert · 2019-02-28 13:31:40 +09:00
  26d53d06a9
• Update licence header (and remove year)
  Dean Herbert · 2019-01-24 17:43:03 +09:00
  8617aaa2a7
• Cleanups
  smoogipoo · 2018-10-17 10:53:21 +09:00
  d431dd59a8
• Fix beatmap conversion tests failing
  smoogipoo · 2018-10-16 12:01:58 +09:00
  41391a6627
• Simplify linq from beatmap conversion
  smoogipoo · 2018-10-11 20:29:37 +09:00
  fb1760f580
• Don't deep-clone beatmapinfo/control points
  smoogipoo · 2018-05-17 13:17:33 +09:00
  397d93660a
• Fix not being able to convert beatmaps with 0 hitobjects
  smoogipoo · 2018-05-07 15:27:45 +09:00
  30a3f4f29f
• Initial rework of beatmap conversion process
  smoogipoo · 2018-04-19 22:04:12 +09:00
  03a5df84c6
• Use IBeatmap wherever possible
  smoogipoo · 2018-04-19 20:44:38 +09:00
  66b3b295e7
• Make an interface for beatmaps
  smoogipoo · 2018-04-19 18:58:40 +09:00
  b5a55a0dce
• Normalize all the line endings
  Dean Herbert · 2018-04-13 18:26:38 +09:00
  32a74f95a5
• Move combo colours completely out of beatmap
  Dean Herbert · 2018-03-20 16:24:06 +09:00
  9a0fc9e29a
• Fix combo colours not working until now
  Dean Herbert · 2018-03-13 19:19:08 +09:00
  16eab2eebf
• Rename to IBeatmapConverter, move to separate file
  smoogipoo · 2018-03-02 20:19:47 +09:00
  a2c239d5e3
• Implement basic structure for beatmap conversion testing
  smoogipoo · 2018-03-02 13:13:00 +09:00
  797d03a65f
• Update licence headers
  Dean Herbert · 2018-01-05 20:21:19 +09:00
  37d393bca0
• Remove AvailableColumns from ManiaRulesetContainer

  Also restructures with the addition of a ManiaBeatmap which holds definitions for "groups" of columns. At the moment these are empty save for a "Column" property, but can be expanded in the future, maybe.

  smoogipoo · 2018-01-03 18:44:25 +09:00
  bd171926d6
• Fix spelling and grammar
  Dean Herbert · 2017-11-28 21:30:03 +09:00
  23b4d2163c
• Add note about sequential execution of ConvertHitObject
  Dean Herbert · 2017-11-28 18:33:41 +09:00
  bd88df2722
• And then everything became one
  Dean Herbert · 2017-09-19 16:06:58 +09:00
  6d3d485565