184 Commits

• Merge branch 'master' into fix-results-f-rank
  Bartłomiej Dach · 2024-02-05 13:05:37 +01:00
  ad69259eb8
• Use better test step name
  Bartłomiej Dach · 2024-02-05 13:05:28 +01:00
  989e46c791
• Update R# + fix inspections
  Dan Balasescu · 2024-02-02 21:00:28 +09:00
  b44f77cee1
• Add step for toggling skins in results screen test scene
  Salman Ahmed · 2024-02-01 16:08:48 +03:00
  6ab8960fdc
• Merge branch 'master' into fix-results-f-rank
  Salman Ahmed · 2024-02-01 15:29:07 +03:00
  35c3f5e250
• Fix more nullable inspections
  Bartłomiej Dach · 2024-01-29 08:44:27 +01:00
  a41ba7c381
• Add visual and failing test cases
  Salman Ahmed · 2024-01-27 01:45:39 +03:00
  2ccd0e3692
• Add test coverage of hidden scores on accuracy circle
  Dean Herbert · 2024-01-25 15:02:44 +09:00
  f22bfa350a
• Adjust results screen to handle S->A rank adjustment when misses are present
  Dean Herbert · 2024-01-22 21:43:32 +09:00
  83f9118b22
• Change S rank to require no miss
  Dean Herbert · 2024-01-22 21:43:32 +09:00
  c8521b49cd
• Adjust catch score grade cutoffs
  Dan Balasescu · 2023-11-29 19:05:31 +09:00
  295a1b01d6
• Merge pull request #25415 from Poyo-SSB-forks/unify-ur

  Change unstable rate calculation to account for rate-change mods

  Dan Balasescu · 2023-11-23 09:53:28 +09:00
  30309cdf11
• Fix broken tests
  Poyo · 2023-11-12 11:13:38 -08:00
  d123ba5bce
• Disable new rider EAP inspection in test class
  Dean Herbert · 2023-11-12 17:21:17 +09:00
  31feeb5ddc
• Fix results screen test failure
  Bartłomiej Dach · 2023-10-27 13:22:17 +02:00
  32fc19ea0d
• Crudely fix crashes when switching between TestResultsWithPlayer cases

  In the visual test browser, if two `TestResultsWithPlayer` test cases
  are ran consecutively, the second would die on `SoloStatisticsWatcher`
  seeing duplicated online score IDs. This surfaced after
  6ef39b87fe, which changed
  `TestResultsScreen` to inherit `SoloResultsScreen` rather than
  `ResultsScreen`.
  
  This is probably _not_ a very good fix, but I'm trying to be pragmatic
  for now. `SoloStatisticsWatcher` should probably not live in
  `OsuGameBase`.

  Bartłomiej Dach · 2023-07-13 19:06:02 +02:00
  4b06b6f34e
• Reorder tests for testability
  Dean Herbert · 2023-07-13 18:12:46 +09:00
  6ef39b87fe
• Add actual statistics changes to better visualise layout
  Dean Herbert · 2023-07-13 18:12:46 +09:00
  654a7057fc
• Show online stats on TestSceneStatisticsPanel

  Fix test regression

  Dean Herbert · 2023-07-13 18:12:37 +09:00
  aebbffacf2
• Add full statistics score to TestSceneResultsScreen
  Dean Herbert · 2023-07-13 18:12:35 +09:00
  b7ab46d87b
• Change order and test population in TestSceneStatisticsPanel to give better visible results
  Dean Herbert · 2023-07-13 18:12:19 +09:00
  6529c810fa
• Silence a few remaining nullability warnings
  Bartłomiej Dach · 2023-07-04 22:39:26 +02:00
  e2ddcb2349
• Make ScoreInfo.BeatmapInfo nullable
  Dean Herbert · 2023-07-04 14:50:34 +09:00
  d74b1e148d
• Fix remaining obvious CI inspections
  Bartłomiej Dach · 2023-06-24 16:07:01 +02:00
  e3a89a6273
• Automated pass
  Dean Herbert · 2023-06-24 01:00:03 +09:00
  0ab0c52ad5
• Return StatisticItems rather than StatisticRows from ruleset

  There were no usages of more than one column being provided per row, so
  it seemed like unnecessarily complexity. I'm currently trying to reduce
  complexity so we can improve the layout of the results screen, which
  currently has up to three levels of nested `GridContainer`s.
  
  Of note, I can't add backwards compatibility because the method
  signature has not changed in `Ruleset` (only the return type). If we do
  want to keep compatibility with other rulesets, we could designate a new
  name for the updated method.

  Dean Herbert · 2023-06-01 14:35:15 +09:00
  985604fab5
• Simplify TestSceneAccuracyCircle test specifications
  Dean Herbert · 2023-02-09 15:42:03 +09:00
  92eb6b6717
• use values closer to the extremities for test cases
  Walavouchey · 2023-02-09 00:02:32 +01:00
  9544a1d26d
• ensure AccuracyCircle doesn't land in gaps created by RankNotches
  Walavouchey · 2023-02-08 13:20:53 +01:00
  6ace6bfee1
• Fix invalid data in test scene
  Bartłomiej Dach · 2022-12-27 19:49:08 +01:00
  e2703bba18
• Fix weird using statement
  Dean Herbert · 2022-12-24 21:48:04 +08:00
  8c7814aaf0
• Remove unused constructor param
  Bartłomiej Dach · 2022-12-24 10:44:38 +01:00
  83a50816b6
• Use plain bindable flow instead of binding to watcher directly
  Bartłomiej Dach · 2022-12-24 10:27:28 +01:00
  4e5109a649
• Implement overall ranking display for solo results screen
  Bartłomiej Dach · 2022-12-24 00:30:38 +01:00
  c7f248e13c
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• test(osu.Game): add slider steps to change the size in timing distribution graph tests
  Acid Chicken (硫酸鶏) · 2022-09-12 04:43:15 +09:00
  bb3d5bc9f4
• Tidy up test logic
  Dean Herbert · 2022-09-07 16:43:48 +09:00
  cb1bb99208
• refactor(osu.Game): improve code quality
  Acid Chicken (硫酸鶏) · 2022-09-07 02:29:15 +09:00
  3003fc1061
• style(osu.Game): fix multiple blank lines
  Acid Chicken (硫酸鶏) · 2022-09-05 07:49:29 +00:00
  6946015d17
• test(osu.Game): add more test cases for HitTimingDistributionGraph
  Acid Chicken (硫酸鶏) · 2022-09-05 03:46:23 +09:00
  19ab1433c6
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Fix difficulty name overflow in score panel
  Henry Lin · 2022-06-07 12:05:03 +08:00
  ef5d601f67
• Fix unobserved exceptions due to unimplemented beatmap converter

  `TestSceneStatisticsPanel` intends to check the operation of statistics
  panels using dummy ruleset classes. However, `StatisticsPanel` relies on
  being able to retrieve the playable beatmap, which requires a converter.
  One was not provided by the dummy rulesets, therefore the retrieval
  would fail with an unobserved exception.
  
  To fix, add a barebones converter implementation that is enough for the
  test to pass.

  Bartłomiej Dach · 2022-05-28 14:10:57 +02:00
  e18fec3d89
• Fix intermittent test failures in results screen
  Salman Ahmed · 2022-05-11 18:28:30 +03:00
  9d30b490ad
• Add method for scaling results screen in tests
  Salman Ahmed · 2022-05-08 16:00:07 +03:00
  077c77d524
• Restructure PerformanceCalculator to not require ScoreInfo argument
  Dan Balasescu · 2022-03-14 14:25:28 +09:00
  4a3e3aba65
• Fix score order related test failure
  Dan Balasescu · 2022-03-08 23:35:35 +09:00
  e9a2d23542
• Decrease overhead of hit event distribution tests
  Dean Herbert · 2022-03-04 14:56:49 +09:00
  92cd8ee29f
• Add the ability to set and show an offset value on timing distribution graph
  Dean Herbert · 2022-03-04 14:36:15 +09:00
  540d7d0e2c
• Fix hit distribution graph midpoint rounding not looking great around zero

  Not sure this will be accepted and it's likely only ever going to show
  in tests, but seems to be a better approach to midpoint rounding for
  this case?

  Dean Herbert · 2022-03-03 15:43:02 +09:00
  a06d806fb9