36396 Commits

This Branch

This Branch

All Branches

• Merge pull request #11662 from smoogipoo/refactor-mod-sections

  Refactor mod sections and make them overridable

  Dean Herbert · 2021-02-02 23:12:34 +09:00
  abb32d11b5
• Merge pull request #11642 from peppy/mod-consistency-function

  Fix invalid mod combinations potentially being selectable at a game level

  Dean Herbert · 2021-02-02 20:46:05 +09:00
  2d7c3d95c0
• Refactor mod sections and make them overridable
  smoogipoo · 2021-02-02 20:11:40 +09:00
  3741f05ab3
• Merge branch 'master' into mod-consistency-function
  Dean Herbert · 2021-02-02 20:01:42 +09:00
  ac5662b1aa
• Merge pull request #11640 from smoogipoo/add-mod-utils

  Add ModUtils class for validating mod usages

  Dean Herbert · 2021-02-02 20:01:20 +09:00
  4ecbe058f7
• Remove unused using statement
  Dean Herbert · 2021-02-02 19:22:13 +09:00
  8e70a50af0
• Add codeanalysis attribute
  smoogipoo · 2021-02-02 19:02:09 +09:00
  180af3c7f8
• Use TestCaseSource and add multi-mod test
  smoogipoo · 2021-02-02 18:51:13 +09:00
  0a9861d0ab
• Reuse existing method
  smoogipoo · 2021-02-02 18:42:02 +09:00
  052cf1abae
• Merge branch 'add-mod-utils' into mod-consistency-function
  smoogipoo · 2021-02-02 18:41:35 +09:00
  5881b8be96
• Merge pull request #11637 from frenzibyte/improve-chat-autoscroll

  Improve auto-scrolling logic for drawable channels

  Dean Herbert · 2021-02-02 18:40:25 +09:00
  c41c854ce3
• Prevent multiple enumeration
  smoogipoo · 2021-02-02 18:37:11 +09:00
  12f52316cd
• Make more tests use the custom mod classes

  For safety purposes... In implementing the previous tests, I found that
  using mod.Object.GetType() can lead to bad assertions since the same
  ModProxy class is used for all mocked classes.

  smoogipoo · 2021-02-02 18:33:14 +09:00
  9955e02898
• Fix incorrect handling of multi-mod incompatibilities
  smoogipoo · 2021-02-02 18:31:08 +09:00
  1df412a03c
• Simplify implementation of CheckCompatibleSet
  smoogipoo · 2021-02-02 18:18:57 +09:00
  d0655c21c6
• Fix incorrect implementation
  smoogipoo · 2021-02-02 18:01:38 +09:00
  8232d9d2fe
• Add failing tests
  smoogipoo · 2021-02-02 18:01:33 +09:00
  7c29386717
• Merge pull request #11657 from peppy/fix-playlist-lounge-test-scene

  Fix PlaylistLoungeTestScene appearing very narrow

  Dan Balasescu · 2021-02-02 17:33:14 +09:00
  45758a5f7f
• Merge pull request #11658 from peppy/playlists-settings-taller-area

  Make playlist settings area taller to better match screen aspect ratio

  Dan Balasescu · 2021-02-02 17:32:47 +09:00
  627c55f748
• Make playlist settings area taller to better match screen aspect ratio
  Dean Herbert · 2021-02-02 16:30:45 +09:00
  bdc05af4b7
• Remove unused using statement
  Dean Herbert · 2021-02-02 16:18:55 +09:00
  43052991f8
• Remove empty parenthesis
  Dean Herbert · 2021-02-02 16:11:13 +09:00
  3002fef05e
• Fix PlaylistLoungeTestScene appearing very narrow
  Dean Herbert · 2021-02-02 16:04:42 +09:00
  54c0bdf7d3
• Use Update instead of UpdateAfterChildren (no need for the latter)
  Dean Herbert · 2021-02-02 15:57:17 +09:00
  a76314a876
• Add coverage of local echo messages performing automatic scrolling
  Dean Herbert · 2021-02-02 15:46:42 +09:00
  b3105fb292
• Add test coverage of user scroll overriding
  Dean Herbert · 2021-02-02 15:44:11 +09:00
  3670bd40c2
• Use a better method of cancelling user scroll
  Dean Herbert · 2021-02-02 15:44:03 +09:00
  bb0753f68d
• Use UserTrackingScrollContainer instead
  Dean Herbert · 2021-02-02 15:29:38 +09:00
  398ab9c2c2
• Add "new" override for ScrollToEnd To UserTrackingScrollContainer
  Dean Herbert · 2021-02-02 15:16:28 +09:00
  ed63b571d2
• Merge pull request #11647 from ppy/dependabot/nuget/Sentry-3.0.1

  Bump Sentry from 2.1.8 to 3.0.1

  Dean Herbert · 2021-02-02 14:43:06 +09:00
  44ed705388
• Fix typo in xmldoc
  Dean Herbert · 2021-02-02 14:14:31 +09:00
  1c645601d4
• Add basic test coverage of CheckValidForGameplay function
  Dean Herbert · 2021-02-02 14:13:50 +09:00
  80d88024d6
• Update sentry sdk usage
  Dean Herbert · 2021-02-02 13:34:37 +09:00
  0d5353008c
• Remove no longer necessary field
  Salman Ahmed · 2021-02-01 22:38:42 +03:00
  dcb1626e4d
• Bump Sentry from 2.1.8 to 3.0.1

  Bumps [Sentry](https://github.com/getsentry/sentry-dotnet) from 2.1.8 to 3.0.1.
  - [Release notes](https://github.com/getsentry/sentry-dotnet/releases)
  - [Changelog](https://github.com/getsentry/sentry-dotnet/blob/main/CHANGELOG.md)
  - [Commits](https://github.com/getsentry/sentry-dotnet/compare/2.1.8...3.0.1)
  
  Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

  dependabot-preview[bot] · 2021-02-01 19:16:51 +00:00
  216b0d89a7
• Merge pull request #11644 from ppy/dependabot/nuget/DiscordRichPresence-1.0.175

  Bump DiscordRichPresence from 1.0.169 to 1.0.175

  Dean Herbert · 2021-02-02 04:15:30 +09:00
  344dc5d6a9
• Unconditionally set "autoscroll" state
  Salman Ahmed · 2021-02-01 22:08:57 +03:00
  5c28c030c8
• Add documentation to auto-scroll leniency

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Salman Ahmed · 2021-02-01 22:04:44 +03:00
  15fcabb128
• Merge pull request #11646 from ppy/dependabot/nuget/ppy.osu.Framework.NativeLibs-2021.115.0
  Dean Herbert · 2021-02-02 03:20:00 +09:00
  6ec4cf20d3
• Bump DiscordRichPresence from 1.0.169 to 1.0.175

  Bumps [DiscordRichPresence](https://github.com/Lachee/discord-rpc-csharp) from 1.0.169 to 1.0.175.
  - [Release notes](https://github.com/Lachee/discord-rpc-csharp/releases)
  - [Commits](https://github.com/Lachee/discord-rpc-csharp/commits)
  
  Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

  dependabot-preview[bot] · 2021-02-01 18:09:07 +00:00
  57213e6308
• Bump ppy.osu.Framework.NativeLibs from 2020.923.0 to 2021.115.0

  Bumps [ppy.osu.Framework.NativeLibs](https://github.com/ppy/osu-framework) from 2020.923.0 to 2021.115.0.
  - [Release notes](https://github.com/ppy/osu-framework/releases)
  - [Commits](https://github.com/ppy/osu-framework/compare/2020.923.0...2021.115.0)
  
  Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

  dependabot-preview[bot] · 2021-02-01 18:09:05 +00:00
  0560676236
• Merge pull request #11651 from ppy/dependabot/nuget/SharpCompress-0.27.1

  Bump SharpCompress from 0.26.0 to 0.27.1

  Dean Herbert · 2021-02-02 03:07:52 +09:00
  9d7bec25da
• Bump SharpCompress from 0.26.0 to 0.27.1

  Bumps [SharpCompress](https://github.com/adamhathcock/sharpcompress) from 0.26.0 to 0.27.1.
  - [Release notes](https://github.com/adamhathcock/sharpcompress/releases)
  - [Commits](https://github.com/adamhathcock/sharpcompress/compare/0.26...0.27.1)
  
  Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

  dependabot-preview[bot] · 2021-02-01 17:44:30 +00:00
  286726feb0
• Merge pull request #11569 from peppy/fix-editor-new-beatmap-crash

  Fix a potential crash when exiting the editor before a new beatmap is added to the database

  Dan Balasescu · 2021-02-01 21:01:51 +09:00
  c70dd2edfc
• Ensure mods are always in a valid state at a game level
  Dean Herbert · 2021-02-01 20:20:19 +09:00
  425dc8a210
• Add function to check for (and return) invalid mods
  Dean Herbert · 2021-02-01 20:20:10 +09:00
  ead8262257
• Add ModUtils class for validating mod usages
  smoogipoo · 2021-02-01 19:37:24 +09:00
  b9832c1b2d
• Merge pull request #11561 from Mysfit/fix-storyboard-samples

  Fix storyboard samples continuing to play when the beatmap is paused or intro is skipped

  Dean Herbert · 2021-02-01 17:48:08 +09:00
  328bd191d4
• Apply documentation changes

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Salman Ahmed · 2021-02-01 11:02:08 +03:00
  49e62c3a4b
• Add more comprehensive commenting and simplify base call logic

  We can call the base method regardless for better safety. Worst case
  it's just going to run `Stop()` twice anyway.

  Dean Herbert · 2021-02-01 16:43:54 +09:00
  05982f42ab