Dan Balasescu
6b4b2a57fc
Expose only as one method
2023-12-21 14:58:23 +09:00
Dan Balasescu
4e3b994142
Relocate HitResult numeric score to ScoreProcessor
2023-12-21 14:52:31 +09:00
Dean Herbert
4f1e6c31d7
Merge pull request #25972 from bdach/argon-pro-no-slider-tick-judgements
2023-12-21 10:01:42 +09:00
Dean Herbert
fa4c9051cb
Merge branch 'master' into argon-pro-no-slider-tick-judgements
2023-12-21 10:01:22 +09:00
Dean Herbert
c8c26df5fa
Merge pull request #25976 from bdach/autopilot-incompatibility
2023-12-21 09:58:23 +09:00
Bartłomiej Dach
88e36eb08c
Fix autopilot mod still declaring incompatibility with fail-preventing mods
...
Closes https://github.com/ppy/osu/issues/25974 .
2023-12-20 21:46:18 +01:00
Bartłomiej Dach
b7cca788b5
Merge pull request #25964 from rushiiMachine/fix-export-replay-spam
...
Fix save & export failed replay hotkeys handling repeated keypresses
2023-12-20 21:07:36 +01:00
Bartłomiej Dach
b6a331b2f7
Fix argon pro not showing slider tick judgements
...
Addresses https://github.com/ppy/osu/discussions/25968 .
2023-12-20 20:52:26 +01:00
Bartłomiej Dach
53cca61e61
Merge pull request #25951 from peppy/show-tick-results
...
Show slider tick / slider end misses with a visible judgement
2023-12-20 20:44:04 +01:00
Bartłomiej Dach
975bacaeb7
Add back blank line to fix code quality inspection
2023-12-20 19:07:26 +01:00
Bartłomiej Dach
a763ad8473
Add remarks to Is{Hit,Miss}() to explain their simultaneous existence
2023-12-20 19:07:18 +01:00
Dean Herbert
c23dd1f808
Merge pull request #25945 from smoogipoo/mania-scorev2-values
...
Adjust mania scoring to be more in line with ScoreV2 + 85% acc / 15% combo
2023-12-21 01:53:30 +09:00
Dean Herbert
c5fb4d0f5c
Mark flaky test temporarily
2023-12-21 01:52:40 +09:00
rushiiMachine
ebbc8333e8
Prevent ExportReplay being spammed on fail by being held down
...
This was already handled in ReplayDownloadButton (98efff0bd6/osu.Game/Screens/Ranking/ReplayDownloadButton.cs (L114-L115)
2023-12-20 08:41:16 -08:00
Dean Herbert
eb8fb8092d
Attempt to standardise miss handling logic
2023-12-21 00:59:35 +09:00
Dean Herbert
fcf47267fd
Revert change to OsuHitWindows and move logic local to pooling initialisation
2023-12-21 00:48:46 +09:00
Bartłomiej Dach
9515f7dbfa
Bump score version in order to recompute legacy scores
2023-12-20 16:01:59 +01:00
Bartłomiej Dach
8c06d3873d
Merge branch 'master' into mania-scorev2-values
2023-12-20 15:54:31 +01:00
Bartłomiej Dach
b0da24176e
Remove outdated inline comments
2023-12-20 15:44:02 +01:00
Dean Herbert
a8c9db2115
Merge pull request #25958 from smoogipoo/remove-mania-rate-multipliers
...
Remove mania mod multiplier for DT/NC
2023-12-20 23:31:44 +09:00
Bartłomiej Dach
77d8bbf152
Merge pull request #25949 from peppy/fix-song-select-extra-selections
...
Fix beatmap updates causing one extra carousel selection
2023-12-20 15:30:38 +01:00
Dan Balasescu
bff08d124b
Remove mania mod multiplier for DT/NC
2023-12-20 22:28:50 +09:00
Bartłomiej Dach
83e885192b
Merge pull request #25931 from peppy/fix-thread-safety
...
Fix thread safety of `OnlineMetadataClient.UserStates`
2023-12-20 12:55:31 +01:00
Dean Herbert
d1ba2a4a64
Use orange for non-combo-breaking miss
2023-12-20 20:45:27 +09:00
Dean Herbert
d2716d8557
Improve animation for legacy skins
2023-12-20 20:34:05 +09:00
Bartłomiej Dach
6bddc56851
Merge branch 'master' into fix-song-select-extra-selections
2023-12-20 12:23:55 +01:00
Dean Herbert
9b383e3276
Add support for showing tick misses
2023-12-20 20:23:19 +09:00
Bartłomiej Dach
22513e0070
Merge pull request #25943 from peppy/fix-song-select-sound-at-gameplay
...
Fix song select running updates when screen is not active
2023-12-20 12:20:06 +01:00
Dan Balasescu
38d6b7f45b
Update total score conversion
2023-12-20 20:03:13 +09:00
Dean Herbert
d417b156b2
Update test expectations
2023-12-20 19:57:42 +09:00
Dean Herbert
e0c27510f2
Remove remaining usage of NotePerfectBonus
2023-12-20 19:47:36 +09:00
Dean Herbert
5284b95bb8
Schedule even more
2023-12-20 19:42:05 +09:00
Dean Herbert
7fa4dcf0fb
Fix selection retention logic copy paste failure
2023-12-20 19:27:57 +09:00
Dean Herbert
e003462f7d
Fix beatmap updates causing one extra carousel selection
2023-12-20 19:15:02 +09:00
Dan Balasescu
72274041eb
Merge pull request #25876 from bdach/fix-standardised-score-conversion
...
Fix osu! standardised score conversion sometimes exceeding bounds
2023-12-20 18:54:33 +09:00
Dan Balasescu
023bbda7db
Change mania to 85% acc / 15% combo
2023-12-20 18:43:06 +09:00
Dan Balasescu
104fbbde94
Change mania scoring to match ScoreV2
2023-12-20 18:35:45 +09:00
Dean Herbert
64f62e7d90
Fix song select running updates when screen is not active
...
Who would have guessed that `Schedule` calls were there for a reason!
I've tidied things up. Most of the changes I've made here are not
required – the schedule is the main thing here. The reason the sound was
playing is because one-too-many schedules was removed causing beatmap
updates to update carousel specifics while still at the player loader
screen.
Note that the selection sound still plays on returning to song select,
but this is not a regression. I'm looking at fixing this in a separate
PR because I'm in a good place as far as understanding the logic right
now and it would be a waste to leave it broken.
Closes https://github.com/ppy/osu/issues/25875 .
2023-12-20 17:31:09 +09:00
Dean Herbert
831c273b45
Merge pull request #25887 from smoogipoo/restore-taiko-accuracy
...
Restore taiko accuracy to ScoreV2 values
2023-12-20 17:29:40 +09:00
Dan Balasescu
188c463c9c
Merge pull request #25934 from peppy/adjust-classic-mod-multiplier
...
Adjust "classic" mod multiplier to 0.96x
2023-12-20 17:11:09 +09:00
Bartłomiej Dach
9a5027e556
Merge pull request #25900 from peppy/editor-from-any-carousel
...
Allow choosing "Edit" from any beatmap carousel item
2023-12-20 08:35:42 +01:00
Dean Herbert
98efff0bd6
Merge pull request #25917 from rushiiMachine/remove-relax-mod-exclusions
...
Allow failing with "relax" and "autopilot" mods
2023-12-20 15:48:21 +09:00
Dean Herbert
b6f0c98a09
Also apply to autopilot
2023-12-20 14:56:52 +09:00
Dean Herbert
14d2d0d215
Remove ModBlockFail
...
Was only being used by `NoFail` now.
2023-12-20 14:50:45 +09:00
Dan Balasescu
3818977a36
Merge pull request #25898 from peppy/song-select-stats
...
Update song select to always show difficulty stats
2023-12-20 14:39:35 +09:00
Dean Herbert
d7603e8021
Adjust "classic" mod multiplier to 0.96x
...
Following discussions on discord, this seems like the most agreed upon
value. Increasing this is important so that imported legacy scores don't
lose too much value.
2023-12-20 14:33:14 +09:00
Dean Herbert
856c59f7f7
Fix thread safety of OnlineMetadataClient.UserStates
...
Closes https://github.com/ppy/osu-framework/issues/6081 .
2023-12-20 14:15:00 +09:00
Dean Herbert
85e5d74a16
Apply proposed changes
2023-12-20 12:42:06 +09:00
Dan Balasescu
ff6a02be82
Merge pull request #25916 from OliBomby/fix-zero-length
...
Fix near zero-length sliders being placeable and crashing the game
2023-12-20 12:38:45 +09:00
rushiiMachine
1b004dbebc
Allow Relax to fail and remove failable mod exclusions
...
Allows the Relax mod to fail, and remove NF/PF/SD mod exclusion
ref: https://github.com/ppy/osu/discussions/13229
2023-12-19 12:33:00 -08:00
