Bartłomiej Dach
a934556bb8
Add failing assertions for head/tail positions after flip
2024-01-31 12:40:03 +01:00
Bartłomiej Dach
f927cb5928
Increase repeat count for better coverage of flip operations
2024-01-31 12:39:48 +01:00
Bartłomiej Dach
e7cfbd3c56
Merge pull request #26876 from peppy/slider-miss-last-longer
...
Adjust slider tick / end misses to show slightly longer
2024-01-31 10:43:58 +01:00
Dean Herbert
edab05672b
Merge pull request #26834 from bdach/2fa-cancel-crash
...
Fix crash when logging out during 2FA email verification
2024-01-31 18:32:33 +09:00
Dean Herbert
fbc923b47e
Revert "Merge pull request #26870 from smoogipoo/adjust-default-minresult"
...
This reverts commit 1acff746ee696ecda398
2024-01-31 17:51:38 +09:00
Dean Herbert
1acff746ee
Merge pull request #26870 from smoogipoo/adjust-default-minresult
...
Adjust default min result of SliderTailHit, remove override
2024-01-31 17:49:58 +09:00
Dean Herbert
ebf637bd3c
Adjust slider tick / end misses to show slightly longer
2024-01-31 17:41:26 +09:00
Dean Herbert
696ecda398
Merge pull request #26871 from peppy/show-better-expired-message
...
Show a better message when score submission fails due to system clock being set wrong
2024-01-31 17:32:18 +09:00
Dean Herbert
a7f9f50ce5
Show a better message when score submission fails due to system clock being set wrong
2024-01-31 16:52:50 +09:00
Dean Herbert
3f527081bd
Update framework
2024-01-31 16:12:46 +09:00
Dan Balasescu
9b1bbe5f48
Adjust default min result of SliderTailHit, remove override
2024-01-31 16:12:05 +09:00
Dean Herbert
012039ff90
Merge pull request #26839 from bdach/fix-judgement-fade
2024-01-31 09:14:05 +09:00
Bartłomiej Dach
c5e118bd10
Revert "Move fade more local to avoid fading twice"
...
This reverts commit d0421fe206https://github.com/ppy/osu/issues/26801 .
https://github.com/ppy/osu/pull/26703#discussion_r1469409667
was correct in saying that the early fade-out needs to be restored, and
that's because of the early-return. Legacy judgements that are the
temporary displayed judgement from new piece should also receive the
fade-out, and d0421fe206
2024-01-30 22:16:46 +01:00
Bartłomiej Dach
000ddc14ac
Fix broken locking in OAuth
...
Closes https://github.com/ppy/osu/issues/26824 ... I think?
Can be reproduced via something like
diff --git a/osu.Game/Online/API/OAuth.cs b/osu.Game/Online/API/OAuth.cs
index 485274f349..e6e93ab4c7 100644
--- a/osu.Game/Online/API/OAuth.cs
+++ b/osu.Game/Online/API/OAuth.cs
@@ -151,6 +151,11 @@ internal string RequestAccessToken()
{
if (!ensureAccessToken()) return null;
+ for (int i = 0; i < 10000; ++i)
+ {
+ _ = Token.Value.AccessToken;
+ }
+
return Token.Value.AccessToken;
}
The cause is `SecondFactorAuthForm` calling `Logout()`, which calls
`OAuth.Clear()`, _while_ the `APIAccess` connect loop is checking if
`authentication.HasValidAccessToken` is true, which happens to
internally check `Token.Value.AccessToken`, which the clearing of
tokens can brutally interrupt.
2024-01-30 21:05:23 +01:00
Bartłomiej Dach
6931af664e
Add missing icon.png entry to nuspec
...
This is only half of the deployment fix, the other half will be in
`osu-deploy` (making sure the icon is actually in the staging
directory).
2024-01-30 12:05:31 +01:00
Bartłomiej Dach
26d3409fca
Merge pull request #26797 from peppy/update-endpoints
...
Update endpoints to final production endpoints
2024-01-30 11:12:25 +01:00
Dean Herbert
d895a91cd5
Update endpoints to final production endpoints
2024-01-30 18:40:17 +09:00
Bartłomiej Dach
f5e7697335
Merge pull request #26781 from frenzibyte/taiko-sv-v2
...
Rewrite osu!taiko's time range computation logic to match 1:1 with stable
2024-01-30 09:16:07 +01:00
Dean Herbert
99f4b2c113
Merge pull request #26788 from EVAST9919/scrolling-alloc
...
Reduce allocation overhead in `ScrollingHitObjectContainer`
2024-01-30 14:06:27 +09:00
Dean Herbert
fc8fdb578a
Merge pull request #26790 from EVAST9919/mania-columns-alloc
...
Reduce allocation overhead in mania's `ColumnFlow`
2024-01-30 12:51:38 +09:00
Andrei Zavatski
8e20eed4ef
Don't use LINQ in ReceivePositionalInputAt
2024-01-30 03:19:27 +03:00
Andrei Zavatski
7dba870518
Rework Content storage in ColumnFlow
2024-01-30 03:07:37 +03:00
Andrei Zavatski
87f853fcd2
Reduce overhead in ScrollingHitObjectContainer
2024-01-30 00:59:31 +03:00
Dean Herbert
58bcef934b
Merge pull request #26785 from bdach/make-populate-maximum-statistics-public
2024-01-30 06:40:35 +09:00
Bartłomiej Dach
6888cda02c
Make LegacyScoreDecoder.PopulateMaximumStatistics() public
...
For `osu-tools` consumption.
2024-01-29 21:42:38 +01:00
Dean Herbert
b3919bff56
Merge pull request #26780 from bdach/fix-websocket-very-bad-not-good
...
Fix incorrect handling of `StartChatRequest` in websocket chat client
2024-01-30 05:11:55 +09:00
Bartłomiej Dach
39883cc102
Merge pull request #26773 from peppy/fix-song-select-osu-logo-position
...
Fix osu! logo being mispositioned in song select on very wide resolutions
2024-01-29 20:39:44 +01:00
Bartłomiej Dach
1fbc92ca7e
Merge branch 'master' into fix-song-select-osu-logo-position
2024-01-29 20:11:52 +01:00
Bartłomiej Dach
acc2614090
Apply alternative solution
...
Fixes the logo flying out of the wrong corner when transitioning from
song select to gameplay.
Co-authored-by: Dean Herbert <pe@ppy.sh>
2024-01-29 20:07:27 +01:00
Salman Ahmed
959cc7c7d9
Rewrite time range computation logic to be completely based on stable code
2024-01-29 21:26:36 +03:00
Bartłomiej Dach
996ae0ecc1
Fix incorrect handling of StartChatRequest in websocket chat client
...
Fixes this happening on staging:
[network] 2024-01-29 17:48:24 [verbose]: WebSocketNotificationsClientConnector connected!
[network] 2024-01-29 17:48:24 [verbose]: WebSocketNotificationsClientConnector connect attempt failed: Can't use WaitSafely from inside an async operation.
I'm not sure how I ever allowed that `.WaitSafely()` to be there. It
did feel rather dangerous but then I must have forgotten and never
noticed it failing. Which is weird because you'd think that would be
caught by testing that chat isn't working but I'm pretty sure that I
tested that chat *was* indeed working.
Anyway now that entire flow is replaced by something that should
hopefully be somewhat more sane? It has a whole retry flow with logging
now which should be more robust than what was there previously (failing
to start to listen to chat events killing the entire websocket
connection for very little good reason).
2024-01-29 19:22:40 +01:00
Dean Herbert
16c06169ed
Update framework
2024-01-30 01:06:32 +09:00
Bartłomiej Dach
2667cb8b36
Merge pull request #26703 from peppy/smaller-slider-misses
...
Adjust slider tick / end defaults again
2024-01-29 13:51:07 +01:00
Dean Herbert
f2546d72c2
Fix osu! logo being mispositioned in song select on very wide resolutions
2024-01-29 20:45:51 +09:00
Dean Herbert
811b31386b
Merge pull request #26616 from peppy/dont-round-sv
2024-01-29 20:42:38 +09:00
Dean Herbert
a3199333bb
Merge pull request #26698 from EVAST9919/slider-sample-alloc
...
Reduce sliding sample allocations in `DrawableSlider`
2024-01-29 20:37:32 +09:00
Dean Herbert
034f8c0388
Also fix spinner case
2024-01-29 20:36:59 +09:00
Dean Herbert
f1c1d9cb14
Merge pull request #26772 from peppy/update-framework
...
Update framework
2024-01-29 20:15:01 +09:00
Bartłomiej Dach
11ec8a1cad
Merge branch 'master' into dont-round-sv
2024-01-29 11:52:46 +01:00
Bartłomiej Dach
8a11ff1227
Apply local precision workaround to editor effect section
2024-01-29 11:52:38 +01:00
Dean Herbert
a1fe5eedd5
Merge pull request #26751 from frenzibyte/fix-multiplayer-fail-freezing-score
...
Fix score processor no longer applying results when failing in multiplayer match
2024-01-29 19:51:31 +09:00
Dean Herbert
1efdf2ae25
Update framework
2024-01-29 19:45:56 +09:00
Dean Herbert
8341da7586
Revert "Remove dead code" (mostly)
...
This reverts commit 6070eac6ee
2024-01-29 19:43:40 +09:00
Dean Herbert
dc28a6b873
Update resources
2024-01-29 19:33:13 +09:00
Dean Herbert
cbbe2f9dc0
Merge pull request #25480 from peppy/2fa
...
Add two factor authentication flow
2024-01-29 19:14:55 +09:00
Dean Herbert
540ff0da5b
Add loading layer when requesting a code reissue
2024-01-29 17:54:34 +09:00
Bartłomiej Dach
4c5dacd559
Merge pull request #26770 from peppy/fucking-hitobject-references
...
Fix `OsuPlayfield` being retained indefinitely after gameplay
2024-01-29 09:40:56 +01:00
Dean Herbert
6a469f2cb6
Use switch instead of if-else
2024-01-29 17:18:17 +09:00
Bartłomiej Dach
96811a8874
Fix APIAccess spamming requests while waiting for second factor
2024-01-29 09:14:30 +01:00
Bartłomiej Dach
363fd1d54f
Remove no longer relevant changes
2024-01-29 09:05:03 +01:00
