45827 Commits

This Branch

This Branch

All Branches

• Merge branch 'aim-refactor-velocity' into aim-refactor-ppcalc
  Xexxar · 2021-11-03 16:15:40 +00:00
  a8d4d7ca2d
• Merge branch 'aim-refactor-slider' into aim-refactor-velocity
  Xexxar · 2021-11-03 16:15:17 +00:00
  d1ec245685
• added radial leniency to movementdistance
  Xexxar · 2021-11-03 16:14:45 +00:00
  7fc60a840e
• adjusted global multiplier to better balance values against inflation
  Xexxar · 2021-11-03 16:02:23 +00:00
  8fdffbf08f
• Merge branch 'aim-refactor-velocity' into aim-refactor-ppcalc
  Xexxar · 2021-11-03 15:55:01 +00:00
  2d48301223
• renamed prev to last
  Xexxar · 2021-11-03 15:54:49 +00:00
  d74e181531
• Merge branch 'aim-refactor-slider' into aim-refactor-velocity
  Xexxar · 2021-11-03 15:53:41 +00:00
  b9fc355f74
• merged in aim-base
  Xexxar · 2021-11-03 15:52:48 +00:00
  b3b44c0795
• rewrote slider algorithm to be based on leniency and stored current cursor positions
  Xexxar · 2021-11-03 15:38:23 +00:00
  9afca5c5b6
• Document special MovementDistance for sliders, ensure always has a value
  smoogipoo · 2021-11-03 01:04:07 +09:00
  133218ecbb
• Merge branch 'master' into aim-refactor-base
  smoogipoo · 2021-11-03 00:32:51 +09:00
  c3a31a019b
• Refactor variables for readability in angle calculations
  smoogipoo · 2021-11-03 00:16:33 +09:00
  b0d9c0eca3
• Refactor documentation around velocity calculations
  smoogipoo · 2021-11-03 00:04:19 +09:00
  93c03b9d37
• Rename variables for readability

  In particular, "last" vs "prev" can get confusing because they mean the
  same thing.

  smoogipoo · 2021-11-02 23:51:10 +09:00
  7e0629774b
• Refactor xmldocs
  smoogipoo · 2021-11-02 23:47:20 +09:00
  5454de7ae8
• Apply styling changes
  smoogipoo · 2021-11-02 23:33:51 +09:00
  be8a1f60c0
• Resolve tests
  smoogipoo · 2021-11-02 23:32:58 +09:00
  5486ca084e
• Merge pull request #15410 from peppy/fix-multiplayer-room-participants

  Fix multiplayer room participants display not updating as new users join/leave

  Dan Balasescu · 2021-11-02 17:55:16 +09:00
  e61f2970b4
• Avoid adding null users to RecentParticipants
  Dean Herbert · 2021-11-02 17:13:37 +09:00
  135df0e190
• Rename "null user" tests to better explain purpose
  Dean Herbert · 2021-11-02 17:13:37 +09:00
  1bfa1365a0
• Fix multiplayer room participants display not updating as new users join/leave

  Can add tests on request, but not sure the code around this area is here
  to stay permanently. Should be pretty low risk.
  
  - Closes https://github.com/ppy/osu/issues/14788.

  Dean Herbert · 2021-11-02 17:13:37 +09:00
  b0bd39fc49
• Add test coverage of room participants updating on room join
  Dean Herbert · 2021-11-02 17:13:37 +09:00
  e472656b37
• Merge pull request #15405 from peppy/legacy-decoder-default-section

  Default legacy decoder to `General` section, rather than none

  Dan Balasescu · 2021-11-02 15:42:25 +09:00
  6f941a8916
• Use explicit type
  smoogipoo · 2021-11-02 15:41:25 +09:00
  1e9211c00b
• Merge pull request #15406 from peppy/fix-skin-hashing-circular-reference

  Avoid any potential infinite loops when re-writing `skin.ini` files

  Dan Balasescu · 2021-11-02 15:39:33 +09:00
  a2f6b816ff
• Merge pull request #15407 from peppy/remove-trailing-exclamations-from-autoplay

  Remove trailing exclamation marks from autoplay character names

  Dan Balasescu · 2021-11-02 15:21:46 +09:00
  e56811783b
• Remove trailing exclamation marks from autoplay character names

  As mentioned in
  https://github.com/ppy/osu/discussions/15401#discussioncomment-1573839.

  Dean Herbert · 2021-11-02 14:53:58 +09:00
  9b705460db
• Merge pull request #15279 from Flux3on/spinner-judgement-fix

  Fix spinner judgements on old beatmaps get incorrectly stacked

  Dan Balasescu · 2021-11-02 14:46:15 +09:00
  3f31cb39c0
• Perform a consistency check by decoding the newly written skin.ini during ComputeHash

  As this has regressed twice now, let's play it safe and bail rather than
  stack overflowing. Note that as all the underlying issues that could
  trigger this have been fixed, no additional tests have been added. To
  test, comment out `SkinManager.cs` line 228-229 to cause a failure. The
  new logic will kick in and show a log output message, but all tests will
  still (correctly) pass.

  Dean Herbert · 2021-11-02 14:11:25 +09:00
  5d784b2ef8
• Always write automated changes to skin metadata at the end of the file

  Apart from being cleaner (and allowing removal at the point of export,
  if that is ever requires), this also gives us a better guarantee that
  the metadata is going to take effect.
  
  By writing the `[General]` section ourselves, we avoid any issues that
  may be present from a user constructing the file (incorrectly)
  themselves, such as multiple `Title:` entries or a malformed `[General]`
  marker.
  
  The main goal is to ensure that the name is updated to what we expect it
  to be.

  Dean Herbert · 2021-11-02 14:11:25 +09:00
  2e66ab453d
• Add test coverage of skin with missing section header
  Dean Herbert · 2021-11-02 14:05:14 +09:00
  d4be6fc797
• Remove no longer used Section.None
  Dean Herbert · 2021-11-02 14:01:41 +09:00
  15c770e155
• Default legacy decoder to General section, rather than none

  This is mainly to reach parity with how stable handles such cases for
  skins specifically. It was brought to our attention after finding a skin
  with a malformed `\[General]` tag which did not break further parsing of
  the file on stable, but did on lazer.
  
  Note that stable defaults to an "unknown" section for beatmaps, but
  functionally I can't think of a regression case from changing this to a
  "general" default.

  Dean Herbert · 2021-11-02 13:59:13 +09:00
  ab28948744
• Merge pull request #15403 from frenzibyte/android-replay-intent

  Add android intent filter for osu! replays

  Dean Herbert · 2021-11-02 12:52:13 +09:00
  ee6af1245c
• Add android intent filter for osu! replays
  Salman Ahmed · 2021-11-02 04:58:53 +03:00
  badbbace10
• Merge pull request #15399 from bdach/update-dependencies

  Update dependencies

  Dean Herbert · 2021-11-02 10:24:11 +09:00
  399aea6740
• Merge branch 'dependabot/nuget/Microsoft.CodeAnalysis.BannedApiAnalyzers-3.3.3' into update-dependencies
  Bartłomiej Dach · 2021-11-01 20:53:48 +01:00
  12c2f03949
• Merge branch 'dependabot/nuget/Microsoft.AspNetCore.SignalR.Client-5.0.11' into update-dependencies
  Bartłomiej Dach · 2021-11-01 20:53:43 +01:00
  90fb536a25
• Merge branch 'dependabot/nuget/Sentry-3.10.0' into update-dependencies
  Bartłomiej Dach · 2021-11-01 20:53:19 +01:00
  d05d0f2b88
• Merge branch 'dependabot/nuget/Microsoft.AspNetCore.SignalR.Protocols.MessagePack-5.0.11' into update-dependencies
  Bartłomiej Dach · 2021-11-01 20:52:56 +01:00
  bfcd7948fe
• Merge branch 'dependabot/nuget/SharpCompress-0.30.0' into update-dependencies
  Bartłomiej Dach · 2021-11-01 20:52:44 +01:00
  e4672981d8
• Merge branch 'dependabot/nuget/Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson-5.0.11' into update-dependencies
  Bartłomiej Dach · 2021-11-01 20:52:43 +01:00
  717403c78f
• Merge branch 'dependabot/nuget/Microsoft.NET.Test.Sdk-17.0.0' into update-dependencies
  Bartłomiej Dach · 2021-11-01 20:52:38 +01:00
  7dc5c5cdcd
• Bump Microsoft.CodeAnalysis.BannedApiAnalyzers from 3.3.2 to 3.3.3

  Bumps [Microsoft.CodeAnalysis.BannedApiAnalyzers](https://github.com/dotnet/roslyn-analyzers) from 3.3.2 to 3.3.3.
  - [Release notes](https://github.com/dotnet/roslyn-analyzers/releases)
  - [Changelog](https://github.com/dotnet/roslyn-analyzers/blob/main/PostReleaseActivities.md)
  - [Commits](https://github.com/dotnet/roslyn-analyzers/commits)
  
  ---
  updated-dependencies:
  - dependency-name: Microsoft.CodeAnalysis.BannedApiAnalyzers
    dependency-type: direct:production
    update-type: version-update:semver-patch
  ...
  
  Signed-off-by: dependabot[bot] <support@github.com>

  dependabot[bot] · 2021-11-01 17:02:23 +00:00
  6e17f92f55
• Bump Microsoft.AspNetCore.SignalR.Client from 5.0.10 to 5.0.11

  Bumps [Microsoft.AspNetCore.SignalR.Client](https://github.com/dotnet/aspnetcore) from 5.0.10 to 5.0.11.
  - [Release notes](https://github.com/dotnet/aspnetcore/releases)
  - [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.10...v5.0.11)
  
  ---
  updated-dependencies:
  - dependency-name: Microsoft.AspNetCore.SignalR.Client
    dependency-type: direct:production
    update-type: version-update:semver-patch
  ...
  
  Signed-off-by: dependabot[bot] <support@github.com>

  dependabot[bot] · 2021-11-01 17:02:20 +00:00
  3b7379b777
• Bump Sentry from 3.9.4 to 3.10.0

  Bumps [Sentry](https://github.com/getsentry/sentry-dotnet) from 3.9.4 to 3.10.0.
  - [Release notes](https://github.com/getsentry/sentry-dotnet/releases)
  - [Changelog](https://github.com/getsentry/sentry-dotnet/blob/main/CHANGELOG.md)
  - [Commits](https://github.com/getsentry/sentry-dotnet/compare/3.9.4...3.10.0)
  
  ---
  updated-dependencies:
  - dependency-name: Sentry
    dependency-type: direct:production
    update-type: version-update:semver-minor
  ...
  
  Signed-off-by: dependabot[bot] <support@github.com>

  dependabot[bot] · 2021-11-01 17:02:14 +00:00
  e0a940be1d
• Bump Microsoft.AspNetCore.SignalR.Protocols.MessagePack

  Bumps [Microsoft.AspNetCore.SignalR.Protocols.MessagePack](https://github.com/dotnet/aspnetcore) from 5.0.10 to 5.0.11.
  - [Release notes](https://github.com/dotnet/aspnetcore/releases)
  - [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.10...v5.0.11)
  
  ---
  updated-dependencies:
  - dependency-name: Microsoft.AspNetCore.SignalR.Protocols.MessagePack
    dependency-type: direct:production
    update-type: version-update:semver-patch
  ...
  
  Signed-off-by: dependabot[bot] <support@github.com>

  dependabot[bot] · 2021-11-01 17:02:10 +00:00
  f215439b4f
• Bump SharpCompress from 0.29.0 to 0.30.0

  Bumps [SharpCompress](https://github.com/adamhathcock/sharpcompress) from 0.29.0 to 0.30.0.
  - [Release notes](https://github.com/adamhathcock/sharpcompress/releases)
  - [Commits](https://github.com/adamhathcock/sharpcompress/compare/0.29...0.30)
  
  ---
  updated-dependencies:
  - dependency-name: SharpCompress
    dependency-type: direct:production
    update-type: version-update:semver-minor
  ...
  
  Signed-off-by: dependabot[bot] <support@github.com>

  dependabot[bot] · 2021-11-01 17:02:04 +00:00
  f8f4b9d3d3
• Bump Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson

  Bumps [Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson](https://github.com/dotnet/aspnetcore) from 5.0.10 to 5.0.11.
  - [Release notes](https://github.com/dotnet/aspnetcore/releases)
  - [Commits](https://github.com/dotnet/aspnetcore/compare/v5.0.10...v5.0.11)
  
  ---
  updated-dependencies:
  - dependency-name: Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson
    dependency-type: direct:production
    update-type: version-update:semver-patch
  ...
  
  Signed-off-by: dependabot[bot] <support@github.com>

  dependabot[bot] · 2021-11-01 17:02:00 +00:00
  f893556b80
• Bump Microsoft.NET.Test.Sdk from 16.11.0 to 17.0.0

  Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 16.11.0 to 17.0.0.
  - [Release notes](https://github.com/microsoft/vstest/releases)
  - [Commits](https://github.com/microsoft/vstest/compare/v16.11.0...v17.0.0)
  
  ---
  updated-dependencies:
  - dependency-name: Microsoft.NET.Test.Sdk
    dependency-type: direct:production
    update-type: version-update:semver-major
  ...
  
  Signed-off-by: dependabot[bot] <support@github.com>

  dependabot[bot] · 2021-11-01 17:01:54 +00:00
  7747fd5810