50128 Commits

This Branch

This Branch

All Branches

• Add test coverage ensuring ruleset ID is correct after bracket read

  Historically, tournament client may have written incorrect `OnlineID`
  values. We wanted to use `ShortName` to re-fetch the ruleset. This test
  ensures this flow is working correctly.

  Dean Herbert · 2022-03-31 18:39:58 +09:00
  a7a7584d3e
• Merge pull request #17570 from peppy/fix-settings-textbox-focus

  Focus focus not being transferred correctly to parent settings panel on exiting nested panel

  Dan Balasescu · 2022-03-31 18:07:51 +09:00
  bc4d6a3ace
• Merge pull request #17572 from peppy/fix-multi-sounds-explosion

  Fix multiplayer sounds playing too much after gameplay

  Dean Herbert · 2022-03-31 16:52:24 +09:00
  140eaa6039
• Fix multiplayer sounds playing too much after gameplay

  Regressed in https://github.com/ppy/osu/pull/15936.
  
  Closes #17295.

  Dean Herbert · 2022-03-31 16:18:28 +09:00
  ef5e37c47a
• Merge pull request #17565 from smoogipoo/fix-gameplay-leaderboard-allocations

  Remove ScoreInfo allocations in multiplayer leaderboard

  Dean Herbert · 2022-03-31 15:48:14 +09:00
  ad14b7cac5
• Merge pull request #17569 from Joehuu/ignore-line-ending-rev

  Ignore line ending normalisation commit from blame

  Dean Herbert · 2022-03-31 15:31:53 +09:00
  496e025fae
• Focus focus not being transferred correctly to parent settings panel on exiting nested panel

  Seemingly harmless schedule delay ommission meant that the textbox may
  not be in a state it can handle the incoming focus event. Regressed in
  https://github.com/ppy/osu/pull/14345#discussion_r690697501.

  Dean Herbert · 2022-03-31 15:24:21 +09:00
  726b49fdf3
• Add test coverage of textbox focus in settings panels when switching between nested panels
  Dean Herbert · 2022-03-31 15:24:21 +09:00
  e8a295a61b
• Merge pull request #17568 from Joehuu/fix-logo-clicking-when-exiting

  Fix osu! logo being clicked when exiting via cmd-q on initial state

  Dean Herbert · 2022-03-31 14:12:15 +09:00
  538e553455
• Ignore line ending normalisation commit from blame
  Joseph Madamba · 2022-03-30 21:58:39 -07:00
  615e4f0f3b
• Fix osu! logo being clicked when exiting via cmd-q on initial state
  Joseph Madamba · 2022-03-30 21:26:30 -07:00
  36c02573a8
• Merge pull request #17509 from peppy/fix-autoplay-mod-user-id

  Fix autoplay avatar being clickable on results screen

  Dan Balasescu · 2022-03-31 12:56:42 +09:00
  d17cf0631f
• Remove no longer necessary ruleset field
  Salman Ahmed · 2022-03-31 06:40:38 +03:00
  9c19ae1df8
• Remove ScoreInfo allocations in multi leaderboard
  Dan Balasescu · 2022-03-31 12:23:00 +09:00
  6e94a9780b
• Remove unused using statement
  Dean Herbert · 2022-03-31 11:34:32 +09:00
  e0d434b89f
• Shorten class name of ModCreatedReplayUser
  Dean Herbert · 2022-03-31 11:34:23 +09:00
  0cac935939
• Update obsolete message to match targeted developers' use case

  Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>

  Dean Herbert · 2022-03-31 11:33:26 +09:00
  2c1ccc7d36
• Remove unnecessary logging
  Dean Herbert · 2022-03-31 11:32:00 +09:00
  234bec45cc
• Remove unnecessary public prefix in interface method
  Salman Ahmed · 2022-03-31 01:50:46 +03:00
  6874cdf0c8
• Fix typo in step name
  Bartłomiej Dach · 2022-03-30 22:04:55 +02:00
  f4184cb6fe
• Use provided extension method instead of reimplementing locally
  Bartłomiej Dach · 2022-03-30 22:04:54 +02:00
  436dec68c9
• Fill out ICreateReplayData xmldocs
  Bartłomiej Dach · 2022-03-30 22:04:54 +02:00
  83bae81095
• Merge branch 'master' into fix-autoplay-mod-user-id
  Bartłomiej Dach · 2022-03-30 21:41:45 +02:00
  9621a7f9cb
• Merge pull request #17520 from smoogipoo/fix-countdown-refresh

  Fix countdown timer not refreshing on new countdown

  Dean Herbert · 2022-03-30 22:58:26 +09:00
  0020102810
• Merge branch 'master' into fix-countdown-refresh
  Salman Ahmed · 2022-03-30 16:26:12 +03:00
  0f144f6801
• Merge pull request #17556 from peppy/fix-multiplayer-unobserved

  Fix `MultiplayerMatchSongSelect` potentially attempting to exit when not the current screen

  Dan Balasescu · 2022-03-30 21:10:11 +09:00
  b60c253831
• Fix MultiplayerMatchSongSelect potentially attempting to exit when not the current screen
  Dean Herbert · 2022-03-30 20:36:12 +09:00
  671386ba6c
• Merge pull request #17555 from peppy/remove-source-from-wedge

  Remove song source from main wedge display

  Dan Balasescu · 2022-03-30 18:57:25 +09:00
  cb1ee05539
• Simplify string bindings
  Dean Herbert · 2022-03-30 17:59:45 +09:00
  f9f6248101
• Remove song source from main wedge display

  This was definitely added at someone's request, since I wouldn't have
  put it here. But it's displayed below in the details section already and
  also not displayed in the updated "wedge" in the new design.
  
  See https://github.com/ppy/osu/discussions/17537 for discussion.

  Dean Herbert · 2022-03-30 17:59:40 +09:00
  bc0b982102
• Merge pull request #17546 from frenzibyte/autoplay-cinema-incompatibility

  Mark both "Autoplay" and "Cinema" mods as mutually exclusive

  Dean Herbert · 2022-03-30 16:41:07 +09:00
  99f141d396
• Merge pull request #17550 from smoogipoo/fix-score-display-race

  Fix scores sometimes shown with incorrect scoring mode

  Dean Herbert · 2022-03-30 16:05:28 +09:00
  bd3c401363
• Merge pull request #17551 from peppy/realm-database-filename-const

  Move all usages of `client.realm` filename to a single `const`

  Dan Balasescu · 2022-03-30 14:09:08 +09:00
  7d338fb4be
• Move all usages of client.realm filename to a single const
  Dean Herbert · 2022-03-30 13:34:48 +09:00
  975883da5c
• Merge pull request #17527 from peppy/switch-osu-folder

  Add ability to "migrate" data to another folder which has an existing install

  Dan Balasescu · 2022-03-30 13:20:49 +09:00
  c311e11496
• Prevent scores being calculated twice
  Dan Balasescu · 2022-03-30 13:15:41 +09:00
  4df63a4900
• Fix scores sometimes shown with incorrect scoring mode
  Dan Balasescu · 2022-03-30 13:03:12 +09:00
  bd9c0076df
• Merge pull request #17547 from frenzibyte/m1-ignore-realm-migration

  Ignore EF-to-realm migration tests on M1 ARM architectures

  Dan Balasescu · 2022-03-30 11:47:29 +09:00
  e869b7286a
• Merge pull request #17510 from Wieku/combo-counter

  Adjust legacy combo counter appearance to closer match stable

  Dean Herbert · 2022-03-30 11:17:30 +09:00
  555e127bc2
• Remove skin dependency as component is reinitialized on skin change
  Sebastian Krajewski · 2022-03-30 01:09:05 +02:00
  cb62d3d4b9
• Use In/Out instead of {In/Out}Quad
  Sebastian Krajewski · 2022-03-30 00:48:59 +02:00
  7582c943a4
• Ignore EF-to-realm migration tests on ARM architectures
  Salman Ahmed · 2022-03-30 01:24:37 +03:00
  7495a04990
• Fix potential nullref on OsuGameTestScene.TearDownSteps
  Salman Ahmed · 2022-03-30 01:15:24 +03:00
  986aad4bd5
• Add test coverage
  Salman Ahmed · 2022-03-30 01:08:22 +03:00
  b7ae431252
• Improve behaviour of "Autoplay" shortcut during gameplay start

  This also opens up the way to adding shortcut for "Cinema" mod
  (Ctrl+Shift+Enter), but will leave adding that until there's a demand
  for it.

  Salman Ahmed · 2022-03-30 01:07:48 +03:00
  cef1b93471
• Add test coverage of migrating to folder with existing data
  Dean Herbert · 2022-03-29 23:28:07 +09:00
  f762af1344
• Mark "autoplay" and "cinema" mods as mutually exclusive
  Salman Ahmed · 2022-03-29 17:26:02 +03:00
  8d4356f23b
• Merge pull request #17530 from frenzibyte/spin-speed-display-value

  Fix "Barrel Roll" tooltip not limiting decimal places for spin speed

  Dean Herbert · 2022-03-29 22:47:40 +09:00
  30fae452a4
• Merge branch 'master' into fix-countdown-refresh
  Salman Ahmed · 2022-03-29 16:16:36 +03:00
  26b72fc449
• Fix "Barrel Roll" tooltip not limiting decimal places for spin speed
  Salman Ahmed · 2022-03-29 16:11:44 +03:00
  9a09c97457