40499 Commits

This Branch

This Branch

All Branches

• Make getTieredComponent local
  Robin Avery · 2021-06-11 06:51:12 -04:00
  a76eaeb52d
• Recalculate closest anchor when origin is changed
  Robin Avery · 2021-06-11 06:28:30 -04:00
  635300b311
• Revert rename of lambda variables
  Robin Avery · 2021-06-11 06:22:24 -04:00
  a506f2a776
• Add guard clause to applyOrigins and rename parameter
  Robin Avery · 2021-06-08 10:29:45 -04:00
  10b6b72909
• Rename applyCustomAnchors to applyFixedAnchors for consistency with UsesFixedAnchor
  Robin Avery · 2021-06-08 10:14:07 -04:00
  d212918d67
• Simplify applyClosestAnchor to one line by moving another guard clause
  Robin Avery · 2021-06-08 10:09:48 -04:00
  2c88e6df8d
• Move guard clause from checkAndApplyClosestAnchor to applyAnchor
  Robin Avery · 2021-06-08 09:51:39 -04:00
  f22cc981d1
• Rename some methods for clarity

  Methods which operate on a collection of `ISkinnableDrawable`s are now
  plural; ones which take a single item are singular.
  
  This also allows cutting down the name of `getClosestAnchorForDrawable`
  to just `getClosestAnchor`.

  Robin Avery · 2021-06-08 09:44:42 -04:00
  529a80871b
• Refactor updateDrawableAnchorIfUsingClosest
  Robin Avery · 2021-06-08 09:25:49 -04:00
  01da73daf2
• Inline updateDrawableAnchorIfUsingClosest
  Robin Avery · 2021-06-08 09:14:04 -04:00
  6b127f50f2
• Rename OverridesClosestAnchor to UsesFixedAnchor
  Robin Avery · 2021-06-08 08:28:42 -04:00
  dc50ae40b9
• Rename applyAnchor to applyCustomAnchor
  Robin Avery · 2021-06-07 05:08:18 -04:00
  65f594f860
• Simplify and rearrange SkinSelectionHandler

  The file has been restructured and reworded such that there are as few
  differences as possible from b36b40cb34.

  Robin Avery · 2021-06-07 02:40:15 -04:00
  6c9594ee35
• Refactor unacceptable syntax
  Robin Avery · 2021-06-07 01:08:39 -04:00
  29fa4fdf57
• Rename UsingClosestAnchor

  It is now "OverridesClosestAnchor". The logic is inverted accordingly.

  Robin Avery · 2021-06-07 00:14:36 -04:00
  133d72a8c0
• Remove all UsingClosestAnchor() extension logic

  It is replaced with ISkinnableDrawable.UsingClosestAnchor.

  Robin Avery · 2021-06-07 00:04:53 -04:00
  f28916e30f
• Add UsingClosestAnchor to ISkinnableDrawable

  Also implement it as an auto property in its inheritors.
  The auto properties default to true.

  Robin Avery · 2021-06-06 23:47:47 -04:00
  ce635af83e
• Rename overly long method
  Robin Avery · 2021-06-06 13:28:17 -04:00
  6a456e53f4
• Remove first-person comment
  Robin Avery · 2021-06-06 13:27:13 -04:00
  888882ac63
• Uninvert logic of SkinnableInfo.UsingClosestAnchor

  Also rename "IsUsingClosestAnchor" to simply "UsingClosestAnchor".

  Robin Avery · 2021-06-06 10:13:35 -04:00
  da1c38d5a9
• Refactor getTieredComponent
  Robin Avery · 2021-06-06 09:40:58 -04:00
  63346f6b75
• Add serialization support via SkinnableInfo
  Robin Avery · 2021-06-06 07:18:08 -04:00
  11b1b8c633
• Move lookup logic to DrawableExtensions

  This is now a global lookup to be shared by serialization and editor.

  Robin Avery · 2021-06-06 06:58:21 -04:00
  c9f5808bf2
• Replace localised strings with static English
  Robin Avery · 2021-06-06 05:34:32 -04:00
  4aee76456f
• Allow skin elements to find closest anchor

  - Resolves ppy/osu#13252
  - Add localisation strings for the context menu instead of using enum

  Robin Avery · 2021-06-06 01:32:04 -04:00
  c452715bf1
• Merge pull request #13338 from Craftplacer/fix-osutestscene-content

  Add `DummyAPIAccess` to `OsuTestScene` one parent up

  Dean Herbert · 2021-06-05 15:32:55 +09:00
  cce0220060
• Merge branch 'master' into fix-osutestscene-content
  Dean Herbert · 2021-06-05 14:49:19 +09:00
  9f6e3996b1
• Add DummyAPIAccess one parent up
  Craftplacer · 2021-06-05 03:30:21 +02:00
  1084906d40
• Merge pull request #13261 from smoogipoo/fix-spectator-frame-conversion

  Fix spectator crashing when converting mania replay frames

  Dean Herbert · 2021-06-05 00:38:15 +09:00
  10acad6524
• Merge pull request #13336 from ekrctb/pdwl-catch-explosion

  Fix catch hit lighting not always showing when a replay is rewound

  Dan Balasescu · 2021-06-04 22:19:34 +09:00
  bde0071de8
• Fix potential race incorrectly pausing the source clock
  smoogipoo · 2021-06-04 21:58:51 +09:00
  009aa994d0
• Merge branch 'master' into fix-spectator-frame-conversion
  Dan Balasescu · 2021-06-04 21:17:40 +09:00
  57a38374db
• Merge pull request #13331 from ekrctb/pdwl-follow-point

  Use general lifetime container for follow point container

  Dan Balasescu · 2021-06-04 20:39:39 +09:00
  fa7611f1e2
• Merge branch 'master' into pdwl-follow-point
  Dan Balasescu · 2021-06-04 20:04:02 +09:00
  a3bec49b3b
• Use seeded RNG for catch explosion animation

  The animation is always the same when a replay is rewound or a beatmap is played multiple times.

  ekrctb · 2021-06-04 19:54:46 +09:00
  8e20f90ed5
• Add NextSingle of version taking output range to StatelessRNG
  ekrctb · 2021-06-04 19:52:12 +09:00
  5512231bf4
• Merge pull request #13303 from LeNitrous/mainmenu-storyboard-backgrounds

  Add storyboards as a main menu background source

  Dean Herbert · 2021-06-04 19:50:40 +09:00
  840f084dc4
• Maintain catch hit explosion by lifetime entries

  - Fix hit explosion not showing when a replay is rewound to a time after a hit object is caught

  ekrctb · 2021-06-04 19:46:50 +09:00
  181f1da3d3
• Bring back scheduling of follow point update
  ekrctb · 2021-06-04 18:41:02 +09:00
  d7da66d876
• Remove one TODO

  It can be removed because pooled drawables are always ready, and `FollowPointConnection` is also ready when applied.

  ekrctb · 2021-06-04 17:09:59 +09:00
  0098ac2760
• Resolve nullable inspection, enable nullable for FollowPointLifetimeEntry
  ekrctb · 2021-06-04 17:09:59 +09:00
  bc892086fe
• Use general lifetime container for follow point container
  ekrctb · 2021-06-04 16:31:50 +09:00
  b373b120ff
• Merge pull request #13313 from ekrctb/factor-out-hoc

  Factor out entry management logic of `HitObjectContainer` to the new base class

  Dan Balasescu · 2021-06-04 16:06:48 +09:00
  2069a5bd28
• Merge pull request #13328 from peppy/increase-music-volume

  Increase music volume back to 80% for the time being

  Dan Balasescu · 2021-06-04 15:36:04 +09:00
  35aeef6838
• Merge branch 'master' into factor-out-hoc
  Dan Balasescu · 2021-06-04 15:31:35 +09:00
  b283c48abb
• Merge pull request #7316 from mcendu/kiai

  Implement kiai flash of hit circles

  Dan Balasescu · 2021-06-04 15:31:19 +09:00
  a02c39b066
• Tidy up code
  Dean Herbert · 2021-06-04 15:18:16 +09:00
  19a44d65c5
• Merge branch 'master' into fix-spectator-frame-conversion
  Dean Herbert · 2021-06-04 15:06:15 +09:00
  23096c58bb
• Increase music volume back to 80% for the time being
  Dean Herbert · 2021-06-04 15:00:53 +09:00
  071c07586a
• apply suggestions

  - apply 0 alpha to beatmap background if storyboard replaces it
  - use an AudioContainer to mute all samples coming from the storyboard

  Nathan Alo · 2021-06-04 13:56:10 +08:00
  996c156106