Bartłomiej Dach
a3b8493751
Remove rounding of slider velocity multiplier on juice streams
...
Compare: https://github.com/ppy/osu/pull/26616
This came up elsewhere, namely in
https://github.com/ppy/osu/pull/28277#issuecomment-2133505958 .
As it turns out, at least one beatmap among those whose scores had
unexpected changes in total score, namely
https://osu.ppy.sh/beatmapsets/971028#fruits/2062131 , was using slider
velocity multipliers that were not a multiple of 0.01 (the specific
value used was 0.225x). This meant that due to the rounding applied to
`SliderVelocityMultiplierBindable` via `Precision`, the raw value was
being incorrectly rounded, resulting in incorrect conversion.
The "direct" change that revealed this is most likely
https://github.com/ppy/osu-framework/pull/6249 , by the virtue of
shuffling the `BindableNumber` rounding code around and accidentally
changing midpoint rounding semantics in the process. But it was not
at fault here, as rounding was just as wrong before that change
as after in this specific context.
2024-05-28 13:14:44 +02:00
Bartłomiej Dach
96af0e1ec3
Add failing test case for catch conversion
...
Test is an abridged / cropped version of
https://osu.ppy.sh/beatmapsets/971028#fruits/2062131 to demonstrate
the specific failure case (unfortunately can't use the whole beatmap
due to other conversion failures).
2024-05-28 13:13:17 +02:00
Dean Herbert
8c4931eeec
Merge branch 'master' into footer-v2-transitions
2024-05-28 18:49:39 +09:00
Dean Herbert
182ca145c7
Merge pull request #28183 from frenzibyte/footer-v2-back-button
...
Add new footer back button and fix shearing being different between components
2024-05-28 18:49:24 +09:00
Dean Herbert
4408039b3e
Merge branch 'master' into footer-v2-back-button
2024-05-28 15:50:34 +09:00
Dan Balasescu
e2b4e25ffa
Merge pull request #28277 from bdach/total-score-without-mods-once-more
...
Compute total score without mods during standardised score conversion
2024-05-28 07:49:27 +09:00
Aurelian
6c4def1c09
Added check for infinite subpoints for PerfectCurve
2024-05-27 20:32:18 +02:00
Aurelian
172cfdf88d
Added missing brackets for formulas
2024-05-27 19:41:38 +02:00
Aurelian
d81be56adf
Test for accuracy of perfect curves
2024-05-27 19:35:33 +02:00
Bartłomiej Dach
daee363743
Merge branch 'master' into total-score-without-mods-once-more
2024-05-27 15:16:58 +02:00
Bartłomiej Dach
c6c66fbd01
Merge pull request #28333 from peppy/preview-playlist-items
...
Allow previewing audio of playlist items
2024-05-27 14:22:49 +02:00
Bartłomiej Dach
405c72c0d6
Fix mod display not being aligned with mapper text
2024-05-27 13:36:44 +02:00
Dean Herbert
aad0982e26
Adjust size of play button / progress to match BeatmapCardThumbnail usage
2024-05-27 20:33:24 +09:00
Dean Herbert
75d961e6f2
Pass the same thing in twice for better maybe
2024-05-27 20:30:01 +09:00
Dean Herbert
d976224912
Standardise padding on both sides of difficulty icon
2024-05-27 19:59:25 +09:00
Bartłomiej Dach
1f41261fc7
Fix test failure
2024-05-27 12:01:02 +02:00
Bartłomiej Dach
1e2cac3e92
Remove unused using directive
2024-05-27 11:44:55 +02:00
Dean Herbert
740a3377fa
Merge branch 'master' into LeaderBoardScore_clean
2024-05-27 17:18:41 +09:00
Dean Herbert
b6471f0b9c
Allow previewing audio of playlist items
2024-05-27 17:09:37 +09:00
Bartłomiej Dach
525663fc27
Merge pull request #28332 from peppy/cinema-mod-overlay-hiding
...
Fix cinema mod not hiding playfield skin layer
2024-05-27 08:48:10 +02:00
Bartłomiej Dach
d22b72a75c
Merge branch 'master' into cinema-mod-overlay-hiding
2024-05-27 08:27:28 +02:00
Bartłomiej Dach
bdfce4b9da
Fix xmldoc reference
2024-05-27 08:26:00 +02:00
Dean Herbert
5aa537f0c8
Merge pull request #28311 from Joppe27/taiko-glow-scale
...
Correct scale of `taiko-glow` element to match stable
2024-05-27 15:19:06 +09:00
Bartłomiej Dach
0aec8da102
Merge pull request #28327 from peppy/windows-16px-icon
...
Revert windows 16px icon to original version
2024-05-27 08:18:41 +02:00
Dean Herbert
11c3d11db9
Fix cinema mod not hiding playfield skin layer
2024-05-27 14:52:28 +09:00
Dean Herbert
0d6adf160b
Share scale factor with hit target
2024-05-27 14:20:28 +09:00
Dean Herbert
a62b9fa633
Revert windows 16px icon to original version
...
This also fixes the 48px version looking uncanny due to smaller paddings.
2024-05-27 11:42:36 +09:00
Joseph Madamba
8e14c24ee3
Follow slanted flow logic precedent in test
...
See `ModSelectOverlay` components.
2024-05-26 00:24:03 -07:00
Joppe27
76f13b21da
Correct scale of taiko-glow element
2024-05-25 23:28:51 +02:00
OliBomby
d4489545f2
add axis toggles
2024-05-25 21:44:08 +02:00
OliBomby
37530eebcc
Enable scale buttons at the correct times
2024-05-25 20:35:06 +02:00
OliBomby
4eeebdf60c
calculate max scale bounds for scale slider
2024-05-25 20:17:27 +02:00
OliBomby
88314dc584
select all input text on popup for an easy typing experience
2024-05-25 18:41:31 +02:00
OliBomby
6aa92bcc45
Add simple scale tool
2024-05-25 18:31:19 +02:00
Salman Ahmed
91fb5ed749
Move toggle step to SetUpSteps
2024-05-25 17:28:03 +03:00
Salman Ahmed
2c18c10ac8
Move to SelectV2 namespace
2024-05-25 17:20:10 +03:00
Salman Ahmed
d395c85418
Adjust right content width based on scoring mode
2024-05-25 17:16:41 +03:00
Salman Ahmed
5955378004
Replace "X mods" text with a pill indicator
2024-05-25 16:11:24 +03:00
Dean Herbert
d55fa423e9
Merge pull request #28305 from EVAST9919/sb-easier-debug
...
Show storyboard element path in `Draw Visualiser`
2024-05-25 20:29:27 +09:00
Andrei Zavatski
1e90e5e38e
Use sb element path as a name
2024-05-25 13:24:25 +03:00
Salman Ahmed
35af518fdb
Remove expanded/contracted states and limit to 5 mods
...
Also adjusts right content width to contain those 5 mods. Not sure how to handle the extra space in the score though...to be dealt with later.
2024-05-25 12:52:48 +03:00
Salman Ahmed
1f01293783
Make scores slanted in test scene
2024-05-25 12:36:09 +03:00
OliBomby
497701950d
fix nitpick
2024-05-24 18:11:28 +02:00
Dean Herbert
2134ff7a1b
Merge pull request #28071 from Fabiano1337/lazer-speedkeys
...
Make ctrl-up/down change speed modifier of mods
2024-05-24 23:20:04 +09:00
Bartłomiej Dach
9f19ab092d
Merge branch 'master' into grids-1
2024-05-24 14:39:55 +02:00
Aurelian
b2c4e0e951
Reworked linear line check, and optimized scaled flat slider test
2024-05-24 14:05:56 +02:00
Bartłomiej Dach
80b7653ae7
Merge pull request #26717 from peppy/fix-editor-didnt-save
...
Fix editor not saving when textbox is focused during exit procedure
2024-05-24 13:28:28 +02:00
Bartłomiej Dach
c800bb5339
Merge branch 'master' into lazer-speedkeys
2024-05-24 13:19:26 +02:00
Bartłomiej Dach
cab8cf7410
Move mod speed hotkey handler to user mod select overlay
...
The very base class is the wrong place for it because
`FreeModSelectOverlay` inherits from it, and that one has different
assumptions and rules than "user" selection. In particular, in non-user
selection, more than one rate adjust mod may be active, which breaks the
mod speed hotkey's basic assumptions.
2024-05-24 13:14:06 +02:00
Bartłomiej Dach
b1b207960a
Actually use return value
2024-05-24 13:09:44 +02:00
