FreezyLemon
2ceb073b5d
Renamed OnClick to OnLinkClicked to (what should be) obvious reasons
2017-12-07 16:30:15 +01:00
FreezyLemon
334cb3dd10
Removed TODO and added another test line
2017-12-07 16:26:50 +01:00
FreezyLemon
d90eb2cdce
Moved "Does this channel exist" check to ChatLine so that if a #name does not exist as a channel, it does not get added as a link (and does not contain a URL or anything else to prevent jankiness)
2017-12-07 16:26:28 +01:00
FreezyLemon
18eabd35f6
Set an empty list as default for AvailableChannels (mostly so that tests don't break, but also so that if no connection exists, the links don't break)
2017-12-07 16:25:30 +01:00
FreezyLemon
2129d6cede
Renamed the "on click" method to OnClick() and moved most of the implementation to ChatLink.
...
Also fixed the tooltip text up
2017-12-07 16:23:43 +01:00
Aergwyn
95955d68ef
rephrased description of local context checking
2017-12-07 14:14:50 +01:00
FreezyLemon
ca40db2b97
Fixed a bug where the hover wouldn't work correctly due to OsuLinkSpriteText assigning Action to a private property.
2017-12-07 13:57:29 +01:00
Aergwyn
1dcbfab18e
removed redundant comment
2017-12-07 13:56:37 +01:00
FreezyLemon
5ded6e877c
Added some tooltip text handling.
...
Also fixed a bug caused by SameLinkSprites where "this" is actually supposed to be included by just adding a manual function call.
2017-12-07 13:49:44 +01:00
Aergwyn
76c09ae59e
added comments for local context checking
2017-12-07 13:44:47 +01:00
FreezyLemon
07660a6600
Added licence header to the new test case
2017-12-07 13:17:51 +01:00
FreezyLemon
8ba66015f4
Implemented the new IHasHoverSounds interface in a private "ChatHoverContainer" class which is now used for ChatLink instances.
...
Also moved the overhead for finding all sprites in the same line that reference the same URL to the LoadComplete (used to be every hover, now only once).
2017-12-07 13:17:40 +01:00
Dean Herbert
5330ca1fa9
Merge pull request #1635 from awesomecuber/fix-sensitivityslider
...
Fix SensitivitySlider keyboard control
2017-12-07 21:16:42 +09:00
FreezyLemon
a8599a1b75
Implemented new interface which allows parent containers to decide on whether a "OnHover" sound should be played.
2017-12-07 13:12:36 +01:00
Dan Balasescu
9e37a122e1
Merge branch 'master' into fix-sensitivityslider
2017-12-07 21:01:53 +09:00
Dean Herbert
805c61d032
Merge pull request #1603 from santerinogelainen/header-button-should-derive
...
Fix beatmap overlay buttons not conforming to design
2017-12-07 20:56:15 +09:00
smoogipoo
d52b84df46
Move KeyboardStep assignment to ctor
2017-12-07 20:53:28 +09:00
smoogipoo
46cd6fdb45
Merge remote-tracking branch 'origin/master' into fix-sensitivityslider
2017-12-07 20:49:48 +09:00
Dean Herbert
24b3b10942
Move drawable assignment to load, remove depth overrides
2017-12-07 20:44:55 +09:00
Dean Herbert
8c89354b36
Remove extra whitespace
2017-12-07 20:44:38 +09:00
Dean Herbert
d36982b1d9
Merge branch 'master' into header-button-should-derive
2017-12-07 20:04:41 +09:00
Dean Herbert
f2eef6621a
Merge branch 'master' into fix-missing-metadata
2017-12-07 19:23:51 +09:00
FreezyLemon
f4f1291919
Removed "wiki:" prefix from wiki links (links are visible on tooltips so this is unnecessary now)
2017-12-07 11:23:31 +01:00
FreezyLemon
8a88040ef5
Added tooltip to links
2017-12-07 11:12:21 +01:00
FreezyLemon
bd11124e6d
Removed unnecessary copy (pass-by-reference anyways)
2017-12-07 11:12:12 +01:00
FreezyLemon
f3f3d1d0fc
Various test fixes
2017-12-07 11:11:43 +01:00
Dan Balasescu
fe2cc4daad
Merge pull request #1663 from peppy/input-revamp
...
Apply changes in line with framework input adjustments
2017-12-07 18:47:40 +09:00
Dean Herbert
13d0524542
Update framework
2017-12-07 18:37:54 +09:00
FreezyLemon
1b971c01e6
Fixed a bug where links would be out of order in their List which would cause the game to crash
2017-12-07 10:31:44 +01:00
FreezyLemon
ec8b5c2465
Permitted nulls in ChatOverlay.load() so that in testing, no "OsuGame" instance is required. Also added null checks to the links' on click actions
2017-12-07 10:31:02 +01:00
FreezyLemon
006ac44e11
Fixed up style in the ChatDisplay test
2017-12-07 10:29:54 +01:00
FreezyLemon
65afbd5c1b
Added new test case for URL parsing / link display in chat
2017-12-07 10:29:33 +01:00
FreezyLemon
541c25e995
Renamed ChatLinkSpriteText to ChatLink for convenience
2017-12-07 10:28:12 +01:00
FreezyLemon
7bf25bdd4d
Changed it so the ":" character does not appear after usernames when the displayed message is an action (e.g. /np). Just makes more sense imo
2017-12-07 10:23:57 +01:00
Dean Herbert
c35c8263b9
Merge remote-tracking branch 'upstream/master' into input-revamp
2017-12-07 18:07:26 +09:00
Dean Herbert
2a0b37e192
Merge pull request #1638 from Aergwyn/fix-beatmap-carousel-lag
...
Fix lagging beatmap carousel because of storyboard-loading
2017-12-07 18:04:38 +09:00
Dean Herbert
2a1a9b9f1f
Fix post-merge issue
2017-12-07 17:26:39 +09:00
Dean Herbert
44ee11e75f
Merge branch 'master' into fix-beatmap-carousel-lag
2017-12-07 15:30:50 +09:00
Dean Herbert
a78441bc5a
Apply changes in line with framework input adjustments
2017-12-07 13:16:59 +09:00
Dan Balasescu
de6d1cc647
Merge pull request #1660 from peppy/shader-precompile
...
Add shader precompile step
2017-12-07 04:25:15 +09:00
Dan Balasescu
9c4ca46786
Merge branch 'master' into shader-precompile
2017-12-07 04:15:24 +09:00
Dan Balasescu
eaffd496f2
Merge pull request #1661 from peppy/fix-async-is-loaded
...
Fix IsValueCreated method not checking whether the async task was completed
2017-12-07 01:28:28 +09:00
FreezyLemon
94eb853d3d
Added centralised handling for some chat links
2017-12-06 16:41:57 +01:00
Dan Balasescu
8e3cce798d
Merge branch 'master' into fix-async-is-loaded
2017-12-06 23:01:38 +09:00
Dean Herbert
34596b3368
Rename and comment for clarification
2017-12-06 21:47:48 +09:00
FreezyLemon
b04ddba2a0
Added basic "on click" actions to the in-chat links
2017-12-06 10:27:30 +01:00
Dean Herbert
04ae64e9fd
Add missing IsCompleted check to ensureValid
2017-12-06 16:20:49 +09:00
Dean Herbert
988cc27f0e
Update framework
2017-12-06 11:59:53 +09:00
Dean Herbert
15ed3b4aac
Fix IsValueCreated method not cecking whether the async task was completed
...
Caused potential stutters for components that relied on this check.
2017-12-06 09:49:12 +09:00
Dean Herbert
fb6408257a
Add shader precompile step
...
Resolves https://github.com/ppy/osu-framework/issues/1180 in a way.
2017-12-05 17:41:47 +09:00
