Bartłomiej Dach
|
9ed676f97a
|
Merge pull request #18941 from peppy/fix-flaky-placeholder-test
Fix flaky song select placeholder test by changing ruleset post-display
|
2022-06-29 23:19:13 +02:00 |
|
Bartłomiej Dach
|
381deaf62d
|
Merge branch 'master' into fix-flaky-placeholder-test
|
2022-06-29 22:31:45 +02:00 |
|
Bartłomiej Dach
|
e25f686850
|
Merge pull request #18939 from peppy/fix-null-test-user
Fix crash on visual testing `TestSceneChatOverlay` due to null user
|
2022-06-29 22:10:44 +02:00 |
|
Dean Herbert
|
46cbbf5c6e
|
Fix flaky song select placeholder test by changing ruleset post-display
Was failing occasionally due to the beatmap present operation causing
the test's ruleset change to undo.
```csharp
TearDown : System.TimeoutException : "wait for placeholder visible" timed out
--TearDown
at osu.Framework.Testing.Drawables.Steps.UntilStepButton.<>c__DisplayClass11_0.<.ctor>b__0()
at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
--- End of stack trace from previous location ---
at osu.Framework.Testing.TestSceneTestRunner.TestRunner.RunTestBlocking(TestScene test)
at osu.Game.Tests.Visual.OsuTestScene.OsuTestSceneTestRunner.RunTestBlocking(TestScene test) in /opt/buildagent/work/ecd860037212ac52/osu.Game/Tests/Visual/OsuTestScene.cs:line 503
at osu.Framework.Testing.TestScene.RunTestsFromNUnit()
------- Stdout: -------
[runtime] 2022-06-29 10:36:45 [verbose]: 💨 Class: TestScenePlaySongSelect
[runtime] 2022-06-29 10:36:45 [verbose]: 🔶 Test: TestPlaceholderConvertSetting
[runtime] 2022-06-29 10:36:45 [verbose]: 🔸 Step #1 exit all screens
[runtime] 2022-06-29 10:36:45 [verbose]: 🔸 Step #2 reset defaults
[runtime] 2022-06-29 10:36:45 [verbose]: 🔸 Step #3 delete all beatmaps
[runtime] 2022-06-29 10:36:45 [verbose]: 🔸 Step #4 change ruleset to 2
[runtime] 2022-06-29 10:36:45 [verbose]: 🔸 Step #5 import test map for ruleset 0
[database] 2022-06-29 10:36:45 [verbose]: [efc1a] Beginning import from unknown...
[database] 2022-06-29 10:36:45 [verbose]: [efc1a] Import successfully completed!
[runtime] 2022-06-29 10:36:45 [verbose]: 🔸 Step #6 wait for imported to arrive in carousel
[runtime] 2022-06-29 10:36:45 [verbose]: 🔸 Step #7 change convert setting
[runtime] 2022-06-29 10:36:45 [verbose]: 🔸 Step #8 create song select
[runtime] 2022-06-29 10:36:45 [verbose]: ScreenTestScene screen changed → TestScenePlaySongSelect+TestSongSelect
[runtime] 2022-06-29 10:36:45 [verbose]: 📺 ScreenTestScene(OsuScreenStack)#338(depth:1) loading TestScenePlaySongSelect+TestSongSelect#263
[runtime] 2022-06-29 10:36:45 [verbose]: decoupled ruleset transferred ("" -> "osu!catch")
[runtime] 2022-06-29 10:36:45 [verbose]: 🔸 Step #9 wait for present
[runtime] 2022-06-29 10:36:45 [verbose]: 📺 ScreenTestScene(OsuScreenStack)#338(depth:1) entered TestScenePlaySongSelect+TestSongSelect#263
[runtime] 2022-06-29 10:36:45 [verbose]: 📺 BackgroundScreenStack#328(depth:1) loading BackgroundScreenBeatmap#338
[runtime] 2022-06-29 10:36:45 [verbose]: 📺 BackgroundScreenStack#328(depth:1) entered BackgroundScreenBeatmap#338
[runtime] 2022-06-29 10:36:45 [verbose]: Song select updating selection with beatmap:null ruleset:fruits
[runtime] 2022-06-29 10:36:45 [verbose]: Song select changing beatmap from "please load a beatmap! - no beatmaps available!" to "null"
[runtime] 2022-06-29 10:36:45 [verbose]: Song select working beatmap updated to Some Artist 0 - Some Song (set id 6224) ece7b702-895c-4f15-892f-05e4ff5e9a24 (Some Guy 3) [Normal 6224000 (length 0:50, bpm 106.7)]
[runtime] 2022-06-29 10:36:45 [verbose]: Song select updating selection with beatmap:null ruleset:osu
[runtime] 2022-06-29 10:36:45 [verbose]: decoupled ruleset transferred ("osu!catch" -> "osu!")
[runtime] 2022-06-29 10:36:45 [verbose]: Song select updating selection with beatmap:74232aa2-2a1f-4920-b643-e85976838251 ruleset:osu
[runtime] 2022-06-29 10:36:45 [verbose]: Song select decided to ensurePlayingSelected
[runtime] 2022-06-29 10:36:45 [verbose]: Game-wide working beatmap updated to Some Artist 0 - Some Song (set id 6224) ece7b702-895c-4f15-892f-05e4ff5e9a24 (Some Guy 3) [Normal 6224000 (length 0:50, bpm 106.7)]
[runtime] 2022-06-29 10:36:45 [debug]: Focus changed from nothing to SeekLimitedSearchTextBox.
[network] 2022-06-29 10:36:45 [verbose]: Failing request osu.Game.Online.API.Requests.GetBeatmapRequest (System.InvalidOperationException: DummyAPIAccess cannot process this request.)
[runtime] 2022-06-29 10:36:45 [verbose]: ✔️ 16 repetitions
[runtime] 2022-06-29 10:36:45 [verbose]: 🔸 Step #10 wait for carousel loaded
[runtime] 2022-06-29 10:36:45 [verbose]: 🔸 Step #11 wait for placeholder visible
[runtime] 2022-06-29 10:36:55 [verbose]: 💥 Failed (on attempt 1,459)
[runtime] 2022-06-29 10:36:55 [verbose]: ⏳ Currently loading components (0)
[runtime] 2022-06-29 10:36:55 [verbose]: 🧵 Task schedulers
[runtime] 2022-06-29 10:36:55 [verbose]: LoadComponentsAsync (standard) concurrency:4 running:0 pending:0
[runtime] 2022-06-29 10:36:55 [verbose]: LoadComponentsAsync (long load) concurrency:4 running:0 pending:0
[runtime] 2022-06-29 10:36:55 [verbose]: 🎱 Thread pool
[runtime] 2022-06-29 10:36:55 [verbose]: worker: min 1 max 32,767 available 32,766
[runtime] 2022-06-29 10:36:55 [verbose]: completion: min 1 max 1,000 available 1,000
[runtime] 2022-06-29 10:36:55 [debug]: Focus on "SeekLimitedSearchTextBox" no longer valid as a result of unfocusIfNoLongerValid.
[runtime] 2022-06-29 10:36:55 [debug]: Focus changed from SeekLimitedSearchTextBox to nothing.
```
|
2022-06-30 04:45:04 +09:00 |
|
Dean Herbert
|
13108155d3
|
Fix crash on visual esting TestSceneChatOverlay due to null user
|
2022-06-30 03:43:56 +09:00 |
|
Dan Balasescu
|
6911b959a6
|
Merge pull request #18937 from peppy/update-framework
Update framework
|
2022-06-29 23:49:54 +09:00 |
|
Dean Herbert
|
582175c3a4
|
Update framework
|
2022-06-29 22:57:52 +09:00 |
|
Dan Balasescu
|
68d4676ad0
|
Merge pull request #18936 from peppy/fix-nan-diff-calc-result
Guard against `NaN` star difficulty results
|
2022-06-29 21:51:29 +09:00 |
|
Dean Herbert
|
18d465eff7
|
Guard against NaN star difficulty results
|
2022-06-29 21:02:29 +09:00 |
|
Dean Herbert
|
6a16b84edb
|
Merge pull request #18935 from peppy/ruleset-guard-icon-creation-failure
Guard against ruleset icon creation failures to avoid whole game death
|
2022-06-29 20:57:58 +09:00 |
|
Salman Ahmed
|
87e3b44181
|
Ensure icon is loaded inside try-catch
|
2022-06-29 13:37:42 +03:00 |
|
Salman Ahmed
|
e3eba58cb6
|
Catch in triangles intro
|
2022-06-29 13:37:42 +03:00 |
|
Dean Herbert
|
6c64cea057
|
Catch a second location
|
2022-06-29 18:56:15 +09:00 |
|
Dean Herbert
|
b092e6937a
|
Guard against ruleset icon creation failures to avoid whole game death
|
2022-06-29 18:51:07 +09:00 |
|
Dan Balasescu
|
d4aa18112b
|
Merge pull request #15035 from emu1337/speed-acc-scaling
Change speed accuracy scaling to be closer to worst case scenario
|
2022-06-29 18:04:23 +09:00 |
|
Dan Balasescu
|
fd0a1e2b9f
|
Merge pull request #18749 from molneya/accuracy-pp-curve
Use accuracy instead of score for mania pp calculation
|
2022-06-29 17:31:19 +09:00 |
|
Dan Balasescu
|
6d91c0f375
|
Resolve inspection issue
|
2022-06-29 16:57:11 +09:00 |
|
Dan Balasescu
|
118b178a25
|
Merge pull request #18791 from apollo-dw/FL-diffspike
Remove difficulty spike nerf from the Flashlight skill in osu!
|
2022-06-29 16:55:38 +09:00 |
|
Dan Balasescu
|
5cdf98b4dc
|
Merge branch 'master' into accuracy-pp-curve
|
2022-06-29 16:48:11 +09:00 |
|
Dan Balasescu
|
ad95f037de
|
Prevent another case of potential div-by-0
|
2022-06-29 16:42:53 +09:00 |
|
Dan Balasescu
|
e6ccca8045
|
Fix inspection
|
2022-06-29 16:29:17 +09:00 |
|
Dan Balasescu
|
0211fe7ae8
|
Fix exception + possible div-by-0
|
2022-06-29 16:29:14 +09:00 |
|
Dan Balasescu
|
2989803b71
|
Merge branch 'master' into speed-acc-scaling
|
2022-06-29 16:15:20 +09:00 |
|
Dan Balasescu
|
34b9118fb3
|
Cleanup by using const value
|
2022-06-29 16:10:06 +09:00 |
|
Dan Balasescu
|
7d743994bc
|
Merge branch 'master' into FL-diffspike
|
2022-06-29 16:05:53 +09:00 |
|
Dan Balasescu
|
f435f0d8e4
|
Merge pull request #18920 from andy840119/remove-nullable-disable-in-the-migration
Remove the nullable disable annotations in the class belongs to the migration namespace.
|
2022-06-29 14:40:11 +09:00 |
|
Dean Herbert
|
3a00131606
|
Bump fastlane
|
2022-06-29 13:51:57 +09:00 |
|
Dan Balasescu
|
fde5b2cf2b
|
Merge pull request #18921 from andy840119/remove-nullable-disable-in-the-localisation
Remove the nullable disable annotation in the localisation.
|
2022-06-29 13:51:50 +09:00 |
|
Dan Balasescu
|
114f1b47c4
|
Merge branch 'master' into remove-nullable-disable-in-the-migration
|
2022-06-29 13:11:45 +09:00 |
|
Dan Balasescu
|
18ea148623
|
Merge pull request #18925 from peppy/closure-elim-hint
Change closure elimination to hint
|
2022-06-29 12:38:31 +09:00 |
|
Bartłomiej Dach
|
6bd3922617
|
Merge pull request #18922 from Joehuu/fix-da-settings-slider-padding
Fix difficulty adjust settings having more padding on sliders
|
2022-06-28 21:42:22 +02:00 |
|
Bartłomiej Dach
|
a0125cbb62
|
Merge branch 'master' into fix-da-settings-slider-padding
|
2022-06-28 20:53:07 +02:00 |
|
Bartłomiej Dach
|
98e2ba749a
|
Merge pull request #18928 from peppy/fix-realm-collection-modified
Fix one more case of collection modification during enumeration
|
2022-06-28 20:15:42 +02:00 |
|
Dean Herbert
|
ecdb30d215
|
Fix one more case of collection modification during enumeration
https://sentry.ppy.sh/share/issue/a61c27b2a63a4a6aa80e75873f9d87ca/
|
2022-06-29 02:28:23 +09:00 |
|
Joseph Madamba
|
36e71d39f2
|
Fix one more mod settings test
|
2022-06-28 09:54:18 -07:00 |
|
Dean Herbert
|
978a80dd6f
|
Change closure elimination to hint
Pretty noisy as a suggestion, and can fire incorrectly quite a lot (aka
`Schedule()`).
|
2022-06-29 01:52:51 +09:00 |
|
Joseph Madamba
|
d07c2a64b9
|
Remove unused using
|
2022-06-28 08:39:09 -07:00 |
|
Joseph Madamba
|
f07107aba9
|
Fix failing diff adjust slider tests
|
2022-06-28 08:38:15 -07:00 |
|
Joseph Madamba
|
aacded0ecf
|
Fix difficulty adjust settings having more padding on sliders
|
2022-06-28 07:33:05 -07:00 |
|
andy840119
|
de7f2a0bba
|
Remove the nullable disable annotation in the localisation.
|
2022-06-28 20:59:57 +08:00 |
|
andy840119
|
2269f1046e
|
Remove the nullable disable annotations.
|
2022-06-28 20:59:03 +08:00 |
|
Dean Herbert
|
7c9c499e19
|
Update resources (translation updates)
|
2022-06-28 19:21:46 +09:00 |
|
Dan Balasescu
|
43c1fd3d94
|
Merge pull request #18916 from peppy/fix-chat-test-ordering-failures
Fix more chat test failures
|
2022-06-28 19:21:18 +09:00 |
|
Dean Herbert
|
8cda55e224
|
Merge pull request #18795 from smoogipoo/full-size-follow-circle
Track the full size of the follow circle at all times
|
2022-06-28 19:20:34 +09:00 |
|
Dean Herbert
|
6ef7c3c0b3
|
Merge pull request #18917 from peppy/framework-bump
Update framework
|
2022-06-28 19:10:25 +09:00 |
|
Dean Herbert
|
c282e19316
|
Update language initialisation in line with framework LocalisationManager changes
|
2022-06-28 18:19:48 +09:00 |
|
Dean Herbert
|
975ba83838
|
Update framework
|
2022-06-28 18:19:48 +09:00 |
|
Dean Herbert
|
ed1b809f54
|
Add missing request handling to actually join PM channels
|
2022-06-28 18:11:37 +09:00 |
|
Dean Herbert
|
21d31ee218
|
Ensure joined channels are actually joined to avoid unexpected tab order
|
2022-06-28 18:11:37 +09:00 |
|
Dan Balasescu
|
d630b62cfc
|
Merge pull request #18915 from peppy/slider-snaking-test-refactoring
Apply various refactorings to `TestSceneSliderSnaking`
|
2022-06-28 16:16:35 +09:00 |
|