72122 Commits

This Branch

This Branch

All Branches

• Describe special case of user mod validation
  Dan Balasescu · 2025-03-12 19:34:34 +09:00
  9c0f3f9bef
• Don't use is for null-checks
  Dan Balasescu · 2025-03-12 17:07:23 +09:00
  aeb55ee25d
• Fix loading layer not showing when closing room
  Dean Herbert · 2025-03-11 17:56:58 +09:00
  338328b911
• Fix missing base dependencies
  Dan Balasescu · 2025-03-11 17:08:52 +09:00
  148fe5ca16
• Apply commenting adjustments

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dan Balasescu · 2025-03-11 15:41:08 +09:00
  3e71a969e6
• Safguard setting states to not depend on screen load timing
  Dan Balasescu · 2025-03-08 00:34:29 +09:00
  dbf571950c
• Fix typo
  Dan Balasescu · 2025-03-08 00:32:56 +09:00
  e69ad86799
• Fix ruleset style not reset when freestyle disabled
  Dan Balasescu · 2025-03-08 00:09:32 +09:00
  eb15217a36
• Add failing test
  Dan Balasescu · 2025-03-08 00:09:20 +09:00
  d220c19885
• Also hide when suspending
  Dan Balasescu · 2025-03-06 18:37:56 +09:00
  b0fad7e83d
• Hide mod select overlay on exit

  Only discovered this when running multiplayer tests on the upcoming
  rewrite for that screen.

  Dan Balasescu · 2025-03-06 18:35:38 +09:00
  05c7b903c3
• Add a slew of tests
  Dan Balasescu · 2025-03-06 16:09:49 +09:00
  ba3d6ddc43
• Simplify user style validation

  This commit takes half a step back.
  
  Rather than trying to preserve the beatmap style across selections, it
  probably makes more sense to always reset it. It is more likely for
  playlists to be dominated by unique beatmap sets anyway. Doing this
  already heavily simplifies the process.
  
  Given the above, we can rely on the fact that the user beatmap and
  ruleset are selected together, and are thus implicitly validated as of
  exiting the style selection screen.
  
  It follows that the only extra validation we need to do is to make sure
  that the user's ruleset is valid for the playlist item.
  
  This even makes the mod structure, which is a bit of an unfortunate
  scenario, somewhat tenable to look at. The user mods only need to be
  validated when either the playlist item or the user ruleset changes. If
  we ever move the ruleset selection into the style selection screen, then
  we can also remove the latter of the validations with similar reason as
  the ruleset.

  Dan Balasescu · 2025-03-06 14:11:41 +09:00
  0bdbaa872c
• Add forgotten partials
  Dan Balasescu · 2025-03-05 23:25:22 +09:00
  26daf085d7
• Block input to screen during gameplay
  Dan Balasescu · 2025-03-05 22:12:48 +09:00
  51f794a566
• Reset mods when exiting to lounge

  To be hoenst, this is all quite abusive but I'm not sure how to do it in
  any better way. I especially dislike the fact that the screen's
  bindables are disabled yet the screen itself is allowed to set their
  value because they're `LeasedBindable`s.
  
  But I feel better doing this in a central location like this
  `ScreenStack` than in the rooms... Otherwise this specific behaviour
  would have to be replicated in the multiplayer screen when it goes
  through the same refactoring.

  Dan Balasescu · 2025-03-05 21:45:51 +09:00
  f887846311
• Merge branch 'master' into room-subscreen-split
  Dan Balasescu · 2025-03-05 20:41:44 +09:00
  4709ebd593
• Merge pull request #32199 from bdach/negative-leaderboard-position

  Fix playlists results screens potentially displaying negative score positions

  Dan Balasescu · 2025-03-05 16:13:12 +09:00
  f6cf63edae
• Rename test scene to match new RoomListing class name
  Dean Herbert · 2025-03-05 13:51:56 +09:00
  9ca1274495
• Merge pull request #31867 from smoogipoo/remove-selectedroom

  Remove `SelectedRoom` from online play tests

  Dean Herbert · 2025-03-04 21:56:30 +09:00
  0d3e66fbfa
• Merge branch 'master' into remove-selectedroom
  Dean Herbert · 2025-03-04 19:21:05 +09:00
  c31a5dcdae
• Split out methods so retrieving the room is not a callback function
  Dean Herbert · 2025-03-04 19:19:53 +09:00
  918315aa65
• Merge pull request #32098 from bdach/dont-drop-green-line-sample-bank

  Attempt to preserve sample control point bank when encoding beatmap

  Dean Herbert · 2025-03-04 18:32:16 +09:00
  d9162daac2
• Merge pull request #32218 from peppy/fix-editor-creation-test-failures
  Dean Herbert · 2025-03-04 18:22:13 +09:00
  43259075ec
• Merge pull request #32214 from smoogipoo/fix-multi-user-kick-threading

  Fix thread safety when kicking multiplayer users

  Bartłomiej Dach · 2025-03-04 09:24:08 +01:00
  28be0e31c2
• Remove duplicated assert
  Dan Balasescu · 2025-03-04 17:22:19 +09:00
  5b0e54a77d
• Merge pull request #32219 from peppy/lounge-minor-redesign

  Adjust scale and display of rooms in multiplayer lounge

  Dan Balasescu · 2025-03-04 17:19:58 +09:00
  e0e7d92e79
• Update recently-added test
  Dan Balasescu · 2025-03-04 17:01:41 +09:00
  b19c2c7f9f
• Merge branch 'master' into remove-selectedroom
  Dan Balasescu · 2025-03-04 17:00:43 +09:00
  cf3664349d
• Fix typo in xmldoc
  Dean Herbert · 2025-03-04 16:15:40 +09:00
  2025.304.0 4a16b4bd98
• Merge pull request #32217 from smoogipoo/fix-mp-channel

  Fix multiplayer not joining correct chat channel

  Dean Herbert · 2025-03-04 16:15:20 +09:00
  667bd6e8f1
• Merge pull request #32075 from Gennadiyev/patch-result-screen-volume-adjust

  Add Alt + mousewheel volume adjustment on result screens

  Dean Herbert · 2025-03-04 16:06:46 +09:00
  c9a492a6eb
• Adjust scale and display of rooms in multiplayer lounge

  Just a quick pass because the rooms were definitely larger than they
  should be.

  Dean Herbert · 2025-03-04 15:55:44 +09:00
  4085ee805a
• Merge pull request #31866 from smoogipoo/remove-roommanager

  Remove `RoomManager`, centralise listing management to lounge

  Dean Herbert · 2025-03-04 15:52:59 +09:00
  5318c370d4
• Attempt to fix common editor test failures

  See
  https://github.com/ppy/osu/actions/runs/13623586844/job/38143232417?pr=32180
  for one example.
  
  Arguably the bindable usage in
  [`ControlPointPart`](https://github.com/ppy/osu/blob/2365b065a4994f38fe67bab7d193e5a09bee538c/osu.Game/Screens/Edit/Components/Timelines/Summary/Parts/ControlPointPart.cs#L24-L26)
  is dangerous, but it's only dangerous in tests (because control points
  aren't mutated outside the editor) so I'm willing to turn a blind eye
  for now to favour async loading support.

  Dean Herbert · 2025-03-04 15:51:08 +09:00
  a0888a7f2c
• Rename RoomsContainer and scope down bindables
  Dean Herbert · 2025-03-04 15:05:12 +09:00
  9e8a611728
• Fix multiplayer not joining correct chat channel
  Dan Balasescu · 2025-03-04 14:45:23 +09:00
  77d5b1d5dd
• LoungePollingComponent -> LoungeListingPoller
  Dean Herbert · 2025-03-04 14:40:55 +09:00
  0696cfa4f2
• Merge branch 'master' into remove-roommanager
  Dean Herbert · 2025-03-04 14:23:51 +09:00
  f3e9d1931c
• Merge branch 'master' into fix-multi-user-kick-threading
  Dean Herbert · 2025-03-04 14:21:38 +09:00
  6ba9491cea
• Merge pull request #32215 from smoogipoo/fix-broken-test

  Fix broken test

  Dean Herbert · 2025-03-04 14:20:55 +09:00
  45e0446e19
• Fix broken test
  Dan Balasescu · 2025-03-04 14:14:42 +09:00
  b73a872b94
• Fix thread safety when kicking multiplayer users
  Dan Balasescu · 2025-03-04 14:02:45 +09:00
  4a00662092
• Merge pull request #32158 from bdach/scaling-crash

  Fix possible crash when scaling objects in editor

  Dean Herbert · 2025-03-04 13:40:41 +09:00
  3fe92fb83c
• Merge pull request #32196 from bdach/disallow-negative-drain-length

  Fix drain length calculation helper method being able to return negative durations

  Dean Herbert · 2025-03-04 13:35:52 +09:00
  57ec2f7228
• Merge branch 'master' into remove-roommanager
  Dan Balasescu · 2025-03-04 13:17:04 +09:00
  446718f929
• Merge pull request #32200 from andy840119/remove-handle-scale-base-method

  Remove unused virtual method after refactor the scale handling.

  Dan Balasescu · 2025-03-04 13:14:14 +09:00
  8c13a86ad1
• Merge pull request #31637 from smoogipoo/room-management-lio

  Create, join, and part multiplayer rooms only via the multiplayer server

  Dean Herbert · 2025-03-04 13:13:55 +09:00
  58a671decb
• Merge pull request #32210 from smoogipoo/fix-multi-join-many-users

  Fix being unable to join multiplayer rooms with many users

  Dean Herbert · 2025-03-04 13:13:15 +09:00
  118f9a3a72
• Merge pull request #32208 from smoogipoo/diffcalc-timed-cancellation

  Cancel difficulty calculation after 10 seconds by default

  Dean Herbert · 2025-03-04 12:52:18 +09:00
  63cd93a9a8