50225 Commits

This Branch

This Branch

All Branches

• Merge pull request #16575 from hlysine/osu-diff-calc-max-combo

  Fix max combo calculation in osu diffcalc and add tests

  Dean Herbert · 2022-04-04 14:47:25 +09:00
  9bd7ccb1ce
• Merge branch 'master' into osu-diff-calc-max-combo
  Dean Herbert · 2022-04-04 14:20:44 +09:00
  ee8451c8ca
• Merge pull request #17617 from ajiiisai/proper-toggable-shortcuts-for-overlays

  Make overlay shortcuts able to be toggled instead of repeatable

  Dean Herbert · 2022-04-04 13:46:42 +09:00
  d6625413fa
• Invert operands for better readability
  Bartłomiej Dach · 2022-04-03 15:24:00 +02:00
  1393e3628b
• Merge pull request #17545 from jai-x/new-chat-textbox

  Implement `ChatTextBox` for new chat design

  Dean Herbert · 2022-04-03 22:12:12 +09:00
  969f7e121a
• Use nameof() in test to reference event names
  Bartłomiej Dach · 2022-04-03 14:27:37 +02:00
  6d1844adc3
• Rewrite logic slightly to better convey meaning of textbox clear
  Bartłomiej Dach · 2022-04-03 14:26:08 +02:00
  970b1951ac
• Use Action<string> for event OnChatMessageCommitted & clear textbox internally
  Jai Sharma · 2022-04-02 21:58:54 +01:00
  94fa5e2ef2
• General fix for ToolbarButton toggle repetition
  Ame · 2022-04-02 20:45:00 +02:00
  35629e9be8
• Merge pull request #17613 from frenzibyte/sucess-rate-tooltip

  Display pass/play count in success rate percentage tooltip

  Bartłomiej Dach · 2022-04-02 20:01:04 +02:00
  a2829b4fc7
• Make overlay shortcuts able to be toggled instead of repeatable
  Ame · 2022-04-02 19:41:15 +02:00
  0f94616890
• Merge branch 'master' into sucess-rate-tooltip
  Bartłomiej Dach · 2022-04-02 19:31:45 +02:00
  28ba437d24
• Merge pull request #17615 from frenzibyte/beatmap-panel-size-config

  Store beatmap listing card size in game configuration

  Bartłomiej Dach · 2022-04-02 19:30:21 +02:00
  e2f1183e7d
• Flip viaConfig conditional branch
  Salman Ahmed · 2022-04-02 19:28:33 +03:00
  b815f685fc
• Fix code quality issues
  Jai Sharma · 2022-04-02 17:27:44 +01:00
  9e152cd3fd
• Simplify TestCase attributes to one Values attribute

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Salman Ahmed · 2022-04-02 19:24:16 +03:00
  8534dd3463
• Use OnChatMessageCommit & OnSearchTermsChanged events in ChatTextBar
  Jai Sharma · 2022-04-02 17:15:19 +01:00
  2297073b7e
• Simplify text clear and placeholder change in ChatTextBox
  Jai Sharma · 2022-04-02 17:14:27 +01:00
  b9421d1415
• Save beatmap listing card size to game config
  Salman Ahmed · 2022-04-02 18:36:49 +03:00
  beb8426d3b
• Add failing test case
  Salman Ahmed · 2022-04-02 18:36:32 +03:00
  c4635f3c03
• Display pass/play count in success rate percentage tooltip
  Salman Ahmed · 2022-04-02 18:08:57 +03:00
  ced5be33e6
• Add random pass/play count data in test scene
  Salman Ahmed · 2022-04-02 18:08:23 +03:00
  a252c4cad5
• Merge pull request #17609 from CenTdemeern1/toolbar-clock-tests

  Add test coverage for toolbar clock mode cycling

  Bartłomiej Dach · 2022-04-02 15:46:57 +02:00
  9d236c503d
• Need to commit the second half again because my Git UI messed up
  CenTdemeern1 · 2022-04-02 04:53:47 +02:00
  c103cee1d5
• Change behavior of the display mode test

  I remembered to run InspectCode this time, all good

  CenTdemeern1 · 2022-04-02 04:45:21 +02:00
  a1baced777
• Remove hover test
  CenTdemeern1 · 2022-04-02 04:41:05 +02:00
  ee9696855b
• Remove redundant typecast I accidentally left in (Thanks InspectCode)
  CenTdemeern1 · 2022-04-02 04:31:43 +02:00
  245e452d41
• Add display mode changing test

  Yup this is gonna fail horribly

  CenTdemeern1 · 2022-04-02 04:26:16 +02:00
  95ccac50d4
• Add spaces around commas in Vector2 construction
  CenTdemeern1 · 2022-04-02 02:59:07 +02:00
  9350f6f5f8
• Trim whitespace
  CenTdemeern1 · 2022-04-02 02:43:51 +02:00
  dc744f18ff
• mainContainer -> toolbarClock
  CenTdemeern1 · 2022-04-02 02:43:44 +02:00
  6685c97147
• Initial attempt at writing a test for the toolbarClock

  I'll add more once I know if this code passes review or not

  CenTdemeern1 · 2022-04-02 02:35:37 +02:00
  b07152a119
• Merge pull request #17592 from peppy/skin-mutation-better-naming

  Fix automatically created "(modified)" skins getting conflicting names

  Dan Balasescu · 2022-04-01 21:25:10 +09:00
  6776c37bbc
• Put ToArray call in correct place in brackets
  Dean Herbert · 2022-04-01 19:30:16 +09:00
  43d03f2825
• Merge pull request #17490 from frenzibyte/improve-bug-issue

  Apply minor changes to the issue report template

  Dean Herbert · 2022-04-01 17:04:28 +09:00
  9d93cffbb2
• Reword log retrieval steps on mobile platforms

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Salman Ahmed · 2022-04-01 10:40:16 +03:00
  fc3ebe9b51
• Add missing ToArray call

  Not sure where this went, was there in my original commit.

  Dean Herbert · 2022-04-01 16:19:02 +09:00
  01681ee874
• Merge pull request #17594 from peppy/move-skin-component-error-handling

  Move `SkinnableInfo` error handling to lower level

  Dan Balasescu · 2022-04-01 16:04:00 +09:00
  cabf6f501f
• Merge pull request #17593 from peppy/disable-random-skin-in-skin-editor

  Disable ability to use random skin shortcut from within the skin editor

  Dan Balasescu · 2022-04-01 16:03:50 +09:00
  c294819128
• Move SkinnableInfo error handling to lower level

  Handling was recently added to handle the usage in
  `Skin.GetDrawableCompoent`, but it turns out this is also required for
  `DrawableExtensions.ApplySkinnableInfo` which can throw in a similar
  fashion.
  
  Found while working on sprite support for the editor, where this becomes
  an actual issue (ie. switching to a branch where the new sprite support
  is not present can cause unexpected crashes).

  Dean Herbert · 2022-04-01 14:30:04 +09:00
  01829cf2d8
• Disable ability to select random skin from within the skin editor

  Reasoning is explained in inline comment.
  
  I knowingly only applied this to the shortcut key. It's still feasible a
  user can choose the option from the skin dropdown while the editor is
  open, but that's less of an issue (because a user won't get the same
  compulsion that I get to mash the key, only to be greeted with 100 new
  mutable skins created).

  Dean Herbert · 2022-04-01 14:22:32 +09:00
  88306a6180
• Fix automatically created "(modified)" skins getting conflicting names

  Applies the already tested and proven method that is used in the editor
  to the mutable skin creation flow.

  Dean Herbert · 2022-04-01 14:11:55 +09:00
  69d4f86122
• Merge pull request #17588 from peppy/aim-assist-rename

  Rename "Aim Assist" to "Magnetised" to better suit the mod's behaviour

  Dan Balasescu · 2022-04-01 14:04:30 +09:00
  0a86bf6fb1
• Merge pull request #17589 from peppy/tournament-scene-manager-key-bindings

  Add ability to switch between most common tournament scenes using key bindings

  Dan Balasescu · 2022-04-01 14:04:21 +09:00
  4c8f427ad3
• Merge pull request #17579 from CenTdemeern1/clock-button

  Make the toolbar clock feel more like a button

  Dean Herbert · 2022-04-01 13:12:48 +09:00
  6b9f5812a5
• Merge pull request #17559 from bdach/mod-overlay/sheared-toggle

  Implement sheared toggle button

  Dean Herbert · 2022-04-01 13:06:22 +09:00
  10f15f2bdb
• Rename magnetised mod attraction strength property to match new naming
  Dean Herbert · 2022-04-01 13:03:48 +09:00
  de625125d6
• Add ability to switch between most common tournament scenes using key bindings
  Dean Herbert · 2022-04-01 12:44:49 +09:00
  ea672745b0
• Rename "Aim Assist" to "Magnetised" to better suit the mod's behaviour

  As proposed in https://github.com/ppy/osu/discussions/17375.

  Dean Herbert · 2022-04-01 12:15:52 +09:00
  a987cda30d
• Merge pull request #17581 from CenTdemeern1/remove-bpm-slider

  Remove BPM slider

  Dean Herbert · 2022-04-01 11:59:16 +09:00
  338a21f4f0