Dan Balasescu
9ac877606b
Fix inspection issues
2024-11-20 12:32:42 +09:00
Dan Balasescu
a5327aa562
Use properties instead of fields
2024-11-19 18:48:30 +09:00
Dan Balasescu
db7def9d34
Remove IDependencyInjectionCandidate interface from Room
2024-11-15 16:05:06 +09:00
Dan Balasescu
1a656d0ec3
Remove CachedModelDependencyContainer usages from online play
2024-11-15 15:59:28 +09:00
Dan Balasescu
bfbae9458a
Remove OnlinePlayComposite
2024-11-15 15:59:28 +09:00
Dan Balasescu
34c0f72dd6
Make Room.Playlist non-bindable
2024-11-15 15:51:01 +09:00
Dan Balasescu
b16edbbf52
Make Room.RecentParticipants non-bindable
2024-11-15 15:25:43 +09:00
Dan Balasescu
dc5337d771
Make Room.UserScore non-bindable
2024-11-15 14:42:46 +09:00
Dan Balasescu
c4f8fd1832
Make Room.DifficultyRange non-bindable
2024-11-15 14:42:46 +09:00
Dan Balasescu
487a010b12
Make Room.PlaylistItemStats non-bindable
2024-11-15 14:42:46 +09:00
Dan Balasescu
80b3e330a6
Make Room.ChannelId non-bindable
2024-11-15 14:42:46 +09:00
Dan Balasescu
6c84e425f8
Make Room.MaxAttempts non-bindable
2024-11-15 14:42:46 +09:00
Dan Balasescu
0ceaafe731
Make Room.Duration & Room.StartDate & Room.EndDate non-bindable
2024-11-15 14:42:45 +09:00
Dan Balasescu
89de4f0f87
Make Room.AutoStartDuration non-bindable
2024-11-15 14:42:45 +09:00
Dan Balasescu
b8bae30b66
Make Room.ParticipantCount & Room.MaxParticipants non-bindable
2024-11-15 14:42:45 +09:00
Dan Balasescu
f001cce24a
Make Room.AutoSkip non-bindable
2024-11-15 14:42:18 +09:00
Dan Balasescu
ec5be6dbc3
Make Room.Password & Room.HasPassword non-bindable
2024-11-15 14:42:18 +09:00
Dan Balasescu
198681e644
Make Room.QueueMode non-bindable
2024-11-15 14:42:18 +09:00
Dan Balasescu
7e3e5208f0
Make Room.Availability non-bindable
2024-11-15 14:42:18 +09:00
Dan Balasescu
5d4838a08b
Make Room.Status non-bindable
2024-11-15 14:42:18 +09:00
Dan Balasescu
81e4cb348f
Make Room.Type non-bindable
2024-11-15 14:42:18 +09:00
Dan Balasescu
bde7b8e610
Make Room.Category non-bindable
2024-11-15 14:42:18 +09:00
Dan Balasescu
8694f7e1cc
Make Room.Host non-bindable
2024-11-15 14:42:17 +09:00
Dan Balasescu
6160df1586
Make Room.Name non-bindable
2024-11-15 14:29:15 +09:00
Dan Balasescu
a2a930aa35
Fix CI issues
2024-11-13 17:15:50 +09:00
Dan Balasescu
5b2568d18b
Fix cases where the bindable is resolved directly
2024-11-13 16:38:49 +09:00
Dan Balasescu
99762da7b8
Make RoomID non-bindable
...
Most important changes are to `RoomSubScreen` and `PlaylistsRoomSubScreen`, because those are the only two cases that now bind to the event instead.
2024-11-13 16:28:54 +09:00
Dan Balasescu
db025d81ee
Reorder public property vs private field
2024-11-13 15:50:01 +09:00
Dan Balasescu
f3fd87af7b
Make DrawableMatchRoom structurally match other implementations
2024-11-12 20:32:59 +09:00
Dan Balasescu
8d5cd2b353
Fix inspection
2024-11-12 20:12:50 +09:00
Dan Balasescu
72564b5c98
Make CurrentPlaylistItem not a bindable
2024-11-12 18:17:24 +09:00
Dan Balasescu
9f08b37792
Fix up tests
2024-11-06 16:35:11 +09:00
Dan Balasescu
788ecc1e7b
Replace MultiplayerRoomComposite with local bindings
2024-11-06 15:31:27 +09:00
Bartłomiej Dach
0811de728e
Merge pull request #30300 from Darius-Wattimena/resizable-catcher
...
Fix catcher size and hyperdashes indication on adjusting CircleSize
2024-11-01 18:22:51 +01:00
Bartłomiej Dach
37c2ab9e6f
Merge branch 'master' into resizable-catcher
2024-11-01 13:08:06 +01:00
Bartłomiej Dach
488fabcd54
Use alternative method of resizing the catcher trails
...
This one preserves the catcher afterimage, which I'd count as a win.
2024-11-01 13:07:32 +01:00
Bartłomiej Dach
9df9a97188
Merge pull request #30321 from smoogipoo/bat-mods
...
Make `BeatmapAttributeText` show values inclusive of mods
2024-11-01 12:41:38 +01:00
Bartłomiej Dach
1b5d1347aa
Merge branch 'master' into bat-mods
2024-11-01 11:27:06 +01:00
Bartłomiej Dach
5f63950598
Add missing disposal
2024-11-01 11:26:59 +01:00
Dan Balasescu
44535d72ac
Merge pull request #30455 from smoogipoo/cap-effective-miss-count
...
Cap effective miss count to total hits
2024-11-01 18:46:21 +09:00
Dan Balasescu
052adc9446
Merge pull request #30459 from Joehuu/fix-android-gameplay-rotation-lock
...
Fix android screen orientation locking in portrait mode during gameplay when exiting/re-entering app
2024-11-01 15:40:46 +09:00
Dean Herbert
9872097513
Merge pull request #30458 from smoogipoo/ignore-acronym-casing
...
Ignore casing when matching mods acronyms
2024-10-31 20:22:21 +09:00
Joseph Madamba
4a26989084
Fix android screen orientation locking in portrait mode during gameplay when exiting/re-entering app
2024-10-30 17:51:06 -07:00
Dan Balasescu
372162de5d
Ignore casing when matching mods acronyms
2024-10-31 08:55:42 +09:00
Dan Balasescu
c1a40388ff
Cap effective miss count to total hits
2024-10-30 23:47:56 +09:00
Dean Herbert
50be7fb077
Merge pull request #30453 from bdach/everything-is-terrible
...
Fix several issues with beatmap online ID management
2024-10-30 19:22:37 +09:00
Bartłomiej Dach
7e3564cb4a
Bring back matching by filename when performing online metadata lookups
2024-10-30 10:25:20 +01:00
Bartłomiej Dach
d52f8c6379
Merge pull request #30450 from Joehuu/fix-polygon-popover-anchor
...
Fix editor sidebar resizing on hover repeatedly when polygon popover is opened
2024-10-30 09:47:24 +01:00
Bartłomiej Dach
2b0fd3558f
Remove more no-longer-required checks
...
The scenario that remaining guard was trying to protect against is
obviated by and no longer possible after
776fabd77c
2024-10-30 08:44:23 +01:00
Bartłomiej Dach
0e52797f29
Prefer not deleted models when picking model instances for reuse when importing
...
This fell out while investigating why the issue with online IDs
mismatching in the `.osu` could be worked around by importing the map
three times in total when starting from it not being available locally.
Here follows an explanation of why that "helped".
Import 1:
- The beatmap set is imported normally.
- Online metadata population sees the online ID mismatch and resets it
on the problematic beatmap.
Import 2:
- The existing beatmap set is found, but deemed not reusable
because of the single beatmap having its ID reset to -1.
- The existing beatmap set is marked deleted, and all the IDs of
its beatmaps are reset to -1.
- The beatmap set is reimported afresh.
- Online metadata population still sees the online ID mismatch
and resets it on the problematic beatmap.
Note that at this point the first import *is still physically present
in the database* but marked deleted.
Import 3:
- When trying to find the existing beatmap set to see if it can be
reused, *the one pending deletion and with its IDs reset -
- the remnant from import 1 - is returned*.
- Because of this, `validateOnlineIds()` resets online IDs
*on the model representing the current reimport*.
- The beatmap set is reimported yet again.
- With the online ID reset, the online metadata population check for
online ID mismatch does not run because *the IDs were reset to -1*
earlier.
Preferring undeleted models when picking the model instance for reuse
prevents this scenario.
2024-10-30 08:18:44 +01:00
