Dean Herbert
99d2d7b805
Add very basic implementation of bundled beatmap downloader
2022-04-28 19:01:21 +09:00
Dean Herbert
94a393c9d7
Merge branch 'master' into first-run-header
2022-04-28 19:00:12 +09:00
Dean Herbert
899e40dff7
Merge pull request #18004 from frenzibyte/update-framework
...
Update framework
2022-04-28 18:45:28 +09:00
Salman Ahmed
d052321eee
Revert "Fix context menus not working"
...
This reverts commit 51aa17eb52
2022-04-28 12:11:06 +03:00
Salman Ahmed
691bec6f16
Use LocalisableString.Interpolate instead of invalid TranslatableStrings
2022-04-28 11:38:40 +03:00
Salman Ahmed
be2d616e34
Fix localisation use cases not falling back to default(LocalisableString)
...
Previously such use cases have been returning `null` values just fine since `GetLocalisableString` was returning `LocalisableFormattableString`, and these null values were wrapped in `LocalisableString`s implicitly, therefore not requiring an explicit fallback string and `null` doesn't break anything.
2022-04-28 11:21:00 +03:00
Salman Ahmed
c8665dc93b
Update TimeSpan localisation to use ToLocalisableString
2022-04-28 11:12:50 +03:00
Salman Ahmed
edeefc2850
Update framework
2022-04-28 11:11:52 +03:00
Salman Ahmed
027ba17844
Merge pull request #17994 from peppy/fix-mod-panel-key-blocking
2022-04-27 18:43:40 +03:00
Salman Ahmed
b70cd47bb6
Merge branch 'master' into fix-mod-panel-key-blocking
2022-04-27 17:17:34 +03:00
Dan Balasescu
97005b898a
Merge pull request #17997 from peppy/fix-what-the-fuck
...
Remove weird duplicated code
2022-04-27 20:54:13 +09:00
Dean Herbert
d0ccd6f895
Merge branch 'master' into first-run-header
2022-04-27 19:26:02 +09:00
Dean Herbert
e9ec406046
Remove weird code
2022-04-27 19:20:08 +09:00
Dean Herbert
20a50ddb6e
Add missing OverlayColourProvider in test scene
2022-04-27 18:45:40 +09:00
Dean Herbert
b29af28028
Fix mod panels not ignoring super key presses
...
Most other usages have this included. Noticed that the panel was
changing state when exiting the game using cmd-w.
Would probably be nice to have an exposed `HasAnyModifierPressed` helper
property.
2022-04-27 16:55:17 +09:00
Dean Herbert
26f34e8fb9
Merge pull request #17991 from frenzibyte/invoke-all-fail-conditions
...
Fix `HealthProcessor` fail conditions not handling multiple invocations
2022-04-27 16:31:36 +09:00
Salman Ahmed
8842847b18
Fix wrong result applied
2022-04-27 00:05:49 +03:00
Salman Ahmed
1676c2c3f6
Change boolean argument to HitResult instead
2022-04-27 00:05:15 +03:00
Salman Ahmed
cccc9d7d39
Rename method to better reflect what it's doing
2022-04-27 00:03:48 +03:00
Salman Ahmed
fb6a112708
Mark OsuModTarget and OsuModSuddenDeath as mutually exclusive
...
`OsuModTarget` already fails on miss, so "Sudden Death" doesn't make
sense to be enabled and may only cause issues.
2022-04-26 23:27:03 +03:00
Salman Ahmed
31f64b1381
Fix HealthProcessor fail conditions not handling multiple invocations
2022-04-26 23:27:03 +03:00
Salman Ahmed
a884f20c65
Add failing test case
2022-04-26 23:27:03 +03:00
Joseph Madamba
b82ccb816c
Merge pull request #17988 from frenzibyte/use-correct-translation
...
Use correct translation for "Accuracy" label in break overlay
2022-04-26 09:42:43 -07:00
Salman Ahmed
e646233722
Use correct translation for "Accuracy" label in break overlay
2022-04-26 19:16:36 +03:00
Dan Balasescu
e9d1982a7f
Merge pull request #17982 from peppy/sheared-button
...
Add basic sheared button implementation
2022-04-26 19:54:06 +09:00
Salman Ahmed
8880ff16c3
Merge branch 'master' into sheared-button
2022-04-26 13:09:10 +03:00
Dan Balasescu
b19e738315
Merge pull request #17913 from molneya/hold-addition-fix
...
Fix mania SR inflation for hold note releases in quick succession
2022-04-26 18:31:07 +09:00
Salman Ahmed
9911f3658f
Merge pull request #17980 from peppy/fix-joystick-bindable-mayhe
2022-04-26 12:27:22 +03:00
Dean Herbert
4a370f429e
Reorder initialisation of bindable action binding to make more sense
2022-04-26 18:21:46 +09:00
Dean Herbert
52a8f3848d
Expose font size and add big button test
2022-04-26 18:14:57 +09:00
Dean Herbert
cd197a9380
Reduce the hover lightening effect slightly
2022-04-26 18:11:03 +09:00
Salman Ahmed
6e83aceaf9
Merge branch 'master' into fix-joystick-bindable-mayhe
2022-04-26 12:05:09 +03:00
Dan Balasescu
c37e87d92f
Merge pull request #17981 from peppy/osu-button-click-flash
...
Fix all buttons gamewide not animating properly on click
2022-04-26 18:04:32 +09:00
Dean Herbert
4bc4ff179a
Add flash effect on click
2022-04-26 18:03:34 +09:00
Dean Herbert
6864623bac
Add ShearedButton test coverage
2022-04-26 18:03:27 +09:00
Dean Herbert
4e260e7410
Fix all buttons gamewide not animating properly on click
...
Not sure how or when this happened.
2022-04-26 17:32:25 +09:00
Dean Herbert
9f33e627de
Split out ShearedButton from ShearedToggleButton
2022-04-26 17:31:55 +09:00
Dean Herbert
c52c08fe97
Rename test to increase scope
2022-04-26 17:31:39 +09:00
Dean Herbert
280cd048f6
Fix joystick settings changing enabled state of config level bindables
...
Just copied what we had in place for the mouse sensitivity setting. For
tablet settings I believe I avoided this by just hiding the settings
when not enabled. Might be a better way forward, but this is simplest
for now.
Run `TestSceneSettingsPanel` twice to get a crash without this change.
2022-04-26 17:31:28 +09:00
Dan Balasescu
dc0f1a9419
Merge pull request #17979 from peppy/first-run-show-get-started
...
Improve displayed text on first run setup back/next buttons
2022-04-26 17:04:03 +09:00
Dean Herbert
01fdb771ee
Add header text to first run setup screens
2022-04-26 16:22:41 +09:00
Dean Herbert
a078440012
Show last step on back button as well
2022-04-26 16:03:17 +09:00
Dean Herbert
37ae39f5fe
Move "Next" localisation to common strings
2022-04-26 15:48:40 +09:00
Dan Balasescu
9d198ad6bb
Merge pull request #17972 from peppy/hotfix-context-menu
...
Fix windows taskbar context menu not popping up correctly
2022-04-26 13:52:02 +09:00
Dan Balasescu
9911584fe1
Merge pull request #17977 from peppy/show-during-gameplay-improvement
...
Change conditions for HUD being shown to include pause/fail states
2022-04-26 12:55:31 +09:00
Dean Herbert
8ab3636f87
Change conditions for HUD being shown to include pause/fail states
...
As proposed in https://github.com/ppy/osu/discussions/17975 . Feels pretty good to me, and probably how it should have been implemented from the start.
2022-04-26 12:09:21 +09:00
Dean Herbert
d310886c26
Add test coverage of IsPlaying state during fail and pause
2022-04-26 12:09:18 +09:00
Dan Balasescu
51b4821efa
Merge pull request #17976 from frenzibyte/improve-score-grading
...
Change score accuracy grading logic to be inclusive
2022-04-26 12:06:58 +09:00
Salman Ahmed
7d32490198
Change score accuracy grading logic to be inclusive
2022-04-26 04:55:27 +03:00
Salman Ahmed
f958010d29
Fix AccuracyCircle storing accuracy values in float
2022-04-26 04:52:48 +03:00
