Dean Herbert
ee9e329db3
Inhibit original callback from firing when sending initial changeset
2024-07-09 16:05:58 +09:00
Dean Herbert
2423bbb776
Ensure realm subscriptions always fire initial callback with null ChangeSet
...
We expect this to be the case, but it turns out that it [may be
coalesced](https://www.mongodb.com/docs/realm-sdks/dotnet/latest/reference/Realms.IRealmCollection-1.html#Realms_IRealmCollection_1_SubscribeForNotifications_Realms_NotificationCallbackDelegate__0__Realms_KeyPathsCollection_ ):
> Notifications are delivered via the standard event loop, and so can't
> be delivered while the event loop is blocked by other activity. When
> notifications can't be delivered instantly, multiple notifications may
> be coalesced into a single notification. This can include the
> notification with the initial collection.
Rather than struggle with handling this locally every time, let's fix
the callback at our end to ensure we receive the initial null case.
I've raised concern for the API being a bit silly with realm
(https://github.com/realm/realm-dotnet/issues/3641 ).
2024-07-09 15:47:43 +09:00
Dean Herbert
c8b9c117cd
Add failing test showing realm not sending through null ChangeSet
2024-07-09 15:47:43 +09:00
Joseph Madamba
cd968d4185
Add caret transition to beatmap sort tab items
2024-07-08 16:46:35 -07:00
Dean Herbert
c100d1ab65
Merge pull request #28769 from peppy/carousel-realm-simplification
...
Simplify realm model tracking in `BeatmapCarousel` (and fix hard delete handling)
2024-07-09 01:40:10 +09:00
Dan Balasescu
64e527852c
Merge pull request #28780 from huoyaoyuan/net8.0/new-api
...
Use Environment.IsPrivilegedProcess and remove Mono.Posix.NETStandard
2024-07-09 01:29:12 +09:00
Huo Yaoyuan
ae78c13684
Use Environment.IsPrivilegedProcess
2024-07-09 00:04:29 +08:00
Dan Balasescu
9c2a0576fb
Merge pull request #28776 from bdach/fix-composer-disappearing
...
Fix composer disappearing when undoing change to control points
2024-07-09 00:54:38 +09:00
Dean Herbert
9a61adc4bc
Ensure other lists are cleared when realm is reset
2024-07-08 23:59:20 +09:00
Bartłomiej Dach
4dd20ccf79
Merge pull request #28771 from frenzibyte/sorted-breaks
...
Fix breaks not showing unless already ordered in the beatmap file
2024-07-08 16:46:50 +02:00
Bartłomiej Dach
275b959c02
Fix composer disappearing when undoing change to control points
...
As mentioned in https://github.com/ppy/osu/issues/28752 .
Regressed in https://github.com/ppy/osu/pull/28444 .
2024-07-08 16:28:54 +02:00
Bartłomiej Dach
449d50a46a
Add failing test case
2024-07-08 16:28:33 +02:00
Bartłomiej Dach
877b5768fc
Merge branch 'master' into sorted-breaks
2024-07-08 15:59:32 +02:00
Bartłomiej Dach
0d22c9a9c6
Pass comparer in all usages for consistency
2024-07-08 15:58:21 +02:00
Salman Ahmed
b33e54d064
Enforce IBeatmap.Breaks to be sorted chronologically
2024-07-08 16:06:38 +03:00
Salman Ahmed
da4067d059
Add failing test case
2024-07-08 16:06:34 +03:00
Bartłomiej Dach
baff790b4c
Merge pull request #28772 from OliBomby/time-accurate
...
Fix CurrentTimeAccurate being inaccurate
2024-07-08 14:50:13 +02:00
Bartłomiej Dach
2cad8d3684
Merge branch 'master' into time-accurate
2024-07-08 14:19:57 +02:00
Dan Balasescu
5cae005027
Merge pull request #28770 from bdach/really-now
...
Fix editor playback control not removing correct adjustment
2024-07-08 20:45:17 +09:00
Bartłomiej Dach
d5158d1035
Fix incorrect changes around success callback refactor
2024-07-08 13:36:30 +02:00
OliBomby
2822ba2377
Fix CurrentTimeAccurate being inaccurate if seeking smoothly in the same frame and a transform is already active
2024-07-08 13:30:11 +02:00
Bartłomiej Dach
0fe2c45e1d
Fix editor playback control not removing correct adjustment
...
Closes https://github.com/ppy/osu/issues/28768 .
great job past me 🤦 🤦 🤦 🤦 🤦 🤦 🤦 🤦 🤦 🤦 🤦
2024-07-08 13:21:42 +02:00
Bartłomiej Dach
6433f29651
Add failing test case
2024-07-08 13:21:38 +02:00
Dean Herbert
c0a1696538
Merge pull request #28762 from frenzibyte/change-chevron-display
...
Change display of "expanded" chevrons in many UI components to use scale instead of rotation
2024-07-08 20:05:59 +09:00
Dean Herbert
8f271170e9
Coalesce beatmap updates
2024-07-08 20:05:18 +09:00
Dean Herbert
1095137a5b
Simplify tracking of hidden beatmaps
...
Handling a few extra events is preferrable to keeping a second realm
subscription live.
2024-07-08 20:05:18 +09:00
Dean Herbert
151c448535
Simplify tracking of beatmap sets in BeatmapCarousel
2024-07-08 20:05:18 +09:00
Dean Herbert
e51d510ea3
Add failing test for beatmap set hard deletion
2024-07-08 20:05:17 +09:00
Dean Herbert
910153c2e0
Fix sizing / padding of collection dropdown header
2024-07-08 19:32:28 +09:00
Dan Balasescu
b2bdb67a3e
Merge pull request #28765 from bdach/editor-menu-max-height
...
Fix editor menus overflowing off screen
2024-07-08 19:13:30 +09:00
Dan Balasescu
44ebec07bb
Merge pull request #28767 from bdach/editor-test-play-ur-counter-crash
...
Fix editor player crashing with UR counter present in skin
2024-07-08 19:13:19 +09:00
Salman Ahmed
2f4e447cba
Merge pull request #28547 from nekodex/audio-ducking-fx
...
Add a 'ducking' effect to the currently playing track when changing ruleset
2024-07-08 13:12:04 +03:00
Salman Ahmed
2fcc61edfa
Merge branch 'master' into audio-ducking-fx
2024-07-08 12:50:46 +03:00
Bartłomiej Dach
14a93bfc1a
Merge pull request #28553 from frenzibyte/mod-select-customisation-panel
...
Detach mod customisation area from the footer and replace with an overlay panel display
2024-07-08 11:26:21 +02:00
Salman Ahmed
784a9ae743
Merge branch 'master' into audio-ducking-fx
2024-07-08 12:26:10 +03:00
Bartłomiej Dach
db7774485a
Fix editor player crashing with UR counter present in skin
...
Closes https://github.com/ppy/osu/issues/28764 .
2024-07-08 11:14:32 +02:00
Bartłomiej Dach
2ceedb0f93
Fix editor menus overflowing off screen
...
Closes https://github.com/ppy/osu/issues/28750 .
Yes this is not the perfect change to fix this (which would probably be
some framework change to take bounds of the parenting input manager into
account). I really do not want to go there and would like to just fix
this locally and move on. Due to the game-wide scaling container this
sorta works for any resolution anyhow.
2024-07-08 11:05:39 +02:00
Joseph Madamba
257de9d08b
Fix arrow direction test
2024-07-08 01:00:36 -07:00
Salman Ahmed
a3e54a6272
Merge pull request #28763 from peppy/revert-to-default-animation
...
Add slight animation when revert to default button is displayed
2024-07-08 10:58:53 +03:00
Joseph Madamba
73d164e0d0
Add chevron transition to CommentRepliesButton
2024-07-08 00:32:54 -07:00
Dean Herbert
03bd6069d8
Add slight animation when revert to default button is displayed
...
This also fixes the transforms running too often (could make the initial
transform take longer than expected if adjusting a slider bar, for
instance).
2024-07-08 15:50:27 +09:00
Joseph Madamba
9532146978
Fix content overflowing to border
...
The +2 for the top isn't really needed for the original purpose as content fades out now, but visually, having the header and content spacing looks more correct.
2024-07-07 23:12:20 -07:00
Salman Ahmed
7dc901df11
Do not be lenient on nullability of dropdown
2024-07-08 08:54:05 +03:00
Salman Ahmed
58e236a247
Add transition to dropdown chevrons
2024-07-08 08:48:52 +03:00
Salman Ahmed
4c2ae07eba
Use scale instead of rotation in ChevronButton (used in top-right of comments section)
2024-07-08 08:48:07 +03:00
Salman Ahmed
dc630ddc9d
Use scale instead of rotation in news month sidebar
2024-07-08 08:45:44 +03:00
Salman Ahmed
be039b85ad
Use scale instead of rotation in profile cover toggle button
2024-07-08 08:32:29 +03:00
Salman Ahmed
5223e0aeae
Use scale instead of rotation for overlay scroll button
2024-07-08 08:31:33 +03:00
Salman Ahmed
22f2f83695
Rescale chevron up and down instead
2024-07-08 08:07:57 +03:00
Dan Balasescu
9375f79879
Add frenzibyte to users that can use diffcalc workflow
2024-07-08 13:58:42 +09:00
