61958 Commits

This Branch

This Branch

All Branches

• Fix tournament song bar tests not showing anything by default
  Dean Herbert · 2023-08-16 17:14:34 +09:00
  965da343a4
• Merge pull request #24402 from QuantumSno/leaderboard-toggle

  Add ability to toggle gameplay leaderboards with tab key

  Dean Herbert · 2023-08-16 16:57:07 +09:00
  7f8455eb06
• Refactor migration to read the same as previous one
  Dean Herbert · 2023-08-16 16:21:42 +09:00
  caf0fd0742
• Re-date migration
  Dean Herbert · 2023-08-16 16:20:17 +09:00
  68db112882
• Add leaderboard toggle as tracked setting to give better use visibility
  Dean Herbert · 2023-08-16 16:17:56 +09:00
  c885b71f3a
• Merge branch 'master' into leaderboard-toggle
  Dean Herbert · 2023-08-16 15:49:55 +09:00
  31c2b7f925
• Merge pull request #24561 from peppy/rename-dummy-local-user

  Rename "dummy" local user to something more descriptive

  Bartłomiej Dach · 2023-08-16 07:34:25 +02:00
  34a519f803
• Rename "dummy" local user to something more descriptive

  This created weird cases in logs which are very hard to understand. The
  one which really got me was this:
  
  ```
  [runtime] 2023-08-13 07:48:27 [verbose]: Invalidating working beatmap cache for unknown artist - unknown title (Dummy)
  ```
  
  Which looks like a dummy working beatmap was invalidated, but it turns
  out that's just the local user which was populated when creating a new
  local beatmap.

  Dean Herbert · 2023-08-16 13:52:27 +09:00
  6001f7e5c7
• Merge pull request #24552 from smoogipoo/hold-off-no-end-notes

  Disable hold end conversion for mania HoldOff mod

  Dean Herbert · 2023-08-16 13:26:28 +09:00
  2a3f7e7362
• Fix test + cleanup
  Dan Balasescu · 2023-08-15 19:42:32 +09:00
  5678db4e70
• Disable hold end conversion for mania HoldOff mod
  Dan Balasescu · 2023-08-15 19:30:40 +09:00
  e34a9a0001
• Merge pull request #24548 from peppy/fix-score-copy-instability

  Fix score being cloned in async method causing random crashes

  Bartłomiej Dach · 2023-08-15 09:38:38 +02:00
  2023.815.0 4e96853c75
• Fix score being cloned in async method causing random crashes

  Closes https://github.com/ppy/osu/issues/24445.

  Dean Herbert · 2023-08-15 16:08:13 +09:00
  e8bde6504a
• Merge pull request #24546 from peppy/update-framework

  Update framework

  Dean Herbert · 2023-08-15 15:34:56 +09:00
  526a145b93
• Merge pull request #24544 from smoogipoo/pool-mania-barlines

  Add pooling for mania barlines

  Dean Herbert · 2023-08-15 15:21:59 +09:00
  3526032c9a
• Merge pull request #24547 from bdach/slider-kiai-stars-broke

  Fix kiai stars flickering on and off during gameplay

  Dean Herbert · 2023-08-15 15:21:46 +09:00
  57e49495bc
• Fix kiai stars flickering on and off during gameplay

  Closes #24503.
  
  The problematic reset of `lastParticleAdded` has been moved to a place
  that should hopefully (a) not cause such problems and (b) be much more
  explicit about what's happening.

  Bartłomiej Dach · 2023-08-15 07:44:05 +02:00
  ab1d523528
• Update framework
  Dean Herbert · 2023-08-15 14:33:21 +09:00
  8c14ff674e
• Merge pull request #24528 from bdach/fix-dual-stages-skinnable-layer

  Fix playfield skinnable layer bounds being incorrectly calculated with multiple stages

  Dean Herbert · 2023-08-15 14:29:18 +09:00
  31c31a9359
• Adjust test to share barline between stages
  Dan Balasescu · 2023-08-15 13:34:02 +09:00
  e9621e7d6e
• Add barline pooling for mania
  Dan Balasescu · 2023-08-15 13:33:49 +09:00
  6a7b0786c9
• Merge pull request #24540 from peppy/remove-fps-fade-in-out

  Don't completely fade FPS counter out when running at full FPS

  Bartłomiej Dach · 2023-08-14 19:26:59 +02:00
  01eceea72f
• Merge branch 'master' into remove-fps-fade-in-out
  Bartłomiej Dach · 2023-08-14 18:46:30 +02:00
  9e7cc05138
• Merge pull request #24541 from smoogipoo/fix-incorrect-cast

  Fix incorrect truncation to int

  Bartłomiej Dach · 2023-08-14 18:46:10 +02:00
  7dd82841ea
• Fix incorrect truncation to int
  Dan Balasescu · 2023-08-15 00:58:13 +09:00
  90d7e46e20
• Don't completely fade FPS counter out when running at full FPS

  I've heard multiple times from uses that this is distracting or
  confusing.

  Dean Herbert · 2023-08-14 23:55:57 +09:00
  34c761946c
• Merge pull request #24538 from smoogipoo/temp-optional-difficulty-attribs

  Temporarily allow new difficulty attributes to not exist

  Dean Herbert · 2023-08-14 17:33:30 +09:00
  2023.814.0 fd3f5d8e79
• Temporarily allow new difficulty attributes to not exist
  Dan Balasescu · 2023-08-14 16:59:01 +09:00
  d1a4a46fd3
• Remove duplicated test case
  Bartłomiej Dach · 2023-08-12 22:46:18 +02:00
  4152b4e523
• Fix playfield skinnable layer bounds being incorrectly calculated with multiple stages

  Closes #24514.
  
  The original PR was _supposed_ to be handling this, and had code that
  _looked_ like it would handle it, but was in fact subtly wrong, as the
  union of `RectangleF.Empty` (initial value of `area`) and an arbitrary
  other rectangle is _not_ the second rectangle, but rather a rectangle
  that contains _both_ the second rectangle and the point (0,0),
  thus leading to the bound calculation fail.

  Bartłomiej Dach · 2023-08-12 21:55:20 +02:00
  3178865cd3
• Merge branch 'master' into leaderboard-toggle
  QuantumSno · 2023-08-12 11:21:02 -04:00
  a0543d97bd
• Merge pull request #24518 from peppy/update-framework

  Update framework

  Bartłomiej Dach · 2023-08-12 11:44:25 +02:00
  2023.812.0 d2baffa0e7
• Update framework
  Dean Herbert · 2023-08-12 17:54:05 +09:00
  0eaa383120
• Merge pull request #24511 from bdach/legacy-exporter-not-converting

  Fix legacy beatmap exporter not converting beatmap between decode and re-encode

  Dean Herbert · 2023-08-12 14:28:08 +09:00
  7fa3508a0b
• Merge remote-tracking branch 'origin/leaderboard-toggle' into leaderboard-toggle
  QuantumSno · 2023-08-12 00:19:48 -04:00
  e9bb9434e9
• Updated test TestSceneGameplayChatDisplay.cs. Now uses new default bind for toggle chat (enter)
  QuantumSno · 2023-08-12 00:18:10 -04:00
  562af8b46d
• Fix LegacyBeatmapExporter not converting beatmap between decode and re-encode
  Bartłomiej Dach · 2023-08-12 00:50:31 +02:00
  253392409e
• Repurpose Flat{File -> }WorkingBeatmap
  Bartłomiej Dach · 2023-08-12 00:49:42 +02:00
  37361cd683
• Update framework
  Dean Herbert · 2023-08-11 21:34:59 +09:00
  2023.811.0 896cbb0ba0
• Reword / fix comments
  Bartłomiej Dach · 2023-08-10 22:55:02 +02:00
  2b738edb93
• Merge branch 'master' into leaderboard-toggle
  Bartłomiej Dach · 2023-08-10 22:50:55 +02:00
  1b3806539a
• Removed comments organizing GlobalActionContainer.cs, since they were incorrectly grouping actions
  QuantumSno · 2023-08-10 10:18:15 -04:00
  5d6ebb4df9
• Updated wording on realm comments
  QuantumSno · 2023-08-10 10:17:12 -04:00
  71c42167e7
• Merge pull request #24409 from cdwcgt/tournament-nullable

  Remove #nullable disable in tournament

  Dean Herbert · 2023-08-10 19:38:16 +09:00
  5b44124ecf
• Fix some more nullability inspections
  Bartłomiej Dach · 2023-08-09 21:32:46 +02:00
  3501b7c22b
• Apply nullability to all remaining tests where it wasn't applied
  Dean Herbert · 2023-08-10 00:24:57 +09:00
  4e83245acf
• Revert some usages of AsNonNull() in tests

  We generally prefer `!` when it is unambiguous usage (ie. direct access).

  Dean Herbert · 2023-08-10 00:20:37 +09:00
  6549ca5304
• let MatchIPCInfo .Beatmap be nullable
  cdwcgt · 2023-08-09 19:13:49 +09:00
  5ad80879b7
• Revert "use no null when true"

  This reverts commit 6ad8339c66.

  cdwcgt · 2023-08-09 19:11:36 +09:00
  5898a9986b
• Fix weird usage of Cast
  Dean Herbert · 2023-08-09 18:21:57 +09:00
  c88045dfc7