Dean Herbert
94cbe1838f
Replace usages of is null with == null
2024-04-03 01:50:39 +08:00
Dean Herbert
aa7b357063
Merge pull request #27768 from 64ArthurAraujo/editor-fix-sliders-same-start-time-merge
...
Fix merging sliders with the same `StartTime` causing a Unhandled Exception
2024-04-03 01:45:55 +08:00
Arthur Araujo
9315aefe41
Fix remove additional blank line
2024-04-02 08:48:01 -03:00
Arthur Araujo
2a2a372595
Check if blueprint is in SelectionBlueprints before changing its depth
2024-04-02 07:45:27 -03:00
Dean Herbert
51e9348d27
Merge pull request #26702 from honguyenminh/fix-rotate-editor-button-disabled
...
Fix rotate tool button in editor disabled when selecting 1 circle
2024-04-02 14:31:43 +08:00
Nguyên Minh Hồ
6642702fa9
Update plurals in editor rotate button tooltip
...
Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>
2024-04-02 12:36:44 +07:00
Dean Herbert
eca242c1c7
Change tooltip text slightly
2024-04-02 13:17:16 +08:00
Dean Herbert
ed5dd5c8cd
Bind using local bindables to avoid potentially event pollution
2024-04-02 13:04:34 +08:00
Dean Herbert
95b50576bd
Merge pull request #27698 from bdach/banish-rulesets-that-do-stupid-crap-to-the-BLAGOLE
...
Attempt to disable custom rulesets that can be linked to an unhandled crash
2024-04-01 15:47:47 +08:00
Dan Balasescu
8160ffa353
Merge pull request #27761 from 64ArthurAraujo/editor-fix-control-points-update-on-stacking
...
Update Slider path control points and connections after stacking application
2024-04-01 16:17:51 +09:00
Dan Balasescu
099ad22a92
Use local bindable instead
...
Binding events directly to an external bindable will cause that
bindable to hold a permanent reference to the current object.
We use `GetBoundCopy()` or otherwise a local bindable + `.BindTo()` to create a
weak-referenced copy of the target bindable. When the local bindable's
lifetime expires, so does the external bindable's reference to it.
2024-04-01 15:31:35 +09:00
Dan Balasescu
7615c71efe
Fix inspection
2024-04-01 15:28:20 +09:00
Arthur Araujo
19f0caa0f3
Fix wrong formatting in array creation
2024-03-31 13:39:19 -03:00
Nguyên Minh Hồ
1adba68357
Merge branch 'fix-rotate-editor-button-disabled' of https://github.com/honguyenminh/osu into fix-rotate-editor-button-disabled
2024-03-31 16:00:58 +07:00
Nguyên Minh Hồ
86def7e263
Change editor rotate button disabled tooltip text
...
Co-authored-by: Dean Herbert <pe@ppy.sh>
2024-03-31 16:00:47 +07:00
Dean Herbert
c17ce3362b
Merge pull request #27760 from EVAST9919/better-break-arrows
...
Fix break overlay arrows look ugly on bright backgrounds
2024-03-31 10:24:32 +08:00
Arthur Araujo
450e7016bc
Bind StackHeight changes to visual update methods
2024-03-30 21:23:05 -03:00
Andrei Zavatski
11b1135804
Adjust blurred icons position due to size handling differences
2024-03-31 01:55:34 +03:00
Andrei Zavatski
58a68e94af
Simplify glowing icons in break overlay
2024-03-31 01:44:54 +03:00
Andrei Zavatski
54472e6452
Decouple GlowingDrawable from GlowingSpriteText
2024-03-31 01:44:54 +03:00
Nguyên Minh Hồ
b445e27ad6
Aggregate two CanRotate bindable for enabling the Rotate button
2024-03-30 17:54:27 +07:00
Nguyên Minh Hồ
6f782266b5
Fix inspection
2024-03-30 17:28:57 +07:00
Nguyên Minh Hồ
5d497ba4a8
Simplify TooltipText for EditorRadioButton
2024-03-30 16:04:22 +07:00
Nguyên Minh Hồ
8d6358a138
Fix editor rotation allowing spinner only bug
2024-03-30 16:02:31 +07:00
Nguyên Minh Hồ
9950395e5f
Merge branch 'fix-rotate-editor-button-disabled' of https://github.com/honguyenminh/osu into fix-rotate-editor-button-disabled
2024-03-30 13:57:44 +07:00
Nguyên Minh Hồ
113dbcd10f
Merge branch 'master' into fix-rotate-editor-button-disabled
2024-03-30 13:56:31 +07:00
Salman Ahmed
93f1578c10
Merge pull request #27758 from peppy/fix-mascot-size
...
Fix taiko mascot size not matching stable
2024-03-29 23:53:24 +03:00
Salman Ahmed
51f79c33e1
Fix URL pointing to non-existent commit
2024-03-29 23:33:06 +03:00
Dean Herbert
c21805589e
Fix taiko mascot size not matching stable
2024-03-29 22:40:04 +08:00
Dan Balasescu
48f8d9c916
Merge pull request #27756 from bdach/pp-on-results-provisional
...
Apply partial fade on pp display on results screen when score will not give pp
2024-03-29 19:57:59 +09:00
Bartłomiej Dach
5371141d3b
Merge pull request #27755 from peppy/fix-import-weirdness
...
Avoid reporting an import as successful when all beatmaps failed to import
2024-03-29 11:25:41 +01:00
Bartłomiej Dach
e06df34a1c
Apply partial fade on pp display on results screen when score will not give pp
2024-03-29 11:16:31 +01:00
Bartłomiej Dach
2d3b273974
Remove redundant string interpolation
2024-03-29 10:37:49 +01:00
Dean Herbert
df4a28db91
Fix failing test due to missing ruleset store
2024-03-29 17:32:20 +08:00
Bartłomiej Dach
320ca04d98
Merge pull request #27748 from smoogipoo/update-diffcalc-gha
...
Update action versions in diffcalc workflow
2024-03-29 10:25:41 +01:00
Bartłomiej Dach
5c7fdeca35
Merge pull request #27754 from peppy/multi-binding-fix
...
Fix double binding causing game crash after API enters failing state
2024-03-29 10:21:33 +01:00
Dean Herbert
233b9eb172
Avoid reporting an import as successful when all beatmaps failed to import
2024-03-29 17:11:55 +08:00
Dean Herbert
d9cf5b5440
Fix bindable not being correctly re-bound across local user changes
2024-03-29 15:50:10 +08:00
Dean Herbert
fef8afb833
Fix double binding causing game crash after API enters failing state
...
See https://sentry.ppy.sh/organizations/ppy/issues/33406/?alert_rule_id=4&alert_timestamp=1711655107332&alert_type=email&environment=production&project=2&referrer=alert_email
2024-03-29 12:19:14 +08:00
Dean Herbert
c51a2e169d
Add test coverage of crash scenario
2024-03-29 12:19:13 +08:00
Dan Balasescu
cbbb46cad8
Update action versions in diffcalc workflow
2024-03-29 00:25:32 +09:00
Bartłomiej Dach
21201e616d
Merge pull request #27723 from 64ArthurAraujo/editor-fix-reverse-selection
...
Fix reverse selection not updating new combo location
2024-03-28 11:25:17 +01:00
Bartłomiej Dach
2f786ffc32
Simplify implementation
2024-03-28 10:12:27 +01:00
Bartłomiej Dach
a9cbabf711
Simplify tests
2024-03-28 10:05:26 +01:00
Dan Balasescu
4a8e0eddd0
Merge pull request #27739 from Susko3/use-invariant-culture-in-skin-parsing
...
Fix `SkinImporter` not using invariant culture when parsing skins without `skin.ini`
2024-03-28 09:52:16 +09:00
Susko3
53900d5472
Fix tests failing locally due to not using invariant culture
2024-03-27 18:56:26 +01:00
Arthur Araujo
60c93d2c6d
Add reverse pattern visual tests
2024-03-27 08:22:51 -03:00
Dan Balasescu
4490dbf896
Update diffcalc workflow
2024-03-27 13:37:47 +09:00
Bartłomiej Dach
6ef54321c4
Merge pull request #26707 from peppy/beat-sync-container-early-adjust
...
Adjust `BeatSyncContainer`'s early animate offset based on source's rate
2024-03-26 18:43:25 +01:00
Bartłomiej Dach
0b29a762b8
Add precautionary guard to avoid potential div-by-zero
...
Probably wouldn't happen outside of tests, but I'd rather not find out
next release.
2024-03-26 17:36:40 +01:00
