Cootz
90aa4288d0
Reduce the allowed length by 5 to account for (99) suffix. Move truncating logic to GetFilename
. Update tests.
2023-02-21 18:35:53 +03:00
Cootz
5fa75805cc
Merge branch 'master' into fix-exporting-a-skin-with-too-long-file-name
2023-02-18 15:52:17 +03:00
Bartłomiej Dach
6b1c8195bc
Merge pull request #22672 from peppy/skin-editor-improve-toolbox-hover
...
Improve the feel of hovering components in the skin editor toolbox
2023-02-18 10:34:28 +01:00
Bartłomiej Dach
fbea3e312f
Merge branch 'master' into skin-editor-improve-toolbox-hover
2023-02-18 10:02:02 +01:00
Bartłomiej Dach
2aa4481f68
Fix toolbox items spontaneously contracting after briefly losing hover
...
Reproduction scenario:
1. Hover a toolbox item
2. Unhover the item, but do not hover any other item (can be done by
exiting the toolbox completely to the right)
3. Come back to the item hovered in step (1)
4. The item would spontaneously contract after a second
2023-02-17 22:54:11 +01:00
Bartłomiej Dach
23a636b74b
Merge pull request #22648 from peppy/skinnable-clean-up-documentation
...
Refactor structure and naming of skin-related classes
2023-02-17 21:37:54 +01:00
Bartłomiej Dach
6afa65bd3d
Merge branch 'master' into skinnable-clean-up-documentation
2023-02-17 20:59:18 +01:00
Salman Ahmed
449e5fa6f8
Rename one more left-over skinnable
naming
2023-02-17 22:09:55 +03:00
Cootz
e3bdb3d852
Align links in one line
2023-02-17 15:32:36 +03:00
Cootz
fd1beaef87
Fix typo
2023-02-17 15:24:27 +03:00
Cootz
a3b440493a
Update xml doc
2023-02-17 15:23:43 +03:00
Cootz
ceed3606cd
Remove redundant comment
...
Co-authored-by: Dean Herbert <pe@ppy.sh>
2023-02-17 13:46:06 +03:00
Dean Herbert
5ed038fbb3
Improve the feel of hovering toolbox component items
2023-02-17 19:26:03 +09:00
Dean Herbert
1a63ca9ece
Add xmldoc around SkinComponentsContainerLookup
2023-02-17 14:18:05 +09:00
Dean Herbert
372b6b794c
I don't know what .ots is but let's not use random file extension that make no sense
2023-02-17 13:46:27 +09:00
Dean Herbert
8ef3fb26e0
More constants and assert fixes
2023-02-17 13:46:27 +09:00
Dean Herbert
86d110e893
Simplify test storage by removing nested storage
2023-02-17 13:43:42 +09:00
Dean Herbert
4560ae6b02
Mark test as fixture
2023-02-17 13:39:31 +09:00
Dean Herbert
99236f0ae8
Move long filename to fixture level
2023-02-17 13:39:24 +09:00
Dean Herbert
8c772a723f
Expose constant public
ly rather than reexposing business
2023-02-17 13:34:19 +09:00
Dean Herbert
96b1498932
Rename max length variable to make sense (it's a filename limit, not path)
2023-02-17 13:33:22 +09:00
Dean Herbert
415220a447
Tidy up new test method code quality
2023-02-17 13:30:00 +09:00
Cootz
810712386d
Merge branch 'master' into fix-exporting-a-skin-with-too-long-file-name
2023-02-17 01:51:24 +03:00
Cootz
f4038a49a1
Fix inspectCode issues
2023-02-17 01:50:24 +03:00
Cootz
1d8b348e4c
Improve naming
2023-02-17 01:46:15 +03:00
Cootz
6cb00cd42f
Add more test cases
2023-02-17 01:44:45 +03:00
Bartłomiej Dach
9f9893d93a
Merge pull request #22338 from Pasi4K5/hide-resume-overlay
...
Hide `ResumeOverlay` when `OsuModAutopilot` is enabled
2023-02-16 22:22:19 +01:00
Bartłomiej Dach
66e9bb2581
Merge branch 'master' into hide-resume-overlay
2023-02-16 21:33:23 +01:00
Bartłomiej Dach
bba1722725
Merge pull request #22645 from peppy/adjust-song-select-background-dim
...
Adjust song select background dimming to be more evenly applied
2023-02-16 21:27:27 +01:00
Bartłomiej Dach
b8084a15eb
Revert ResumeOverlay
setter accessibility change
2023-02-16 21:26:01 +01:00
Bartłomiej Dach
0186062246
Merge branch 'master' into adjust-song-select-background-dim
2023-02-16 20:52:36 +01:00
Bartłomiej Dach
ad5132ed41
Remove redundant conditional access qualifier
...
It is impossible for the callback passed to `ApplyToBackground()` to
receive a null reference. See `OsuScreen.ApplyToBackground()` - if the
background to call the callback on were `null`, then an
`InvalidOperationException` would be thrown instead.
2023-02-16 20:47:51 +01:00
Bartłomiej Dach
7d86f49fce
Merge pull request #22658 from peppy/gameplay-sample-trigger-source-test-fix
...
Refactor `GameplaySampleTriggerSource` test to not be realtime dependent
2023-02-16 19:39:18 +01:00
Bartłomiej Dach
5bdc5dfadd
Add one more assert to keep coverage from previous implementation
2023-02-16 19:02:51 +01:00
Cootz
6819a45a1b
Improve code slightly
2023-02-16 16:42:07 +03:00
Cootz
f1da213bea
Add tests
2023-02-16 16:26:57 +03:00
Dean Herbert
cb7df7282b
Apply NRT to SerialisedDrawableInfo
2023-02-16 20:01:59 +09:00
Cootz
3057ccb635
Merge branch 'master' into fix-exporting-a-skin-with-too-long-file-name
2023-02-16 13:22:11 +03:00
Dean Herbert
394d368f16
Fix song select potentially updating background parameters when not the current screen
2023-02-16 18:45:22 +09:00
Dean Herbert
979c079f8b
Refactor GameplaySampleTriggerSource
test to not be realtime dependent
2023-02-16 17:58:44 +09:00
Dean Herbert
9d02a2ef0e
Apply NRT to GamepleSampleTriggerSource
tests
2023-02-16 17:58:44 +09:00
Dean Herbert
ce9ef3bc3c
Always create ResumeOverlay
, with UseResumeOverlay
flag only affecting whether it is displayed or not
2023-02-16 15:47:20 +09:00
Dean Herbert
7afdcb9383
Merge branch 'master' into hide-resume-overlay
2023-02-16 15:42:14 +09:00
Dean Herbert
81dcc105a9
Rename left-over skinnable
naming in SerialisedDrawableExtensions
2023-02-16 15:34:41 +09:00
Dean Herbert
76f7accd13
Standardise all local SkinComponentsContainerLookup
variables to containerLookup
2023-02-16 15:33:56 +09:00
Dean Herbert
eea0cd3cf8
Reword xmldoc on ISerialisableDrawable
to make less skin-centric
2023-02-16 15:31:35 +09:00
Dean Herbert
0b25f7baeb
Reword and fix typos in some new xmldoc
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-02-16 15:27:30 +09:00
Bartłomiej Dach
87901bc8b1
Merge pull request #22292 from ekrctb/maximum-judgement-offset-in-hit-object
...
Move MaximumJudgementOffset to HitObject
2023-02-16 00:52:35 +01:00
Bartłomiej Dach
c315113fde
Merge branch 'master' into maximum-judgement-offset-in-hit-object
2023-02-16 00:15:51 +01:00
Bartłomiej Dach
768eea1ea8
Merge branch 'master' into skinnable-clean-up-documentation
2023-02-15 21:26:11 +01:00