1
0
mirror of https://github.com/ppy/osu.git synced 2024-09-23 06:07:25 +08:00
Commit Graph

53914 Commits

Author SHA1 Message Date
Dean Herbert
8f1e3b0154 Fix editor summary timeline not responding to kiai changes correctly 2022-07-29 19:31:49 +09:00
Dan Balasescu
6703b8df02
Merge pull request #19454 from peppy/filter-control-tests-realm-refresh
Ensure realm is in a good state before asserts in `TestSceneFilterControl`
2022-07-29 17:57:38 +09:00
Dan Balasescu
70420e6238
Merge pull request #19440 from peppy/bypass-local-metadata-cache
Fix beatmap updater potentially using outdated local metadata
2022-07-29 17:33:53 +09:00
Dean Herbert
07e3765b34 Ensure collection is added to dropdown before trying to click it 2022-07-29 17:25:30 +09:00
Dean Herbert
eb92c35335
Merge pull request #19442 from smoogipoo/fix-beginplaying-misordering
Move spectator begin/end playing to SubmittingPlayer
2022-07-29 16:09:50 +09:00
Dean Herbert
cb52b696ed
Merge branch 'master' into bypass-local-metadata-cache 2022-07-29 16:05:54 +09:00
Dean Herbert
2ff6ff06d3 Use tuple to better explain new bool parameter 2022-07-29 16:05:41 +09:00
Dean Herbert
e07e761c10 Ensure realm is in a good state before asserts in TestSceneFilterControl 2022-07-29 15:59:53 +09:00
Dean Herbert
be7a9e1487
Merge pull request #19453 from smoogipoo/multiplayer-test-misordering
Fix potential test failures due to Setup/SetUpSteps ordering
2022-07-29 15:59:51 +09:00
Dan Balasescu
aaa6f963bd Fix potential test failures due to Setup/SetUpSteps ordering 2022-07-29 15:27:39 +09:00
Dan Balasescu
bc685918b6
Merge pull request #19451 from peppy/dont-wait-spectator-frames
Revert blocking call when sending spectator frames
2022-07-29 14:17:57 +09:00
Dean Herbert
fd09155990 Revert blocking call when sending spectator frames
There are a lot of these requests, and we don't really care about
waiting on them to finish sending. This may have negatively affected
send performance for users with very high latency.

Reverts part of 0533249d11.

Addresses concerns in https://github.com/ppy/osu/discussions/19429#discussioncomment-3276400.
2022-07-29 12:24:54 +09:00
Dean Herbert
45879f7836
Merge pull request #19443 from smoogipoo/fix-intermittent-hud-tests
Fix intermittent HUD tests
2022-07-28 23:20:46 +09:00
Dan Balasescu
0d6b45e515
Merge pull request #19431 from peppy/collections-track-beatmap-updates
Add collection transfer logic to beatmap import-as-update flow
2022-07-28 22:52:54 +09:00
Dan Balasescu
a59d7f6710
Merge branch 'master' into collections-track-beatmap-updates 2022-07-28 22:05:34 +09:00
Dan Balasescu
aa03df905f
Merge pull request #19441 from peppy/test-working-beatmap-unfuck
Reduce calls to `LoadTrack` by implicitly running on test/dummy classes
2022-07-28 22:05:25 +09:00
Dan Balasescu
5003eb5629
Merge pull request #19430 from peppy/realm-collections
Move beatmap collections to realm
2022-07-28 22:05:10 +09:00
Dan Balasescu
11e0022fad Merge branch 'master' into realm-collections 2022-07-28 21:00:08 +09:00
Dan Balasescu
ce694123eb Move spectator begin/end playing to SubmittingPlayer 2022-07-28 20:44:04 +09:00
Dean Herbert
a21aee4e9c Reduce calls to LoadTrack by implicitly running on test/dummy classes 2022-07-28 18:11:40 +09:00
Dan Balasescu
1039338d80 Fix intermittent HUD tests 2022-07-28 17:58:07 +09:00
Dean Herbert
628a30193f Remove incorrect TrackLoaded override from TestWorkingBeatmap 2022-07-28 17:49:17 +09:00
Dan Balasescu
1da9830145
Merge pull request #19435 from peppy/remove-beatmap-manager-ruleset-store
Remove unused `RulesetStore` from `BeatmapManager` constructor
2022-07-28 17:46:12 +09:00
Dean Herbert
8cb4fb35e0 Rename parameter to read better (and still use local cache if no online API is available) 2022-07-28 17:08:59 +09:00
Dan Balasescu
6d4023b933 Adjust comment 2022-07-28 16:56:11 +09:00
Dan Balasescu
ebe64422d6
Merge pull request #19433 from peppy/beatmap-model-documentation
Add more comprehensive xmldoc for beatmap model classes
2022-07-28 16:40:29 +09:00
Dan Balasescu
cd01c5d3ac Fix assertion 2022-07-28 16:34:31 +09:00
Dean Herbert
c35da62224 Add flow for bypassing local cache lookups when refreshing beatmap metadata 2022-07-28 16:33:51 +09:00
Dean Herbert
17a3fd30fb Move scheduler from OnlineLookupQueue to BeatmapUpdater 2022-07-28 16:32:22 +09:00
Dan Balasescu
fe6b487d75
Merge pull request #19432 from peppy/fix-update-test-failures
Add realm refresh calls to fix intermittent test failures on new update tests
2022-07-28 16:19:46 +09:00
Dean Herbert
2b9d46d803 Remove unused RulesetStore from BeatmapManager constructor 2022-07-28 16:19:05 +09:00
Dan Balasescu
c1aaf27c54 Link to correct model in xmldoc 2022-07-28 16:02:19 +09:00
Dean Herbert
525e4a2019 Fix crash in DrawableRoomPlaylistItem context menu creation due to incorrect enumeration casting 2022-07-28 15:51:18 +09:00
Dan Balasescu
6bf293e130 Fix managed object reused between test runs 2022-07-28 15:45:33 +09:00
Dean Herbert
452d82f292 Add more comprehensive xmldoc for beatmap model classes 2022-07-28 15:41:28 +09:00
Salman Ahmed
ce48984bda
Merge pull request #19419 from andy840119/remove-nullable-disable-in-the-mods-for-taiko-ruleset
Remove nullable disable annotation in mods for taiko ruleset.
2022-07-28 09:32:35 +03:00
Dean Herbert
8ac886a247 Update test to account for sort order 2022-07-28 15:20:25 +09:00
Dean Herbert
67c44552cb Add realm Refresh calls to ensure tests are stable 2022-07-28 15:18:04 +09:00
Dean Herbert
485d140a21 Add realm refresh calls to fix intermittent test failures on new update tests 2022-07-28 15:15:41 +09:00
Dean Herbert
070f56c30c Add collection transfer logic to beatmap import-as-update flow 2022-07-28 15:03:23 +09:00
Dean Herbert
2209afd0e8 Mark Live methods as InstantHandleAttribute 2022-07-28 15:03:08 +09:00
Dean Herbert
2ae5a34c0e Add test coverage of beatmap updates transferring collection hashes 2022-07-28 15:02:58 +09:00
Salman Ahmed
1f13d89205
Merge branch 'master' into remove-nullable-disable-in-the-mods-for-taiko-ruleset 2022-07-28 09:01:50 +03:00
Salman Ahmed
61bdcab651
Merge pull request #19418 from andy840119/remove-nullable-disable-in-the-mods-for-mania-ruleset
Remove nullable disable annotation in mods for mania ruleset.
2022-07-28 08:57:12 +03:00
Dean Herbert
ca68574473 Make NotificationOverlay dependency optional in CollectionSettings 2022-07-28 14:35:27 +09:00
Salman Ahmed
c74ffea236
Merge branch 'master' into remove-nullable-disable-in-the-mods-for-mania-ruleset 2022-07-28 08:21:23 +03:00
Dean Herbert
392cb352cc Force alphabetical ordering for now 2022-07-28 14:07:42 +09:00
Dean Herbert
da06467891 Add missing realm subscription cleanup 2022-07-28 13:57:21 +09:00
Dean Herbert
ad482b8afc Tidy up naming of collection dropdowns 2022-07-28 13:57:21 +09:00
Dean Herbert
226eefcc5c Add note about hash storage 2022-07-28 13:57:21 +09:00