Dan Balasescu
8dece70097
Merge branch 'master' into updates-outside-of-gameplay-only-2
2024-10-07 17:41:42 +09:00
Dean Herbert
38ee824b12
Add second call of runOutsideGameplay on update progress notification
...
At this point the update is already started in the background but I
guess we can still block the notification from interrupting the user.
2024-10-07 17:07:25 +09:00
Dean Herbert
1f45b2134f
Remove unnecessary runOutsideOfGameplay call
2024-10-07 17:04:52 +09:00
Dean Herbert
a41c6dce04
Fix android build failure due to enum rename
2024-10-07 16:43:50 +09:00
Bartłomiej Dach
cf66d40b00
Merge pull request #30132 from smoogipoo/diffcalc-workflow-new-comment
...
Make diffcalc workflow recreate comment on completion
2024-10-07 09:42:55 +02:00
Dan Balasescu
c7f2564c0a
Make diffcalc workflow recreate comment on completion
2024-10-07 15:50:59 +09:00
Dean Herbert
5c826be652
Merge pull request #29860 from bdach/fix-nudging
...
Only allow seek to next/previous object via keybinding if there is no selection
2024-10-07 15:36:19 +09:00
Bartłomiej Dach
77f32708e0
Merge pull request #29980 from tsunyoku/speed-distance-hotfix
...
Various speed distance difficulty calculation changes
2024-10-07 08:31:52 +02:00
Dan Balasescu
944f8f5f67
Merge pull request #30078 from CloneWith/update/progresshover
...
Add progress tooltip for ArgonSongProgressBar
2024-10-07 15:20:50 +09:00
Dean Herbert
af43b368ea
Merge pull request #30114 from bdach/form-slider-bar-transfer-value-on-commit
...
Fix difficulty settings sliders attempting to reprocess all hitobjects on every instantaneous change
2024-10-07 14:59:48 +09:00
Dan Balasescu
b977a187e5
Merge pull request #30021 from bdach/fix-random-mod-broken-sr
...
Fix broken star rating on Random mod
2024-10-07 14:54:55 +09:00
Dean Herbert
6e4eed657c
Fix weird mouse position handling and don't return true to event
2024-10-07 14:32:31 +09:00
Dean Herbert
b5cc45bdda
Simplify format code (and adjust formatting slightly)
2024-10-07 14:26:42 +09:00
Bartłomiej Dach
1854e1c2f9
Merge branch 'master' into form-slider-bar-transfer-value-on-commit
2024-10-07 07:21:23 +02:00
Bartłomiej Dach
8496005e47
Merge pull request #30088 from stanriders/uncap-od-accuracy
...
Uncap speed OD-accuracy scaling
2024-10-07 07:15:03 +02:00
Dean Herbert
2bcbaed5b8
Update framework
2024-10-07 14:11:31 +09:00
Dean Herbert
5859021003
Merge pull request #30113 from bdach/fix-separator-jank
...
Fix improper handling of decimal separator in "form" number boxes / sliders
2024-10-07 13:42:02 +09:00
Dean Herbert
e64c2d57bb
Merge pull request #30121 from smoogipoo/rollback-ios-workload
...
Rollback iOS workload to last known working version
2024-10-06 22:07:49 +09:00
Dan Balasescu
72ac2eeb1d
Update osu!framework package
2024-10-06 07:54:56 +09:00
Dan Balasescu
232381c9fb
Rollback iOS workload to last known working version
2024-10-05 23:00:04 +09:00
CloneWith
d7ba4ce7f2
Refactor progress tooltip updating method
...
* Rewrite calculating logic
* Remove useless variables
2024-10-04 23:30:50 +08:00
Bartłomiej Dach
94aecae0ce
Fix tests
2024-10-04 14:48:48 +02:00
Bartłomiej Dach
7816c41b94
Only transfer difficulty slider values on commit
...
Closes https://github.com/ppy/osu/issues/30112 .
2024-10-04 14:08:46 +02:00
Bartłomiej Dach
86c3e3e987
Replace FormSliderBar.Instantaneous with TransferValueOnCommit
...
Rather than control the propagation of the value between the slider and
the textbox, add a property that controls the propagation of the value
between the bindables inside the form control to external bindables.
This will help alleviate issues where the external bindable update
incurs overheads due to having heavy change callbacks attached.
2024-10-04 14:07:16 +02:00
Bartłomiej Dach
31aea86eab
Merge pull request #30110 from peppy/new-colour-better-ux
...
When adding a new combo colour, use the last colour as a starting point
2024-10-04 13:19:01 +02:00
Bartłomiej Dach
45a6a743a2
Fix improper handling of decimal separator in "form" number boxes / sliders
...
Spotted in passing in
https://discord.com/channels/188630481301012481/1097318920991559880/1291693852981329981 .
2024-10-04 13:12:25 +02:00
Bartłomiej Dach
96b6780e0c
Merge pull request #30101 from bdach/menu-padding-left
...
Do not add checkbox padding to the left of menu items if no item actually needs it
2024-10-04 12:22:35 +02:00
Dean Herbert
4fc0aae486
Merge pull request #30108 from bdach/default-combo-colours-in-editor
...
Initialise colours section with default combo colours if none present
2024-10-04 18:57:25 +09:00
Dean Herbert
24227b4d02
Merge pull request #30109 from bdach/editor/setup-screen-better-background-selector
...
Move setup screen background preview to appropriate form control
2024-10-04 18:57:15 +09:00
Dean Herbert
ff2777a3b9
When adding a new combo colour, use the last colour as a starting point
...
Also opens the popover automatically because you always want to edit it.
2024-10-04 18:44:33 +09:00
Bartłomiej Dach
e136568a18
Remove linq usage to kill allocations
2024-10-04 11:25:21 +02:00
Bartłomiej Dach
61103cc712
Remove redundant initialiser
2024-10-04 11:18:09 +02:00
Bartłomiej Dach
7cd724f342
Move setup screen background preview to appropriate form control
...
See
https://discord.com/channels/188630481301012481/188630652340404224/1291361342971707463 .
2024-10-04 11:09:14 +02:00
CloneWith
fd5655455a
Adjust tooltip text format
2024-10-04 16:56:16 +08:00
CloneWith
2d7fdaf892
Override OnMouseMove for cursor position fetching
2024-10-04 16:42:48 +08:00
Bartłomiej Dach
6e5a38c6c8
Initialise colours section with default combo colours if none present
...
Closes https://github.com/ppy/osu/issues/30100 .
2024-10-04 10:01:24 +02:00
Bartłomiej Dach
114e53f8b2
Add failing test
2024-10-04 10:00:37 +02:00
Dean Herbert
2914a5b93b
Merge pull request #30099 from bdach/editor/setup-screen
...
Redesign editor setup screen with new "form" controls
2024-10-04 01:32:25 +09:00
Bartłomiej Dach
29418226c0
Do not add checkbox padding to the left of menu items if no item actually needs it
...
RFC. As per
https://discord.com/channels/188630481301012481/188630652340404224/1291346164976980009 .
The diff is extremely dumb but I tried a few smarter methods and they're
either not fully correct or don't work. Primary problem is that menu
items are mutable externally and there's no hook provided by the
framework to know that items changed. One could probably be made but I'd
prefer that this change be examined visually first before I engage in
too much ceremony and start changing framework around.
2024-10-03 15:36:53 +02:00
Bartłomiej Dach
1280d7ea15
Fix tests again
2024-10-03 15:05:15 +02:00
Bartłomiej Dach
1bab2236fe
Ensure columns collapse into one correctly if no space
2024-10-03 15:01:23 +02:00
Bartłomiej Dach
090c8ee602
Make colour palette things circular again
2024-10-03 14:35:03 +02:00
Bartłomiej Dach
2c0a7d4c18
Adjust slider bar padding
...
https://discord.com/channels/188630481301012481/188630652340404224/1291374650256916482
2024-10-03 14:32:46 +02:00
Bartłomiej Dach
99eb26b7d5
Redo the layout of sections based on discord feedback
...
See
https://discord.com/channels/188630481301012481/188630652340404224/1291358770064130140
and everything after.
2024-10-03 13:53:21 +02:00
Bartłomiej Dach
8a650deab6
Fix tests
2024-10-03 13:11:02 +02:00
Bartłomiej Dach
ddfa877b12
Fix code quality
2024-10-03 13:08:04 +02:00
Dean Herbert
0a0e31163b
Merge branch 'master' into editor/setup-screen
2024-10-03 20:05:08 +09:00
Dean Herbert
7f6f9e0de2
Merge pull request #30098 from bdach/editor/setup-screen-palette
...
Implement "form" colour palette control
2024-10-03 19:43:40 +09:00
Dean Herbert
19356d0487
Match corner radius of "new" button
2024-10-03 19:33:48 +09:00
Bartłomiej Dach
a567c6369d
Autoselect contents of "form" number box
2024-10-03 11:49:05 +02:00
