70788 Commits

This Branch

This Branch

All Branches

• Clean up model

  - Properly annotate things as nullable
  - Remove weird passthrough property (more on that later)

  Bartłomiej Dach · 2024-12-16 13:14:21 +09:00
  8d1d026f56
• Fix code quality issues
  Nicholas Chin · 2024-12-15 13:53:33 +08:00
  e2edd9e0d5
• Use Count comparison instead of Any
  Nicholas Chin · 2024-12-14 08:29:32 +08:00
  153e6c0c22
• Fix text anchor for mania tooltip
  Nicholas Chin · 2024-12-13 21:58:23 +08:00
  c0b6e784a5
• Replace switch expression with LocalisableDescription attribute for variant display

  Use existing localisation strings from BeatmapsStrings instead of CommonStrings for consistent localisation handling

  Nicholas Chin · 2024-12-12 22:39:21 +08:00
  a22f3416d6
• Add missing mania tooltip overlay for 4k and 7k
  Nicholas Chin · 2024-12-11 23:15:05 +08:00
  26f15def70
• Merge pull request #31076 from peppy/beatmap-store-interface

  Access beatmap store via abstract base class

  Bartłomiej Dach · 2024-12-11 17:48:32 +09:00
  4e4a99decc
• Merge pull request #30763 from Darius-Wattimena/catch-convert-to-stream

  Add convert to stream functionality for juice streams

  Bartłomiej Dach · 2024-12-11 17:37:44 +09:00
  99f9e2800a
• Merge pull request #31037 from frenzibyte/ios-beatmap-export

  Enable beatmap exports on iOS

  Dean Herbert · 2024-12-11 00:12:56 -08:00
  cc1f94939f
• Merge branch 'master' into ios-beatmap-export
  Dean Herbert · 2024-12-10 23:59:15 -08:00
  2a4f596f90
• Merge pull request #31039 from frenzibyte/ios-temporary-export-storage

  Use temporary storage for file exports on iOS

  Dean Herbert · 2024-12-10 23:53:40 -08:00
  02c52e41bd
• Merge pull request #30877 from peppy/medal-display-fix

  Fix potential issues with medal display

  Dean Herbert · 2024-12-10 23:53:34 -08:00
  8079784e96
• Remove BeatmapCarousel testing backdoor
  Dean Herbert · 2024-12-11 16:28:51 +09:00
  a868c33380
• Access beatmap store via abstract base class

  The intention here is to make things more testable going forward.
  Specifically, to remove the "back-door" entrance into `BeatmapCarousel`
  where `BeatmapSets` can be set by tests and bypas/block realm retrieval.

  Dean Herbert · 2024-12-11 16:28:51 +09:00
  c94b393e30
• Remove no-longer-correct comment
  Dean Herbert · 2024-12-11 16:28:50 +09:00
  bab9b9c937
• Some Carousel classes can be abstract
  Dean Herbert · 2024-12-11 16:28:50 +09:00
  de31a48beb
• Add comments backreferences to copies of duplicated code for future use
  Bartłomiej Dach · 2024-12-11 16:26:11 +09:00
  5a0b732ee3
• Merge branch 'master' into catch-convert-to-stream
  Bartłomiej Dach · 2024-12-11 16:24:45 +09:00
  1f43ad3928
• Merge branch 'master' into medal-display-fix
  Bartłomiej Dach · 2024-12-11 15:52:38 +09:00
  c4374c7315
• Revert unnecessary complexity
  Salman Alshamrani · 2024-12-11 01:03:55 -05:00
  e0aec6f907
• Revert "Update exporter test to use OsuStorage"

  This reverts commit f0f3c53571.

  Salman Alshamrani · 2024-12-11 01:03:20 -05:00
  723883e1f0
• Merge pull request #30860 from frenzibyte/editor-multiple-background-audio-files

  Allow choosing different background/audio files for individual difficulties

  Bartłomiej Dach · 2024-12-11 14:12:58 +09:00
  89e3c551ff
• Merge pull request #31071 from smoogipoo/add-diffcalc-allowed-users
  Dean Herbert · 2024-12-10 18:28:40 -08:00
  842829db7a
• Allow tsunyoku and stanriders to trigger diffcalc spreadsheet generator
  Dan Balasescu · 2024-12-11 09:59:18 +09:00
  315a9dba9b
• Merge pull request #31052 from peppy/fix-hitcircle-lookup-fallback

  Fix lookups of hit circle slider pieces potentially using wrong source skin

  Dan Balasescu · 2024-12-10 23:16:40 +09:00
  86f86fa5d4
• Fix lookups of hit circle slider pieces potentially using wrong source skin

  Addresses https://github.com/ppy/osu/discussions/30927.

  Dean Herbert · 2024-12-10 22:03:07 +09:00
  dae380b7fa
• Merge pull request #31047 from peppy/silly-thing

  Avoid beatmap lookup per bar in logo visualisation

  Salman Alshamrani · 2024-12-10 03:41:44 -05:00
  d8e545e034
• Merge branch 'master' into silly-thing
  Salman Alshamrani · 2024-12-10 03:00:53 -05:00
  e6e79cbd11
• Add note about expensive operation
  Dean Herbert · 2024-12-10 16:45:26 +09:00
  bbaa542d4a
• Rewrite resource changing code to be more legible (to my eye)
  Dean Herbert · 2024-12-10 16:45:26 +09:00
  3cac583754
• Merge pull request #30960 from bdach/bookmarks

  Implement basic bookmark support in editor

  Dean Herbert · 2024-12-09 23:42:04 -08:00
  48bf2fa001
• Use Alt-{Left,Right} as default bindings for bookmark navigation
  Bartłomiej Dach · 2024-12-10 14:59:19 +09:00
  7fcfebf4b4
• Avoid beatmap lookup per bar in logo visualisation

  Just noticed in passing.

  Dean Herbert · 2024-12-10 14:45:36 +09:00
  d69f5fd4cf
• Adjust bad grammar
  Dean Herbert · 2024-12-10 14:35:09 +09:00
  92dfcae6eb
• Merge branch 'master' into editor-multiple-background-audio-files
  Dean Herbert · 2024-12-10 14:19:55 +09:00
  7ec2d91e14
• Merge pull request #31041 from bdach/wtf-wtf-wtf-wtf-wtf-wtf

  Fix top score statistics section total score display being terminally broken

  Dean Herbert · 2024-12-09 19:57:00 -08:00
  197d553238
• Fix top score statistics section total score display being terminally broken

  Closes https://github.com/ppy/osu/issues/31038.
  
  If you don't realise why this does anything, realise this: the drawable
  creation callback runs for every created sprite text in the text flow.
  ANd the created sprite texts are split by whitespace. And Russian /
  Ukrainian / Polish etc. use spaces as thousands separators.
  So on those languages the first encountered part of the score would
  duplicate itself to the remaining parts.
  
  I'm actively convinced it was _more difficult_ to produce what was in
  place in `master` than to do it properly. Why did `TextColumn` even have
  `LocalisableString Text` and `Bindable<string> Current` next to each
  other?????

  Bartłomiej Dach · 2024-12-09 23:51:57 +09:00
  1febed66cf
• Update exporter test to use OsuStorage
  Salman Alshamrani · 2024-12-09 08:26:18 -05:00
  f0f3c53571
• Merge pull request #31035 from frenzibyte/ios-uttype-description

  Add description to osu! file associations in iOS

  Dan Balasescu · 2024-12-09 22:16:42 +09:00
  216e0c768b
• Use temporary storage for exported files on iOS
  Salman Alshamrani · 2024-12-09 08:16:37 -05:00
  0c0dcb1e15
• Enable exporting beatmaps in iOS
  Salman Alshamrani · 2024-12-09 07:47:28 -05:00
  e9868c6318
• Add description to osu! file associations in iOS
  Salman Alshamrani · 2024-12-09 07:02:53 -05:00
  a46070be30
• Merge pull request #30973 from frenzibyte/copy-effect-points

  Preserve effect point specifications when creating blank difficulties

  Dan Balasescu · 2024-12-09 16:13:52 +09:00
  1b8d9370aa
• Merge branch 'master' into bookmarks
  Bartłomiej Dach · 2024-12-07 22:22:04 +09:00
  459533aba6
• Merge pull request #31000 from LittleEndu/release-ipc-name

  Fix IPC not working in release

  Dean Herbert · 2024-12-07 04:37:13 -08:00
  2024.1208.0 eeac8f530f
• Fix IPC not working in release
  Endrik Tombak · 2024-12-07 14:13:14 +02:00
  b04f5ab6e4
• Merge pull request #30956 from peppy/named-pipe

  Fix osu! sometimes not starting when WSL is running in the background

  Dean Herbert · 2024-12-06 18:49:52 -08:00
  3e7005d50f
• Update framework
  Dean Herbert · 2024-12-07 10:46:03 +09:00
  b9f1fef250
• Merge branch 'master' into named-pipe
  Dean Herbert · 2024-12-07 10:42:55 +09:00
  e22f3b7d05
• Merge pull request #30921 from huoyaoyuan/netcore-analyzer

  Set up-to-date .NET code quality analyzers

  Dean Herbert · 2024-12-06 17:29:09 -08:00
  5849a69a86