Dean Herbert
a5081826b7
Handle cancellation at more points during Player initialisation
...
As discussed in discord, this will help avoid null references during
cancellation which can otherwise be quite confusing to debug.
2022-08-09 23:25:19 +09:00
Dean Herbert
d59f4720f1
Merge pull request #19664 from peppy/test-assertions
...
Update multiple tests to use new assert output for easier to understand failures
2022-08-09 23:15:16 +09:00
Dean Herbert
1392395ea0
Merge pull request #19668 from smoogipoo/fix-ended-room-status
...
Fix host room status showing ended after playing
2022-08-09 23:02:38 +09:00
Dan Balasescu
4107049b08
Fix host room status showing ended after playing
2022-08-09 21:43:10 +09:00
Dan Balasescu
41af03dec5
Merge pull request #19597 from frenzibyte/hotfix-multi-spectator-results-screen
...
Fix multi-spectator potentially getting stuck for passed players (hotfix)
2022-08-09 21:11:10 +09:00
Dan Balasescu
2de9e5f40f
Fix test failure
2022-08-09 20:23:45 +09:00
Dean Herbert
551e1cf7ff
Revert ordering and reword comment
2022-08-09 19:26:24 +09:00
Dean Herbert
1270ee9624
Update multiple tests to use new assert output for easier to understand failures
2022-08-09 19:19:54 +09:00
Dean Herbert
940629f2f1
Fix database storing order being changed by previous changes
2022-08-09 18:18:03 +09:00
Dean Herbert
106932b906
Add null check in TestPlayer's disposal code to avoid cascading test failure
2022-08-09 18:15:50 +09:00
Dan Balasescu
efc4a129d9
Merge pull request #19658 from peppy/user-button-better-display
...
Display connecting / failing states on toolbar user display
2022-08-09 17:59:28 +09:00
Dean Herbert
4a312d5658
Use a placeholder user with the correct username during connecting process
...
This allows for various components (like gameplay) to obtain a correct
username even if the API is not yet in a connected state. The most
common case is during startup, where a connection may not have been
established yet, but the user's username was restored from their config
file.
By making the change, local scores will now have the correct username
(although avatar etc. will be missing, which I think it fine) even if
the API is not yet connected. Previously, they would show up as "Guest".
2022-08-09 17:13:09 +09:00
Dean Herbert
f9d0cc3c4e
Change APIAccess.IsLoggedIn to also return true when connecting
...
All usages of this are made with the intention of showing data when an
api is going to eventually become available. In the case of a login
failure, components are also able to display a correct state.
With this change, it makes online components display in a more correct
state during startup or initial logging in phase.
2022-08-09 17:11:44 +09:00
Dean Herbert
beb3d41f0c
Fix unsafe usage of APIAccess.LocalUser in BeatmapListingOverlay
2022-08-09 17:11:44 +09:00
Andrew Hong
ce67820d87
Merge branch 'master' into open-profile-hotkey
2022-08-09 04:10:27 -04:00
Andrew Hong
aee18135a9
Switch to toggle
2022-08-09 04:09:22 -04:00
Dean Herbert
961f5d4acc
Reorganise global bindings section to be easier to find things
2022-08-09 17:08:31 +09:00
Dan Balasescu
d80db2aee7
Merge pull request #19639 from peppy/fix-fps-damping
...
Fix incorrect FPS damping implementation
2022-08-09 17:03:55 +09:00
Dean Herbert
a71c2bbe28
Split overlay toggles into own section in key bindings
...
Things were getting hard to find..
2022-08-09 17:01:38 +09:00
Andrew Hong
6903ce1bcc
Merge branch 'master' into open-profile-hotkey
2022-08-09 03:25:41 -04:00
Andrew Hong
a705c4f5d2
Moved ShowProfile to the bottom of the enum
2022-08-09 03:17:55 -04:00
Andrew Hong
04108a749e
Rename translation key
2022-08-09 03:03:14 -04:00
Dean Herbert
47ca812faf
Merge pull request #19656 from smoogipoo/fix-gameplay-test-rerun
...
Fix gameplay tests crashing when run multiple times
2022-08-09 16:01:39 +09:00
Dean Herbert
32852e5b21
Fix potentially thread-unsafe LocalUser usage
2022-08-09 16:01:04 +09:00
Andrew Hong
ededaed5ef
Remove unused import
2022-08-09 02:58:28 -04:00
Dean Herbert
5d8bd1de28
Share localised strings with expanded display message
2022-08-09 15:57:16 +09:00
Andrew Hong
3473347f35
Lowercase "p"
2022-08-09 02:56:12 -04:00
Dean Herbert
3f8cedff3a
Add tooltips showing current connecting status
2022-08-09 15:51:27 +09:00
Dean Herbert
4da9482a3e
Add ability for loading layer to not block input
2022-08-09 15:51:11 +09:00
Dean Herbert
c35b4ef914
Display connecting / failing states on toolbar user display
2022-08-09 15:51:10 +09:00
Dean Herbert
aa9ced7f04
Add test coverage of ToolbarUserButton
2022-08-09 15:51:10 +09:00
Andrew Hong
f65b7ef058
Add keybind for showing profile
2022-08-09 02:49:53 -04:00
Dean Herbert
c7313ac371
Allow LoadingLayer's spinning circle to scale smaller than before
2022-08-09 15:34:11 +09:00
Dan Balasescu
2f0e80e726
Merge pull request #19642 from peppy/barline-less-present
...
Adjust visuals of osu!mania barlines to be less present
2022-08-09 15:10:01 +09:00
Dan Balasescu
00bdd52cff
Move to TestPlayer and add null check
2022-08-09 15:05:40 +09:00
Dan Balasescu
e79052c8a0
Merge pull request #19651 from bdach/mod-select/mod-preset-buggy-sounds
...
Fix spurious sample playbacks from already-removed mod preset panels
2022-08-09 15:00:47 +09:00
Dan Balasescu
6c671434ec
Fix gameplay tests crashing when run multiple times
2022-08-09 14:41:36 +09:00
Dan Balasescu
a52fa8eb8b
Rename const
2022-08-09 13:20:20 +09:00
Bartłomiej Dach
fbd645f06e
Merge pull request #19638 from peppy/fix-collection-import-notification
...
Fix collection import not showing progress notification
2022-08-08 21:37:53 +02:00
BlauFx
0afa3a5ec8
Fix xml doc
2022-08-08 21:20:09 +02:00
BlauFx
e4879aa450
Add test
2022-08-08 21:12:38 +02:00
Bartłomiej Dach
f74fb3491e
Use alternative implementation of preset panel cleanup
2022-08-08 21:08:54 +02:00
Bartłomiej Dach
e77f47e489
Merge branch 'master' into fix-collection-import-notification
2022-08-08 21:05:48 +02:00
BlauFx
f6e65cf1af
Improve implementation
2022-08-08 20:53:05 +02:00
Bartłomiej Dach
a0a6e1faee
Fix spurious sample playbacks from already-removed panels
2022-08-08 20:30:55 +02:00
Bartłomiej Dach
eba070a0f8
Add weak test coverage of broken audio playback after soft-delete
2022-08-08 20:30:37 +02:00
Dean Herbert
3b79cb6fce
Merge pull request #19640 from peppy/mod-preset-column-task-logic
2022-08-09 03:14:28 +09:00
Bartłomiej Dach
f21a51aa24
Simplify mirror copy of task logic in ModColumn
2022-08-08 19:20:50 +02:00
Bartłomiej Dach
00333fb0d2
Change ?? false test to == true for legibility
2022-08-08 19:19:13 +02:00
its5Q
9f043e725f
Fix CI code quality
2022-08-08 22:06:23 +10:00
