cdwcgt
bc2ca11bb0
move to initialiser
2023-07-30 02:41:45 +09:00
cdwcgt
8a06914438
remove #nullable disable in tournament
2023-07-29 22:25:06 +09:00
Bartłomiej Dach
b7ddb5c946
Remove fallbacks to empty APIBeatmap on population failure
...
Was causing there to be two kinds of missing `TournamentBeatmap`s: one
with missing `Beatmap == null`, and one with `Beatmap == new
APIBeatmap()`. In particular, they would appear differently in UI
(either as "unknown - unknown", or the intensely enigmatic " - ").
2023-07-27 22:33:00 +02:00
Dean Herbert
219ba00fb2
Fix startup tournament population not recovering from null beatmaps
2023-07-25 16:35:00 +09:00
Dean Herbert
b40532dde1
Fix tournament bracket parsing regression
...
Closes #24136 .
Regressed in #24037 .
2023-07-06 17:17:17 +09:00
cdwcgt
1b671b8c6e
Use GetResultSafely()
2023-06-26 00:45:59 +09:00
cdwcgt
14e26d2a85
use BeatmapCache for populate beatmap information
2023-06-25 22:57:39 +09:00
Dean Herbert
540b38dc21
Fix tournament interface save button not usable after changing match progression/round
2023-03-23 14:01:19 +09:00
Dean Herbert
154c258248
Fix TournamentGameBase calling AddInternal
2023-01-20 23:53:30 +09:00
Bartłomiej Dach
bb4d520500
Merge branch 'master' into tournament-always-use-production-endpoint
2023-01-17 19:46:48 +01:00
Bartłomiej Dach
7dbbb7caa2
Merge branch 'master' into tournament-fix-save-changes-on-population
2023-01-17 18:49:08 +01:00
Dean Herbert
74bb44e05d
Fix player rank data not being re-fetched after a tournament's ruleset is changed
2023-01-17 19:00:31 +09:00
Dean Herbert
68636aeaaa
Fix tournament client not saving changes after populating new data
2023-01-17 18:56:15 +09:00
Dean Herbert
26cd70f2bf
Always use production (non-experimental) endpoints for tournament client
2023-01-17 18:46:06 +09:00
Dan Balasescu
7bc8908ca9
Partial everything
2022-11-27 00:00:27 +09:00
Dean Herbert
1e2e0dea74
Ensure seeding results get beatmaps populated if BeatmapIno model is null
2022-11-07 19:04:19 +09:00
Dean Herbert
ef10145d6f
Rename MenuCursorContainer and clean up code
2022-07-26 14:11:52 +09:00
Salman Ahmed
018da74fe8
Replace default with CountryCode.Unknown
2022-07-18 08:54:35 +03:00
Salman Ahmed
100c53f9ef
Country -> CountryCode
2022-07-18 08:40:34 +03:00
Salman Ahmed
b2b2a4adaf
Update tournament migration logic to check for null Country
2022-07-16 05:04:24 +03:00
Dean Herbert
11c8a2c16e
Disable tournament client "save changes" button when there's no changes to save
2022-07-13 17:46:09 +09:00
Bartłomiej Dach
a83c45b50e
Fix compile failures from framework breaking change
2022-06-24 16:07:14 +02:00
Dean Herbert
31a447fda0
Update parameter discards
2022-06-24 21:26:19 +09:00
Dean Herbert
f3c9f9a216
Merge pull request #18751 from frenzibyte/tournament-beatmap
...
Improve tournament beatmap JSON storage using lightweight model
2022-06-18 11:00:26 +09:00
Salman Ahmed
4c47996130
TournamentPlayer -> TournamentUser
2022-06-18 02:33:26 +03:00
Salman Ahmed
60903be566
Standardise naming for online ID
...
Rather than continuing with `ID` or `Id`, this should follow the new
standards and use `OnlineID` instead. Only updating this since it's a
newly introduced class.
2022-06-18 01:48:16 +03:00
Salman Ahmed
9f97d1a7db
Replace tournament beatmap storage type with lightweight model
2022-06-18 01:34:09 +03:00
Salman Ahmed
b977ce7995
Replace tournament player storage type with lightweight model
2022-06-17 21:35:04 +03:00
Dan Balasescu
f8830c6850
Automated #nullable processing
2022-06-17 16:37:17 +09:00
Dean Herbert
afbb1fa750
Fix tournament user stat population potentially using wrong ruleset
...
`OsuGameBase.Ruleset` is bound
[late](7d0470794b/osu.Game.Tournament/TournamentGameBase.cs (L169)https://github.com/ppy/osu/issues/18363 .
2022-05-23 14:07:11 +09:00
Dean Herbert
218642c300
Update unsafe file write usages
2022-05-16 18:05:27 +09:00
Dean Herbert
a06b0a4966
Fix tournament bracket parsing's ruleset refetch logic not working correctly
...
Due to equality being based on `ShortName`, it was feasible that the
re-fetch exited early (in bindable shortcutting logic) causing the
ruleset's `OnlineID` to remain `-1` or something equally wrong.
Resolves issue pointed out at
https://github.com/ppy/osu/discussions/17538#discussioncomment-2471746 .
2022-03-31 18:41:00 +09:00
Dean Herbert
a7a7584d3e
Add test coverage ensuring ruleset ID is correct after bracket read
...
Historically, tournament client may have written incorrect `OnlineID`
values. We wanted to use `ShortName` to re-fetch the ruleset. This test
ensures this flow is working correctly.
2022-03-31 18:39:58 +09:00
Dean Herbert
b5f670cc5b
Add far too many fixes for ruleset non-nullable requirements
2022-01-12 23:24:11 +09:00
Dean Herbert
51251e3204
Fix CI reported warnings
2022-01-12 22:39:00 +09:00
Dean Herbert
5158736839
Avoid saving bracket if parsing failed, at all costs
2021-12-03 16:06:38 +09:00
Dean Herbert
ba05a0a383
Centralise specification of bracket.json filename
2021-12-03 16:04:11 +09:00
Dean Herbert
0ecf5f201c
Rename User to APIUser and move to correct namespace
2021-11-07 11:26:01 +09:00
Dan Balasescu
f9ca7f5df1
Merge pull request #15319 from peppy/beatmap-refactor/tournament
...
Remove all usage of `BeatmapInfo` / `BeatmapSetInfo` from tournament mode
2021-10-28 16:26:06 +09:00
Dean Herbert
a6669a3892
Add mention of why the serialisation happens outside stream usage
2021-10-28 15:04:09 +09:00
Dean Herbert
ef26b0ba8a
Fix serlialisation failure during ladder saving causing all existing file content to be deleted
2021-10-28 15:00:30 +09:00
Dean Herbert
f1499641f3
Rename all usages of APIBeatmap to beatmap in tournament namespace
2021-10-27 18:42:48 +09:00
Dean Herbert
5448b94039
Change repopulation rules to cover the fact that the serisalisation model has changed
...
This also adds a progress display to show how repopulation is going. It
can take a while on a large bracket.
2021-10-27 18:42:48 +09:00
Dean Herbert
35168948fe
Fix PopulateUser not populating immediately when immediate is specified (due to scheduling)
2021-10-27 18:26:44 +09:00
Dean Herbert
3130616300
Update tournament components to use APIBeatmap directly
2021-10-27 18:26:44 +09:00
Dean Herbert
6944151486
Apply batch fixing of built-in types using var
2021-10-27 13:04:41 +09:00
Dean Herbert
7111f58bfe
Fix tournament client silently failing on error during parsing
2021-10-25 16:49:33 +09:00
Dean Herbert
b41fa41c85
Rename APIRequest.Result to Response
2021-10-05 14:28:56 +09:00
Dean Herbert
ec61c3c5ee
Rename all remaining cases
2021-10-03 00:55:29 +09:00
Dean Herbert
77b354bfba
Resolve ruleset from store after loading tournament ladder
2021-07-30 02:12:03 +09:00
