Joseph Madamba
92f94278c1
Fix external links not working on Android
2023-03-04 13:35:34 -08:00
OliBomby
b0cd801405
fix code quality
2023-03-04 19:34:22 +01:00
OliBomby
5146f7c978
using array again in GetSearchableTerms
2023-03-04 16:49:46 +01:00
OliBomby
70a925aab1
added extra early-returns
2023-03-04 16:49:33 +01:00
OliBomby
b90c389ff0
using List instead of Span in GetSearchableTerms
2023-03-04 15:42:35 +01:00
OliBomby
3185418834
Add benchmarks for carousel beatmap filter
2023-03-04 15:14:22 +01:00
Bartłomiej Dach
60cdd3c070
Clear components sidebar unconditionally on every target change
...
Fixes the working layer dropdown lingering after exiting from a
skinnable screen to a non-skinnable one.
2023-03-04 14:10:05 +01:00
Bartłomiej Dach
9d4bb2ecf7
Add failing test coverage for clearing sidebar contents
2023-03-04 14:08:50 +01:00
Bartłomiej Dach
d233f3a3ab
Show non-skinnable screen placeholder at higher level
2023-03-04 13:49:10 +01:00
Bartłomiej Dach
49e298e304
Accept ISerialisableDrawableContainer directly in SkinBlueprintContainer
...
An end result of #22674 is that `SkinBlueprintContainer`s are only ever
created by supplying a `SkinComponentsContainer` to them. However,
`SkinBlueprintContainer` still contained remnants of code that suggested
it was designed to handle cases where more than the drawable supplied to
it contained more than one `ISerialisableDrawableContainer`, or even
zero.
The zero path is totally dead right now (because every
`SkinComponentsContainer` is *by necessity* an
`ISerialisableDrawableContainer`), and the more-than-one path is dead
*for now* (and potentially forever?). Therefore, just hard-couple
`SkinBlueprintContainer` to receive a single target container.
2023-03-04 13:33:21 +01:00
Bartłomiej Dach
2f25fb4083
Move NonSkinnableScreenPlaceholder to outer scope
2023-03-04 13:22:43 +01:00
Bartłomiej Dach
15409b9c15
Fix skin selection not clearing on exit to non-skinnable screen
2023-03-04 13:18:34 +01:00
Bartłomiej Dach
3dd3b5e77a
Add failing test case
2023-03-04 13:17:54 +01:00
tsrk
d5ba5eed88
fix(SkinnableAvatar): init avatar.CornerRadius
2023-03-03 23:47:22 +00:00
OpenSauce04
b4ed2db15e
Removed accidental strong hit in single tap break test
2023-03-03 20:40:30 +00:00
OpenSauce04
41e6956432
Improved single tap strong hit test
2023-03-03 20:38:11 +00:00
Bartłomiej Dach
866987d6e1
Merge pull request #22776 from peppy/fix-mania-upscroll
...
Fix upwards scroll direction not working with recent hold note display changes
2023-03-03 21:37:51 +01:00
OpenSauce04
93fd940164
Added new tests for Taiko Single Tap mod
2023-03-03 20:35:28 +00:00
tsrk
d39b8c7c23
fix(SkinnableAvatar): update outdated interface
2023-03-03 19:35:45 +00:00
EXtremeExploit
edd37a9a7c
cleanup
2023-03-03 16:16:45 -03:00
EXtremeExploit
ada610b907
Revert my changes on tests
2023-03-03 16:15:49 -03:00
EXtremeExploit
e23db62386
Do list group'badges in a nicer way
2023-03-03 16:14:19 -03:00
Ruki
e75aa9138b
Merge branch 'ppy:master' into hud/avatar-thing
2023-03-03 20:03:56 +01:00
OliBomby
91d206e8d2
Optimised GetSearchableTerms
...
Reduced memory allocations to 1
2023-03-03 19:21:50 +01:00
OpenSauce04
50b0fca264
Code formatting
2023-03-03 18:11:29 +00:00
OpenSauce04
4dbe589de2
Fixed Taiko Single Tap test pass condition
2023-03-03 17:22:45 +00:00
OpenSauce04
865f785f50
Fixed an issue where Taiko's Single Tap could allow alternation under very specific circumstances
2023-03-03 17:13:39 +00:00
Cootz
322f3e86ba
Merge branch 'master' into fix-exporting-a-skin-with-too-long-file-name
2023-03-03 20:02:09 +03:00
OpenSauce04
ec95d00313
Added Taiko Single Tap test scene
2023-03-03 16:57:09 +00:00
mk56-spn
3bff415909
Change ResetDialogue text
2023-03-03 15:16:48 +01:00
mk56-spn
2b7111867c
Adjust reversion header text naming.
2023-03-03 15:12:20 +01:00
Dean Herbert
36058b3da2
Fix upwards scroll direction not working with recent hold note display changes
2023-03-03 18:03:06 +09:00
Dean Herbert
a14dede036
Ensure TestBeatmapCarousel.Items only returns actually visible items (and in correct order)
...
Turns out that items could be in an order that isn't the same as how
things look on the carousel, so this change ensures that for testing
purposes they are sorted by Y position.
Also uses the `CarouselItem.Visible` flag to ensure that we don't have
to wait for drawable fade transitions after a filter operation.
2023-03-03 17:18:34 +09:00
Dean Herbert
7a092ea995
Add better coverage and more comments explaining the structure of test setup
2023-03-03 17:18:14 +09:00
Dean Herbert
82293c0c86
Don't filter away results with missing data when using "Date Submitted" or "Date Ranked" sort modes
...
From a user's perspective, changing a sort / order mode shouldn't filter
away results, but we were doing this.
In terms of UX expectations, in stable this kind of scenario would
results in a group being added to the end of son select with "Not
ranked" or "Unknown". I think we should aim to match this eventually.
2023-03-03 16:36:18 +09:00
Dean Herbert
dc669835e2
Show count of visible beatmaps at song select
2023-03-03 15:28:51 +09:00
Dean Herbert
6ff1fb6b1a
Adjust sizing to allow for timing point information now being longer than before
2023-03-02 18:57:54 +09:00
Dean Herbert
29be26b150
Merge pull request #22766 from Joehuu/fix-talking-with-text-overflow
...
Fix "talking with" text overflowing when usernames are too long
2023-03-02 17:04:11 +09:00
Joseph Madamba
af540de69b
Fix "talking with" text overflowing when usernames are too long
2023-03-01 22:10:15 -08:00
Joseph Madamba
bb5791a714
Fix overlay sidebars not scrolling to end due to parent scroll view
2023-03-01 21:41:01 -08:00
Dean Herbert
bd11d5d29a
Merge pull request #22743 from Joehuu/scroll-back-to-previous
...
Add ability to scroll back to previous position after scrolling to top via button on overlays
2023-03-01 22:55:47 +09:00
Dean Herbert
21ebcdf5ed
Merge pull request #22755 from EVAST9919/colour-info-framework
...
Use `ColourInfo.Interpolate(Quad)` where possible
2023-03-01 12:05:54 +09:00
Bartłomiej Dach
24723ca873
Merge pull request #22749 from peppy/rename-setting-source-tests
...
Rename `SettingSource` tests to match attribute name
2023-02-28 20:40:07 +01:00
OpenSauce04
d4bb08a440
Fixed CodeInspector complaining
2023-02-28 18:38:09 +00:00
Andrei Zavatski
31f58a33ac
Use ColourInfo.Interpolate where possible
2023-02-28 18:47:27 +03:00
OpenSauce04
0a76c8ee7f
Further simplified a type check
2023-02-28 15:41:06 +00:00
OpenSauce04
8851da05f1
Merge branch 'taiko-single-tap' of https://github.com/OpenSauce04/osu into taiko-single-tap
2023-02-28 15:37:54 +00:00
OpenSauce04
616f7b3f64
Simplified a type check
2023-02-28 15:37:46 +00:00
OpenSauce
781da032e9
Merge branch 'master' into taiko-single-tap
2023-02-28 15:22:41 +00:00
OpenSauce04
3aa8c81c5d
Added missing mod incompatabilities
2023-02-28 15:20:53 +00:00
