88 Commits

Author	SHA1	Message	Date
Dean Herbert	a2f96ea120	Make random implicitly null to avoid potential incorrect behaviour in randomBool	2022-09-09 17:55:54 +09:00
Dean Herbert	5defb8b471	Merge branch 'master' into enhance-randomisation	2022-09-09 17:53:13 +09:00
Pasi4K5	5106c00a9c	Improve code quality	2022-08-14 19:02:29 +02:00
Pasi4K5	7a41b9f25a	Adjust angle and sectionOffset calculations	2022-08-13 03:11:58 +02:00
Pasi4K5	8c624d3269	Add comments and improve code readability	2022-08-13 00:57:49 +02:00
Pasi4K5	78fe72476d	Adjust parameters	2022-08-13 00:01:40 +02:00
naoei	3e38baca3c	Change ruleset mod description types	2022-08-10 16:09:11 -04:00
Pasi4K5	da7d297d85	Adjust parameters	2022-07-26 19:07:25 +02:00
Pasi4K5	3356742ba2	Adjust angle offset caluclations	2022-06-20 00:05:03 +02:00
Pasi4K5	1bb27cd488	Code optimisation	2022-06-19 23:03:41 +02:00
Pasi4K5	7317b9b909	Remove unused field	2022-06-19 14:59:28 +02:00
Pasi4K5	c6ac60c0b5	Enhance target angle calculation	2022-06-19 13:07:10 +02:00
Dan Balasescu	f8830c6850	Automated #nullable processing	2022-06-17 16:37:17 +09:00
Henry Lin	e205aeff38	Merge branch 'master' into random-mod-slider-rotation	2022-05-26 22:51:34 +08:00
Pasi4K5	d5702e2955	Append incompatible mods to base.IncompatibleMods	2022-04-28 18:29:37 +02:00
Pasi4K5	d6395b14be	Add incompatibilities	2022-04-28 05:15:04 +02:00
Henry Lin	ee65677884	Use height of playfield instead of width when randomizing the first object ... This is the change discussed in #17194. The effect of this change is barely noticeable, but it makes more sense to generate the object within playfield from the start.	2022-04-01 11:57:45 +08:00
Henry Lin	e44db4e726	Revert unintentional behavior change of random mod ... Actually, using OsuPlayfield.BASE_SIZE.Y makes a touch more sense since it is the short side of the playfield, but I guess it is better to preserve replays than to introduce pointless breaking changes.	2022-03-25 15:13:25 +08:00
Henry Lin	3a71d81775	Convert the position modifier to stateless methods	2022-03-10 11:53:03 +08:00
Henry Lin	e8dbed738e	Move OsuHitObjectPositionModifier to Utils/	2022-03-09 21:52:15 +08:00
Henry Lin	6a507ca11b	Rename identifiers to remove references to random mod	2022-03-09 20:52:11 +08:00
Henry Lin	37328f8d24	Extract hit object positioning logic to a separate class ... It is intentional to not rename the identifiers at this point to produce a cleaner diff.	2022-03-09 20:36:31 +08:00
Dan Balasescu	353b251d38	Attempt to merge conditional expression ... Hoping to fix CI error, caused by older R# version.	2022-03-09 17:46:42 +09:00
Dean Herbert	75c6a676b4	Apply nullable to OsuModRandom rather than using jetbrains annotations	2022-03-09 16:58:36 +09:00
Henry Lin	e3cf2c6acd	Merge getAbsoluteAngle into computeRandomisedPosition	2022-03-09 13:27:33 +08:00
Henry Lin	3ced5e7904	Rename Distance to DistanceFromPrevious	2022-03-09 13:09:33 +08:00
Henry Lin	ae1c65c38d	Add xmldoc	2022-03-08 12:07:10 +08:00
Henry Lin	8cfeffc085	Extract a major part of ApplyToBeatmap to a new method	2022-03-08 11:50:30 +08:00
Henry Lin	ded84cab3f	Separate randomisation and object positioning logic	2022-03-08 11:45:16 +08:00
Dean Herbert	6944151486	Apply batch fixing of built-in types using var	2021-10-27 13:04:41 +09:00
Dean Herbert	4314946e10	Reorganise functions to order more logically (hitcircle before slider methods)	2021-07-13 19:37:17 +09:00
Dean Herbert	6b663037e4	Use switch for pattern matching	2021-07-13 19:37:02 +09:00
Bartłomiej Dach	63dedb36de	Rename variable	2021-07-11 16:49:23 +02:00
Bartłomiej Dach	7aecafeecb	Rename constant to reflect its purpose	2021-07-11 16:46:30 +02:00
Henry Lin	c181a724c6	Refactor hit object clamping	2021-07-11 22:01:28 +08:00
Bartłomiej Dach	e10b7867c1	Rewrite method again to hopefully help readability	2021-07-10 12:13:36 +02:00
Henry Lin	eecf4af029	Rename getSliderBoundingBox and add comments	2021-07-05 09:16:01 +08:00
Henry Lin	c69455cfd0	Fixed slider bounding box calculation	2021-07-01 11:20:55 +08:00
Henry Lin	7585f1f790	Move special case handling back to moveSliderIntoPlayfield	2021-07-01 11:03:22 +08:00
Henry Lin	6e1839fcf2	Rename shift_object_count to objects_to_shift_before_slider	2021-07-01 11:03:22 +08:00
Henry Lin	328dcb4d6b	Use Math.Clamp instead of MathHelper.Clamp	2021-07-01 11:03:22 +08:00
Henry Lin	3c1f0452a2	Refactor and rename getMinSliderMargin to getSliderBoundingBox.	2021-07-01 11:03:22 +08:00
Henry Lin	3f185a0622	Fixed an exception when clamping large sliders	2021-06-30 10:35:06 +08:00
Henry Lin	8d1eae7c70	Use IndexInCurrentCombo	2021-06-29 14:25:45 +08:00
Henry Lin	2722565204	Take circle radius into account when clamping to playfield	2021-06-29 13:36:30 +08:00
Henry Lin	0c5777c2c8	Added comments	2021-06-29 12:56:05 +08:00
Henry Lin	96e09605d8	Osu random mod improvements ... - Reduce "jump streams" by increasing maximum jump angle and variance in jump angle - Reduce weird jumps to sliders by shifting hit circles in front of sliders	2021-06-29 12:33:40 +08:00
Henry Lin	26086ca1ef	Rename VectorUtils to OsuHitObjectGenerationUtils	2021-06-25 09:43:14 +08:00
Henry Lin	3fcda83713	Rename VectorHelper to VectorUtils	2021-06-24 22:00:19 +08:00
Henry Lin	2268d7f8a5	Extract utility methods into helper class; Better xmldoc and naming	2021-06-24 13:19:42 +08:00