Dean Herbert
0e228791c0
Remove unnecessary Reset call in MultiSpectatorScreen
2022-08-19 01:39:01 +09:00
Dean Herbert
cc86909633
Increase lenience on TestSceneLeadIn tests
...
I've gone through these in detail and can't find an issue with the
actual flow of things. For whatever reason, the new structure has a
slightly higher delay, likely due to performing less `Seek` calls
(previously a `Seek` was called after the clock start which may have
been making this more accurate on the first `Player.Update`).
I don't think it really matters that this is slightly off, but we'll see
how this plays out.
2022-08-19 01:39:00 +09:00
Bartłomiej Dach
bc851c174b
Merge pull request #19836 from peppy/split-offset-clock
...
Split `OffsetCorrectionClock` out of `MasterGameplayClockContainer`
2022-08-18 18:26:51 +02:00
Bartłomiej Dach
4ad782b5a0
Merge branch 'master' into split-offset-clock
2022-08-18 17:52:45 +02:00
Dean Herbert
0f0b4fdfec
Merge pull request #19838 from peppy/test-scene-lead-in-updates
...
Update `TestSceneLeadIn` to use new assert style
2022-08-18 20:55:55 +09:00
Dean Herbert
2eba8650ca
Update TestSceneLeadIn to use new assert style
2022-08-18 19:26:19 +09:00
Dean Herbert
43879633db
Ensure setting a StartTime on a GameplayClockContainer always resets to the new time
2022-08-18 18:54:10 +09:00
Dean Herbert
343efa1d11
Split OffsetCorrectionClock out of MasterGameplayClockContainer
2022-08-18 18:54:10 +09:00
Dean Herbert
2c6fd1ec6e
Fix `GameplayClockContainer potentially resetting external seeks
2022-08-18 18:54:10 +09:00
Dean Herbert
728cd96508
Update TestSceneLeadIn to use new assert style
2022-08-18 18:54:10 +09:00
Dean Herbert
bcc153f738
Add xmldoc and reorganise FramedBeatmapClock
2022-08-18 18:54:10 +09:00
Dean Herbert
6003afafc7
Use FramedBeatmapClock in GameplayClockContainer
2022-08-18 18:54:10 +09:00
Dean Herbert
32e127a6fa
Add FramedBeatmapClock
...
Expose `IsCoupled` in `FramedBeatmapClock` for now to provide editor compatibility
2022-08-18 18:54:10 +09:00
Dan Balasescu
fa167b1d12
Merge pull request #19779 from peppy/no-gameplay-clock
...
Remove all remaining usage of `GameplayClock`
2022-08-18 18:52:57 +09:00
Dean Herbert
3e34959a6e
Merge pull request #19833 from smoogipoo/fix-backwards-asserts
...
Fix some backwards asserts
2022-08-18 18:42:23 +09:00
Dan Balasescu
5d8d584afb
Fix some backwards asserts
2022-08-18 18:08:46 +09:00
Dan Balasescu
c4dee1cf6d
Merge pull request #19832 from peppy/fix-taiko-span-blueprint-overlay
...
Fix taiko blueprints displaying incorrectly for drum rolls
2022-08-18 17:57:14 +09:00
Dan Balasescu
8480703e0b
Merge pull request #19831 from peppy/fix-zero-length-taiko-spans
...
Fix taiko drum rolls with zero length being placeable in editor
2022-08-18 17:56:46 +09:00
Dean Herbert
ad28bfc9b2
Fix taiko blueprints displaying incorrectly for drum rolls
2022-08-18 17:18:11 +09:00
Dean Herbert
48fac9f8a5
Fix taiko drum rolls with zero length being placeable in editor
...
Addresses https://github.com/ppy/osu/discussions/19808 .
2022-08-18 16:50:36 +09:00
Dean Herbert
8d026eeeea
Merge pull request #19827 from smoogipoo/upgrade-analyser
...
Upgrade LocalisationAnalyser and disable warning
2022-08-18 16:35:34 +09:00
Dean Herbert
bb46f72f9e
Fix Pippidon crash on empty beatmap conversion
2022-08-18 16:17:50 +09:00
Dean Herbert
b0a740071e
Centralise logging of failed ruleset loads
2022-08-18 16:14:38 +09:00
Dean Herbert
e0edaf996f
Test ruleset compatibility during initial startup to avoid runtime errors
...
As we continue to break the ruleset API, it makes more sense to
proactively check known changes and bail early during ruleset loading to
avoid a user experiencing a crash at a random point during execution.
This is a RFC and needs to be tested against known broken rulesets.
There might be some other calls we want to add in addition to the ones
I've listed.
2022-08-18 16:03:38 +09:00
Dan Balasescu
e55b94d412
Also upgrade tools
2022-08-18 15:18:35 +09:00
vun
40b1554fea
Change FindRepetitionInterval to start with one previous encoding
2022-08-18 14:12:03 +08:00
Dan Balasescu
7512c126b7
Upgrade LocalisationAnalyser and disable warning
2022-08-18 15:08:24 +09:00
Dean Herbert
9735728cf6
Reverse conditionals to better define intent in addSourceClockAdjustments
2022-08-18 15:08:09 +09:00
Dan Balasescu
7878231a73
Merge pull request #19817 from peppy/various-test-fixes
...
Refactor some tests
2022-08-18 14:39:43 +09:00
OliBomby
cb6339a20b
added slider splitting option
2022-08-18 01:29:03 +02:00
Bartłomiej Dach
d06959e1dd
Update incorrect xmldoc
2022-08-17 22:03:35 +02:00
Bartłomiej Dach
3d14b14cfe
Use alternative method for checking panel readiness to eliminate bool flag
2022-08-17 21:56:11 +02:00
Dean Herbert
d40d09a544
Rename method to be more specific and standardise setBeatmap calls
2022-08-17 23:03:39 +09:00
Dean Herbert
e7ddbc41c8
Merge branch 'master' into no-gameplay-clock
2022-08-17 22:21:10 +09:00
Dan Balasescu
4627e4f53b
Merge pull request #19120 from molneya/mania-note-order-fix
...
Fix mania star rating varying by order of notes in a chord
2022-08-17 20:39:52 +09:00
Dan Balasescu
11301f52b7
Merge pull request #19814 from peppy/update-framework
...
Update framework (and other dependencies)
2022-08-17 19:24:01 +09:00
Dean Herbert
553ae4781f
Remove unnecessary local implementation in TestScenePlaybackControl
2022-08-17 19:21:54 +09:00
Dean Herbert
7d8fbc4dbc
Refactor TestSceneDrawableTaikoMascot to read a bit better
2022-08-17 19:21:50 +09:00
Dean Herbert
4ef4d66f49
Add some extra initial state checks to TestSceneEditorSeekSnapping
2022-08-17 19:21:46 +09:00
Dan Balasescu
f381bc9115
Add explanatory comment
2022-08-17 19:03:48 +09:00
Dan Balasescu
203b8b22b9
Adjust tests
2022-08-17 19:02:16 +09:00
Dan Balasescu
237637f0c4
Merge pull request #19804 from stanriders/clamp-sb-estimation
...
Clamp effective miss count to maximum amount of possible breaks
2022-08-17 18:58:12 +09:00
Dean Herbert
e1e6be039a
Don't create destination stream if backup source doesn't exist
2022-08-17 18:20:47 +09:00
Dean Herbert
eb9cfe97d2
Merge pull request #19815 from smoogipoo/fix-quick-retry-test
...
Fix flaky quick retry test
2022-08-17 17:43:31 +09:00
Dean Herbert
fca076b988
Fix edge case of realm backup cascading failure
2022-08-17 17:17:22 +09:00
Dean Herbert
243fe56b1d
Realm bump for props
2022-08-17 17:11:17 +09:00
Dan Balasescu
3a0017c87b
Fix flaky quick retry test
2022-08-17 17:09:44 +09:00
Dean Herbert
a5ac69a554
Update various dependencies
2022-08-17 16:57:56 +09:00
Dean Herbert
7191fbb6d6
Update framework
2022-08-17 16:40:07 +09:00
Dean Herbert
c3b3733307
Merge pull request #19782 from OliBomby/slider-merger
...
Add ability to merge hit objects in osu! editor to create sliders
2022-08-17 15:52:16 +09:00
