1
0
mirror of https://github.com/ppy/osu.git synced 2026-06-04 04:53:38 +08:00

Merge pull request #19804 from stanriders/clamp-sb-estimation

Clamp effective miss count to maximum amount of possible breaks
This commit is contained in:
Dan Balasescu
2022-08-17 18:58:12 +09:00
committed by GitHub
Unverified
@@ -270,8 +270,8 @@ namespace osu.Game.Rulesets.Osu.Difficulty
comboBasedMissCount = fullComboThreshold / Math.Max(1.0, scoreMaxCombo);
}
// Clamp miss count since it's derived from combo and can be higher than total hits and that breaks some calculations
comboBasedMissCount = Math.Min(comboBasedMissCount, totalHits);
// Clamp miss count to maximum amount of possible breaks
comboBasedMissCount = Math.Min(comboBasedMissCount, countOk + countMeh + countMiss);
return Math.Max(countMiss, comboBasedMissCount);
}