82 Commits

• Adjust multiplayer logic to accommodate for referees spectating in-game (#37152)

  - Last part of / closes
  https://github.com/ppy/osu-server-spectator/issues/406.
  - Remaining work on slots will be tracked in
  https://github.com/ppy/osu-server-spectator/issues/405.
  
  This PR is a corollary of
  https://github.com/ppy/osu-server-spectator/pull/453 and all of the
  dispensations referee users in a multiplayer have received therein. The
  goal here is to allow access to all relevant room management functions
  even if the referee in question isn't host, as well as to disallow
  access to all non-relevant functions to do with the actual match
  gameplay.
  
  I'm not going to lie, this logic *is* ugly. I would argue that it
  already *was* ugly on `master` and my goal was to operate with as light
  a touch as possible myself. But you could see this as copping out and
  that I should try to refactor some of this. I will try - but only after
  someone else's seen the initial approach and deemed it unsuitable.
  
  The logic in `MatchStartControl` is awful - there are so many moving
  pieces of state that dictate what can happen when with all the buttons,
  and yes, I am making it worse here.
  
  This time there is some test coverage. Not everything is covered, but
  the coverage should be on par in all components and pieces of relevant
  logic I touched that already had tests covering them. On that note,
  please forgive the diffstat size, but the tests *are* most of that size.
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Bartłomiej Dach · 2026-04-03 19:38:44 +09:00
  31c1168d76
• Various tournament-minded improvements for multiplayer (#37000)

  https://github.com/user-attachments/assets/042311f1-b8c3-479b-a173-13b93fe2c5cc
  
  - `/roll` command is now supported in multiplayer chat for all players
  (don't need to be a referee).
  - Referees are shown in the room with a special status.
  - Tournament mode rooms can be locked, which prevents users from
  changing team (and slot, whenever those get brought back). When the room
  is locked, the user team indicator shows a padlock icon on top to
  indicate the lock state.
  
  ---
  
  - Related: https://github.com/ppy/osu-server-spectator/issues/406
  
  Grab-bag because I really don't think splitting this into 3 PRs is very
  helpful.
  
  I was going to add an animation for rolling but I had a go on Friday and
  my attempt got more or less the same reception as a wet fart so I'm not
  trying again. Someone else can if so inclined. I have completely lost
  trust in my design senses.
  
  Contrary to stable the roll results are completely ephemeral and go away
  when the room is re-entered. This could be both considered good and bad.
  Not for me to say.

  Bartłomiej Dach · 2026-03-20 18:56:45 +09:00
  43c53b5a8d
• Fix test scene leaks through RealmRulesetStore/RealmAccess
  Dan Balasescu · 2025-10-09 15:28:15 +09:00
  79c367d208
• Add failing tests
  Dan Balasescu · 2025-07-14 17:57:41 +09:00
  e36c590315
• Fix tests
  Dean Herbert · 2025-06-20 20:37:58 +09:00
  3af0ce7e5e
• Fix intermittent online play mod select tests
  Dan Balasescu · 2025-06-09 23:15:48 +09:00
  55a3ec5026
• Add failing test
  Dan Balasescu · 2025-04-23 16:04:38 +09:00
  eafb52ffb4
• Add failing countdown start test
  Dan Balasescu · 2025-04-08 18:35:22 +09:00
  968fe6e618
• Rewrite match subscreen to use full online state
  Dan Balasescu · 2025-04-04 10:48:55 +09:00
  286b3d9f5b
• Add failing test
  Dan Balasescu · 2025-04-02 19:58:31 +09:00
  56169d7ac4
• Fix code quality issue
  Dan Balasescu · 2025-03-19 15:50:39 +09:00
  54b079098b
• Add playlists/multiplayer versions of RoomPanel
  Dan Balasescu · 2025-03-19 15:28:50 +09:00
  ec0f8142c2
• Rename DrawableRoom -> RoomPanel
  Dan Balasescu · 2025-03-19 15:24:51 +09:00
  36e78119ae
• Update recently-added test
  Dan Balasescu · 2025-03-04 17:01:41 +09:00
  b19c2c7f9f
• Merge branch 'master' into remove-selectedroom
  Dan Balasescu · 2025-03-04 17:00:43 +09:00
  cf3664349d
• Add failing test
  Dan Balasescu · 2025-02-28 15:51:54 +09:00
  306b30cb12
• Remove SelectedRoom abstraction from OnlinePlayTestScene
  Dan Balasescu · 2025-02-12 22:55:19 +09:00
  205d6ecffb
• Fix test
  Dan Balasescu · 2024-12-25 16:51:50 +09:00
  95fe8d67e4
• Enable NRT for multiplayer and playlists
  Dan Balasescu · 2024-11-21 20:32:09 +09:00
  6870c99eb2
• Remove MultiplayerMatchSubScreen flaky test attribute

  Didn't really work to fix these tests due to the sticky nature of the
  failure. Also I can no longer reproduce locally, so the hope is that
  these are fixed by https://github.com/ppy/osu/pull/30634.

  Dean Herbert · 2024-11-20 17:11:49 +09:00
  c6d08daee8
• Make Room.Playlist non-bindable
  Dan Balasescu · 2024-11-15 15:51:01 +09:00
  34c0f72dd6
• Make Room.Name non-bindable
  Dan Balasescu · 2024-11-15 14:29:15 +09:00
  6160df1586
• Switch multiplayer away from using UserLookupCache

  After switching `UserLookupCache` to `GET /users/lookup` from `GET
  /users`, multiplayer sort of breaks, since the former endpoint does not
  return `ruleset_statistics`, which are used in multiplayer to show
  users' ranks. Therefore, switch multiplayer to use the appropriate
  request type directly.

  Bartłomiej Dach · 2024-10-08 14:46:50 +02:00
  5104f3e7ac
• Add screen footer to ScreenTestScene
  Salman Ahmed · 2024-07-11 15:30:07 +03:00
  7a5624fd0e
• Extract user mod select button for reuse
  Bartłomiej Dach · 2024-06-10 12:45:27 +02:00
  dd6e9308b3
• Improve test coverage
  Salman Ahmed · 2024-02-26 22:30:09 +03:00
  2151e0a294
• Add test coverage
  Salman Ahmed · 2024-02-23 18:16:44 +03:00
  c1db9d7819
• Rename IsValid to Visible
  Cootz · 2023-06-02 11:33:38 +03:00
  4c7cca101e
• Fix testing
  Cootz · 2023-05-06 11:09:44 +03:00
  a226caff56
• Update testing
  Cootz · 2023-05-03 13:12:11 +03:00
  f0d35eb12b
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Fix failing tests
  Salman Ahmed · 2022-07-30 11:49:33 +03:00
  8ca8484f0e
• Fix potential test failures due to Setup/SetUpSteps ordering
  Dan Balasescu · 2022-07-29 15:27:39 +09:00
  aaa6f963bd
• Remove unused RulesetStore from BeatmapManager constructor
  Dean Herbert · 2022-07-28 16:19:05 +09:00
  2b9d46d803
• Merge pull request #18965 from peppy/mark-flaky-tests

  Mark, document and silence remaining flaky tests on standard CI runs

  Dan Balasescu · 2022-07-03 21:41:14 +09:00
  385bd5a1b2
• Merge pull request #18969 from smoogipoo/fix-multiplayer-cross-pollution

  Fix cross-pollution of server- and client-side multiplayer objects in tests

  Dean Herbert · 2022-07-02 13:18:35 +09:00
  2cc9c579d4
• More test hardening around ClientAPIRoom usages
  Dan Balasescu · 2022-07-01 19:49:27 +09:00
  93c68e4329
• Isolate client's Room from TestMultiplayerClient
  Dan Balasescu · 2022-07-01 19:23:25 +09:00
  b64c0d011c
• Rename APIRoom -> ClientAPIRoom, remove unused asserts
  Dan Balasescu · 2022-07-01 19:21:59 +09:00
  0be858b5bf
• Remove one flaky test description (fixed via #18966)
  Dean Herbert · 2022-07-01 16:55:47 +09:00
  8f8c2a8c9a
• Apply PR reviews/fixes
  Dan Balasescu · 2022-07-01 16:51:15 +09:00
  58c9bb031f
• Fix test sometimes referencing old ModSelect object
  Dan Balasescu · 2022-07-01 16:46:27 +09:00
  c22e77e481
• Mark and document remaining flaky tests
  Dean Herbert · 2022-07-01 16:17:40 +09:00
  b597843579
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Adjust test slightly

  * Import `osuTK.Input` instead of using full qualified name
  * Use some more straightforward assertions

  Bartłomiej Dach · 2022-05-22 19:27:20 +02:00
  0bef2ca752
• Test coverage + no virtual
  maromalo · 2022-05-21 18:16:29 -03:00
  fc25d248ad
• Rename ModSelect{Screen -> Overlay} in place of removed old design
  Bartłomiej Dach · 2022-05-10 22:56:50 +02:00
  76c63f1d0a
• Fix next queued item not selecting after gameplay
  Dan Balasescu · 2022-05-09 17:55:42 +09:00
  a16f2349aa
• Replace references to old mod select classes in multiplayer match screen test
  Bartłomiej Dach · 2022-05-05 22:16:57 +02:00
  d296f78dfe
• Merge branch 'master' into beatmap-decoder-ruleset-store
  Dean Herbert · 2022-02-18 16:52:33 +09:00
  631c23ea3a