3320 Commits

• Re-fetch status of any beatmaps stuck in qualified status

  Best we do this rather than leaving it up to users to fix their broken
  beatmaps.
  
  https://github.com/ppy/osu/discussions/32406
  https://github.com/ppy/osu/discussions/32431

  Dean Herbert · 2025-03-19 14:35:43 +09:00
  76f286a01b
• Fix tests
  Bartłomiej Dach · 2025-03-18 14:18:00 +01:00
  efe1416aa3
• Fix editor crashing if beatmap does not have a mode explicitly specified in the .osu

  Closes https://github.com/ppy/osu/issues/32440.
  
  Probably another "regression" from
  https://github.com/ppy/osu/pull/32315.
  
  Trying very hard not to type out any hyperbolic rants here.

  Bartłomiej Dach · 2025-03-18 12:05:36 +01:00
  87a8281b29
• Move BeatmapVersion from BeatmapInfo to IBeatmap

  Closes https://github.com/ppy/osu/issues/32420.
  
  The failure cause here is that in editor the beatmap version for the
  beatmap affected (or... any beatmap, really), is 0 (ZERO). That is
  probably a regression from https://github.com/ppy/osu/pull/32315, but
  like... can we universally agree that calling that change "a regression"
  in any capacity is dumb? Like what was that code *doing* playing dumb
  reference games and copying stuff into an arbitrary instance that could
  get or not get used later on? And now you have a 50/50 chance of
  accessing the *correct* model's field, depending on whether you go via
  `BeatmapInfo` or `Beatmap.BeatmapInfo`?
  
  Moving the field to `IBeatmap`, i.e. what is by now - by consensus,
  since https://github.com/ppy/osu/pull/28473 - supposed to be the "decoded
  and materialised" beatmap, fixes this issue.
  
  I probably should have done this as part of
  https://github.com/ppy/osu/pull/28473 but it slipped my mind. Probably
  for the better too because this change has rather large chances of
  breaking stuff so maybe better to examine it in isolation (via diffcalc
  runs or whatever).
  
  For added humour points, you'd say that the field on `BeatmapInfo` was
  not `[Ignore]`d, so this is a realm schema change, right? No. As far as
  I can tell, it's not. I opened realm studio and `BeatmapVersion` *is not
  a listed column` on `Beatmap` models.
  
  I'm also not gonna get into the fact that I think `EditorBeatmap` doing
  dumb games with juggling two `BeatmapInfo` references since
  https://github.com/ppy/osu/pull/15075 is bad, because I don't think I
  have the mental capacity to hotfix this by going down that train of
  thought.

  Bartłomiej Dach · 2025-03-17 15:04:48 +01:00
  91f3be5fea
• Use reference check rather than Guid comparison
  Dean Herbert · 2025-03-12 17:18:30 +09:00
  16afd5f117
• Fix default beatmap not being correctly set after aborting new beatmap creation

  Closes https://github.com/ppy/osu/issues/32337.

  Dean Herbert · 2025-03-12 14:01:11 +09:00
  65cdcb4696
• Merge pull request #32221 from bdach/user-tags-visual

  Add visual component for assigning user tags to beatmaps

  Dean Herbert · 2025-03-12 11:37:47 +09:00
  ad04b5b1af
• Merge pull request #32329 from peppy/local-cache-nuke

  Ensure qualified beatmaps are never looked up on stale cache source

  Bartłomiej Dach · 2025-03-11 11:16:13 +01:00
  a2966d93cc
• Add brackets to ensure correct lookups

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2025-03-11 18:17:18 +09:00
  914a230446
• Add basic helper method to update beatmap statistics
  Dean Herbert · 2025-03-11 17:03:06 +09:00
  be5c89c2e4
• Ensure only ranked/approved/loved lookups occur on local cached source
  Dean Herbert · 2025-03-11 16:37:46 +09:00
  8d83dfede7
• Remove previous version of local cache lookup handling
  Dean Herbert · 2025-03-11 16:29:47 +09:00
  5ef2479e24
• Apply more granular copying from database when retrieving working beatmap
  Bartłomiej Dach · 2025-03-10 13:06:50 +01:00
  afad2cf278
• Merge branch 'master' into user-tags-visual
  Dean Herbert · 2025-03-08 22:07:47 +09:00
  5359455c23
• Add UI for assigning custom tags to beatmaps

  Visual part for https://github.com/ppy/osu/issues/31913. Opening
  separately for appropriate visual UI adjustments.
  
  Also mostly ready to be hooked up to the results screen, pending merge
  of https://github.com/ppy/osu-web/pull/11951.

  Bartłomiej Dach · 2025-03-04 13:08:02 +01:00
  c051ff84d2
• Merge pull request #32098 from bdach/dont-drop-green-line-sample-bank

  Attempt to preserve sample control point bank when encoding beatmap

  Dean Herbert · 2025-03-04 18:32:16 +09:00
  d9162daac2
• Fix drain length calculation helper method being able to return negative durations

  This is the principal failure behind
  https://github.com/ppy/osu-server-beatmap-submission/issues/40.

  Bartłomiej Dach · 2025-03-03 09:35:46 +01:00
  87fb8da351
• Fix status pills displaying wrong
  Dean Herbert · 2025-02-28 16:47:57 +09:00
  0e257038e8
• Limit beatmap encoder & decoder to at most 8 combo colours
  Bartłomiej Dach · 2025-02-26 11:13:57 +01:00
  2167c7b8d5
• Attempt to preserve sample control point bank when encoding beatmap

  This was reported internally in
  https://discord.com/channels/90072389919997952/1259818301517725707/1343470899357024286.
  The issue described was that sample specifications on control points in
  stable disappeared after the beatmap was updated from lazer.
  
  The reason why the sample specifications were getting dropped is that
  they got lost in the logic that attempts to translate per-hitobject
  samples that lazer has back into stable "green line" type control
  points. That process only attempted to preserve volume and custom sample
  bank, but did not keep the standard bank - likely because it's kind of
  superfluous information *for correct sample playback of the objects*, as
  the samples get encoded again for each object individually. However
  dropping this information makes for a subpar editing experience.
  
  The choice of which sample to pick the bank from is sort of arbitrary
  and I'm not sure if there's a correct one to pick. Intuitively picking
  the normal sample's bank (if there is one) seems most correct.

  Bartłomiej Dach · 2025-02-25 15:39:35 +01:00
  65a62d5440
• Merge branch 'master' into carousel-v2-implement-designs
  Dean Herbert · 2025-02-18 15:49:34 +09:00
  40cae4f0a5
• Changed the Currently Playing Text when no track is selected

  Changed the currently playing text for when the track isnt selected/loaded

  SebastianPeP · 2025-02-09 01:29:22 -03:00
  bcd4fcbeed
• Merge branch 'master' into carousel-v2-implement-designs
  Dean Herbert · 2025-02-07 19:37:06 +09:00
  d8f3dbf988
• Simplify naming of endpoints
  Dean Herbert · 2025-02-07 17:33:32 +09:00
  41c8f64806
• Implement beatmap set header design
  Salman Alshamrani · 2025-02-05 08:16:41 -05:00
  206b5c93c0
• Expose EndpointConfiguration directly in IAPIAccess
  Bartłomiej Dach · 2025-02-05 13:31:37 +01:00
  7d299bb2ad
• Merge pull request #31734 from bdach/simplify-slider-encoding-logic

  Fix multi-segment-type sliders getting mangled on legacy export

  Dean Herbert · 2025-02-04 15:08:44 +09:00
  1e1fb5476e
• Avoid accessing WorkingBeatmap.Beatmap every update call

  Notice in passing.
  
  Comes with overheads that can be easily avoided. Left a note for a
  future (slightly more involved) optimisation.

  Dean Herbert · 2025-02-03 16:30:31 +09:00
  a23de0b188
• Do not reset online info on beatmap save
  Bartłomiej Dach · 2025-01-31 12:21:42 +01:00
  c3981f1097
• Move implicit slider path segment handling logic to Bezier converter

  The logic in `LegacyBeatmapEncoder` that was supposed to handle
  the lazer-exclusive feature of supporting multiple slider segment types
  in a single slider was interfering rather badly with the Bezier
  converter. Generally it was a bit difficult to follow, too.
  
  The nice thing about `BezierConverter` is that it is *guaranteed* to
  only output Bezier control points. In light of this, the same double-up-
  -the-control-point logic that was supposed to make multiple slider
  segment types backwards-compatible with stable can be placed in
  the Bezier conversion logic, and be *much* more understandable, too.

  Bartłomiej Dach · 2025-01-30 14:03:51 +01:00
  749704344c
• Add inline comments for sets that are not marked FA but should be
  Bartłomiej Dach · 2025-01-27 09:40:53 +01:00
  e24af4b341
• Remove explicit beatmap set from list of bundled beatmap sets
  Bartłomiej Dach · 2025-01-27 09:40:20 +01:00
  836a9e5c25
• Adjust code again to avoid weird throw mishandling
  Dean Herbert · 2025-01-22 18:24:01 +09:00
  6ceb348cf6
• Adjust code style slightly
  Dean Herbert · 2025-01-22 17:03:01 +09:00
  910c0022e3
• Refetch local metadata cache if corruption is detected

  Addresses one of the points in https://github.com/ppy/osu/issues/31496.
  
  Not going to lie, this is mostly best-effort stuff (while the refetch is
  happening, metadata lookups using the local source *will* fail), but I
  see this as a marginal scenario anyways.

  Bartłomiej Dach · 2025-01-14 11:20:52 +01:00
  b0c0c98c5d
• Constrain range of usable characters in romanised metadata to ASCII only

  Closes https://github.com/ppy/osu/issues/31398.
  
  Rationale given in issue.
  
  Compare stable logic:
  
  - https://github.com/peppy/osu-stable-reference/blob/2280c4c436f80d04f9c79d3c905db00ac2902273/osu!/GameModes/Edit/Forms/SongSetup.cs#L118-L122
  - https://github.com/peppy/osu-stable-reference/blob/2280c4c436f80d04f9c79d3c905db00ac2902273/osu!common/Helpers/GeneralHelper.cs#L410-L423
  
  The control character check is a bit gratuitous (text boxes will already
  not allow insertion of those, see
  https://github.com/ppy/osu-framework/blob/e05cb86ff64abd343de49a143ada9734fd160a0a/osu.Framework/Graphics/UserInterface/TextBox.cs#L92),
  but as it's a general helper I figured might as well.

  Bartłomiej Dach · 2025-01-06 14:04:47 +01:00
  3a4497af32
• Merge pull request #31138 from bdach/mark-as-played

  Implement ability to mark beatmap as played

  Dean Herbert · 2024-12-24 21:43:15 +09:00
  62e536baf6
• Merge pull request #30984 from smoogipoo/fix-mania-spinner-conversion

  Fix "spinner" conversion for mania-specific beatmaps

  Bartłomiej Dach · 2024-12-19 15:30:10 +01:00
  1057aa867f
• Implement ability to mark beatmap as played

  Reported at https://osu.ppy.sh/community/forums/topics/2015478?n=1.
  
  Would you believe it that this button that has been there for literal
  years never did anything?
  
  Implemented at a per-beatmap level. Also additionally added to context
  menu (at @peppy's suggestion), and also copy reworded from "Delete from
  unplayed" to "Mark as played" because double negation hurt my tiny
  brain.

  Bartłomiej Dach · 2024-12-16 10:49:19 +09:00
  a6e00d6eac
• Merge branch 'master' into recommended-diff-beatmap-listing
  Dan Balasescu · 2024-12-13 16:38:07 +09:00
  62a1a5883a
• Update recommended difficulty for osu!taiko
  Joseph Madamba · 2024-12-12 16:17:57 -08:00
  38b3d5fc00
• Add test and null protections
  Joseph Madamba · 2024-12-12 15:23:00 -08:00
  f7364de01a
• Add recommended difficulty numerical value near filter in beatmap listing
  Joseph Madamba · 2024-12-12 15:23:00 -08:00
  92e07b4f99
• Add FormatStarRating() method util
  Joseph Madamba · 2024-12-12 15:23:00 -08:00
  e95dc2b308
• Apply NRT to incoming changed files
  Joseph Madamba · 2024-12-12 15:22:58 -08:00
  3035e8435d
• Merge pull request #30860 from frenzibyte/editor-multiple-background-audio-files

  Allow choosing different background/audio files for individual difficulties

  Bartłomiej Dach · 2024-12-11 14:12:58 +09:00
  89e3c551ff
• Merge pull request #30960 from bdach/bookmarks

  Implement basic bookmark support in editor

  Dean Herbert · 2024-12-09 23:42:04 -08:00
  48bf2fa001
• Adjust bad grammar
  Dean Herbert · 2024-12-10 14:35:09 +09:00
  92dfcae6eb
• Merge pull request #30973 from frenzibyte/copy-effect-points

  Preserve effect point specifications when creating blank difficulties

  Dan Balasescu · 2024-12-09 16:13:52 +09:00
  1b8d9370aa
• Fix reference effect point getting mutated
  Salman Alshamrani · 2024-12-06 05:47:41 -05:00
  5cb6b86b1c