39 Commits

• Use safer fix for now
  Bartłomiej Dach · 2023-12-19 17:25:15 +01:00
  3f41c20ac6
• Roll back incorrect change in ShouldMigrateToNewStandardised()
  Bartłomiej Dach · 2023-12-19 08:13:02 +01:00
  ddb67c87a8
• Run score conversion for previously-imported scores
  Bartłomiej Dach · 2023-12-18 22:27:51 +01:00
  9c8df4e6d1
• Fix osu! standardised score conversion sometimes exceeding bounds

  Co-authored-by: Zyf <zyfarok@gmail.com>
  
  Closes https://github.com/ppy/osu/issues/25860
  
  Users reported that some stable scores would convert to large negative
  total scores in lazer after the introduction of combo exponent. Those
  large negative total scores were actually mangled NaNs.
  
  The root cause of this was the following calculation going below zero
  unexpectedly:
  
  	https://github.com/ppy/osu/blob/8e8d9b2cd96be4c4b3d8f1f01dc013fc9d41f765/osu.Game/Database/StandardisedScoreMigrationTools.cs#L323
  
  which then propagates negative numbers onward until
  
  	https://github.com/ppy/osu/blob/8e8d9b2cd96be4c4b3d8f1f01dc013fc9d41f765/osu.Game/Database/StandardisedScoreMigrationTools.cs#L337
  
  which yields a NaN due to attempting to take the square root of a
  negative number.
  
  To fix, clamp `comboPortionInScoreV1` to sane limits: to
  `comboPortionFromLongestComboInScoreV1` from below, and to
  `maximumAchievableComboPortionInScoreV1` from above. This is a less
  direct fix than perhaps imagined, but it seems like a better one as it
  will also affect the calculation of both the lower and the upper
  estimate of the score.

  Bartłomiej Dach · 2023-12-18 22:05:19 +01:00
  017003deea
• Account for legacyAccScore in score conversion
  Zyf · 2023-11-24 23:07:27 +01:00
  71e5654b64
• Fix scoring-conversion when miss-count is 0
  Zyf · 2023-11-24 22:05:24 +01:00
  27f9dfccc4
• Rename and comment everything in score migration code

  Hopefully, _hopefully_, makes all this a little bit less inscrutable.

  Bartłomiej Dach · 2023-11-24 10:34:13 +09:00
  7590bae445
• Scoring conversion: remove mention of v3 + improve comments
  Clément Burgelin (Zyfarok) · 2023-11-21 14:26:07 +01:00
  901e45b6a4
• Fix: update score migration of special case to match the new score

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Clément Burgelin (Zyf) · 2023-11-21 11:27:03 +01:00
  16acec335f
• Fix syntax
  Clément Burgelin (Zyfarok) · 2023-11-20 03:05:46 +01:00
  1f88658bad
• Scoring : change formula parameters to match survey results
  Zyf · 2023-11-20 00:02:58 +01:00
  432b88674b
• Merge remote-tracking branch 'upstream/master' into scorev3
  Zyf · 2023-11-19 23:53:05 +01:00
  cadd9b4ace
• Update score conversion to consider legacy multiplier
  Dan Balasescu · 2023-10-02 16:56:15 +09:00
  b9ab4a2b7c
• Fix overflow
  Dan Balasescu · 2023-09-08 00:27:01 +09:00
  4198e025fa
• Split legacy scoring attributes into a separate object
  Dan Balasescu · 2023-09-07 21:10:38 +09:00
  2334be1987
• Move combo exponent to shared constant
  Dean Herbert · 2023-08-24 14:55:44 +09:00
  5ddb10281b
• Bump version to allow migration to re-run
  Dean Herbert · 2023-08-22 16:13:01 +09:00
  5dee43815c
• Merge branch 'master' into scorev3
  Dean Herbert · 2023-08-22 15:52:22 +09:00
  4e9e084b2c
• Scoring : Implement v1 to v3 conversion.
  Zyf · 2023-07-15 23:20:49 +02:00
  b672b49e02
• Ensure migration is never run on scores with new-enough TotalScoreVersions
  Dean Herbert · 2023-07-14 20:02:25 +09:00
  480259b8d2
• Split helper method for populations from replay
  Bartłomiej Dach · 2023-07-10 21:10:01 +02:00
  9e4ffc8c12
• Do not run legacy conversion with ScoreV2 mod present
  Bartłomiej Dach · 2023-07-09 17:48:25 +02:00
  e12255bbe5
• Count missing beatmaps as errored items
  Dean Herbert · 2023-07-04 18:35:03 +09:00
  dd9998127e
• ILegacyScoreProcessor -> ILegacyScoreSimulator
  Dean Herbert · 2023-07-04 17:32:54 +09:00
  1629024111
• Remove unnecessary null check
  Dean Herbert · 2023-07-04 14:19:25 +09:00
  67650831bd
• Move Ruleset method to ILegacyRuleset interface
  Dan Balasescu · 2023-06-29 17:24:37 +09:00
  c6ad184d94
• Make LegacyTotalScore nullable
  Dan Balasescu · 2023-06-29 17:19:10 +09:00
  ddd870e843
• Refactoring
  Dan Balasescu · 2023-06-28 16:14:32 +09:00
  09bc8e45de
• Fix old-new standardised score conversion missing some scores due to not rounding correctly
  Dean Herbert · 2023-06-16 14:01:56 +09:00
  94b7de4b3f
• Apply migration to new standardised score on normal reimport too
  Bartłomiej Dach · 2023-06-15 21:53:15 +02:00
  51b5a0863f
• Fix score migration not considering mod multipliers
  Bartłomiej Dach · 2023-06-13 19:00:13 +02:00
  6205864c62
• Ensure all misses are dequeued
  Dean Herbert · 2023-06-13 05:24:04 +09:00
  c1b0c60e79
• Add more commenting
  Dean Herbert · 2023-06-13 05:20:29 +09:00
  3304e41a30
• Avoid tracking hit events altogether during migration
  Dean Herbert · 2023-06-13 02:15:41 +09:00
  e9fb1f8932
• Move local classes to their rightful location
  Dean Herbert · 2023-06-13 02:12:23 +09:00
  385f6dbd84
• Avoid overhead from retrieving MaxCombo inside loop from realm
  Dean Herbert · 2023-06-13 02:05:00 +09:00
  87520ae400
• Add basic profiling output of realm migrations
  Dean Herbert · 2023-06-13 01:57:41 +09:00
  0916ae1671
• Account for scores which don't have correct maximum statistics populated
  Dean Herbert · 2023-06-13 01:40:43 +09:00
  d19f8997fc
• Add basic setup for score migration
  Dean Herbert · 2023-06-13 01:40:43 +09:00
  f30c1a564f