70 Commits

• Standardise HasReplay implementation (and remove from persisting to realm)
  Dean Herbert · 2022-07-15 16:14:21 +09:00
  c8c79d2185
• Fix realm backup creation failing when run from RealmAccess constructor

  At the point of construction, we are not on the update thread, but it
  doesn't really matter at this point because there's no other usages.

  Dean Herbert · 2022-07-04 16:45:23 +09:00
  506409a9c4
• Add more verbose logging to realm blocking process
  Dean Herbert · 2022-07-02 12:36:56 +09:00
  4fd47b5fa0
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Move null to finally
  Dean Herbert · 2022-06-16 23:37:24 +09:00
  bf6c6682bc
• Add explanatory comments
  Dean Herbert · 2022-06-16 23:31:49 +09:00
  7809566f16
• Null disposal token after use
  Dean Herbert · 2022-06-16 23:29:33 +09:00
  7b0fad6461
• Move database backup creation to async thread where possible
  Dean Herbert · 2022-06-16 17:01:17 +09:00
  4526f8c07d
• Split out INotificationOverlay to allow for easier testing
  Dean Herbert · 2022-04-18 20:14:01 +09:00
  043599081b
• Avoid deadlock during migration failed exit process
  Dean Herbert · 2022-03-29 00:04:13 +09:00
  ea46e024c1
• Limit macOS specific log output to macOS platforms specifically
  Dean Herbert · 2022-03-28 23:46:07 +09:00
  b6ae0ebb6f
• Better inform users of migration failure reason when running Apply Silicon build

  As mentioned in https://github.com/ppy/osu/discussions/17409#discussioncomment-2445464?

  Dean Herbert · 2022-03-28 17:34:36 +09:00
  a98aac3bf2
• Remove unnecessary MaxCombo migration between unmapped database fields
  Salman Ahmed · 2022-03-20 16:27:54 +03:00
  c2063f415d
• Add AsSplitQuery specification to avoid optimisation recommendation log messages
  Dean Herbert · 2022-02-15 15:23:17 +09:00
  334fe1f120
• Run EF migrations before migrating to realm

  Turns out that there are more than zero users that are upgrading from
  old databases. I think we probably want to support this for now.
  
  Tested against database in https://github.com/ppy/osu/discussions/16700
  and one other I had locally, both work correctly.

  Dean Herbert · 2022-01-29 23:13:23 +09:00
  1a14ccc7ee
• Skip scores missing beatmaps during realm migration
  Dean Herbert · 2022-01-28 01:20:32 +09:00
  942ea896f1
• Skip beatmap imports where ruleset is not present in realm

  Closes #16651.
  
  When a ruleset is not available, the `Find` call would return null. When
  a null is passed to the constructor, `BeatmapInfo` would create an "osu"
  ruleset, which tries to get stored to realm and fails on duplicate
  primary key.
  
  Probably need to add better safeties against this (or change that
  constructor...) but this will fix the migration process.
  
  Probably not serious enough to pull the build. This only affects
  rulesets like karaoke which have custom beatmaps.

  Dean Herbert · 2022-01-28 00:14:20 +09:00
  81461be49f
• Add exception message to discussion template url
  Dean Herbert · 2022-01-27 14:56:04 +09:00
  67ccb87992
• Add safety against zip creation potentially failing (probably can't but still)
  Dean Herbert · 2022-01-27 14:55:52 +09:00
  fb081384e1
• Avoid showing the external link warning
  Dean Herbert · 2022-01-27 14:53:11 +09:00
  465e7d29fe
• Automatically zip and show the backup archive to the user
  Dean Herbert · 2022-01-27 14:52:58 +09:00
  31abb372e5
• Show notification when migration fails to give users a recovery path
  Dean Herbert · 2022-01-27 14:39:11 +09:00
  b745252962
• Change migration process to always delete old EF database

  It is already backed up, so this is probably fine.

  Dean Herbert · 2022-01-27 14:33:46 +09:00
  deb5d75b5f
• Block collection loading until realm migration has completed
  Dean Herbert · 2022-01-27 00:34:51 +09:00
  f21e3d0d86
• Skip importing scores which have no matching realm ruleset

  There's no real way to recover these unless we want to start importing
  rulesets into realm. And that seems counter productive. This can only
  happen if users don't have the dll present any more, and it was removed
  far before realm was tracking rulesets (else it would have an
  `Available=0` entry in realm to match).

  Dean Herbert · 2022-01-26 18:04:54 +09:00
  3aa681005b
• Update remaining cases of clashes with realm.Write and realm.RegisterForNotifications
  Dean Herbert · 2022-01-25 13:09:48 +09:00
  d7342880f5
• Update remaining cases of clashing variable name in realm.Run(realm..
  Dean Herbert · 2022-01-25 13:04:05 +09:00
  e23b10e6a5
• Rename RealmContextFactory to RealmAccess
  Dean Herbert · 2022-01-24 20:38:07 +09:00
  6eb2c28e41
• Allow realm migration to run again if interrupted halfway
  Dean Herbert · 2022-01-24 18:55:15 +09:00
  66c5d77d63
• Move log statement about migration completed closer to rest of migration code
  Bartłomiej Dach · 2022-01-22 14:20:28 +01:00
  7e68371d28
• Merge branch 'master' into realm-migration-ui
  Bartłomiej Dach · 2022-01-22 13:52:19 +01:00
  1b2cca4a0d
• Remove no longer used resolved storage
  Bartłomiej Dach · 2022-01-22 13:48:49 +01:00
  c99f227879
• Remove using statements
  Dean Herbert · 2022-01-22 11:54:40 +09:00
  daed0b04dc
• Create backup before any realm contexts are used
  Dean Herbert · 2022-01-22 11:52:46 +09:00
  855ef3fa92
• Merge branch 'master' into realm-context-use-update-when-feasible
  Dean Herbert · 2022-01-21 18:03:09 +09:00
  8f1dfa33a2
• Update all usages of CreateContext to use either Run or Write
  Dean Herbert · 2022-01-21 17:27:08 +09:00
  114c9e8c1f
• Show realm migration progress at Loader
  Dean Herbert · 2022-01-21 14:56:49 +09:00
  5622d2ba4f
• Create backup of databases before opening contexts

  Attempt to avoid file IO issues.
  
  Closes #16531.

  Dean Herbert · 2022-01-21 00:46:53 +09:00
  079b2dfc42
• Remove all calls to Realm.Refresh to fix blocking overhead from subscriptions

  Turns out this is not required if realm is aware of a
  `SynchronizationContext`. See
  https://github.com/realm/realm-dotnet/discussions/2775#discussioncomment-2005412
  for further reading.

  Dean Herbert · 2022-01-20 20:23:18 +09:00
  5df46d0a54
• Merge pull request #16520 from peppy/refresh-after-migrate

  Improve realm migration performance further

  Dan Balasescu · 2022-01-20 14:38:23 +09:00
  64fe7d8dd3
• Remove duplicate setters
  Dean Herbert · 2022-01-20 04:34:00 +09:00
  a27a3b308c
• Backup collections alongside main databases when migrating to realm
  Dean Herbert · 2022-01-19 16:31:36 +09:00
  fad66d7682
• Centralise backup code and also run on skin/settings migrations
  Dean Herbert · 2022-01-19 16:31:36 +09:00
  aa93042aa3
• Avoid using parameterless constructors in migration code

  Minor performance improvement (less garbage).

  Dean Herbert · 2022-01-19 16:22:18 +09:00
  fd5198d667
• Add transactional committing of scores/beatmaps

  This helps slightly with performance, allows better monitoring via realm
  studio, but most importantly greatly reduces filesize.
  
  fully compacted:        109M
  transaction size 100:   115M
  transaction size 1000:  123M
  transaction size 10000: 164M
  single transaction:     183M
  
  With a transaction size of 100 there is a performance reduction, so 1000
  seems to be the best middle-ground.

  Dean Herbert · 2022-01-19 16:08:48 +09:00
  42736c9995
• Avoid using a write context for EF migration

  This reduces a stall delay as EF tries to process changes over tracked
  objects during disposal of the context.

  Dean Herbert · 2022-01-19 15:56:58 +09:00
  973836484c
• Force a realm refresh after migration

  This really shouldn't have much effect as it will be run in the first
  `Update` method and is probably a noop (we are already pointing to the
  newest version due to just performing writes), but seems like a safe addition.
  
  In general `Realm.Refresh()` only really does anything when there's multithreaded
  usage and notifications to be sent.

  Dean Herbert · 2022-01-19 15:56:58 +09:00
  faec62be51
• Merge branch 'master' into realm-integration/faster-migration
  Dean Herbert · 2022-01-19 12:56:42 +09:00
  d440197fb3
• Merge pull request #16507 from peppy/more-ingore-rules

  Add some missing `IgnoredAttributes` to reduce automapper overhead

  Dan Balasescu · 2022-01-19 12:26:37 +09:00
  f6f44029e8
• Only output "successful" messages when copy actually occurred
  Dean Herbert · 2022-01-19 10:31:13 +09:00
  195534a1d2