103 Commits

• Refactor DifficultyHitObject to include ClockRate and HitWindows (#36630)

  This changes difficulty calculations to use `ClockRate` and `HitWindows`
  from `DifficultyHitObjects` instead of providing them manually. It's
  main purpose is unifying all the calculations to use the same source of
  truth, and also allowing future work on supporting variable clockrates.
  
  ---------
  
  Co-authored-by: James Wilson <tsunyoku@gmail.com>

  StanR · 2026-02-10 20:01:51 +00:00
  c8318d6edd
• Replace nested ternaries with ifs
  Dan Balasescu · 2025-09-23 13:45:10 +09:00
  82ac42cae3
• Prevent Taiko difficulty crash if a map only contains 0-strains (#34829)

  * Prevent Taiko difficulty crash if a map only contains 0-strains
  
  * Add second check for safety
  
  This is accessing a different array of strains. I'd rather be safe than sorry.
  
  * Add guard in PP too
  
  * Make `MarginOfError` a const

  James Wilson · 2025-08-31 12:04:56 +00:00
  6a35b7237b
• Implement deltatimenormaliser into rhythm grouping logic (#33403)

  * additions
  
  * review fixes
  
  * Formatting
  
  * comments + review
  
  * fix
  
  * fix renaming and namespace
  
  * balancing + round
  
  ---------
  
  Co-authored-by: tsunyoku <tsunyoku@gmail.com>
  Co-authored-by: StanR <hi@stanr.info>

  Jay Lawton · 2025-08-28 13:19:13 +00:00
  087f0565e6
• Fix inspections
  Dean Herbert · 2025-02-07 13:54:35 +09:00
  4f6fd68a91
• Initial tidy-up pass on IntervalGroupingUtils
  Dean Herbert · 2025-02-05 15:47:18 +09:00
  8447679db9
• Tidy up xmldoc and remove another unused field
  Dean Herbert · 2025-02-05 15:33:06 +09:00
  325483192a
• Remove unused HitObjectInterval
  Dean Herbert · 2025-02-05 15:10:15 +09:00
  fc93390284
• Simplify TaikoRhythmData's ratio computation
  Dean Herbert · 2025-02-05 15:09:51 +09:00
  709ad02a51
• Rename Colour / Rhythm related fields and classes
  Dean Herbert · 2025-02-05 15:08:15 +09:00
  fa844b0ebc
• Use correct English
  tsunyoku · 2025-01-27 12:56:33 +00:00
  f3c17f1c2b
• Rename class, rename children to hit objects and groups, make fields un-settable
  tsunyoku · 2025-01-27 12:54:22 +00:00
  71b89c390f
• Account for floating point errors
  tsunyoku · 2025-01-26 20:15:13 +00:00
  13c956c248
• Fix incorrect startTime calculation
  tsunyoku · 2025-01-26 16:21:07 +00:00
  a7aa553445
• Remove unused default value
  tsunyoku · 2025-01-23 10:29:04 +00:00
  8f17a44976
• Keep old behaviour of double.PositiveInfinity being the default for Interval
  tsunyoku · 2025-01-22 13:26:12 +00:00
  753e9ef7c7
• Fix incorrect namespace
  tsunyoku · 2025-01-22 13:24:30 +00:00
  2c0d6b14c8
• Replace weird IntervalGroupedHitObjects inheritance layer
  tsunyoku · 2025-01-21 15:58:33 +00:00
  14c68bcc58
• Revert Precision.DefinitelyBigger usage
  tsunyoku · 2025-01-21 15:01:32 +00:00
  1c4bc6dffd
• Rename rhythm preprocessing objects to be clearer with intent
  tsunyoku · 2025-01-21 14:29:07 +00:00
  20a76d832d
• Add xmldoc to explain IHasInterval.Interval
  tsunyoku · 2025-01-21 14:28:15 +00:00
  ef8867704a
• Remove EffectiveBPMPreprocessor
  tsunyoku · 2025-01-21 14:24:04 +00:00
  fa20bc6631
• Rewrite of the Rhythm Skill within osu!taiko (#31284)

  * implement bell curve into diffcalcutils
  
  * remove unneeded attributes
  
  * implement new rhythm skill
  
  * change dho variables
  
  * update dho rhythm
  
  * interval interface
  
  * implement rhythmevaluator
  
  * evenhitobjects
  
  * evenpatterns
  
  * evenrhythm
  
  * change attribute ordering
  
  * initial balancing
  
  * change naming to Same instead of Even
  
  * remove attribute bump for display
  
  * Fix diffcalc tests
  
  ---------
  
  Co-authored-by: StanR <hi@stanr.info>

  Jay Lawton · 2024-12-27 16:30:30 +03:00
  824497d82c
• Implement Reading Skill into osu!taiko (#31208)
  Jay Lawton · 2024-12-21 13:19:14 +03:00
  f6a36f7b2e
• Minor refactoring to reduce amount of looping
  vun · 2022-10-09 07:09:05 +08:00
  122064d03f
• Refactor previous and next colour change into TaikoDifficultyHitObjectColour
  vun · 2022-09-30 11:42:48 +08:00
  02092ede64
• Implement mono tl nerf for stamina, disable convert specific nerfs
  vun · 2022-09-30 09:10:56 +08:00
  09a38fec94
• Refactor to move first-object detection to evaluation
  vun · 2022-09-29 15:27:26 +08:00
  d84c956af9
• Declare Parent as non-nullable
  vun · 2022-08-24 08:57:13 +08:00
  fb9bb2d42d
• Remove redundant using statement
  vun · 2022-08-19 16:19:45 +08:00
  f3e1287f04
• Add FirstHitObject as a property of encoding classes
  vun · 2022-08-19 16:13:36 +08:00
  684efefb50
• Add HitType property to MonoStreak
  vun · 2022-08-19 16:05:34 +08:00
  a26de0a10f
• Naming changes
  vun · 2022-08-19 15:45:43 +08:00
  51176e9577
• Naming changes
  vun · 2022-08-19 15:31:03 +08:00
  5dcd4ce7c5
• Change FindRepetitionInterval to start with one previous encoding
  vun · 2022-08-18 14:12:03 +08:00
  40b1554fea
• Add back null check
  Dan Balasescu · 2022-08-15 21:57:41 +09:00
  8e0049c005
• Fix notes not being added to list
  Dan Balasescu · 2022-08-15 21:56:03 +09:00
  c03e47317a
• Whoops I meant to remove these
  Dan Balasescu · 2022-08-15 21:56:03 +09:00
  4d4ee05981
• Remove TaikoDifficultyPreprocessor
  Dan Balasescu · 2022-08-15 21:43:09 +09:00
  78283ce3c5
• Privatise internals of TaikoColourDifficultyPreprocessor
  Dan Balasescu · 2022-08-15 21:35:57 +09:00
  21d2998032
• Use ctor in a place that looks visually weird

  I read through this thinking "why doesn't Previous get assigned to
  currentEncoding here? But it's because the initializer runs right after
  the ctor and before the "method" returns. So really there's 3 operations
  running on one line here - ctor, init, and assignment.

  Dan Balasescu · 2022-08-15 21:30:46 +09:00
  94c6beeaf7
• General refactoring
  Dan Balasescu · 2022-08-15 21:26:54 +09:00
  502e31dd37
• Remove review-specific comment
  vun · 2022-07-22 18:31:59 +08:00
  fc08d77090
• Fix comments
  vun · 2022-07-22 18:20:35 +08:00
  7d4593eb6d
• Fix outdated comment
  vun · 2022-07-22 16:31:19 +08:00
  6359c1a4fe
• Fix and add comments
  vun · 2022-07-22 10:49:53 +08:00
  4433f902ea
• Implement stateless colour evaluator and required encoding changes
  vun · 2022-07-21 19:15:22 +08:00
  e4086b058b
• Move TaikoDifficultyHitObject creation back to TaikoDifficultyCalculator
  vun · 2022-07-21 15:45:03 +08:00
  7917a60e3c
• Share sigmoid, Fix Preprocessor XML
  Jay L · 2022-07-21 10:52:41 +10:00
  b7567f7db2
• Partial Review changes
  Jay L · 2022-07-20 23:33:38 +10:00
  cb63ec282e