1054 Commits

• Add AsSplitQuery specification to avoid optimisation recommendation log messages
  Dean Herbert · 2022-02-15 15:23:17 +09:00
  334fe1f120
• Update OsuDbContext in line with EF changes
  Dean Herbert · 2022-02-15 15:19:50 +09:00
  8ec28dc8bc
• Update stream read operations to use new helper methods
  Dean Herbert · 2022-02-11 16:02:25 +09:00
  908c31c687
• Add support for creating new blank difficulties
  Bartłomiej Dach · 2022-02-02 21:55:33 +01:00
  dc96c4888b
• Fix RealmLive unnecessarily passing ID around

  Appears to have never been needed. When the `retrieveFromID` method was
  created in 81b5717ae7, it didn't use the
  `id` parameter for anything either.

  Bartłomiej Dach · 2022-02-01 21:35:12 +01:00
  a378e78ced
• Run EF migrations before migrating to realm

  Turns out that there are more than zero users that are upgrading from
  old databases. I think we probably want to support this for now.
  
  Tested against database in https://github.com/ppy/osu/discussions/16700
  and one other I had locally, both work correctly.

  Dean Herbert · 2022-01-29 23:13:23 +09:00
  1a14ccc7ee
• Skip scores missing beatmaps during realm migration
  Dean Herbert · 2022-01-28 01:20:32 +09:00
  942ea896f1
• Skip beatmap imports where ruleset is not present in realm

  Closes #16651.
  
  When a ruleset is not available, the `Find` call would return null. When
  a null is passed to the constructor, `BeatmapInfo` would create an "osu"
  ruleset, which tries to get stored to realm and fails on duplicate
  primary key.
  
  Probably need to add better safeties against this (or change that
  constructor...) but this will fix the migration process.
  
  Probably not serious enough to pull the build. This only affects
  rulesets like karaoke which have custom beatmaps.

  Dean Herbert · 2022-01-28 00:14:20 +09:00
  81461be49f
• Merge pull request #16640 from peppy/realm-migration-always-delete

  Improve realm migration UX to give users a recovery path on error

  Dan Balasescu · 2022-01-27 15:43:14 +09:00
  9ff2b9eb95
• Add exception message to discussion template url
  Dean Herbert · 2022-01-27 14:56:04 +09:00
  67ccb87992
• Add safety against zip creation potentially failing (probably can't but still)
  Dean Herbert · 2022-01-27 14:55:52 +09:00
  fb081384e1
• Avoid showing the external link warning
  Dean Herbert · 2022-01-27 14:53:11 +09:00
  465e7d29fe
• Automatically zip and show the backup archive to the user
  Dean Herbert · 2022-01-27 14:52:58 +09:00
  31abb372e5
• Show notification when migration fails to give users a recovery path
  Dean Herbert · 2022-01-27 14:39:11 +09:00
  b745252962
• Change migration process to always delete old EF database

  It is already backed up, so this is probably fine.

  Dean Herbert · 2022-01-27 14:33:46 +09:00
  deb5d75b5f
• Add more attempts to delete EF database

  Just noticed in passing. Probably best we do this since it was known to
  fail on windows in some rare cases.

  Dean Herbert · 2022-01-27 14:32:21 +09:00
  587c0f965c
• Block collection loading until realm migration has completed
  Dean Herbert · 2022-01-27 00:34:51 +09:00
  f21e3d0d86
• Merge branch 'master' into fix-out-of-order-events-on-block-fail
  Dan Balasescu · 2022-01-26 19:08:55 +09:00
  94d3e2c90c
• Merge pull request #16626 from peppy/fix-skin-section-realm-usage

  Refactor `SkinSection` to avoid unnecessary realm queries

  Dan Balasescu · 2022-01-26 19:01:15 +09:00
  b1a23486c5
• Remove collection ToLive helper method to avoid confusion
  Dean Herbert · 2022-01-26 18:26:37 +09:00
  45636ce04b
• Skip importing scores which have no matching realm ruleset

  There's no real way to recover these unless we want to start importing
  rulesets into realm. And that seems counter productive. This can only
  happen if users don't have the dll present any more, and it was removed
  far before realm was tracking rulesets (else it would have an
  `Available=0` entry in realm to match).

  Dean Herbert · 2022-01-26 18:04:54 +09:00
  3aa681005b
• Move final empty result set sending to post-compact
  Dean Herbert · 2022-01-26 17:21:57 +09:00
  885fb92aad
• Add flag to guard against deadlocks during blocking operations
  Dean Herbert · 2022-01-26 17:09:28 +09:00
  791ea0308f
• Revert "Move final result set firing to before the update realm is disposed"

  This reverts commit 24bcba6418.

  Dean Herbert · 2022-01-26 16:21:24 +09:00
  11f0f3c17d
• Move final result set firing to before the update realm is disposed

  Without this, if any registered callback attempts to access
  `RealmAccess.Realm` when handling the empty set callback, it will
  deadlock the game.

  Dean Herbert · 2022-01-26 15:57:06 +09:00
  24bcba6418
• Send unsubscribe actions to synchronization context for consistency and safety
  Dean Herbert · 2022-01-26 15:24:53 +09:00
  5ea781faef
• Merge branch 'master' into fix-out-of-order-events-on-block-fail
  Dean Herbert · 2022-01-26 15:21:10 +09:00
  91e0d1021f
• Remove ILive<> interface (and use abstract Live<> instead)
  Dean Herbert · 2022-01-26 13:38:56 +09:00
  cd71ec0edd
• Move statistics to static class
  Dean Herbert · 2022-01-26 13:29:12 +09:00
  d37c3c463e
• Add statistics for Live usage
  Dean Herbert · 2022-01-26 12:42:24 +09:00
  c7947b3489
• Fix RealmLive not refetching if update thread context was closed at some point
  Dean Herbert · 2022-01-26 12:32:34 +09:00
  56b06f34f0
• Avoid creating realm contexts or refetching when accessing RealmLive from the update thread
  Dean Herbert · 2022-01-26 12:32:34 +09:00
  d76822b685
• Use blocking calls to SynchronizationContext to guarantee order of execution
  Dean Herbert · 2022-01-25 20:49:52 +09:00
  4a9f4eecba
• Merge pull request #16604 from peppy/less-async-import

  Remove `Task` from the inner-most `Import` method in `RealmArchiveModelImporter`

  Dan Balasescu · 2022-01-25 16:47:07 +09:00
  d8270fe14f
• Fix notification reset events potentially arriving out of order if a block operation times out
  Dean Herbert · 2022-01-25 16:26:06 +09:00
  1bb1366c9f
• Merge branch 'master' into realm-subscription-tracking
  Dan Balasescu · 2022-01-25 16:03:21 +09:00
  7f2e66298b
• Remove Task from the inner-most Import method in RealmArchiveModelImporter

  One of my pending work items for post-realm merge.
  
  The lowest-level import task is no longer asynchronous, as we don't want
  it to span multiple threads to allow easier interaction with realm.
  Removing the `Task` spec simplifies a heap of usages.
  
  Individual usages should decide whether they want to run the import
  asynchronously, by either using an alternative override or spooling up a
  thread themselves.

  Dean Herbert · 2022-01-25 15:30:29 +09:00
  778d2a71b4
• Add tracking of total subscriptions
  Dean Herbert · 2022-01-25 14:51:41 +09:00
  5fb9b58c9b
• Merge branch 'realm-clean-up' into realm-block-timeout-assert-failure
  Dean Herbert · 2022-01-25 13:58:36 +09:00
  9ad4d66e4d
• Fix a few more cases of "context" terminology usage
  Dean Herbert · 2022-01-25 13:56:47 +09:00
  a5c76a9647
• Update remaining cases of clashes with realm.Write and realm.RegisterForNotifications
  Dean Herbert · 2022-01-25 13:09:48 +09:00
  d7342880f5
• Update remaining cases of clashing variable name in realm.Run(realm..
  Dean Herbert · 2022-01-25 13:04:05 +09:00
  e23b10e6a5
• Fix a failed BlockAllOperations leaving update realm in unretrieved state

  If the operation timed out on..
  
  ```csharp
     throw new TimeoutException(@"Took too long to acquire lock");
  ```
  
  ..from an update thread, it would not restore the update context.
  
  The next call would then fail on the assert that ensures a non-null
  context in such cases.
  
  Can add test coverage if required.

  Dean Herbert · 2022-01-24 20:53:29 +09:00
  6f4c337a56
• Update terminology to realm "instance" rather than "context"

  This matches the terminology used by realm themselves, which feels
  better.

  Dean Herbert · 2022-01-24 20:38:38 +09:00
  f30894840c
• Rename RealmContextFactory to RealmAccess
  Dean Herbert · 2022-01-24 20:38:07 +09:00
  6eb2c28e41
• Merge pull request #16547 from peppy/realm-stable-subscriptions

  Fix realm subscriptions getting lost after a context recycle

  Dan Balasescu · 2022-01-24 20:20:04 +09:00
  bb54ad9ad8
• Allow realm migration to run again if interrupted halfway
  Dean Herbert · 2022-01-24 18:55:15 +09:00
  66c5d77d63
• Fix attempt to revive update thread realm context from non-update thread
  Dean Herbert · 2022-01-24 18:36:16 +09:00
  9afa034296
• Merge branch 'master' into realm-stable-subscriptions
  Dean Herbert · 2022-01-24 18:25:47 +09:00
  9ff9611296
• Fix copy pasted xmldoc
  Dean Herbert · 2022-01-24 18:05:30 +09:00
  e3083c2477