1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-14 15:33:05 +08:00
Commit Graph

64938 Commits

Author SHA1 Message Date
Bartłomiej Dach
c107bfcd31
Fix TestSceneSideOverlays test failure 2023-12-26 20:09:34 +01:00
Bartłomiej Dach
668ce937a8
Merge pull request #26138 from peppy/fix-audio-rate-playback-not-fail
Bail from score submission if audio playback rate is too far from reality
2023-12-26 19:13:46 +01:00
rushiiMachine
c087578e01
Force minimum cursor size for OsuResumeOverlay
On cursor sizes below 0.3x it becomes exceedingly difficult to quickly locate and then accurately click the resume cursor on the pause overlay as it could as big as a handful of pixels. This clamps the minimum cursor size to 1x for the resume overlay, which is way more comfortable and more closely resembles stable.
2023-12-26 10:07:21 -08:00
Dean Herbert
5d0b524794
Adjust back button to match style better 2023-12-27 02:54:24 +09:00
Dean Herbert
8e13f65c5d
Adjust hover effect slightly 2023-12-27 02:46:21 +09:00
Dean Herbert
5b1deb7c4b
Give buttons a touch of padding to make click effect feel better 2023-12-27 02:40:50 +09:00
Dean Herbert
5de8307918
Reduce width of sidebar buttons 2023-12-27 02:38:23 +09:00
Dean Herbert
9a1a97180d
Change settings overlay to always show expanded buttons 2023-12-27 02:33:17 +09:00
Dean Herbert
58476d5429
Allow ExpandingContainer to not auto expand on hover 2023-12-27 02:33:02 +09:00
Dean Herbert
c55458e49c
Remove pointless intermediary class 2023-12-27 02:32:47 +09:00
Dean Herbert
d70fddb6fd
Fix elapsed time being counted twice on first frame 2023-12-27 00:11:22 +09:00
Bartłomiej Dach
223e459f2d
Merge pull request #26141 from peppy/control-point-fixes
Fix editor timing mode not handling undo/redo correctly
2023-12-26 14:25:08 +01:00
Dean Herbert
03e2463b06
Add test coverage and refactor to better handle equality edge case 2023-12-26 21:21:08 +09:00
Dean Herbert
1f2f749db6
Fix selection not being retained in control point list when undoing / redoing 2023-12-26 21:04:42 +09:00
Dean Herbert
f2c0e7cf2e
Fix editor's control point list refreshing multiple times for a single change 2023-12-26 21:04:42 +09:00
Bartłomiej Dach
b1a26acdd0
Merge pull request #26136 from peppy/add-waveform-visual-offset
Add visual offset to better align editor waveforms with expectations
2023-12-26 12:57:13 +01:00
Bartłomiej Dach
4077d3a259
Merge pull request #26127 from ntransw/fix-rewind-backtracking
Fix rewind incorrectly selecting the same beatmap
2023-12-26 12:56:56 +01:00
Bartłomiej Dach
30b5b36f1d
Fix code quality inspection 2023-12-26 12:20:17 +01:00
Nathan
6269c79c17
Merge branch 'master' into fix-rewind-backtracking 2023-12-26 03:10:00 -08:00
Dean Herbert
92f7a42fd7
Merge pull request #26131 from smoogipoo/fix-mania-scroll-difference
Make mania scroll speed independent of hit position
2023-12-26 19:27:43 +09:00
Dean Herbert
225528d519
Bail from score submission if audio playback rate is too far from reality
Closes https://github.com/ppy/osu/issues/23149.
2023-12-26 19:20:58 +09:00
Nathan Tran
4e3bdb2b56 Add test coverage 2023-12-26 00:57:06 -08:00
Dean Herbert
f9e47242db
Add visual offset to better align editor waveforms with expectations 2023-12-26 17:44:49 +09:00
Dan Balasescu
2ec6aa7fbb
Make mania scroll speed independent of hit position 2023-12-26 12:46:21 +09:00
Dean Herbert
ef4191fb57
Merge pull request #26124 from bdach/wasapi-preview-track-breakage
Do not attempt to stop preview tracks when arriving from a "track completed" sync
2023-12-26 12:07:14 +09:00
Dean Herbert
b18b5b9977
Add inline note about deadlock 2023-12-26 12:06:56 +09:00
Nathan Tran
060bf8beff Fix rewind backtracking 2023-12-25 15:27:32 -08:00
Bartłomiej Dach
f84b07e71a
Do not attempt to stop preview tracks when arriving from a "track completed" sync
This fixes an issue identified with the WASAPI implementation in
https://github.com/ppy/osu-framework/pull/6088. It has no real effect
on current `master`, but fixes a deadlock that occurs with the
aforementioned framework branch when one lets a preview track play out
to the end - at this point all audio will stop and an attempt to perform
any synchronous BASS operation (playing another track, seeking) will
result in a deadlock.

It isn't terribly clear as to why this is happening precisely, but
there does not appear to be any need to stop and seek at that point,
so this feels like a decent workaround even if the actual issue is
upstream (and will unblock pushing out WASAPI support to users).
2023-12-25 19:01:06 +01:00
Bartłomiej Dach
dde88bb05e
Merge pull request #26117 from peppy/add-slider-tick-end-miss-sprites
Add classic skin sprites for slider tick and slider end misses
2023-12-25 15:26:41 +01:00
Bartłomiej Dach
4fa35d709c
Update resources 2023-12-25 14:56:40 +01:00
Bartłomiej Dach
3748541569
Merge branch 'master' into add-slider-tick-end-miss-sprites 2023-12-25 14:55:09 +01:00
Bartłomiej Dach
651a608e73
Merge pull request #26120 from peppy/argon-triangle-tick-end-miss
Update argon and triangles slider tick/end miss to match display style
2023-12-25 14:42:59 +01:00
Bartłomiej Dach
8142a7cb7e
Remove incorrect spec 2023-12-25 14:00:32 +01:00
Dean Herbert
4fc1691a57
Merge pull request #25653 from EVAST9919/depth-mod
Implement `OsuModDepth`
2023-12-25 21:32:44 +09:00
Dean Herbert
8e6ea2dd9b
Update argon and triangles to match display style 2023-12-25 17:37:28 +09:00
Dean Herbert
02c771f540
Add warning for linux users about to report a non-bug as a bug 2023-12-25 17:27:15 +09:00
Dean Herbert
b1d994b6ff
Add classic skin sprites for slider tick and slider end misses 2023-12-25 17:17:23 +09:00
Andrei Zavatski
19d0236418 Change mod acronym 2023-12-23 22:11:00 +03:00
Andrei Zavatski
e470a42da0 Merge branch 'master' into depth-mod 2023-12-23 22:09:12 +03:00
Dean Herbert
ee00f7ea1f
Merge pull request #26086 from peppy/fix-toolbar-button-lag
Use a realm subscription to avoid overhead when hovering a toolbar button
2023-12-24 04:01:04 +09:00
Bartłomiej Dach
a0915a0dd1
Merge pull request #26076 from peppy/gameplay-offset-adjust
Add control to allow changing offset from gameplay
2023-12-23 19:41:57 +01:00
Bartłomiej Dach
68430d6ecd
Fix toolbar keybinding hint not clearing after unbinding the keybinding 2023-12-23 19:39:17 +01:00
Dean Herbert
5b03dc8d0b
Use a realm subscription to avoid overhead when hovering a toolbar button
Addresses https://github.com/ppy/osu/discussions/26018.
2023-12-24 03:20:42 +09:00
Dean Herbert
686b2a4394
Disable positional interaction for now 2023-12-24 03:00:51 +09:00
Dean Herbert
72bec527fd
Add conditions to match stable offset adjust limitations 2023-12-24 02:36:27 +09:00
Dean Herbert
92b490f2e7
Don't bother with alt support for now 2023-12-24 01:59:48 +09:00
Dean Herbert
d72ec81684
Merge pull request #26083 from smoogipoo/try-improve-hp-drain
Replace recently-added HP drain density calculation with combo-end bonus
2023-12-24 01:30:49 +09:00
Dan Balasescu
7437d21f49
Adjust comment regarding slider tail 2023-12-24 00:45:22 +09:00
Dan Balasescu
ee0bd69e24
Merge pull request #26072 from peppy/fix-migration-hard-crash
Fix hard crash when attempting to change folder location during a large import
2023-12-24 00:09:13 +09:00
Dan Balasescu
8b11bcc6ea
Remove unused using 2023-12-24 00:08:15 +09:00