268 Commits

Author	SHA1	Message	Date
smoogipoo	43e48406ca	Miss all ticks when hold note is hit	2021-03-31 12:21:14 +09:00
Bartłomiej Dach	9a330c4c56	Fix mania hold note heads hiding when frozen ... This was an insidious regression from a3dc1d5. Prior to that commit, `DrawableHoldNoteHead` had `UpdateStateTransforms()` overridden, to set the hold note head's lifetime. When that method was split into `UpdateInitialStateTransforms()` and `UpdateHitStateTransforms()`, the lifetime set was moved to the former. Unfortunately, that override served two purposes: both to set the lifetime, and to suppress hit animations which would normally be added by the base `DrawableManiaHitObject`. That fact being missed led to `UpdateHitStateTransforms()` hiding the hold note head immediately on hit and with a slight delay on miss. To resolve, explicitly override `UpdateHitStateTransforms()` and suppress the base call, with an explanatory comment.	2021-03-21 18:46:41 +01:00
ekrctb	e3c035fe9c	Adjust namespace	2020-12-07 12:32:52 +09:00
ekrctb	40da799103	Move piece files of Mania ruleset	2020-12-07 12:31:56 +09:00
smoogipoo	0414e5c550	Add MaximumJudgementOffset to DrawableHitObject, use in more places	2020-11-26 01:12:42 +09:00
Dean Herbert	49b8331ccd	Merge pull request #10877 from smoogipoo/fix-mania-judgement-displays ... Fix hold note judgements displaying incorrectly	2020-11-18 19:00:14 +09:00
smoogipoo	77942af3a6	Fix hold note judgements displaying incorrectly	2020-11-17 13:37:58 +09:00
Bartłomiej Dach	b62bf5798d	Store time of hold note break	2020-11-13 21:14:34 +01:00
Bartłomiej Dach	7a89e58483	Disable pressed/released action logic when rewinding	2020-11-13 20:49:06 +01:00
Dean Herbert	a3dc1d5730	Update existing implementations	2020-11-04 17:14:23 +09:00
Bartłomiej Dach	1f0620ffd4	Replace assignment references to HitResult.Miss with Judgement.MinResult	2020-10-02 23:31:24 +02:00
Bartłomiej Dach	2b1ef16f89	Replace comparison references to HitResult.Miss with IsHit	2020-10-02 23:31:24 +02:00
smoogipoo	e789e06c86	Don't display hold note tick judgements	2020-09-29 16:33:38 +09:00
smoogipoo	b1877b649b	Use new hit results in mania	2020-09-29 16:33:38 +09:00
Bartłomiej Dach	d419fe4dbf	Remove note shaking mention that doesn't apply in mania	2020-08-31 12:03:05 +02:00
smoogipoo	acbeb5406f	Add/improve xmldoc	2020-08-31 13:33:41 +09:00
smoogipoo	aa151e4cd7	Merge branch 'master' into mania-notelock	2020-08-31 13:31:41 +09:00
smoogipoo	deb172bb6c	Implement basic mania hit order policy	2020-08-27 20:24:21 +09:00
smoogipoo	1db836e9e0	Merge branch 'master' into hold-note-lighting	2020-08-26 20:22:07 +09:00
smoogipoo	9372c6eef6	Implement hold note lighting	2020-08-26 20:21:56 +09:00
smoogipoo	b3338347b7	Remove fade on successful hits	2020-08-21 23:56:27 +09:00
smoogipoo	8632c3adf0	Fix hold notes bouncing with SV changes	2020-08-21 23:11:15 +09:00
Dan Balasescu	42ee9b75df	Apply suggestions from code review ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2020-08-21 19:38:59 +09:00
smoogipoo	aead13628b	Rework freezing to use masking	2020-08-21 17:52:42 +09:00
smoogipoo	37cf7999b1	Merge branch 'master' into hold-note-freeze	2020-08-21 14:39:25 +09:00
Dean Herbert	74f8e61381	Merge branch 'master' into mania-body-recycling	2020-08-19 20:40:15 +09:00
smoogipoo	1d9d885d27	Mask the tail as the body gets shorter	2020-08-19 01:40:26 +09:00
smoogipoo	4d4d9b7356	Add rewinding support	2020-08-19 01:37:31 +09:00
smoogipoo	99315a4aa7	Fix incorrect anchors for up-scroll	2020-08-19 00:05:36 +09:00
smoogipoo	988ad378a7	Fix body size + freeze head piece	2020-08-19 00:05:05 +09:00
smoogipoo	385f7cf85d	Implement mania hold note body recycling	2020-08-18 17:56:48 +09:00
smoogipoo	583760100a	Implement mania invert mod	2020-08-18 01:40:55 +09:00
smoogipoo	548ccc1a50	Initial implementation of hold note freezing	2020-08-18 00:29:00 +09:00
smoogipoo	f044c06d08	Fix hold notes accepting presses during release lenience	2020-07-20 22:26:58 +09:00
Dean Herbert	cbd563e80b	Rename to IHasDuration	2020-05-27 12:38:39 +09:00
smoogipoo	4719fcc291	Actually use the cancellation token	2020-05-15 18:17:39 +09:00
smoogipoo	98125102a7	Add cancellation token support to CreateNestedHitObjects()	2020-05-15 18:07:41 +09:00
smoogipoo	330521a2ae	Fix lifetime override not working	2020-04-28 15:34:10 +09:00
Dean Herbert	59bd2b3035	Merge pull request #8823 from smoogipoo/all-ruleset-encoders ... Implement legacy beatmap encoding for all rulesets	2020-04-24 17:49:34 +09:00
smoogipoo	4f0b5a34d3	Fix hold note placement body sized incorrectly	2020-04-23 12:53:23 +09:00
smoogipoo	6da0872ae5	Use the last node sample for the tail note	2020-04-22 09:06:04 +09:00
smoogipoo	1f962f5c56	Reword comment	2020-04-22 09:06:04 +09:00
smoogipoo	cc0c82aaeb	Implement IHasXPosition on ManiaHitObject	2020-04-22 09:06:04 +09:00
smoogipoo	d957614fc9	Cleanup handling of mania samples	2020-04-22 09:06:04 +09:00
Dean Herbert	c51bad0e35	Cache ManiaPlayfield instead	2020-04-13 13:42:21 +09:00
Dean Herbert	cdff6060d3	Remove recursive hierarchy traversal for mania sample balance	2020-04-13 13:01:27 +09:00
Dean Herbert	65b96079a0	Move dampening to base implementation and change range to 0..1	2020-04-13 13:01:02 +09:00
Fire937	f274ec297c	Add positional sound support for all rulesets ... The SamplePlaybackBalance is calculated in a way that the balance remains between -0.4 and 0.4. Positional sound is not supported in osu!taiko.	2020-04-12 01:33:25 +02:00
smoogipoo	1f797207f7	Rework lookups to not require total playfield columns	2020-04-03 12:31:05 +09:00
smoogipoo	3cd353d387	Fix possible nullrefs	2020-03-31 16:57:58 +09:00