35567 Commits

This Branch

This Branch

All Branches

• Remove double handling of restart allowance on results screen (already handled locally)
  Dean Herbert · 2020-12-24 13:32:35 +09:00
  61a5d3ef4a
• Merge branch 'master' into disallow-multiplayer-restart-retry
  Dean Herbert · 2020-12-24 13:31:54 +09:00
  76935b93b6
• Merge pull request #11270 from bdach/better-error-handling

  Improve error handling at realtime room settings screen

  Dean Herbert · 2020-12-24 13:23:49 +09:00
  b29a5e2073
• Merge pull request #11275 from peppy/safer-user-ids

  Send multiplayer user IDs via ctor for better thread safety

  Dean Herbert · 2020-12-24 12:20:48 +09:00
  15cef44351
• Merge pull request #11268 from bdach/fix-room-song-select-stuck

  Fix realtime multiplayer song select getting stuck after selecting invalid beatmap

  Dean Herbert · 2020-12-24 11:26:07 +09:00
  1ac93d4eeb
• Merge pull request #11274 from bdach/create-match-button

  Split create game buttons for timeshift and realtime multiplayer

  Dean Herbert · 2020-12-24 11:07:36 +09:00
  547c71bdaf
• Send multiplayer user IDs via ctor for better thread safety
  Dean Herbert · 2020-12-24 10:39:15 +09:00
  d6dadd12fa
• Split timeshift & multiplayer "create" buttons

  Multiplayer button gets new, different "Create match" text, and disable
  logic in case of a dropped connection to the multiplayer server.

  Bartłomiej Dach · 2020-12-23 22:03:57 +01:00
  414f886b02
• Move out sizing logic to multiplayer screen
  Bartłomiej Dach · 2020-12-23 22:03:30 +01:00
  c13acb609a
• Move out create room button to separate class
  Bartłomiej Dach · 2020-12-23 22:03:30 +01:00
  05d9f23762
• Merge branch 'master' into better-error-handling
  Bartłomiej Dach · 2020-12-23 18:13:50 +01:00
  152df2ad84
• Merge branch 'master' into fix-room-song-select-stuck
  Bartłomiej Dach · 2020-12-23 18:13:27 +01:00
  e7a91b3dca
• Merge pull request #11266 from peppy/fix-hard-crash-on-signal-r-exceptions
  Bartłomiej Dach · 2020-12-23 18:12:43 +01:00
  3087aba5bc
• Merge branch 'master' into fix-hard-crash-on-signal-r-exceptions
  Bartłomiej Dach · 2020-12-23 17:37:49 +01:00
  b1fb906773
• Merge pull request #11265 from peppy/fix-multiplayer-server-disconnection-flow
  Bartłomiej Dach · 2020-12-23 17:35:53 +01:00
  2549039362
• Improve user-facing error messages in room settings
  Bartłomiej Dach · 2020-12-23 17:10:53 +01:00
  e4959489b7
• Fix JoinRoom failing to return canceled token

  As it turns out, `Task.FromCanceled` expects to receive an already
  cancelled `CancellationToken`, which `CancellationToken.None` is not.

  Bartłomiej Dach · 2020-12-23 17:01:01 +01:00
  3b0bf11366
• Merge branch 'master' into fix-multiplayer-server-disconnection-flow
  Bartłomiej Dach · 2020-12-23 16:55:22 +01:00
  6c421b873d
• Refactor player exit logic to convey intention better
  Bartłomiej Dach · 2020-12-23 16:16:24 +01:00
  980e85ce25
• Tidy up event flow of change settings call
  Dean Herbert · 2020-12-23 22:39:14 +09:00
  4296f61d6c
• Merge pull request #11254 from frenzibyte/fix-multi-songselect-looping

  Fix beatmap track not looping on multiplayer song selects

  Dean Herbert · 2020-12-23 22:35:11 +09:00
  60be1bedc9
• Re-enable carousel selection after error
  Bartłomiej Dach · 2020-12-23 14:19:30 +01:00
  c5692a5d6a
• Revert logic to be closer to original

  Note the reversal of the order of operations in `endHandlingTrack()`
  (done for extra safety, to ensure no more value changed events can be
  fired at the point of cancelling looping).

  Bartłomiej Dach · 2020-12-23 13:47:28 +01:00
  582b0d2a74
• Merge branch 'fix-multiplayer-server-disconnection-flow' into fix-hard-crash-on-signal-r-exceptions
  Bartłomiej Dach · 2020-12-23 13:31:36 +01:00
  74f0c50d82
• Merge branch 'master' into fix-multiplayer-server-disconnection-flow
  Bartłomiej Dach · 2020-12-23 11:57:43 +01:00
  c839892a4c
• Bring back accidentally-removed license header
  Bartłomiej Dach · 2020-12-23 11:27:15 +01:00
  94e4928c4b
• Merge pull request #11253 from peppy/realtime-leaderboard
  Bartłomiej Dach · 2020-12-23 10:31:44 +01:00
  2b818f149d
• Fix missed inspections
  Dean Herbert · 2020-12-23 18:07:38 +09:00
  f9fd909187
• Merge branch 'master' into realtime-leaderboard
  Bartłomiej Dach · 2020-12-23 09:56:47 +01:00
  64095307de
• Move player constructor configuration to dedicated class; add AllowRestart parameter
  Dean Herbert · 2020-12-23 17:47:46 +09:00
  3c8f871b28
• Rename method to avoid weird code analysis rule
  Dean Herbert · 2020-12-23 17:14:58 +09:00
  0ddcab574f
• Use extension method in all call sites of fire-and-forget async usage
  Dean Herbert · 2020-12-23 17:10:34 +09:00
  7cc38f03d1
• Add extension method to handle cases of fire-and-forget async usage
  Dean Herbert · 2020-12-23 17:10:02 +09:00
  1864da00e6
• Simplify error handling of JoinRoom call
  Dean Herbert · 2020-12-23 16:56:57 +09:00
  c3c3364d39
• More correctly handle fire-and-forget async call
  Dean Herbert · 2020-12-23 16:51:11 +09:00
  d27b83d678
• Remove unused using
  Dean Herbert · 2020-12-23 16:49:17 +09:00
  91021eb8c4
• Merge pull request #11226 from peppy/fix-legacy-skin-texture-loader-store

  Fix incorrectly provided texture loader store to skins

  Dean Herbert · 2020-12-23 16:41:01 +09:00
  d7279dab40
• Standardise flow for aborting realtime player exit to avoid double-exit call
  Dean Herbert · 2020-12-23 16:35:39 +09:00
  f5d27b40a8
• Move notification to stateful client so it is only shown to the user from one location
  Dean Herbert · 2020-12-23 16:35:39 +09:00
  569c4092ef
• Don't allow creating or joining a room when not connected to server
  Dean Herbert · 2020-12-23 16:35:39 +09:00
  a1d42dc4a0
• Ensure appropriate screens handle exiting when the server gets disconnected

  I would have liked for this to be handled via the `OnRoomChanged` event
  flow, but this isn't present in RealtimeMatchSubScreen due to
  inheritence woes.

  Dean Herbert · 2020-12-23 16:35:39 +09:00
  12df3056e6
• Ensure the current room is left at a mutliplayer client level on client disconnection
  Dean Herbert · 2020-12-23 16:35:39 +09:00
  00d50150de
• Apply track looping and play on track change
  Salman Ahmed · 2020-12-23 08:47:34 +03:00
  286884421d
• Merge pull request #11256 from frenzibyte/disallow-joining-ended-realtime-room

  Disallow joining ended rooms in realtime multiplayer

  Dean Herbert · 2020-12-23 14:30:00 +09:00
  b632e44bac
• Fix realtime leaderboard showing accuracy based on final base score, not rolling
  Dean Herbert · 2020-12-23 14:20:35 +09:00
  be427a4ec0
• Add comment explaining why things are done where they are
  Dean Herbert · 2020-12-23 13:57:48 +09:00
  45dcd3242d
• Add early check for room status before joining
  Salman Ahmed · 2020-12-23 05:52:10 +03:00
  3aa2b22838
• Revert previous logic of join guarding
  Salman Ahmed · 2020-12-23 05:50:15 +03:00
  7751ef4f3e
• Merge pull request #8759 from LittleEndu/present-recommended
  Bartłomiej Dach · 2020-12-23 00:09:47 +01:00
  fa94703b9b
• Merge branch 'master' into present-recommended
  Bartłomiej Dach · 2020-12-22 23:36:13 +01:00
  08d87ccb1e