54537 Commits

This Branch

This Branch

All Branches

• Add test coverage for outdated ruleset
  Dean Herbert · 2022-08-29 14:26:12 +09:00
  5ff4e6a4fe
• Remove "internal" identifier as unnecessary
  Dean Herbert · 2022-08-29 14:01:15 +09:00
  90b9c02ac6
• Add basic check for correct ruleset API version
  Dean Herbert · 2022-08-22 16:35:08 +09:00
  758a554180
• Add ruleset API versioning
  Dean Herbert · 2022-08-22 16:35:08 +09:00
  f5710d8000
• Merge pull request #19906 from peppy/fix-editor-crash-mobile

  Fix editor crashing on mobile releases

  Dan Balasescu · 2022-08-22 16:31:19 +09:00
  3fb3a18e68
• Merge pull request #19695 from naoei/ruleset-localization

  Change most ruleset-accessible string types to Localisable strings

  Dean Herbert · 2022-08-22 16:13:23 +09:00
  058d67f8e8
• Fix editor crashing on mobile releases
  Dean Herbert · 2022-08-22 15:57:24 +09:00
  19bba143ee
• Merge pull request #19783 from bdach/mod-select/presets-dont-open-customisation

  Fix selecting preset containing Difficulty Adjust automatically opening customisation panel

  Dan Balasescu · 2022-08-22 15:44:00 +09:00
  0815b01b75
• Merge pull request #19830 from peppy/test-ruleset-compatibility

  Test ruleset compatibility during initial startup to avoid runtime errors

  Dan Balasescu · 2022-08-22 15:24:46 +09:00
  2bc0a68911
• Update GetVariantName to also support localisation
  Dean Herbert · 2022-08-22 14:51:00 +09:00
  d199b3b100
• Don't throw when a ruleset type is completely missing
  Dean Herbert · 2022-08-22 14:35:44 +09:00
  9d31f61ca9
• Merge pull request #19905 from smoogipoo/fix-text-boldening

  Fix language change removing mod column bold text

  Dean Herbert · 2022-08-22 14:15:22 +09:00
  594353fca1
• Merge pull request #19868 from peppy/fix-test-deadlocks

  Add safeties to avoid deadlock in `SubmittingPlayer`

  Dan Balasescu · 2022-08-22 13:17:41 +09:00
  b81c7ffc60
• Fix language change removing mod column bold text
  Dan Balasescu · 2022-08-22 13:00:47 +09:00
  e1fa959f0b
• Merge pull request #19898 from bdach/mod-select/fix-difficulty-multiplier-rounding

  Adjust rounding in mod select difficulty multiplier to match song select footer

  Dean Herbert · 2022-08-22 11:18:34 +09:00
  3ef6c60d1f
• Adjust rounding in mod select difficulty multiplier to match song select footer

  The 0.01 `Precision` spec on `DifficultyMultiplierDisplay.Current` would
  cause the difficulty multiplier to use a different midpoint rounding
  strategy than `double.ToString()`, which is the one that the song select
  footer relies on. For example, a value of 0.015 would be rounded down
  to 0.01 by `double.ToString()`, but rounded up to 0.02
  by `BindableDouble`.
  
  Fix the discrepancy by just deleting the `Precision` spec. Since the
  value of the bindable would go through `ToLocalisableString(@"N2")`
  anyway, it was redundant as is.
  
  Fixes #19889.

  Bartłomiej Dach · 2022-08-21 23:15:49 +02:00
  aa15e84bea
• Check if StatisticItem.Name is null or empty
  naoei · 2022-08-20 21:48:53 -04:00
  29ef1c8db8
• Make StatisticItem.Name not nullable
  naoei · 2022-08-20 21:48:35 -04:00
  9386d352b8
• Merge branch 'master' into ruleset-localization
  Nao · 2022-08-20 21:39:10 -04:00
  189a407cb1
• Merge pull request #19865 from OliBomby/fix-slider-flip

  Fix flipping a slider sometimes changing the curve type from "Perfect" to "Bezier"

  Dean Herbert · 2022-08-21 00:04:35 +09:00
  2022.821.0 513ba69f6f
• fix code quality
  OliBomby · 2022-08-20 16:09:02 +02:00
  7732fb21d5
• Added tests for making sure flipping and rotating retains perfect control point type
  OliBomby · 2022-08-20 15:57:39 +02:00
  614ae815c0
• Guard against SubmittingPlayer potentially getting stuck waiting on request forever
  Dean Herbert · 2022-08-20 17:19:17 +09:00
  8566e93c72
• Ensure that DummyAPIAccess runs all queued tasks on disposal
  Dean Herbert · 2022-08-20 16:22:35 +09:00
  a1e849c4db
• Merge pull request #19693 from its5Q/editor-localisation

  Add localisation support for beatmap editor setup

  Dean Herbert · 2022-08-20 11:51:57 +09:00
  cbdd870ecf
• Add inline comment explaining necessity to use AddRange for slider transform operations
  Dean Herbert · 2022-08-20 11:38:43 +09:00
  36e202c70e
• moving all controlpoints at once for slider
  OliBomby · 2022-08-20 00:26:04 +02:00
  65f7ecec83
• Merge pull request #19851 from peppy/update-framework

  Update framework and resources

  Dan Balasescu · 2022-08-19 22:03:55 +09:00
  4ef8e00a78
• Use CompositeComponent in various locations
  Dean Herbert · 2022-08-19 20:43:15 +09:00
  c3c44c19cd
• Update resources
  Dean Herbert · 2022-08-19 20:40:05 +09:00
  41321521e5
• Update framework
  Dean Herbert · 2022-08-19 20:39:53 +09:00
  426c4c9bf7
• Improve string consistency
  its5Q · 2022-08-19 03:17:05 +10:00
  4c24d8ed58
• Merge pull request #19836 from peppy/split-offset-clock

  Split `OffsetCorrectionClock` out of `MasterGameplayClockContainer`

  Bartłomiej Dach · 2022-08-18 18:26:51 +02:00
  bc851c174b
• Merge branch 'master' into split-offset-clock
  Bartłomiej Dach · 2022-08-18 17:52:45 +02:00
  4ad782b5a0
• Merge pull request #19838 from peppy/test-scene-lead-in-updates

  Update `TestSceneLeadIn` to use new assert style

  Dean Herbert · 2022-08-18 20:55:55 +09:00
  0f0b4fdfec
• Update TestSceneLeadIn to use new assert style
  Dean Herbert · 2022-08-18 19:26:19 +09:00
  2eba8650ca
• Split OffsetCorrectionClock out of MasterGameplayClockContainer
  Dean Herbert · 2022-08-18 18:54:10 +09:00
  343efa1d11
• Merge pull request #19779 from peppy/no-gameplay-clock

  Remove all remaining usage of `GameplayClock`

  Dan Balasescu · 2022-08-18 18:52:57 +09:00
  fa167b1d12
• Merge pull request #19833 from smoogipoo/fix-backwards-asserts

  Fix some backwards asserts

  Dean Herbert · 2022-08-18 18:42:23 +09:00
  3e34959a6e
• Fix some backwards asserts
  Dan Balasescu · 2022-08-18 18:08:46 +09:00
  5d8d584afb
• Merge pull request #19832 from peppy/fix-taiko-span-blueprint-overlay

  Fix taiko blueprints displaying incorrectly for drum rolls

  Dan Balasescu · 2022-08-18 17:57:14 +09:00
  c4dee1cf6d
• Merge pull request #19831 from peppy/fix-zero-length-taiko-spans

  Fix taiko drum rolls with zero length being placeable in editor

  Dan Balasescu · 2022-08-18 17:56:46 +09:00
  8480703e0b
• Fix taiko blueprints displaying incorrectly for drum rolls
  Dean Herbert · 2022-08-18 17:18:11 +09:00
  ad28bfc9b2
• Fix taiko drum rolls with zero length being placeable in editor

  Addresses https://github.com/ppy/osu/discussions/19808.

  Dean Herbert · 2022-08-18 16:50:36 +09:00
  48fac9f8a5
• Merge pull request #19827 from smoogipoo/upgrade-analyser

  Upgrade LocalisationAnalyser and disable warning

  Dean Herbert · 2022-08-18 16:35:34 +09:00
  8d026eeeea
• Fix Pippidon crash on empty beatmap conversion
  Dean Herbert · 2022-08-18 16:17:50 +09:00
  bb46f72f9e
• Centralise logging of failed ruleset loads
  Dean Herbert · 2022-08-18 16:14:38 +09:00
  b0a740071e
• Test ruleset compatibility during initial startup to avoid runtime errors

  As we continue to break the ruleset API, it makes more sense to
  proactively check known changes and bail early during ruleset loading to
  avoid a user experiencing a crash at a random point during execution.
  
  This is a RFC and needs to be tested against known broken rulesets.
  There might be some other calls we want to add in addition to the ones
  I've listed.

  Dean Herbert · 2022-08-18 16:03:38 +09:00
  e0edaf996f
• Also upgrade tools
  Dan Balasescu · 2022-08-18 15:18:35 +09:00
  e55b94d412
• Upgrade LocalisationAnalyser and disable warning
  Dan Balasescu · 2022-08-18 15:08:24 +09:00
  7512c126b7