44824 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Dean Herbert	5f129ae33c	Remove local overridden storage of Mods in Player ... Not required and only causing headaches. Accessing mods should now be done via `GameplayState`. Closes #14912.	2021-10-07 14:53:39 +09:00
Dean Herbert	acaef26af7	Merge pull request #14986 from peppy/fix-wind-mods ... Fix rate mods not working if pp counter is displayed	2021-10-06 22:29:44 +09:00
Dean Herbert	9705c7b546	Use cloned mods in one more place	2021-10-06 21:30:30 +09:00
Dean Herbert	433e7cd403	Fix rate mods not working if pp counter is displayed	2021-10-06 21:26:30 +09:00
Dean Herbert	622e81f47a	Merge pull request #14982 from smoogipoo/fix-score-panel-test ... Fix intermittent score panel test failure	2021-10-06 17:56:18 +09:00
smoogipoo	456cfd62bf	Fix intermittent score panel test failure	2021-10-06 16:46:27 +09:00
Dan Balasescu	0d1243a0b5	Merge pull request #14981 from peppy/fix-leaderboard-incorrect-load ... Fix leaderboard potentially displaying the wrong scores	2021-10-06 16:40:26 +09:00
Dean Herbert	3803f2f462	Fix leaderboard potentially displaying the wrong scores ... Closes #14762. This class is ugly. I think the whole process should be clened up once we have correctly-scheduled `SynchronizationContext`s. There's not much saving it as long as all these interdispersed `Schedule`s around required.	2021-10-06 16:07:29 +09:00
Dan Balasescu	e6aa05a4a4	Merge pull request #14978 from peppy/fix-editor-file-selector-textbox-drags ... Fix dragging on an editor file selection text box causing repeated popover display	2021-10-06 13:52:08 +09:00
Dan Balasescu	80c8612630	Merge pull request #14977 from peppy/fix-working-beatmap-cache-invalidation ... Fix changes not being reflected immediately after exiting the editor	2021-10-06 13:51:21 +09:00
Dan Balasescu	5eb4210f78	Merge pull request #14918 from peppy/beatmap-difficulty-more-interface-usage ... Convert usages of `BeatmapDifficulty` to `IBeatmapDifficultyInfo`	2021-10-06 13:17:16 +09:00
Dean Herbert	d9849bcf49	Fix dragging on an editor file selection text box causing repeated popover display ... Local fix and no tests as this is a pretty weird usage of `TextBox`. We'll probably want to change it to not use a textbox eventually. Closes #14969.	2021-10-06 13:15:05 +09:00
Dean Herbert	90fdaf18c0	Fix PushAndConfirm potentially failing if new screen quickly pushes a child screen	2021-10-06 12:55:04 +09:00
Dean Herbert	8ffaa491e7	Fix BeatmapModelManager not receiving WorkingBeatmapCache	2021-10-06 12:55:04 +09:00
Dean Herbert	007b33cd88	Add missing methods to interfaces	2021-10-06 12:55:04 +09:00
Dean Herbert	6e797ddcac	Add test coverage of creating, saving and loading a new beatmap	2021-10-06 12:55:04 +09:00
Dean Herbert	ffbb7a9b1a	Remove incorrect csproj change ... Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>	2021-10-06 12:22:32 +09:00
Dan Balasescu	e837a3511d	Merge branch 'master' into beatmap-difficulty-more-interface-usage	2021-10-06 12:18:51 +09:00
Dan Balasescu	13bea7833e	Merge pull request #14917 from peppy/new-interfaces ... Add new read-only interfaces for all remaining model types	2021-10-06 12:18:31 +09:00
Dan Balasescu	4bbff2ebf7	Merge branch 'master' into new-interfaces	2021-10-06 11:38:17 +09:00
Dan Balasescu	9491e5a547	Merge pull request #14954 from peppy/rename-result-response ... Rename `APIRequest.Result` to `Response`	2021-10-06 10:52:33 +09:00
Dan Balasescu	007e5f174c	Merge pull request #14959 from peppy/add-screen-test-debug ... Add various logging output in an atttempt to figure multiplayer test failure	2021-10-06 10:11:50 +09:00
Dan Balasescu	4e13af6524	Merge pull request #14957 from peppy/fix-song-select-test-failure ... Fix `TestDifficultyIconSelectingForDifferentRuleset` potentially failing due to async load	2021-10-06 10:10:57 +09:00
Dan Balasescu	23f9b7a740	Merge pull request #14958 from peppy/fix-delete-local-score-test-failure ... Fix delete local score test not waiting for "fetch" to complete	2021-10-06 10:09:26 +09:00
Dean Herbert	8dad20aa60	Merge pull request #14968 from peppy/fix-replay-download ... Fix downloading replays not working as expected	2021-10-06 06:19:32 +09:00
Dean Herbert	4f59fc15a5	Mark BeatmapSet as nullable for the time being	2021-10-06 05:54:37 +09:00
Dean Herbert	4d5696959b	Remove unnecessary access modifier in interface ... Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>	2021-10-06 05:52:28 +09:00
Dean Herbert	d6f25e07cc	Add assert coverage of non-downloadable states	2021-10-06 05:49:18 +09:00
Dean Herbert	31c0c7a888	Remove pointless (and incorrect) click step	2021-10-06 05:49:04 +09:00
Dean Herbert	1a784b788d	Fix incorrect load state check ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2021-10-06 05:31:07 +09:00
Dean Herbert	1f6a31355c	Remove unused using statement ... Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2021-10-06 05:30:49 +09:00
Dean Herbert	5a4474e1b2	Fix incorrect DI retrieval in ReplayDownloadButton	2021-10-06 05:29:00 +09:00
Dean Herbert	777763a550	Add more comprehensive (and failing) test coverage of replay download button	2021-10-06 05:29:00 +09:00
Dean Herbert	c23acb8f05	Merge pull request #14967 from bdach/fix-accidental-json-property-rename ... Fix "most played beatmap" request breakage after property rename	2021-10-06 05:00:12 +09:00
Dean Herbert	f9b7b41011	Merge pull request #14966 from bdach/fix-backwards-chat-overlay-load-check ... Fix backwards containment check in chat channel load callback	2021-10-06 04:58:54 +09:00
Bartłomiej Dach	baa8baaa1e	Fix "most played beatmap" request breakage after property rename	2021-10-05 21:17:19 +02:00
Bartłomiej Dach	a5b07ce4fe	Fix backwards containment check in chat channel load callback	2021-10-05 20:53:06 +02:00
Bartłomiej Dach	12da27cde7	Add test coverage for loading process on channel join	2021-10-05 20:52:40 +02:00
Dean Herbert	6f7b8293af	Merge pull request #14919 from smoogipoo/realtime-pp-display ... Implement real-time PP counter	2021-10-05 20:50:03 +09:00
Dean Herbert	98fef6ece2	Handle judgement reverts with actual display updates	2021-10-05 19:08:30 +09:00
Dean Herbert	5c62d3b6cb	Merge pull request #14907 from peppy/remove-local-realm-thread-switch-handling ... Remove local handling of realm when switching thread modes	2021-10-05 19:00:19 +09:00
Dean Herbert	e6efdae7c9	Add various logging output in an atttempt to figure multiplayer test failure	2021-10-05 18:53:20 +09:00
Dean Herbert	bd84a8b749	Merge branch 'new-interfaces' into beatmap-difficulty-more-interface-usage	2021-10-05 18:21:21 +09:00
Dean Herbert	5d708b612d	Fix delete local score test not waiting for "fetch" to complete ... Even though this is a completely local operation in this case, there's still a level of asynchronous operation which was recent introduced with the score ordering: 853cf6feaa/osu.Game/Screens/Select/Leaderboards/BeatmapLeaderboard.cs (L159) This means there is a brief period where the `Scores` property is null, after `Reset()` is called in the re-fetch procedure.	2021-10-05 18:17:22 +09:00
Dean Herbert	94153e8bba	Fix TestDifficultyIconSelectingForDifferentRuleset potentially failing due to async load	2021-10-05 18:06:24 +09:00
Dean Herbert	2be44188ef	Add missing null checks	2021-10-05 17:59:38 +09:00
Dan Balasescu	f8156b0df9	Merge pull request #14955 from peppy/fix-import-notifications ... Fix import notifications not showing correct text	2021-10-05 17:55:04 +09:00
Dean Herbert	0859c336de	Also dim counter during initial calculation phase	2021-10-05 17:24:36 +09:00
Dean Herbert	1e4da81120	Fix import notifications not showing correct text	2021-10-05 17:14:09 +09:00
Dean Herbert	f64226ded6	Fix display not displaying correctly after initial load	2021-10-05 17:10:32 +09:00