69392 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Bartłomiej Dach	5e5bb49cd8	Fix rate change hotkeys sometimes losing track of adjust pitch setting ... Fixes https://osu.ppy.sh/community/forums/topics/1983327. The cause of the bug is a bit convoluted, and stems from the fact that the mod select overlay controls all of the game-global mod instances if present. `ModSpeedHotkeyHandler` would store the last spotted instance of a rate adjust mod - which in this case is a problem, because on deselection of a mod, the mod select overlay resets its settings to defaults: a258059d43/osu.Game/Overlays/Mods/ModSelectOverlay.cs (L424-L425) A way to defend against this is a clone, but this reveals another issue, in that the existing code was *relying* on the reference to the mod remaining the same in any other case, to read the latest valid settings of the mod. This basically only mattered in the edge case wherein Double Time would swap places with Half Time and vice versa (think [0.95,1.05] range). Therefore, track mod settings too explicitly to ensure that the stored clone is as up-to-date as possible.	2024-09-30 08:47:02 +02:00
Bartłomiej Dach	23b8354af4	Add more test steps demonstrating another failure case	2024-09-30 08:46:45 +02:00
Bartłomiej Dach	3fac9baa9f	Add test steps demonstrating failure case	2024-09-30 08:46:33 +02:00
Dean Herbert	a258059d43	Merge pull request #29918 from bdach/control-drag ... Add to existing selection when dragging with control pressed	2024-09-30 14:00:36 +09:00
Dean Herbert	71a5cd182a	Merge pull request #30040 from EVAST9919/file-popover-border ... Fix text in `FormFileSelector` bleeding through the border	2024-09-30 11:07:39 +09:00
Andrei Zavatski	f473f4398c	Fix text in FormFileSelector bleeding through the border	2024-09-28 22:37:16 +03:00
Dean Herbert	c46d787f1e	Merge pull request #29949 from minetoblend/feature/scale-around-center ... Support scaling around center when scaling with select box	2024-09-28 21:37:39 +09:00
Bartłomiej Dach	c1e51e05df	Merge pull request #29704 from Fabep/ModCustomisationHeaderColor ... Mod customisation header color	2024-09-27 12:40:35 +02:00
Bartłomiej Dach	d607331755	Fix control-drag selection expansion deselecting object if control is released over one of the blueprints	2024-09-27 12:15:08 +02:00
Bartłomiej Dach	eb725ec1fb	Nudge test coverage to also cover discovered fail case	2024-09-27 12:13:11 +02:00
Bartłomiej Dach	b45fedc356	Merge branch 'master' into control-drag	2024-09-27 11:39:50 +02:00
Dean Herbert	a358731af5	Merge pull request #29913 from Joehuu/fix-romanised-searching ... Fix searching by clicking title/artist in beatmap overlay not following original language setting	2024-09-27 18:39:33 +09:00
Dean Herbert	e7c4451206	Reduce brightness of hover effect	2024-09-27 18:20:16 +09:00
Dean Herbert	64c1ced80d	Merge branch 'master' into ModCustomisationHeaderColor	2024-09-27 18:15:30 +09:00
Dean Herbert	d9de2ad97b	Merge pull request #29899 from bdach/mania-selection-dropped ... Ensure selection is preserved when moving selection between columns	2024-09-27 18:11:23 +09:00
Bartłomiej Dach	a00ed8dd77	Merge pull request #29914 from peppy/fix-judgement-counter-sync ... Fix judgement counter not showing correct counts when spectating user mid-play	2024-09-27 10:57:26 +02:00
Bartłomiej Dach	33593280d8	Merge pull request #29938 from OliBomby/selection-center ... Use minimum enclosing circle as selection centre for scale and rotate	2024-09-27 10:46:32 +02:00
Dean Herbert	371cee1617	Consume framework change to avoid weird unbind flow	2024-09-27 17:41:55 +09:00
Dean Herbert	92ee86e3dd	Update framework	2024-09-27 17:40:06 +09:00
Dean Herbert	048e3c2505	Merge branch 'master' into fix-romanised-searching	2024-09-27 17:40:03 +09:00
Bartłomiej Dach	766d2d2ad2	Merge pull request #29950 from minetoblend/feature/freeze-select-box-buttons ... Freeze select box buttons position on press	2024-09-27 10:13:06 +02:00
Dan Balasescu	eb8cc7fbb2	Merge pull request #30019 from smoogipoo/fix-ios-ci-build ... Fix iOS CI build	2024-09-27 16:58:47 +09:00
Dan Balasescu	73a9b03401	Merge pull request #30018 from peppy/add-missing-shader-preload ... Update shader preloader with missing shader usages	2024-09-27 16:58:15 +09:00
Dean Herbert	1dd6082aa9	Rename method to be more appropriate	2024-09-27 16:56:22 +09:00
Dean Herbert	9a39b80a4d	Merge pull request #29970 from bdach/volume-aware-sample-equality-pitfall ... Fix argon volume-aware hitsounds not correctly playing immediately after object placement	2024-09-27 16:38:35 +09:00
Dean Herbert	19a96bcc50	Merge pull request #29967 from bdach/storyboard-full-dim ... Continue displaying storyboard even if fully dimmed in specific circumstances	2024-09-27 16:33:58 +09:00
Bartłomiej Dach	fa90b43233	Merge branch 'master' into selection-center	2024-09-27 09:30:36 +02:00
Dan Balasescu	cb51e12d13	Fix iOS CI build	2024-09-27 16:26:11 +09:00
Bartłomiej Dach	21796900e2	Fix code quality naming issue	2024-09-27 09:26:08 +02:00
Dean Herbert	5be63ee304	Reorganise with ruleset shader separated out	2024-09-27 16:19:24 +09:00
Dean Herbert	4205a21c0c	Add one more shader usage	2024-09-27 16:11:24 +09:00
Bartłomiej Dach	8ca68be5fe	Merge pull request #30017 from peppy/file-picker-hover-states ... Add basic hover states for file selector elements	2024-09-27 08:57:16 +02:00
Dean Herbert	b2983e2562	Update shader preloader with missing shader usages	2024-09-27 14:21:20 +09:00
Dean Herbert	5efdc6cdd7	Merge pull request #29936 from u4vh3/skinning-colour-customisation ... Add colour customisation to layout editor	2024-09-27 14:20:58 +09:00
Dean Herbert	eacd9b9756	Move dependent files to namespace	2024-09-27 14:00:54 +09:00
Dean Herbert	cbeeb4a2b4	Add basic hover states for file selector elements	2024-09-27 13:44:37 +09:00
Dean Herbert	cec3f1487a	Merge pull request #30005 from bdach/editor/setup-screen-file-picker ... Implement "form" file picker	2024-09-27 13:42:52 +09:00
Dean Herbert	9e9bfc3721	Update velopack with zstd changes ... Closes https://github.com/ppy/osu/issues/29810.	2024-09-27 12:48:50 +09:00
Dan Balasescu	33c40079b6	Merge pull request #29997 from peppy/async-wait-exit-velopack ... Update velopack and switch to using async version of `WaitExitThenApplyUpdates`	2024-09-26 21:56:24 +09:00
Bartłomiej Dach	f4a4807449	Implement "form" file picker	2024-09-26 14:36:24 +02:00
Bartłomiej Dach	f16f419928	Merge pull request #29983 from bdach/directory-selector-redesign ... Redesign directory & file selector	2024-09-26 14:14:22 +02:00
Dean Herbert	b1a05f463e	Reduce size of hidden toggle slightly	2024-09-26 19:42:31 +09:00
Dean Herbert	78c1426a30	Merge pull request #29992 from smoogipoo/fix-ios-realm-crashes ... Fix reflection-related iOS crashes	2024-09-26 17:34:36 +09:00
Dean Herbert	89e8baf1d3	Add inline comments for iOS locals	2024-09-26 16:48:42 +09:00
Dean Herbert	df0966abb2	Update velopack and switch to using async version of WaitExitThenApplyUpdates	2024-09-26 01:12:19 +09:00
Dan Balasescu	2fe229d620	Inline condition	2024-09-25 22:47:37 +09:00
Dan Balasescu	fd4891cf31	Fix similar Bindable-related crashes	2024-09-25 20:59:35 +09:00
Dan Balasescu	3111d6a74d	Merge pull request #29986 from OliBomby/refactor-placement-tool ... Refactor placement blueprints to not be limited to hit objects	2024-09-25 17:59:43 +09:00
Dan Balasescu	5b8ae90ec1	Merge pull request #29962 from Givikap120/use_max_combo ... Make all difficulty calculators use `GetMaxCombo` function	2024-09-25 17:51:49 +09:00
Dan Balasescu	3ab04d98f6	Fix Realm-related iOS crashes by removing object references	2024-09-25 16:45:37 +09:00