147 Commits

• Apply batch fixing of built-in types using var
  Dean Herbert · 2021-10-27 13:04:41 +09:00
  6944151486
• Use null check instead of assert in Hide() due to public exposure
  Dean Herbert · 2021-09-29 18:58:43 +09:00
  4fd19cbb0d
• Fix skin editor potentially crashing during close process

  As reported at
  https://github.com/ppy/osu/discussions/14850#discussioncomment-1399382.

  Dean Herbert · 2021-09-29 18:53:49 +09:00
  c5b7e97bd9
• Fix skin editor potentially leaving game-wide masking in the wrong state

  Just going with the simplest way to solve this.
  
  Closes https://github.com/ppy/osu/issues/14769.

  Dean Herbert · 2021-09-17 13:48:20 +09:00
  1b13b74740
• Update with keybinding changes
  smoogipoo · 2021-09-16 18:26:12 +09:00
  f9d5abff8a
• Merge branch 'master' into skin-editor-button-access
  Bartłomiej Dach · 2021-07-22 22:49:44 +02:00
  b1087d14f3
• Fix skin editor potentially eating GlobalAction.Back when not displayed
  Dean Herbert · 2021-07-22 15:59:00 +09:00
  21053381c7
• Fix skin editor's fake overlay potentially getting into a bad state
  Dean Herbert · 2021-07-22 15:57:47 +09:00
  3fd8de3b91
• Allow specifying flipping support of selection box different from scaling
  ekrctb · 2021-07-21 15:59:45 +09:00
  1bff4373b3
• Use existing localisation
  Dean Herbert · 2021-07-20 19:44:02 +09:00
  16a2e63bd4
• Move further to the right to avoid overlap with toolbox listing
  Dean Herbert · 2021-07-20 19:43:52 +09:00
  59457743e5
• Add the ability to enter and exit the skin editor via on-screen buttons
  Dean Herbert · 2021-07-20 19:36:12 +09:00
  9c4fbf45e9
• Merge pull request #13382 from ribbanya/clamp-skin-scale

  Fix skin elements flipping when scaled below zero

  Dean Herbert · 2021-07-02 20:50:47 +09:00
  6e31c781bb
• Make flipping reflect across the axes of the selection box
  aitani9 · 2021-07-01 15:38:38 -07:00
  9b0fa6d3fc
• Move scoped functionality into local function
  Dean Herbert · 2021-06-22 16:40:56 +09:00
  4b3165084d
• Extract drawable.ScreenSpaceDrawQuad to a variable
  Robin Avery · 2021-06-11 07:06:22 -04:00
  0c8851f4b7
• Inline getOriginPositionFromQuad
  Robin Avery · 2021-06-11 06:59:00 -04:00
  a6774eb5b5
• Make getOriginPositionFromQuad local
  Robin Avery · 2021-06-11 06:55:47 -04:00
  c9b4f9eb71
• Rename getTieredComponent to getAnchorFromPosition

  Also rename parameter `component` to `xOrY`.

  Robin Avery · 2021-06-11 06:53:40 -04:00
  1bc8460902
• Rename parameters of getTieredComponent
  Robin Avery · 2021-06-11 06:53:04 -04:00
  6e181a6b63
• Make getTieredComponent local
  Robin Avery · 2021-06-11 06:51:12 -04:00
  a76eaeb52d
• Recalculate closest anchor when origin is changed
  Robin Avery · 2021-06-11 06:28:30 -04:00
  635300b311
• Revert rename of lambda variables
  Robin Avery · 2021-06-11 06:22:24 -04:00
  a506f2a776
• Ensure scale x or y does not go below zero in SkinSelectionHandler.HandleScale
  Robin Avery · 2021-06-08 11:49:25 -04:00
  2484ccd50c
• Add guard clause to applyOrigins and rename parameter
  Robin Avery · 2021-06-08 10:29:45 -04:00
  10b6b72909
• Rename applyCustomAnchors to applyFixedAnchors for consistency with UsesFixedAnchor
  Robin Avery · 2021-06-08 10:14:07 -04:00
  d212918d67
• Simplify applyClosestAnchor to one line by moving another guard clause
  Robin Avery · 2021-06-08 10:09:48 -04:00
  2c88e6df8d
• Move guard clause from checkAndApplyClosestAnchor to applyAnchor
  Robin Avery · 2021-06-08 09:51:39 -04:00
  f22cc981d1
• Rename some methods for clarity

  Methods which operate on a collection of `ISkinnableDrawable`s are now
  plural; ones which take a single item are singular.
  
  This also allows cutting down the name of `getClosestAnchorForDrawable`
  to just `getClosestAnchor`.

  Robin Avery · 2021-06-08 09:44:42 -04:00
  529a80871b
• Refactor updateDrawableAnchorIfUsingClosest
  Robin Avery · 2021-06-08 09:25:49 -04:00
  01da73daf2
• Inline updateDrawableAnchorIfUsingClosest
  Robin Avery · 2021-06-08 09:14:04 -04:00
  6b127f50f2
• Rename OverridesClosestAnchor to UsesFixedAnchor
  Robin Avery · 2021-06-08 08:28:42 -04:00
  dc50ae40b9
• Rename applyAnchor to applyCustomAnchor
  Robin Avery · 2021-06-07 05:08:18 -04:00
  65f594f860
• Simplify and rearrange SkinSelectionHandler

  The file has been restructured and reworded such that there are as few
  differences as possible from b36b40cb34.

  Robin Avery · 2021-06-07 02:40:15 -04:00
  6c9594ee35
• Refactor unacceptable syntax
  Robin Avery · 2021-06-07 01:08:39 -04:00
  29fa4fdf57
• Rename UsingClosestAnchor

  It is now "OverridesClosestAnchor". The logic is inverted accordingly.

  Robin Avery · 2021-06-07 00:14:36 -04:00
  133d72a8c0
• Remove all UsingClosestAnchor() extension logic

  It is replaced with ISkinnableDrawable.UsingClosestAnchor.

  Robin Avery · 2021-06-07 00:04:53 -04:00
  f28916e30f
• Rename overly long method
  Robin Avery · 2021-06-06 13:28:17 -04:00
  6a456e53f4
• Remove first-person comment
  Robin Avery · 2021-06-06 13:27:13 -04:00
  888882ac63
• Uninvert logic of SkinnableInfo.UsingClosestAnchor

  Also rename "IsUsingClosestAnchor" to simply "UsingClosestAnchor".

  Robin Avery · 2021-06-06 10:13:35 -04:00
  da1c38d5a9
• Refactor getTieredComponent
  Robin Avery · 2021-06-06 09:40:58 -04:00
  63346f6b75
• Move lookup logic to DrawableExtensions

  This is now a global lookup to be shared by serialization and editor.

  Robin Avery · 2021-06-06 06:58:21 -04:00
  c9f5808bf2
• Replace localised strings with static English
  Robin Avery · 2021-06-06 05:34:32 -04:00
  4aee76456f
• Allow skin elements to find closest anchor

  - Resolves ppy/osu#13252
  - Add localisation strings for the context menu instead of using enum

  Robin Avery · 2021-06-06 01:32:04 -04:00
  c452715bf1
• Remove unnecessary double specification
  Dean Herbert · 2021-05-26 15:20:47 +09:00
  b36b40cb34
• Prevent skin editor crash when scaling 0 area drawables

  Some skinnable drawables can have 0 width or height in certain
  cases, leading to division by 0 and a crash when the position is
  updated.

  kamp · 2021-05-24 21:36:42 +02:00
  65649e5a62
• Merge branch 'refactor-selection-rotate-logic' into fix-flip-logic-discrepancy
  Dean Herbert · 2021-05-22 21:17:58 +09:00
  45c6a9ca91
• Remove unnecessary field storage of origin reference
  Dean Herbert · 2021-05-22 21:03:40 +09:00
  7d88a19d7f
• Merge branch 'master' into refactor-selection-rotate-logic
  Dean Herbert · 2021-05-22 20:52:28 +09:00
  34a5b22b79
• Merge pull request #12866 from peppy/refactor-selection-scale-logic

  Add proper scaling support to skin editor

  Dean Herbert · 2021-05-22 20:07:03 +09:00
  485728ca4e