61771 Commits

This Branch

This Branch

All Branches

• Fix skin component toolbox not working correctly for ruleset matching

  Until now, the only usage of ruleset layers was where there is both a
  ruleset specific and non-ruleset-specific layer present. The matching
  code was making assumptions about this.
  
  As I tried to add a new playfield layer which breaks this assumption,
  non-ruleset-specifc components were not being displayed in the toolbox.
  This turned out to be due to a `target` of `null` being provided due to
  the weird `getTarget` matching (that happened to *just* do what we
  wanted previously due to the equals implementation, but only because
  there was a container without the ruleset present in the available
  targets).
  
  I've changed this to be a more appropriate lookup method, where the
  target for dependency sourcing is provided separately from the ruleset
  filter.

  Dean Herbert · 2023-07-28 15:50:44 +09:00
  5bd06832d0
• Expose a new SSDQ from playfield for skinnable area bounds
  Dean Herbert · 2023-07-28 15:47:57 +09:00
  06fe5583cb
• Merge pull request #24357 from peppy/tournament-fix-null-population

  Fix startup tournament population not recovering from null beatmaps

  Dean Herbert · 2023-07-28 14:31:48 +09:00
  57e51f4d5b
• Merge pull request #24377 from ILW8/fix-tournament-switcher-height

  Allow scrolling in tournament setup screen to avoid information ending up off-screen

  Dean Herbert · 2023-07-28 14:27:55 +09:00
  c824b2dedf
• make SetupScreen scrollable
  Dao Heng Liu · 2023-07-28 14:18:48 +09:00
  c7717da232
• Merge branch 'master' into tournament-fix-null-population
  Bartłomiej Dach · 2023-07-27 22:36:11 +02:00
  780b8f0ec8
• Remove fallbacks to empty APIBeatmap on population failure

  Was causing there to be two kinds of missing `TournamentBeatmap`s: one
  with missing `Beatmap == null`, and one with `Beatmap == new
  APIBeatmap()`. In particular, they would appear differently in UI
  (either as "unknown - unknown", or the intensely enigmatic " - ").

  Bartłomiej Dach · 2023-07-27 22:33:00 +02:00
  b7ddb5c946
• Fix even more missed nullability-related inspections
  Bartłomiej Dach · 2023-07-27 22:10:41 +02:00
  3c923b9e81
• Merge pull request #24367 from peppy/fix-replay-export-from-results

  Fix attempting to export replay from results screen after play not working

  Bartłomiej Dach · 2023-07-27 20:47:07 +02:00
  22163020c3
• Avoid intercepting temporary files in new test
  Dean Herbert · 2023-07-27 17:44:36 +09:00
  e702e0a23e
• Fix some missed null checks
  Dean Herbert · 2023-07-27 17:41:27 +09:00
  1e9b927b50
• Merge pull request #24375 from peppy/add-back-mode-select-enter-close

  Add back the ability to close mod select using enter key

  Bartłomiej Dach · 2023-07-26 22:43:38 +02:00
  057bac39dd
• Update wrong comment, too
  Bartłomiej Dach · 2023-07-26 21:56:04 +02:00
  973e6ded2a
• Use more consistent way of closing overlay
  Bartłomiej Dach · 2023-07-26 21:54:35 +02:00
  992f78b158
• Revert failing test to prior assertions too
  Bartłomiej Dach · 2023-07-26 21:51:32 +02:00
  f66093d3cf
• Fix code quality inspection
  Bartłomiej Dach · 2023-07-26 20:52:03 +02:00
  7bc3edb05a
• Add back the ability to close mod select using enter key

  I've seen this brought up a few times (with people thinking
  the fact it's not working is a bug) so we'll need to keep this
  behaviour for now.

  Dean Herbert · 2023-07-27 02:36:25 +09:00
  8d5efc9612
• Apply NRT and avoid throws from null RoundBeatmap.Beatmaps
  Dean Herbert · 2023-07-26 17:49:07 +09:00
  fa4992f05a
• Fix files references not correctly being copied after replay import in Player
  Dean Herbert · 2023-07-26 15:22:00 +09:00
  4889864478
• Fix ReplayDownloadButton handling key repeat
  Dean Herbert · 2023-07-26 15:21:43 +09:00
  e26afc2b89
• Add test coverage of score arriving on disk when exporting from results screen after play
  Dean Herbert · 2023-07-26 15:21:43 +09:00
  2dace742a3
• Merge pull request #24358 from peppy/song-select-drain-length

  Show break time in tooltip at song select

  Bartłomiej Dach · 2023-07-25 23:22:18 +02:00
  0b5be51ee0
• Merge branch 'master' into song-select-drain-length
  Bartłomiej Dach · 2023-07-25 22:40:45 +02:00
  57ccf82f34
• Merge pull request #24359 from peppy/fix-unknown-mod-test-failure

  Fix `TestSceneUnknownMod` failing due to null reference

  Bartłomiej Dach · 2023-07-25 22:40:03 +02:00
  653f01f4ce
• Merge pull request #24208 from peppy/menu-star-fountains

  Add kiai fountains to main menu

  Bartłomiej Dach · 2023-07-25 22:39:07 +02:00
  5214efca5a
• Rename test to match class
  Bartłomiej Dach · 2023-07-25 22:18:31 +02:00
  c6099edb88
• Revert "Show only the break length instead of total minute breaks"

  This reverts commit 9edaa6909e.

  Bartłomiej Dach · 2023-07-25 22:17:55 +02:00
  3b11559fd0
• Merge branch 'master' into menu-star-fountains
  Bartłomiej Dach · 2023-07-25 21:58:13 +02:00
  3b9f250c1b
• Merge pull request #24305 from chayleaf/fix-taiko-hd-hit-overlap

  Fix alive hitobjects blocking hits in taiko with HD

  Bartłomiej Dach · 2023-07-25 21:20:29 +02:00
  7c78fcd6f5
• Merge branch 'master' into fix-taiko-hd-hit-overlap
  Bartłomiej Dach · 2023-07-25 20:11:43 +02:00
  0b7b70fd9c
• Use update-invariant way of checking for second press on same frame

  Fixes the same issue that 970ea50269 did,
  but with no `AlwaysPresent` usage.

  Bartłomiej Dach · 2023-07-25 20:07:03 +02:00
  7e98d319d8
• Merge pull request #24288 from peppy/fix-editor-blueprint-input-extension

  Fix editor blueprints being selectable for too long when hit markers are enabled

  Bartłomiej Dach · 2023-07-25 20:05:40 +02:00
  b86defbeb1
• Add test covering blocking of second hit on same frame
  Bartłomiej Dach · 2023-07-25 20:05:37 +02:00
  5cedd428bb
• Merge branch 'master' into fix-editor-blueprint-input-extension
  Bartłomiej Dach · 2023-07-25 19:29:36 +02:00
  e95f9cdd98
• Merge pull request #24356 from peppy/fix-scheduler-screen-selection-alignment

  Fix misalignment of selection box on schedule screen

  Bartłomiej Dach · 2023-07-25 19:21:56 +02:00
  a6da45a99b
• Adjust cyclic selection test to hitcircle lifetime adjustments

  As it turns out, the tightening of hitcircle lifetimes in editor caused
  the test to fail, since the objects were too far apart and at the
  starting time of the test, the first object was fully faded out and as
  such not alive, therefore leading cyclic selection to fail to select it.
  
  To fix, bring all three objects closer together time-wise so that this
  does not happen and the test can continue to exercise its original
  behaviour.

  Bartłomiej Dach · 2023-07-25 18:54:13 +02:00
  d75e6f78d6
• Merge branch 'master' into fix-scheduler-screen-selection-alignment
  Bartłomiej Dach · 2023-07-25 18:44:44 +02:00
  72db0c17ca
• Privatise currentMatchSelectionBox

  Because nobody else should need to do anything as cursed as what
  `ScheduleScreen` was doing (which is 95% of the reason why the selection
  box even broke there).

  Bartłomiej Dach · 2023-07-25 18:41:54 +02:00
  43876ba2b0
• Merge pull request #24284 from ILW8/tourney-dangerous-action-confirm

  Add confirmation dialog when performing dangerous actions in tournament client

  Bartłomiej Dach · 2023-07-25 18:22:17 +02:00
  2c0e419d86
• Fix TestSceneUnknownMod failing due to null reference
  Dean Herbert · 2023-07-25 19:06:13 +09:00
  c1d93607e0
• Cache IDialogOverlay in a simpler way
  Dean Herbert · 2023-07-25 18:33:41 +09:00
  0130c356ed
• Merge branch 'master' into tourney-dangerous-action-confirm
  Dean Herbert · 2023-07-25 18:27:58 +09:00
  2c5a329b04
• Add new property to avoid overlapping usages
  Dean Herbert · 2023-07-25 18:14:03 +09:00
  eac6271bd0
• Merge branch 'master' into fix-editor-blueprint-input-extension
  Dean Herbert · 2023-07-25 18:14:02 +09:00
  2f7d38d98b
• Merge pull request #24331 from ILW8/tourney-fix-screen-auto-switch

  Fix auto advance screens sometimes not advancing

  Dean Herbert · 2023-07-25 17:53:27 +09:00
  ec1b0884f7
• Fix skin mapping not working for menu fountains
  Dean Herbert · 2023-07-25 17:46:05 +09:00
  43107f8cf0
• Merge branch 'master' into tourney-fix-screen-auto-switch
  Dean Herbert · 2023-07-25 17:18:43 +09:00
  7d5305c5e8
• Separate out each type of scheduled operation and refactor tidy-up code
  Dean Herbert · 2023-07-25 17:18:13 +09:00
  c84381d802
• Show only the break length instead of total minute breaks
  Dean Herbert · 2023-07-25 17:02:27 +09:00
  9edaa6909e
• Show drain length in length tooltip at song select
  Dean Herbert · 2023-07-25 16:58:53 +09:00
  480163ec2e